mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-13 13:50:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

peerconnection: prefer spec names for signaling state

Browse source 
Map the internal state names to the spec ones defined in
  https://w3c.github.io/webrtc-pc/#rtcsignalingstate-enum
instead of exposing them. This only affects the (not specified)
error strings.

Bug: None
Change-Id: Ib0b35bb3106b1688e8386f6fdd0b8c7fdebaf1dc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178390
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/master@{#31591}
This commit is contained in:
Philipp Hancke 2020-06-30 13:56:40 +02:00 committed by Commit Bot
parent f9e5248f5d
commit f79bfc65e5
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
pc/peer_connection.cc
View file

@ -251,21 +251,23 @@ uint32_t ConvertIceTransportTypeToCandidateFilter(
return cricket::CF_NONE; return cricket::CF_NONE;
} }
// Map internal signaling state name to spec name:
// https://w3c.github.io/webrtc-pc/#rtcsignalingstate-enum
std::string GetSignalingStateString( std::string GetSignalingStateString(
PeerConnectionInterface::SignalingState state) { PeerConnectionInterface::SignalingState state) {
switch (state) { switch (state) {
case PeerConnectionInterface::kStable: case PeerConnectionInterface::kStable:
return "kStable"; return "stable";
case PeerConnectionInterface::kHaveLocalOffer: case PeerConnectionInterface::kHaveLocalOffer:
return "kHaveLocalOffer"; return "have-local-offer";
case PeerConnectionInterface::kHaveLocalPrAnswer: case PeerConnectionInterface::kHaveLocalPrAnswer:
return "kHavePrAnswer"; return "have-local-pranswer";
case PeerConnectionInterface::kHaveRemoteOffer: case PeerConnectionInterface::kHaveRemoteOffer:
return "kHaveRemoteOffer"; return "have-remote-offer";
case PeerConnectionInterface::kHaveRemotePrAnswer: case PeerConnectionInterface::kHaveRemotePrAnswer:
return "kHaveRemotePrAnswer"; return "have-remote-pranswer";
case PeerConnectionInterface::kClosed: case PeerConnectionInterface::kClosed:
return "kClosed"; return "closed";
} }
RTC_NOTREACHED(); RTC_NOTREACHED();
return ""; return "";