Evan Shrubsole
047238ebda
WebRTC perfetto chromium integration
...
Bug: webrtc:15917
Change-Id: I2a459565364e0eedba8d22c23427409b35ba8387
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/348780
Reviewed-by: Mikhail Khokhlov <khokhlov@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Evan Shrubsole <eshr@google.com>
Cr-Commit-Position: refs/heads/main@{#42192}
2024-04-29 12:12:48 +00:00
Evan Shrubsole
db50b03553
Add perfetto build config
...
This adds Perfetto support to WebRTC with a GN flag rtc_use_perfetto.
The configuration of perfetto depends on whether or not webrtc is
build within Chrome or not. When in Chrome, WebRTC will depend on
//third_party/perfetto:libperfetto. When building standalone, specific includes required for Perfetto are exposed with the library webrtc_libperfetto.
The perfetto trace API is exposed with a header export in
trace_event.h which is used instead of the legacy API.
The addition of Perfetto means there are 4 compilation modes for
tracing in WebRTC,
1. No tracing implementation.
2. Legacy tracing (AddTraceEvent/GetCategoryEnabled).
3.a. Perfetto statically linked (webrtc_libperfetto).
3.b. Perfetto in Chrome (Chrome's libperfetto).
This CL removes the tracing expectations from
rtc_stats_integrationtest.cc because those directly used the old API.
Integration into Chrome is a follow up CL which depends on
https://chromium-review.googlesource.com/c/chromium/src/+/5471691 .
Tested: Ran Chrome with Perfetto and traces appear. WebRTC Unit test tracing working: https://ui.perfetto.dev/#!?s=04ea2613ea36b814394639a1ec4b60be5b5097527f1a485995ecc13469885468
Bug: webrtc:15917
Change-Id: I537d79dc247c2b759689910c621087286a4d8fdc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347880
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Evan Shrubsole <eshr@google.com>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Mikhail Khokhlov <khokhlov@google.com>
Cr-Commit-Position: refs/heads/main@{#42166}
2024-04-24 20:53:23 +00:00
Bjorn Terelius
a0672c5f32
Roll chromium_revision
...
(from b9338390dfcef481083d44d44c243c0c73196342
to 247e4de55550191706972861e586831a0d94d524)
Manually remove third_party/accessibility_test_framework from DEPS
Bug: b/329245293
Change-Id: Ie977314daf636f5208948ae74b7958ef3e296ffb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/342762
Commit-Queue: Jeremy Leconte <jleconte@webrtc.org>
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41902}
2024-03-15 07:58:00 +00:00
Jeremy Leconte
49f08ba8ac
Roll chromium_revision 01dc2965ca..917876224a (1209117:1211391)
...
Change log: 01dc2965ca..917876224a01dc2965ca..917876224a535e730300..6732bf03f7b0d25e8dad..cc1dedc3ff67cee5ecfd..7bbf5da81622678d3aca..b915f348d177870d2f05..ba6866fdda16e0426d42..30390e5d61https://chromium.googlesource.com/catapult.git/+log/171b75b883..b9ebaddcd0
* src/third_party/dav1d/libdav1d: f8ae94eca0..47107e384ba51863b2f8..406be8281eacb78dc0f4..e1ca3f06ad322e580bd0..749b8f9d34e07dcc1eaa..2f6750b44b7b1593d5ca..11d9f3e05558e677929f..2b538edb67c3738e7bc8..36269b619a01dc2965ca..917876224ahttps://webrtc-review.googlesource.com/c/src/+/323983
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40965}
2023-10-18 15:15:07 +00:00
Mirko Bonadei
12199b1f96
Roll chromium_revision 1a86984556..de49bd6f22 (1204416:1205695)
...
Change log: 1a86984556..de49bd6f221a86984556..de49bd6f2219c600fca5..858655d3c08a44cdc629..76f5031632c8bee3e69d..c3c28168c6533f961c05..c5c008727486a2370993..73590462a655c4796b77..3799cfa702https://chromium.googlesource.com/catapult.git/+log/b018f901e8..1a33dd1f59
* src/third_party/depot_tools: f90b3b035c..c2e00617230ba3773340..0d75f366d50343396e49..bcb9ef187605fe2a64f5..0eb5ce7284a094e2535c..e0cb589445e8e4eb8f1c..b6e1ac16497608093d21..2ce7927479d44dbe4ad2..8e5b8483f38a2e7818c8..b40f8fd9a81a86984556..de49bd6f221a86984556..de49bd6f22https://webrtc-review.googlesource.com/c/src/+/322424
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40870}
2023-10-05 10:33:16 +00:00
Mirko Bonadei
fd9ac12756
Add more owners to build_overrides.
...
Bug: None
Change-Id: Ie8be9cde1a453003859e6c55db6cbf3dd8038cb5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322441
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#40868}
2023-10-05 09:32:59 +00:00
Björn Terelius
51f6a20d1d
Roll chromium_revision 6b95b8aa08..80c35b98ae (1175249:1180373)
...
Manually
- update the path to libc++, libunwind, and android_toolchain
- update paths to licence files
- add missing arg `use_perfetto_trace_processor`
- use C++20 for android compilation (due to dependency on //base from the JNI generator)
- only test on Android sdk version (21) due to non-hermetic test `TCPChannelClientTest`
Change log: 6b95b8aa08..80c35b98ae6b95b8aa08..80c35b98aedcfe245ca1..4845bf859db74cdc4550..c14d86f2ac16be42a9ff..a9a6f0c49d51a637843f..af5e59ca5cb946312a89..43317e989d93b5f4c408..3b06b3cc29https://boringssl.googlesource.com/boringssl.git/+log/b98ce18c5b..e4acd6cb56
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/84e3795d98..220cbb13b5
* src/third_party/clang-format/script: f97059df7f..e5337933f254e86436a8..6d0c235dae881c5c3f64..0ba377334006929a556f..2fb3419a929e3c5d7e18..3829fdaae5e8c3bc9ea9..de4ce0071ehttps://aomedia.googlesource.com/aom.git/+log/af2b02ce05..92fb72a64e
* src/third_party/libunwind/src: 6c0013015b..b113f23e4c9ad950a9c4..e1c124f896ab16995d92..446adf5b7b4057b98943..e3244f7e276b95b8aa08..80c35b98aehttps://webrtc-review.googlesource.com/c/src/+/315181
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40532}
2023-08-10 07:50:10 +00:00
Daniel Cheng
b03c4a5437
Define enable_safe_libcxx in build_overrides/build.gni.
...
enable_safe_libcxx will be overridable by projects that embed Chrome's
//build using the build_overrides mechanism. All downstream projects
will need to define this new variable so Chrome can stop conditionally
defining enable_safe_libcxx upstream.
Bug: chromium:1385662
Change-Id: I62e8cf7988b76eed48c95c4993f4aea73a164bc7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/293981
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39974}
2023-05-03 08:18:25 +00:00
Peter Kasting
1e6d77c29a
Always check out google_benchmark, part 3.
...
Add a WebRTC-specific arg that can be used to control use of targets
that rely on //third_party/google_benchmarks, so the .gni in that
directory can eventually be removed.
Bug: chromium:1404759
Change-Id: I2a9422fae119ca13eb50028d962fc0a671b5fb33
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/297460
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/main@{#39553}
2023-03-14 12:14:51 +00:00
Byoungchan Lee
36f668c8bb
Use default values provided by PartitionAlloc instead of hard-coded ones
...
https://crrev.com/c/2738677 added a variable to
base/allocator/partition_allocator/build_overrides/partition_alloc.gni
and this change prevents chromium roll.
Instead of adding a variable to WebRTC's partition_alloc.gni,
import that file. This will avoid repeating these operations in the
future.
Bug: None
Change-Id: I8ad2e8900d5ca7828cf415ecf7933c8eb1d5160a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/286201
Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38834}
2022-12-07 09:11:35 +00:00
landrey
1a43f2c6c5
Add stub for build_overrides/partition_alloc.gni
...
Also roll chromium revision that required the fix
Bug: None
Change-Id: I66d54a4de763dba3ddadd9e1b4e89c52ab917934
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273321
Auto-Submit: Andrey Logvin <landrey@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Andrey Logvin <landrey@google.com>
Cr-Commit-Position: refs/heads/main@{#37929}
2022-08-29 12:17:02 +00:00
Artem Titov
c39080c883
Roll chromium + fix: blacklist -> ignorelist for sanitizers suppressions
...
Roll chromium_revision 19159a8788..a0132a2044 (886529:887053)
Change log: 19159a8788..a0132a204419159a8788..a0132a2044eb591f0d4b..43f91dbc504f39b7cf99..2f6e88e05d7846d25635..c8d0fb870a6d4134ba11..61b28637d904abc75222..55ab025d496dc8812614..3544467673https://chromium.googlesource.com/catapult.git/+log/74a278f9bb..e83a92e7b8
* src/third_party/depot_tools: 6d45691f60..6fc394f93d23ef29555e..a3460d1aee78af063a63..be406c7d16255ad6c868..451fade86319159a8788..a0132a2044https://webrtc-review.googlesource.com/c/src/+/220364
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#34145}
2021-05-27 16:16:01 +00:00
Mirko Bonadei
80939356cc
Roll chromium_revision 34f3c82122..2dffe06711 (867171:871492)
...
Change log: 34f3c82122..2dffe0671134f3c82122..2dffe06711cbc66d2601..db151ac5c50cea8e20fb..399fa5ad7499a2527e91..5dbd89c9d9cbf9455e83..d0f33885a2cc80b4ac98..08f35c8514b106ab6171..3ba3cf8e849511ad8751..85de9f3f89d4a93a19d0..32fe4ba2c6dff7d5afd5..3bea2815bfhttps://chromium.googlesource.com/catapult.git/+log/36e45025a8..ab687ea7be
* src/third_party/depot_tools: e0de6a88e5..057831ef1f104674b531..4fb42ae52ee9c50fa77d..b9b74f9f781a8ecf1813..965f8ecbfdd879aac971..81d656878ehttps://aomedia.googlesource.com/aom.git/+log/79b7757996..6c93db7ff6
* src/third_party/libyuv: a8c181050c..64994843e6https://chromium.googlesource.com/linux-syscall-support.git/+log/29f7c7e018..92a65a8f5d
* src/third_party/perfetto: acb2e677b4..9511660f9379f0178cd3..70d42ae95aadd6c82864..78b6ac0da434f3c82122..2dffe0671134f3c82122..2dffe06711TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I3b3a469e48383e250adaf46b186d5cad038957a6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215021
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33696}
2021-04-12 18:25:58 +00:00
Andrey Logvin
bccfd26322
Allow webrtc mac cross compile
...
Chromium side changes: https://crrev.com/c/2743475
Bug: b/180976558
Change-Id: I4db49b91379d8b7f293147bdefb4296861faf0a2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/210684
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Andrey Logvin <landrey@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33424}
2021-03-10 18:42:58 +00:00
Mirko Bonadei
d892e6e1b4
[build] Remove obsolete gn flag
...
Bug: chromium:1164276
Change-Id: I814f831e218703cfb1f45802b62f38a78dee82e1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/201281
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32939}
2021-01-11 17:57:44 +00:00
Courtney Edwards
e3f70cddc8
set perfetto flag to default value of false
...
Bug: None
Change-Id: I415052619119e2f72deffce17c9950a98c23df3c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179961
Commit-Queue: Courtney Edwards <courtneyfe@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31780}
2020-07-22 10:14:53 +00:00
Mirko Bonadei
2a8932020e
Rename sanitizers suppression files.
...
Bug: webrtc:11680
Change-Id: Idc5b0644ecf1368c5e070d92120c66487855cf31
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178382
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31627}
2020-07-03 18:29:58 +00:00
Jeremy Leconte
f4b956c026
Roll chromium_revision 71a0e1904e..51d47a5bb4 (782339:783422)
...
Change log: 71a0e1904e..51d47a5bb471a0e1904e..51d47a5bb4736d9fb42c..057fa3c509ceecd92e25..d83f4a5f0073c8bcb1b1..3e0172132577ba7104d5..6cdbe3084b1908162da7..9f9e479209https://chromium.googlesource.com/catapult.git/+log/e0658a4adf..a2a7e05eb7
* src/third_party/depot_tools: 87c8b91639..6e6c67d0ea44e38c4643..3e2475b08dd6998993f9..15b01f76a171a0e1904e..51d47a5bb471a0e1904e..51d47a5bb4TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ie86e05ccd1d9f460e6d84ef7bfe938ebf931bfc0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178342
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31576}
2020-06-29 09:24:15 +00:00
Jeremy Leconte
b19cfeeb5c
Roll chromium_revision 4d95e6c77b..71a0e1904e (776481:782339)
...
Change log: 4d95e6c77b..71a0e1904e4d95e6c77b..71a0e1904e2df7267880..736d9fb42ca03951acb9..876a7806001b066f0216..1ed99573d59200aad36b..73c8bcb1b1502600d41a..77ba7104d5e0df6e10ad..1908162da7https://boringssl.googlesource.com/boringssl.git/+log/88024df121..430a742303
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2ad47493f8..e0658a4adf
* src/third_party/depot_tools: 37e562110f..87c8b91639be66dc5fd0..23b2a15c2562fea391fa..a443474755630b884f84..79326efe26https://aomedia.googlesource.com/aom.git/+log/2aa13c436e..e1ebb418eb
* src/third_party/libunwindstack: 046920fc49..11659d420ac176557314..769129fb2960cf022c02..44e38c464395f6fb6f1e..1c98ea6854050a4a5e26..d6998993f94d95e6c77b..71a0e1904e4d95e6c77b..71a0e1904eTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,marpan@webrtc.org, jianj@chromium.org ,
BUG=None
Change-Id: Idb4a2ccc6eab502ecf78b34247a479ff5726b50a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178084
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#31569}
2020-06-26 05:33:14 +00:00
Andrey Logvin
0c3062efcb
Roll chromium_revision 5177dd5686..4d95e6c77b (776000:776481)
...
Change log: 5177dd5686..4d95e6c77b5177dd5686..4d95e6c77b12aafbd23b..2df726788045f27c5e79..a03951acb96d0f4efc06..9200aad36ba67f60963b..502600d41ab81d3c846f..e0df6e10adhttps://chromium.googlesource.com/catapult.git/+log/03e7ff4035..2ad47493f8
* src/third_party/depot_tools: a85d58e50e..37e562110fd018c278d3..050a4a5e265177dd5686..4d95e6c77b5177dd5686..4d95e6c77bTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I55bb359cd525252ea0c46035d0f27447cd7fe010
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176821
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Andrey Logvin <landrey@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31477}
2020-06-09 14:24:01 +00:00
Markus Handell
f70fbc8411
Introduces rtc_base/synchronization/mutex.h.
...
This change introduces a new non-reentrant mutex to WebRTC. It
enables eventual migration to Abseil's mutex.
The mutex types supportable by webrtc::Mutex are
- absl::Mutex
- CriticalSection (Windows only)
- pthread_mutex (POSIX only)
In addition to introducing the mutexes, the CL also changes
PacketBuffer to use the new mutex instead of rtc::CriticalSection.
The method of yielding from critical_section.cc was given a
mini-cleanup and YieldCurrentThread() was added to
rtc_base/synchronization/yield.h/cc.
Additionally, google_benchmark benchmarks for the mutexes were added
(test courtesy of danilchap@), and some results from a pthread/Abseil
shootout were added showing Abseil has the advantage in higher
contention.
Bug: webrtc:11567, webrtc:11634
Change-Id: Iaec324ccb32ec3851bf6db3fd290f5ea5dee4c81
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176230
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31443}
2020-06-04 09:55:12 +00:00
Patrik Höglund
afa2e5f18c
Purge phoglund from most OWNERS files.
...
I'll hold on to the root OWNER for a bit longer for convenience.
Bug: None
Change-Id: I13303ba726fed612adc74008eeaaeadf9595e084
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170047
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30727}
2020-03-09 14:08:30 +00:00
Mirko Bonadei
e07d3b432a
Remove crbug.com/904400 workaround.
...
The bug is now fixed.
Bug: chromium:904400
Change-Id: I86e0766cec5ebc8f22af604ba7cc977a20a95ad6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127881
Reviewed-by: Artem Titarenko <artit@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27150}
2019-03-15 18:36:23 +00:00
Mirko Bonadei
10b051083c
Disable hermetic toolchain when building on macOS 10.14.
...
This is copied from https://chromium-review.googlesource.com/1333877
More info is available at crbug.com/904400.
Bug: webrtc:10093
Change-Id: Ia256b3515b354b501663f0536c2735542474d3c0
Reviewed-on: https://webrtc-review.googlesource.com/c/113422
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25932}
2018-12-07 13:57:28 +00:00
Elad Alon
f0db2e2ef5
nit: Missing space in build_overrides/build.gni
...
Bug: None
Change-Id: I98aceaa0bb2db34aa04273f9dfcca35f604915c9
Reviewed-on: https://webrtc-review.googlesource.com/c/111082
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25657}
2018-11-15 14:17:12 +00:00
Mirko Bonadei
6ef89e7a36
Rectify comment about 'build_with_chromium'.
...
Bug: webrtc:9988
Change-Id: I0cc7e0c9da0ff969d6269086c9df8f6725536da5
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/c/110862
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25631}
2018-11-14 10:08:32 +00:00
Mirko Bonadei
c58c8a5422
Adding mbonadei@ to build_overrides/OWNERS.
...
Bug: None
Change-Id: I40b3f5371d86054872e17381d612b888637861dc
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/c/110864
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25630}
2018-11-14 10:07:27 +00:00
Henrik Kjellander
90d46c472d
Add phoglund@ to various OWNERS and remove kjellander@
...
TBR=henrika@webrtc.org
Bug: webrtc:8363
Change-Id: Ibcb3e8d40a93542ea0825faf92a6db11dc5a0c13
Notry: True
Reviewed-on: https://webrtc-review.googlesource.com/7606
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20344}
2017-10-19 09:21:12 +00:00
oprypin
370c6d5694
Use hermetic toolchain on Mac, except for local iOS builds
...
Copied from https://chromium.googlesource.com/chromium/src/+/d04b06a98/build_overrides/build.gni
BUG=chromium:763924
Review-Url: https://codereview.webrtc.org/3013003002
Cr-Commit-Position: refs/heads/master@{#19781}
2017-09-11 18:38:48 +00:00
kjellander
ec2c93e947
Use bundled SDK 10.12 toolchain for Mac and iOS.
...
BUG=webrtc:6608, webrtc:8099, chromium:659726, chromium:763440
TBR=mbonadei@webrtc.org
NOTRY=True
Review-Url: https://codereview.webrtc.org/2995033002
Cr-Commit-Position: refs/heads/master@{#19753}
2017-09-08 17:52:17 +00:00
erikchen
bc266bc867
Remove deprecated macOS SDK overrides.
...
The same overrides now live in .gn.
Bug:chromium:669240
Review-Url: https://codereview.webrtc.org/2982863002
Cr-Commit-Position: refs/heads/master@{#19030}
2017-07-14 21:29:23 +00:00
Henrik Kjellander
90fd7d84fd
Rename tools-webrtc -> tools_webrtc
...
This aligns with established naming convention for all
other directories.
BUG=webrtc:7593
NOTRY=True
NOTREECHECKS=True
R=ehmaldonado@webrtc.org , mbonadei@webrtc.org
TBR=henrika@webrtc.org
Review-Url: https://codereview.webrtc.org/2864213004 .
Cr-Commit-Position: refs/heads/master@{#18059}
2017-05-09 06:30:13 +00:00
mbonadei
18e83ea598
Moving sanitizers from build/ to base/
...
We have to move the content of the 'webrtc/build/' directory up of one level (see crbug.com/611808 for further details).
To avoid a collision with the DEPSed build/ at the top level we are moving all the content of 'webrtc/build/' to different locations (see webrtc:7030 for the suggested locations).
BUG=webrtc:7030
NOTRY=True
Review-Url: https://codereview.webrtc.org/2651913002
Cr-Commit-Position: refs/heads/master@{#16259}
2017-01-25 07:04:51 +00:00
mbonadei
822d2586fb
Move webrtc/build/android -> tools-webrtc/android
...
BUG=webrtc:7030
Review-Url: https://codereview.webrtc.org/2649883004
Cr-Commit-Position: refs/heads/master@{#16239}
2017-01-24 12:22:11 +00:00
Henrik Kjellander
7d9305f473
Remove WebRTC-specific test runner script for Android
...
After moving away from the Chromium checkout and the symlinks, we
no longer need to have our own test_runner.py script for Android tests
BUG=webrtc:5006
TBR=ehmaldonado@webrtc.org
Review-Url: https://codereview.webrtc.org/2600193002 .
Cr-Commit-Position: refs/heads/master@{#15801}
2016-12-27 08:21:19 +00:00
Henrik Kjellander
9547033637
Move tools/{msan,ubsan} -> tools-webrtc/
...
After landing https://codereview.chromium.org/2580313002/ in
Chromium and rolled it in, this is now possible.
BUG=webrtc:5006
TBR=charujain@webrtc.org
NOTRY=True
Review-Url: https://codereview.webrtc.org/2589093002 .
Cr-Commit-Position: refs/heads/master@{#15695}
2016-12-20 07:04:25 +00:00
kthelgason
2305b701ae
Remove unused build override
...
BUG=webrtc:6431
Review-Url: https://codereview.webrtc.org/2545503002
Cr-Commit-Position: refs/heads/master@{#15335}
2016-11-30 15:01:24 +00:00
kjellander
847f6897f2
Roll chromium_revision 5e821a778b..5c22c2afac (432715:434448)
...
Manual changes needed to use our own test runner for Android tests.
VideoProcessorIntegrationTest.ProcessNoLossChangeFrameRateFrameDropVP9
is failing for TSan and UBSan configs, so disable the test for them here.
Change log: 5e821a778b..5c22c2afac5e821a778b..5c22c2afac1f985091a5..991f459071https://chromium.googlesource.com/android_tools.git/+log/c02a002b48..811a2c3f91
* src/third_party/catapult: 249cfbcd88..671a6547363c7a098821..d16162e3f47ddf5e9ba1..dda089a98a5c64c01c7c..d7f1d60c5157d33bee78..7acede9c035e821a778b..5c22c2afac5e821a778b..5c22c2afacTBR=marpan@webrtc.org , ehmaldonado@webrtc.org
BUG=webrtc:6775, webrtc:6739, webrtc:6781
NOTRY=True
Review-Url: https://codereview.webrtc.org/2533733002
Cr-Commit-Position: refs/heads/master@{#15256}
2016-11-28 10:04:45 +00:00
kjellander
218f436713
Roll chromium_revision 1a6cf4da7c..f1e2718a3f (431807:431838)
...
Use system Xcode on Mac instead of the hermetic toolchain which
is now the default in Chromium. WebRTC needs the 10.12 SDK to
compile successfully, which is not availble in the hermetic
toolchain Chromium is rolling out to Googlers.
Change log: 1a6cf4da7c..f1e2718a3f1a6cf4da7c..f1e2718a3fTBR=ehmaldonado@webrtc.org
BUG=webrtc:6700
Review-Url: https://codereview.webrtc.org/2496113002
Cr-Commit-Position: refs/heads/master@{#15057}
2016-11-14 07:54:34 +00:00
kthelgason
cc2d1c6917
Bump mac deployment target to 10.9
...
BUG=webrtc:6431
Review-Url: https://codereview.webrtc.org/2488943002
Cr-Commit-Position: refs/heads/master@{#15004}
2016-11-09 15:44:34 +00:00
kjellander
b1125685a0
Roll chromium_revision 9b5bb47fa0..04e7c673d9 (426837:427632)
...
Configure ignore_elf32_limitations = true in build_overrides/build.gni
as made possible by https://codereview.chromium.org/2448453002/
Changes to webrtc/test/ios/Info.plist were needed due to https://codereview.chromium.org/2441793002
Change log: 9b5bb47fa0..04e7c673d99b5bb47fa0..04e7c673d99aa0bddeb6..0a3128c75d294a734a5f..9a032fa262198bce3959..550cf829fb9b5bb47fa0..04e7c673d99b5bb47fa0..04e7c673d9TBR=marpan@webrtc.org ,
BUG=webrtc:6596, webrtc:6608
NOTRY=True
Review-Url: https://codereview.webrtc.org/2447263003
Cr-Commit-Position: refs/heads/master@{#14794}
2016-10-26 20:38:10 +00:00
ehmaldonado
4016a0b2e8
GN: Move variables from //build_overrides/webrtc.gni to //webrtc/build/webrtc.gni
...
There is no clear reason to have them in build_overrides, and
webrtc/build seems to be a better place.
Also, delete build_overrides/webrtc.gni
NOTRY=True
BUG=webrtc:5949
Review-Url: https://codereview.webrtc.org/2309253004
Cr-Commit-Position: refs/heads/master@{#14108}
2016-09-07 13:50:23 +00:00
ehmaldonado
70279215a6
Add linux_use_bundled_binutils_override = true to build_overrides.
...
This variable was introduced in https://codereview.chromium.org/2293853002
and causes builds to fail, since is not defined in WebRTC.
NOTRY=True
BUG=webrtc:6281
Review-Url: https://codereview.webrtc.org/2295923005
Cr-Commit-Position: refs/heads/master@{#13987}
2016-08-31 09:00:01 +00:00
ehmaldonado
08c047ee37
GN: Use custom suppressions for lint in android.
...
Also, suppress lint warnings that were causing compiling errors.
BUG=webrtc:6281
NOTRY=True
Review-Url: https://codereview.webrtc.org/2293383002
Cr-Commit-Position: refs/heads/master@{#13985}
2016-08-31 08:55:10 +00:00
ehmaldonado
2df32a31d2
GN: Override lsan and tsan suppression files.
...
BUG=webrtc:6236
NOTRY=True
Review-Url: https://codereview.webrtc.org/2274883002
Cr-Commit-Position: refs/heads/master@{#13897}
2016-08-24 14:46:16 +00:00
phoglund
18832f6c35
Make rtc_include_tests true by default in gn.
...
See bug for discussion.
BUG=webrtc:6119
TBR=kjellander@webrtc.org
Review-Url: https://codereview.webrtc.org/2156203002
Cr-Commit-Position: refs/heads/master@{#13500}
2016-07-19 19:56:56 +00:00
phoglund
136778252d
Revert of Fix inconsistent setting of the rtc_include_unittests flag. (patchset #1 id:1 of https://codereview.webrtc.org/2154693002/ )
...
Reason for revert:
Nope, breaks chromium
Original issue's description:
> Fix inconsistent setting of the rtc_include_unittests flag.
>
> On advice from brettw, se discussion here:
> https://codereview.webrtc.org/2149543002/
>
> The problem was we were setting the flag to both false and true,
> and the the true happened to win out for WebRTC checkouts and
> false for Chromium checkouts. This change should make this
> mechanic more obvious.
>
> This change _should_ have no effect downstream.
>
> Doing tbr to see if we can get the chromium import back into a good state today.
>
> TBR=tommi@webrtc.org
>
> Committed: https://crrev.com/9d34148714773339a4e8396bd28aceb571554d36
> Cr-Commit-Position: refs/heads/master@{#13484}
TBR=tommi@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.webrtc.org/2150293002
Cr-Commit-Position: refs/heads/master@{#13486}
2016-07-15 11:13:28 +00:00
phoglund
9d34148714
Fix inconsistent setting of the rtc_include_unittests flag.
...
On advice from brettw, se discussion here:
https://codereview.webrtc.org/2149543002/
The problem was we were setting the flag to both false and true,
and the the true happened to win out for WebRTC checkouts and
false for Chromium checkouts. This change should make this
mechanic more obvious.
This change _should_ have no effect downstream.
Doing tbr to see if we can get the chromium import back into a good state today.
TBR=tommi@webrtc.org
Review-Url: https://codereview.webrtc.org/2154693002
Cr-Commit-Position: refs/heads/master@{#13484}
2016-07-15 10:56:14 +00:00
kjellander
68208897be
Roll chromium_revision 7fa6701bc5..1a73d11e65 (398458:399420)
...
A fix was needed to make Android tests pass after
https://codereview.chromium.org/2043803003
Another fix was needed for the webrtc_perf_tests.isolate sinc eit was missing
one file.
Change log: 7fa6701bc5..1a73d11e657fa6701bc5..1a73d11e658dd3c8e39a..099f1da55bhttps://boringssl.googlesource.com/boringssl.git/+log/0fc7df55c0..171b5403ee
* src/third_party/ffmpeg: 7f03319b9d..bcb8b67b8b7fa6701bc5..1a73d11e65https://codereview.webrtc.org/2074043002
Cr-Commit-Position: refs/heads/master@{#13178}
2016-06-17 06:29:38 +00:00
kjellander
dfe6937666
Revert of Roll chromium_revision 7fa6701bc5..1a73d11e65 (398458:399420) (patchset #2 id:20001 of https://codereview.webrtc.org/2061723002/ )
...
Reason for revert:
webrtc_perf_tests fails on all Android Release testers:
http://build.chromium.org/p/client.webrtc/builders/Android64%20Tests%20%28L%20Nexus9%29/builds/3673
Original issue's description:
> Roll chromium_revision 7fa6701bc5..1a73d11e65 (398458:399420)
>
> A fix was needed to make Android tests pass after
> https://codereview.chromium.org/2043803003
>
> Change log: 7fa6701bc5..1a73d11e657fa6701bc5..1a73d11e658dd3c8e39a..099f1da55bhttps://boringssl.googlesource.com/boringssl.git/+log/0fc7df55c0..171b5403ee
> * src/third_party/ffmpeg: 7f03319b9d..bcb8b67b8b7fa6701bc5..1a73d11e65https://crrev.com/c49cf1308f879ce029f5f0e804b4eef3b08b67c5
> Cr-Commit-Position: refs/heads/master@{#13117}
TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5990
Review-Url: https://codereview.webrtc.org/2059423002
Cr-Commit-Position: refs/heads/master@{#13118}
2016-06-13 21:11:09 +00:00
