Commit graph

20 commits

Author SHA1 Message Date
Danil Chapovalov
85bea5a11b Recommend to follow C++ tips of the week in webrtc c++ style guide
Link c++ tips of the week as best practices for better discoverability.
Extend deprecated section with recommendation to use recently published ABSL_DEPRECATE_AND_INLINE macro.

No-Try: True
Bug: None
Change-Id: I3336e5929ae31542ff12ef6b1dfd9c272b9c480a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347743
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42100}
2024-04-17 14:08:57 +00:00
Mirko Bonadei
6f72008cd6 Update TODO example in the style guide.
This CL fixes the example in the WebRTC style guide and aligns it to
https://google.github.io/styleguide/cppguide.html#TODO_Comments.

Bug: None
Change-Id: Ic1d424b56f047d7d8266a76acb3fb881c8de4c50
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/328220
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41206}
2023-11-21 23:11:09 +00:00
Sergey Silkin
ebc4d3edd5 Move StrJoin to rtc_base/strings
A similar function was defined in rtc_base/openssl_adapter. Moving it from net/dcsctp/common/ to rtc_base/strings/. I'm planning to use StrJoin in a video codec test (a follow-up change).

Bug: webrtc:14852
Change-Id: Ie657c03e7f9fb52c189c127af6f66ec505b512ae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/327322
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41166}
2023-11-15 12:10:28 +00:00
Harald Alvestrand
e677c7937e Recommend rtc::StringBuilder rather than +
Bug: none
Change-Id: Ib6d5d582b1c1c5032ba5c388e47963784db2b6b2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/325282
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41039}
2023-10-30 13:38:38 +00:00
Artem Titov
a617867a45 Reland "Migrate WebRTC documentation to new renderer"
This reverts commit 0f2ce5cc1c.

Reason for revert: Downstream infrastructure should be ready now

Original change's description:
> Revert "Migrate WebRTC documentation to new renderer"
>
> This reverts commit 3eceaf4669.
>
> Reason for revert:
>
> Original change's description:
> > Migrate WebRTC documentation to new renderer
> >
> > Bug: b/258408932
> > Change-Id: Ib96f39fe0c3912f9746bcc09d079097a145d6115
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290987
> > Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> > Commit-Queue: Artem Titov <titovartem@webrtc.org>
> > Cr-Commit-Position: refs/heads/main@{#39205}
>
> Bug: b/258408932
> Change-Id: I16cb4088bee3fc15c2bb88bd692c592b3a7db9fe
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291560
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
> Owners-Override: Artem Titov <titovartem@webrtc.org>
> Commit-Queue: Artem Titov <titovartem@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#39209}

Bug: b/258408932
Change-Id: Ia172e4a6ad1cc7953b48eed08776e9d1e44eb074
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291660
Owners-Override: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39231}
2023-01-31 09:30:04 +00:00
Artem Titov
0f2ce5cc1c Revert "Migrate WebRTC documentation to new renderer"
This reverts commit 3eceaf4669.

Reason for revert: 

Original change's description:
> Migrate WebRTC documentation to new renderer
>
> Bug: b/258408932
> Change-Id: Ib96f39fe0c3912f9746bcc09d079097a145d6115
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290987
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Commit-Queue: Artem Titov <titovartem@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#39205}

Bug: b/258408932
Change-Id: I16cb4088bee3fc15c2bb88bd692c592b3a7db9fe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291560
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39209}
2023-01-26 20:19:12 +00:00
Artem Titov
3eceaf4669 Migrate WebRTC documentation to new renderer
Bug: b/258408932
Change-Id: Ib96f39fe0c3912f9746bcc09d079097a145d6115
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290987
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39205}
2023-01-26 14:58:00 +00:00
Mirko Bonadei
ab397ddec4 Update WebRTC style guide about GN.
No-Try: True
Bug: None
Change-Id: Iaee25f35eba70d05c0bd2abd1a578db44414ede9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/288363
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38907}
2022-12-16 10:19:13 +00:00
Harald Alvestrand
f88487c5c9 Explicitly forbid dynamic_cast
After discussion on webrtc-core, this option is still thought to be
a Bad Idea in webrtc.

Bug: none
Change-Id: I15d0a6f7d6489b8bf37c1dfa31572139c9b85753
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/281881
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38555}
2022-11-04 12:37:57 +00:00
Emil Lundmark
11174e7058 Clarify how to reference WebRTC bugs in TODOs
Bug: None
No-Try: true
Change-Id: Iaa8b57dea096ef0588979faa5ba7c22dcff1dada
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267282
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Emil Lundmark <lndmrk@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37387}
2022-07-01 08:03:34 +00:00
Harald Alvestrand
832657f162 Recommend using [[deprecated]] over ABSL_DEPRECATED
Bug: none
Change-Id: I6018fc75d347d610d078077e7b34131efaaef0db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260160
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36696}
2022-04-28 15:27:18 +00:00
Danil Chapovalov
23bb9d75fc Allow designated initializers in WebRTC
to align with chromium and google style guides

Bug: None
Change-Id: I92e1bb6d187eac6b531d495aedb8176f66186a5f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251689
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36002}
2022-02-15 13:23:12 +00:00
Danil Chapovalov
8ad0be0ab1 Update link to chromium modern c++ page
The page was renamed in
https://chromium-review.googlesource.com/c/chromium/src/+/3399246

Bug: None
No-Try: true
Change-Id: I7ddfb6c91b61ec071fbac95a30c56161119cc683
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/248863
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35783}
2022-01-25 11:07:43 +00:00
Danil Chapovalov
80569ea2be Refresh WebRTC style guide
Remove advice to keep legacy style for consistency because it condridicts a recent addition to style guide goals
Remove debatable reason for banning std::shared_ptr, keep main reason
to ban it as the only one.

Bug: None
Change-Id: I4c31f9247a33430df0b286a15f1a35ab23060d1c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247183
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35720}
2022-01-18 10:54:23 +00:00
Mirko Bonadei
28cd164ac7 Update style guide about C++17
Bug: None
Change-Id: Ic1ec302d317232291a3ec54fa7a6fa28c8635c1d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/242960
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35589}
2021-12-29 08:06:27 +00:00
Joe Mason
9cd326c0cf Update missed link to chromium C++11 styleguide
Follow-up to https://webrtc-review.googlesource.com/c/src/+/232260:
there's a second link to the obsolete chromium-cpp.appspot.com in the
same file that was missed.

Also updates the link to be more precise: the new markdown file has
anchors on individual entries, not just the section headers.

R=danilchap@webrtc.org

Bug: chromium:1243839
Change-Id: I17918d155aacf3465a46fd674a598139a0870165
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232560
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35043}
2021-09-20 21:05:39 +00:00
Joe Mason
4893dbe7f1 Update link to Chromium Modern C++ style guide
Bug: chromium:1243839
Change-Id: I4a914eec78c919347a65be4d5b5fc6447408bc39
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232260
Commit-Queue: Joe Mason <joenotcharles@google.com>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35028}
2021-09-17 14:06:01 +00:00
Tony Herre
b0ed12099f Update links to point at main branch
As part of go/coil update code search links to not point to the
"master" branch.

Bug: chromium:1226942
Change-Id: I0ae9e84ecc660f789a69fe0b226f93bbc39a8a66
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226081
Commit-Queue: Tony Herre <toprice@chromium.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#34531}
2021-07-22 16:41:26 +00:00
Fanny Linderborg
0d2dc1f38f Reference "main" branches instead of "master" branches.
Both WebRTC and Chromium have migrated from the "master" to the "main" branch.

TBR=hta@webrtc.org

Bug: None
Change-Id: I2b5e6973bdd8fdc9c1bd96e2747a8a9ac2630b14
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226080
Commit-Queue: Fanny Linderborg <linderborg@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#34475}
2021-07-15 11:07:44 +00:00
Danil Chapovalov
46f5c11e4f Move style guide and abseil-in-webrtc into g3doc subfolder
No-Try: true
Bug: None
Change-Id: I45c3e515f6e446f8982333869d8ad2c6ae15978d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/218347
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#34004}
2021-05-13 14:43:10 +00:00
Renamed from style-guide.md (Browse further)