Bilinear is faster but lesser quality, box is best quality. Our code
base has disagreed about which filter to use for quite some time,
causing aliasing bug reports. In an effort to avoid aliasing artifacts
and make our scaling filters more predictable, we're updating all uses
to kFilterBox.
WebRTC already uses kFilterBox everywhere except for these three
places. The main discrepency was between Chromium and WebRTC but that
has already been fixed. This CL fixes the last remaining bilinears.
This brings the WebRTC kFilterBox use count up from 11 to 14 and the
kFilterBilinear use count down from 3 to 0.
Bug: chromium:1212630
Change-Id: I5fe4aa92b9275d65b91ea97925533055d190d317
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/221372
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#34248}
This class adds logic for aligning what part of a test video has been
encoded from a reference video. It does that by cropping and zooming in
on a region of the reference video that most closely matches the test
video. A small cropping does not have much impact on human perception,
but it has a big impact on PSNR and SSIM calculations.
For example, if the test video is cropped with one row in the top and
bottom, adjusting for this improves average PSNR from 27.7146 to
29.3357 and average SSIM from 0.934891 to 0.95318 in an example test
video.
TBR=phoglund
Bug: webrtc:9642
Change-Id: I02cfe0e2261fb58df8cdb1e15ba93285e3dc4538
Reviewed-on: https://webrtc-review.googlesource.com/c/99480
Commit-Queue: Magnus Jedvert <magjed@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@google.com>
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25755}
