Commit graph

1724 commits

Author SHA1 Message Date
Jim Gustafson
a322dda556
Add audio device module for android based on Oboe 2024-07-03 12:28:41 -07:00
Jim Gustafson
16dbd7a436 Remove support for setting mobile aec 2024-06-28 14:28:54 -07:00
Jim Gustafson
99c102adad m126 merge fixes 2024-06-25 14:25:19 -07:00
Jim Gustafson
49c96f3e79 Merge remote-tracking branch 'google/branch-heads/6478' 2024-06-21 16:31:45 -07:00
Jim Gustafson
c43adafcd5 Merge m123/6312 2024-06-12 22:25:35 -07:00
Guy Hershenbaum
94dfe1cc59 Fix NetworkMonitor race condition when dispatching native observers
There is a race condition in NetworkMonitor where native observers may be removed concurrently with a notification being dispatched, leading to a dangling pointer dereference (trying to dispatch an observer that was already removed and destroyed), and from there a crash with access violation.

By ensuring dispatching to native observers is done within the synchronization lock that guards additions/removals of native observers protects against this race condition.
Since native observers callbacks are posted to the networking thread in the C++ side anyway, there should be no risk of deadlock/starvation due to long-running observers.

Bug: webrtc:15837
Change-Id: Id2b788f102dbd25de76ceed434c4cd68aa9a569e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/338643
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42256}
2024-05-08 08:27:19 +00:00
Mohamed
bc5c5e9d66 Migrate webrtc to stop using its own JniZero mirror classes
Bug: chromium:325408567
Change-Id: I2eb33b077148bf89223f1f69b07339fc9f2d948e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347921
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42151}
2024-04-23 12:50:19 +00:00
Florent Castelli
f4673f97ed Move webrtc::AudioDeviceModule include to api/ folder
Bug: webrtc:15874
Change-Id: I5bdb19d5e710838b41e6ca283d406c9f1f21286b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/348060
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42137}
2024-04-22 08:56:31 +00:00
Florent Castelli
0afde7614d Move webrtc::AudioProcessing include to api/ folder
Bug: webrtc:15874
Change-Id: Ie8a6e031c0f0505cfe238f7d252c47e9c34408d4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347983
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Auto-Submit: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42128}
2024-04-20 07:02:50 +00:00
Jonas Oreland
299b285696 Add PortAllocatorFlags to JAVA API
And add PORTALLOCATOR_ENABLE_ANY_ADDRESS_PORTS
which makes WebRTC allocate an unbound port.

BUG=None

Tested: Manually (not the flag, but that it doesn't break anything)
Change-Id: Iba541eb366f111e5ab7844bb3a2dc25ca0838cfe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347881
Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42119}
2024-04-19 07:00:22 +00:00
Danil Chapovalov
bdfcaba85b Propagate field trials to VideoEncoderSoftwareFallbackWrapper with Environment
Bug: webrtc:15860
Change-Id: Ief6a2eeab1713a371bc0350f6bdb5a18fb01945b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/345660
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42051}
2024-04-12 12:47:10 +00:00
Danil Chapovalov
424342d8ee Migrate objc VideoEncoders to RTCNativeBideoEncoderBuilder protocol
Bug: webrtc:15860
Change-Id: Iace411b2768cc788a5e6e8bab194267ed5a7dcec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/343741
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41995}
2024-04-04 13:14:45 +00:00
Mirko Bonadei
f090bf70ed Roll chromium_revision 566136c383..0d298af41c (1274799:1277684)
* Fix jni_zero integration following https://chromium-review.googlesource.com/c/chromium/src/+/5370266.
* Add infra team as owner of jni_generator_helper.

Change log: 566136c383..0d298af41c
Full diff: 566136c383..0d298af41c

Changed dependencies
* fuchsia_version: version:19.20240312.3.1..version:19.20240320.0.1
* src/base: 669f5c90a1..c76e0b4d4e
* src/build: 68409c6133..1104ba151b
* src/buildtools: 68fce43789..608975a0c5
* src/buildtools/linux64: git_revision:22581fb46c0c0c9530caa67149ee4dd8811063cf..git_revision:cfddfffb7913868936e76a269ae824aadd737b1b
* src/buildtools/mac: git_revision:22581fb46c0c0c9530caa67149ee4dd8811063cf..git_revision:cfddfffb7913868936e76a269ae824aadd737b1b
* src/buildtools/win: git_revision:22581fb46c0c0c9530caa67149ee4dd8811063cf..git_revision:cfddfffb7913868936e76a269ae824aadd737b1b
* src/ios: 8c8e35d7e8..17d9539a97
* src/testing: c0afd10e6e..903dfae8ff
* src/third_party: d0ea1392a4..a421ed20aa
* src/third_party/android_build_tools/manifest_merger: F0PdwwAdegLPfHzchRQ5Ec8_64ioPvucBKmei_kTraYC..HxnrwdWmIAhi90brIHiGZ4zmnmgKxP4PD0ZsJX6j-mUC
* src/third_party/androidx: bvCkZXWHMfORF34pYpyjkz-Bpco6EkcB2RWz8y9iEt0C..0EwFJFrU0PTFeq4_1_rFm4DwtqgHn--H2ZSrSUj4yUgC
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/4fa4804c8a..368d0d87d0
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/fb6c0bb480..9128ec6d34
* src/third_party/depot_tools: ca4cfdaf00..1cba129f31
* src/third_party/fuzztest/src: bddcd9f77b..d7c63cd216
* src/third_party/kotlin_stdlib: -uFeIws_FQzyqmgZlGL37ooRLAD8mwClD33O8rZwnTsC..8ap4rwZkKWCv2SPYRERFhMf-wVSsLCAE3fAFe7smZsoC
* src/third_party/kotlinc/current: DoPNLH4-m0sn0ERonCwcex3XmEpvbAWd2Pwv1ZSDGsQC..-kUQ1HWm0wwi5pXKSqIplyfSInHmtRS9cVUzg-2l-Y0C
* src/third_party/libaom/source/libaom: https://aomedia.googlesource.com/aom.git/+log/158761dfb4..80123cb352
* src/third_party/libc++/src: 80307e66e7..0c90b8212c
* src/third_party/libvpx/source/libvpx: 19832b1702..cab4f31e1d
* src/third_party/perfetto: 13fb5d53a1..1d622188fc
* src/third_party/r8: JTVRM33_2BjCw-dM85_HEcqBxFWTyphkzbKXDSuJLkoC..nB1Wwa_24Z-187iGmdHqyghl0vGR2QEbt8HiBKfSq2YC
* src/third_party/turbine: D9u_Hp4Dkt63hBSf5_oNk-Y7bOLGC7toa6H9cJ3rNokC..JYrlFcNFCmJoG4mYco1fxSNuhgASzU-EdBb4_Bd2-z0C
* src/tools: 2fb44b3615..5e1e0c8f88
DEPS diff: 566136c383..0d298af41c/DEPS

No update to Clang.

BUG=None

Change-Id: I52cfdd18a66529da2b56ac8d4884fe9d4aefa682
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/344500
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41979}
2024-03-30 16:33:59 +00:00
Kári Tristan Helgason
3277fe1d75 Fix UIDeviceOrientation enums.
Bug: b/328490295
Change-Id: Ieaeaddbc94528fba32c793986d20d54683a1d7a9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/343782
Auto-Submit: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41938}
2024-03-21 11:07:28 +00:00
Danil Chapovalov
007a62d83d Cleanup sdk android code from using VideoEncoderFactory::CreateVideoEncoder
To force webrtc::Environment propagation through android VideoEncoderFactory wrappers

Bug: webrtc:15860
Change-Id: Icad7249b47a5c738b089e09714c729f91eddaf5d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/342960
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41936}
2024-03-21 10:18:37 +00:00
Danil Chapovalov
d7e0981281 Propagate webrtc::Environment through objc VideoEncoderFactory
Bug: webrtc:15860
Change-Id: I9e7ee89e1ac9f950d38734510cf843e144108d24
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/342800
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41933}
2024-03-20 09:55:19 +00:00
Bjorn Terelius
a0672c5f32 Roll chromium_revision
(from b9338390dfcef481083d44d44c243c0c73196342
to 247e4de55550191706972861e586831a0d94d524)

Manually remove third_party/accessibility_test_framework from DEPS

Bug: b/329245293
Change-Id: Ie977314daf636f5208948ae74b7958ef3e296ffb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/342762
Commit-Queue: Jeremy Leconte <jleconte@webrtc.org>
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41902}
2024-03-15 07:58:00 +00:00
Per K
0fa90887c5 Deprecate VideoFrame::timestamp() and set_timestamp
Instead, add rtp_timestamp and set_rtp_timestamp.

Bug: webrtc:13756
Change-Id: Ic4266394003e0d49e525d71f4d830f5e518299cc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/342781
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Markus Handell <handellm@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41894}
2024-03-13 11:08:37 +00:00
Danil Chapovalov
f3096afd48 Propagate Environment to create VideoEncoder through java wrappers
Bug: webrtc:15860
Change-Id: If1a2873a899e1b839822a4b56aa87d4bae70c581
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/342740
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41887}
2024-03-12 15:34:12 +00:00
Harald Alvestrand
afaae4e38a Remove remaining .cc files from rtc_media_base
Also remove all dependencies on rtc_media_base except for a few
that are suspected of being linker directives.

Bug: webrtc:14775
Change-Id: Ic0daf88b5422047d3ed7079ee6af9e689853310c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/341461
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41886}
2024-03-12 14:09:38 +00:00
Harald Alvestrand
fb4ad29e3b Continue breakup of media/rtc_media_base
Left in target are just .cc files with .h files used externally.

Bug: webrtc:14775
Change-Id: I264f69bb29147fc0f8db877e3def8b21ed42181d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/341420
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41835}
2024-02-28 12:29:54 +00:00
Danil Chapovalov
dcc1534764 Delete rtc::TaskQueue
All usage was updated to use TaskQueueBase interface directly bypassing rtc::TaskQueue wrapper

Bug: webrtc:14169
Change-Id: I1808afd363b50448d4014d8d8402fce41b16a3ff
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/341082
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41834}
2024-02-28 10:22:49 +00:00
Philipp Hancke
bbff58d935 Introduce "well-known" SdpVideoFormat codecs
describing video codecs with their parameters as static members of SdpVideoFormat:
  static const SdpVideoFormat VP8();
  static const SdpVideoFormat H264();
  static const SdpVideoFormat VP9Profile0();
  static const SdpVideoFormat VP9Profile1();
  static const SdpVideoFormat VP9Profile2();
  static const SdpVideoFormat VP9Profile3();
  static const SdpVideoFormat AV1Profile0();
  static const SdpVideoFormat AV1Profile1();
This removes the need to craft instances of these by hand.

BUG=webrtc:15703

Change-Id: I2171e08b48ec98f18424f53f3b5d6d148130532e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/337441
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41833}
2024-02-28 06:57:10 +00:00
Danil Chapovalov
f7682f01bb Delete RTCWrappedNativeVideoDecoder
Instead implement creating native VideoDecoder via RTCNativeVideoDecoderBuilder protocol

Bug: webrtc:15791
Change-Id: Iea66d09e01eae3b064a2943932d9a3cd33e8d19c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/340321
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41824}
2024-02-27 17:03:28 +00:00
Mirko Bonadei
8adb080624 Roll chromium_revision a4279f2842..1f0d2a10bd (1259805:1264465)
Change log: a4279f2842..1f0d2a10bd
Full diff: a4279f2842..1f0d2a10bd

Changed dependencies
* fuchsia_version: version:18.20240207.3.1..version:18.20240215.1.1
* reclient_version: re_client_version:0.131.1.784ddbb-gomaip..re_client_version:0.132.0.1a8ff94-gomaip
* src/base: fd5eca261f..4edcfa650a
* src/build: a3566ffdee..e36f984f6f
* src/buildtools: f35a7d885a..88acf0de99
* src/buildtools/linux64: git_revision:a2e2717ea670249a34b0de4b3e54f268d320bdfa..git_revision:03d10f1657b4ddace618c34ab61b6357d1ae9c9a
* src/buildtools/mac: git_revision:a2e2717ea670249a34b0de4b3e54f268d320bdfa..git_revision:03d10f1657b4ddace618c34ab61b6357d1ae9c9a
* src/buildtools/reclient: re_client_version:0.131.1.784ddbb-gomaip..re_client_version:0.132.0.1a8ff94-gomaip
* src/buildtools/win: git_revision:a2e2717ea670249a34b0de4b3e54f268d320bdfa..git_revision:03d10f1657b4ddace618c34ab61b6357d1ae9c9a
* src/ios: 37d33be47e..0f9045d95e
* src/testing: a7e90605df..c863d4783f
* src/third_party: 121de111a9..9338c47087
* src/third_party/android_build_tools/manifest_merger: DEhOvoBwWVbV8XAI9NG-tn5g27KeMh2pXa44mY4dY10C..tQIUabJkFuwAI7BH20b0nn5fKWSPAa_M8cbkzpIW0VkC
* src/third_party/android_deps/libs/com_google_android_gms_play_services_base: version:2@18.0.1.cr1..version:2@18.1.0.cr1
* src/third_party/androidx: W2mpTbVe6yo3_GJiaoEVjCGnpicqsSrxcRMEADDJzMMC..t9WCSa3pyfLqHhv8_577tLFVY-ANlLru3HBHLPHdgAAC
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/10a2132f50..23824fa0fe
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c712e9cc34..189b13f92e
* src/third_party/dav1d/libdav1d: 47107e384b..7b15ca1375
* src/third_party/depot_tools: f76550541c..9d64acedea
* src/third_party/ffmpeg: 7c1b0b524c..79a88d3393
* src/third_party/icu: a622de35ac..1112fa6b3b
* src/third_party/kotlinc/current: 8nR_4qTn61NDCwL0G03LrNZzpgmsu5bbyRGior3fZX8C..ZrpoPpdqeDMIMIhXyd95yML-ZbNUIKDXSeYiWuxz2J0C
* src/third_party/libaom/source/libaom: https://aomedia.googlesource.com/aom.git/+log/0cee19cfc8..a2d599c975
* src/third_party/libc++/src: 9d119c1f4a..1506720cb3
* src/third_party/libvpx/source/libvpx: 96b64eaac5..3316c11240
* src/third_party/libyuv: 2f2c04c157..a6a2ec654b
* src/third_party/perfetto: e01c38d714..4183dabcac
* src/third_party/r8: tp4vVuXzmyHJxDFlwxDb7RYZLLEufc3EnGTyOTCTNkgC..ArRcmPYQPKnDIwdwwIr6T8QKNoFb-sQoKac2acxErbsC
* src/third_party/re2/src: ab7c5918b4..f9550c3f72
* src/tools: 2b9f1d699f..2b7d7f5046
* src/tools/luci-go: git_revision:c7b026b3a6a1f877ce46a90c5f761b10e5149891..git_revision:3df60a11d33a59614c0e8d2bccc58d8c30984901
* src/tools/luci-go: git_revision:c7b026b3a6a1f877ce46a90c5f761b10e5149891..git_revision:3df60a11d33a59614c0e8d2bccc58d8c30984901
Added dependencies
* src/third_party/android_deps/libs/com_google_android_gms_play_services_tflite_java
* src/third_party/android_deps/libs/com_google_android_gms_play_services_tflite_impl
* src/third_party/android_deps/libs/org_tensorflow_tensorflow_lite_api
DEPS diff: a4279f2842..1f0d2a10bd/DEPS

Clang version changed llvmorg-18-init-17730-gf670112a:llvmorg-19-init-2319-g7c4c2746
Details: a4279f2842..1f0d2a10bd/tools/clang/scripts/update.py

BUG=b/325398782

Change-Id: I2fa689dc0694e45d7ab7279da2dcbde215437c2d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/340402
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41796}
2024-02-23 23:57:11 +00:00
Zoé Lepaul
dc6a001b6b Update and open WebRtcAudioUtils
Opening the visibility of a few methods from this utils class to allow
it to be used by other implementations of `AudioDeviceModule`.

Also updating a few methods, like adding new audio device types from
recent Android SDKs, and updating the definition of an emulator.

Bug: b/287409066
Change-Id: I1473fa0342252347ce92ee2319380ebb14e9885b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/339905
Commit-Queue: Zoé Lepaul <xalep@webrtc.org>
Reviewed-by: Ranveer Aggarwal‎ <ranvr@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41778}
2024-02-21 11:18:40 +00:00
Danil Chapovalov
36d5eec6e1 Propagate webrtc::Environment through objc VideoDecoderFactory
Bug: webrtc:15791
Change-Id: I9e9206c6e2f7be2d2d59f80241cafcc27b9e6ad6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/339864
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41767}
2024-02-20 11:08:21 +00:00
Danil Chapovalov
0355f455a4 Use Environment propagated through android sdk
This way VP8Decoder and DecoderFallback would use propagated instead of global field trials.

Bug: webrtc:15791, webrtc:10335
Change-Id: I5ad5fae38f5b9379bc6376334562c154fbc56e39
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/340040
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41763}
2024-02-19 15:54:39 +00:00
Danil Chapovalov
2eee89e904 Cleanup webrtc::Environment propagation through java wrappers
Force and thus guarantee VideoDecoder created through java wrappers get access to the webrtc::Environment

Bug: webrtc:15791
Change-Id: I3f145937c0b914c8e34b24e1ecc55da756551069
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/338441
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41745}
2024-02-15 13:33:48 +00:00
Jim Gustafson
c37ca3fc86 Merge branch m122 2024-02-14 22:44:28 -08:00
Danil Chapovalov
22b6564d77 Propagate webrtc::Environment to create VideoDecoder through java wrappers
Bug: webrtc:15791
Change-Id: I25976158ef780211355deb934e83d275d4f881e2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/336980
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41686}
2024-02-07 11:58:20 +00:00
Byoungchan Lee
ff616269f8 Fix Chromium roll failures due to classpath format changes in jni_zero
This commit addresses an issue resulting from a change [1] in the
jni_zero project, where the format of classpath entries changed
(from using slashes 'org/webrtc/PeerConnectionFactory'
to dots 'org.webrtc.PeerConnectionFactory'). These changes led to
failures in the Chromium rolls in WebRTC, as the Class loader in JNI
was not designed to handle class names with dots.

This CL fixes this issue by changing webrtc::GetClass to convert class
paths to what JNI expects.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/5234469

Bug: chromium:1377351
Change-Id: I2f243bb4ed04136f86510fcd5472e9bfc2d4ba85
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/337900
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#41666}
2024-02-05 12:41:39 +00:00
Florent Castelli
a8375bb973 iOS: Fix building tests on real devices
Bug: webrtc:15797
Change-Id: Ieae0a08bb6b141cb70d6c865bf98041f1d21e1ca
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/336060
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Auto-Submit: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org>
Reviewed-by: Christoffer Dewerin <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#41604}
2024-01-24 15:10:25 +00:00
Linus Nilsson
676fac993e Parameterize EglRendererTest to also run with RenderSynchronizer
Bug: b/307672498
Change-Id: I3577bdcaf1dc4c4ccca02e8d9e53a799b680ecc1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/325183
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Commit-Queue: Linus Nilsson <lnilsson@webrtc.org>
Auto-Submit: Linus Nilsson <lnilsson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41027}
2024-01-23 09:51:58 -08:00
Linus Nilsson
c8e0a21126 Adopt EglThread in EglRenderer once again.
The regression obseverved on Samung devices the last time was caused
by the not detaching the context/surface prior to releasing an
EGLSurface or EGLContext. This was fine on most devices but obviously
not all.

Bug: b/225229697
Change-Id: I1849c772f3ed3e8819c748d997e5261289c4b2bc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/321842
Commit-Queue: Linus Nilsson <lnilsson@webrtc.org>
Reviewed-by: Zoé Lepaul <xalep@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40844}
2024-01-23 09:51:58 -08:00
Karim H
1b61c7161e Expose setCodecPreferences/getCapabilities for iOS
Bug: webrtc:15749
Change-Id: I92f5d5dc5d9eb4d0a60c33ed724a0d3e8b4fa1a8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/333402
Auto-Submit: Karim Ham <karim@karhm.com>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41601}
2024-01-23 13:54:26 +00:00
Harald Alvestrand
1768705d99 Revert^4 "Delete pc/peerconnection build target"
This reverts commit 7f457533a2.

Reason for revert: Added missing dependency

Original change's description:
> Revert^3 "Delete pc/peerconnection build target"
>
> This reverts commit b51c4b01f6.
>
> Reason for revert: Breaks downstream project
>
> Original change's description:
> > Revert^2 "Delete pc/peerconnection build target"
> >
> > This reverts commit 771b524606.
> >
> > Reason for revert: Downstream usage removed
> >
> > Original change's description:
> > > Revert "Delete pc/peerconnection build target"
> > >
> > > This reverts commit 18a42e3272.
> > >
> > > Reason for revert: Breaks downstream project.
> > >
> > > Original change's description:
> > > > Delete pc/peerconnection build target
> > > >
> > > > It is not useful any more.
> > > >
> > > > Bug: webrtc:13634, b/238176207
> > > > Change-Id: I3dd4ebca355bb828c6c3c30392333d9fe03a478c
> > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267821
> > > > Commit-Queue: Harald Alvestrand <hta@webrtc.org>
> > > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > > > Cr-Commit-Position: refs/heads/main@{#41427}
> > >
> > > Bug: webrtc:13634, b/238176207
> > > Change-Id: Ib53e0b0cc81ac218e3c19e4c652ffe0b19155c22
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/332220
> > > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
> > > Owners-Override: Christoffer Dewerin <jansson@google.com>
> > > Commit-Queue: Christoffer Dewerin <jansson@google.com>
> > > Cr-Commit-Position: refs/heads/main@{#41430}
> >
> > Bug: webrtc:13634, b/238176207
> > Change-Id: I3e99aa0ae37350b56e5f33be932f78903d1d4969
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334120
> > Reviewed-by: Christoffer Dewerin <jansson@google.com>
> > Commit-Queue: Harald Alvestrand <hta@webrtc.org>
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > Cr-Commit-Position: refs/heads/main@{#41543}
>
> Bug: webrtc:13634, b/238176207
> Change-Id: I0a586fb57716272bb4ab9daa542d59238dda03e1
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334940
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#41552}

Bug: webrtc:13634, b/238176207
Change-Id: I9f5759392dbf29e9ed5d19cd2e53e58e8d4a53c2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/335121
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Christoffer Dewerin <jansson@google.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41589}
2024-01-21 22:59:48 +00:00
Olov Brändström
4c335b70e8 Record audio timestamps from iOS.
This is a step towards sending audio timestamps from Meet in iOS.
Next step is to enable sending the audio timestamps (in harmony).

After enable absolute-capture-time header extension in harmony, the receiving participants will be able to store E2E audio latency and A/V sync metrics.

Bug: webrtc:13609
Change-Id: I797c1ed0035625ed065307314ac34c932c5abe7e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334720
Commit-Queue: Olov Brändström <brandstrom@google.com>
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41574}
2024-01-19 12:35:53 +00:00
Jim Gustafson
3d44a9e3b5 Merge branch m120 2024-01-17 12:11:58 -08:00
Mirko Bonadei
7f457533a2 Revert^3 "Delete pc/peerconnection build target"
This reverts commit b51c4b01f6.

Reason for revert: Breaks downstream project

Original change's description:
> Revert^2 "Delete pc/peerconnection build target"
>
> This reverts commit 771b524606.
>
> Reason for revert: Downstream usage removed
>
> Original change's description:
> > Revert "Delete pc/peerconnection build target"
> >
> > This reverts commit 18a42e3272.
> >
> > Reason for revert: Breaks downstream project.
> >
> > Original change's description:
> > > Delete pc/peerconnection build target
> > >
> > > It is not useful any more.
> > >
> > > Bug: webrtc:13634, b/238176207
> > > Change-Id: I3dd4ebca355bb828c6c3c30392333d9fe03a478c
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267821
> > > Commit-Queue: Harald Alvestrand <hta@webrtc.org>
> > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > > Cr-Commit-Position: refs/heads/main@{#41427}
> >
> > Bug: webrtc:13634, b/238176207
> > Change-Id: Ib53e0b0cc81ac218e3c19e4c652ffe0b19155c22
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/332220
> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
> > Owners-Override: Christoffer Dewerin <jansson@google.com>
> > Commit-Queue: Christoffer Dewerin <jansson@google.com>
> > Cr-Commit-Position: refs/heads/main@{#41430}
>
> Bug: webrtc:13634, b/238176207
> Change-Id: I3e99aa0ae37350b56e5f33be932f78903d1d4969
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334120
> Reviewed-by: Christoffer Dewerin <jansson@google.com>
> Commit-Queue: Harald Alvestrand <hta@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#41543}

Bug: webrtc:13634, b/238176207
Change-Id: I0a586fb57716272bb4ab9daa542d59238dda03e1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334940
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41552}
2024-01-17 19:04:53 +00:00
Henrik Boström
361d74bc36 [Stats] Fix missing dependency on stats.
To help avoid future WebRTC importer problems. The .cc and the .h files
are spread out over multiple targets and the bots do not always detect
these issues.

Bug: webrtc:15164, b/320646178, webrtc:15781
Change-Id: I65b271e786c760b5ee024bec436b4cd4aef05d37
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334840
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41549}
2024-01-17 16:05:13 +00:00
Harald Alvestrand
b51c4b01f6 Revert^2 "Delete pc/peerconnection build target"
This reverts commit 771b524606.

Reason for revert: Downstream usage removed

Original change's description:
> Revert "Delete pc/peerconnection build target"
>
> This reverts commit 18a42e3272.
>
> Reason for revert: Breaks downstream project.
>
> Original change's description:
> > Delete pc/peerconnection build target
> >
> > It is not useful any more.
> >
> > Bug: webrtc:13634, b/238176207
> > Change-Id: I3dd4ebca355bb828c6c3c30392333d9fe03a478c
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267821
> > Commit-Queue: Harald Alvestrand <hta@webrtc.org>
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > Cr-Commit-Position: refs/heads/main@{#41427}
>
> Bug: webrtc:13634, b/238176207
> Change-Id: Ib53e0b0cc81ac218e3c19e4c652ffe0b19155c22
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/332220
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
> Owners-Override: Christoffer Dewerin <jansson@google.com>
> Commit-Queue: Christoffer Dewerin <jansson@google.com>
> Cr-Commit-Position: refs/heads/main@{#41430}

Bug: webrtc:13634, b/238176207
Change-Id: I3e99aa0ae37350b56e5f33be932f78903d1d4969
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334120
Reviewed-by: Christoffer Dewerin <jansson@google.com>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41543}
2024-01-17 11:41:18 +00:00
Henrik Boström
0bf7a6080f [Stats] Migrate Java to Attributes().
To unblock code cleanup, uses of Members() are replaced by
Attributes(). This will allow replacing RTCStatsMember<T> with
absl::optional<T> in a future CL.

Bug: webrtc:15164
Change-Id: Ic4ca0d333a9cdaa78739bd8dd4515d2ecfacffbc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334162
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41512}
2024-01-12 10:33:31 +00:00
Henrik Boström
77605363b9 [Stats] Migrate ObjC to Attributes().
To unblock code cleanup, uses of Members() are replaced by
Attributes(). This will allow replacing RTCStatsMember<T> with
absl::optional<T> in a future CL.

Bug: webrtc:15164
Change-Id: I4ed32ef8ea3d8fd7506415848e044e34377fce8f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334161
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41511}
2024-01-12 10:32:13 +00:00
Bjorn Terelius
3a20023719 Roll chromium_revision 49983e8c01..93bbe3fbc0 (1242712:1244582)
Change log: 49983e8c01..93bbe3fbc0
Full diff: 49983e8c01..93bbe3fbc0

Changed dependencies
* fuchsia_version: version:17.20231218.3.1..version:17.20240105.3.1
* src/base: 1a6ee27f96..44d8736657
* src/build: b4c3d1df5f..e920e5bbda
* src/buildtools: 5e016b7d32..f5d99b3266
* src/ios: 566a1bd097..6103905d1b
* src/testing: 5d325c28aa..ee8b405f32
* src/third_party: 68c88f4ea9..dd54978044
* src/third_party/android_build_tools/manifest_merger: WTmajghAylCsg6DjtBSRd1dHKUjkkeex-9ASgLJ0cu8C..00I6IYO5b1mwIYv-jWPmTZvw3paoypOPHYEg9vpqFDUC
* src/third_party/androidx: fxep2qUxHMuSadHbR8ufKuYVmB9SKknNkkBDLneqqhwC..FDe_K3g_4EJbBdE-dAJHpM0XG6rt6GyjbI31j2ozMTgC
* src/third_party/breakpad/breakpad: f49c2f1a20..22f54f197f
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/65730c4295..f582f5bb51
* src/third_party/depot_tools: 259976c748..6953ebe3c1
* src/third_party/freetype/src: a07ca46cd0..7bac4d146a
* src/third_party/harfbuzz-ng/src: 920c40cd43..155015f4be
* src/third_party/libc++/src: 15db46be4e..8c2468e9dd
* src/third_party/libc++abi/src: 7451ba4b85..f80f02a81e
* src/third_party/libunwind/src: 2602aecdf4..42293b96f8
* src/third_party/perfetto: 805d611c93..8650986e8c
* src/third_party/r8: Deex61FDXcnUcwzjKHy_-EIsIgHjWot2d7dcvIsk3BQC..kTbaOlJzi5hYF_n8tweI4zxcmTeJ0wo7ckimuDOpkYwC
* src/third_party/turbine: M27KV5bN2pvX97rzQXxamxLUFHmKEes8wvZevk8nU2YC..ABguU2WKErRBdXX1LMt0zqZListLS_05X0Rp_V7pwAYC
* src/tools: 1be790cb8e..708b76cf07
DEPS diff: 49983e8c01..93bbe3fbc0/DEPS

Clang version changed llvmorg-18-init-14420-gea3a3b25:llvmorg-18-init-16072-gc4146121e940
Details: 49983e8c01..93bbe3fbc0/tools/clang/scripts/update.py

BUG=None

Change-Id: I1ca84db4f5eda38a93125fbdde51536f680df264
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/333880
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41488}
2024-01-09 14:06:11 +00:00
Bjorn Terelius
9702f6c9fb Roll chromium_revision fd0452ac3a..49983e8c01 (1242677:1242712)
Change log: fd0452ac3a..49983e8c01
Full diff: fd0452ac3a..49983e8c01

Changed dependencies
* src/ios: 61c7041d9f..566a1bd097
* src/testing: 9eafcc3b22..5d325c28aa
* src/third_party: d012611f35..68c88f4ea9
* src/third_party/android_build_tools/manifest_merger: SsLJuePpgSRlofU-tTKtZM6uoAelYZV8509WbBDI-ecC..WTmajghAylCsg6DjtBSRd1dHKUjkkeex-9ASgLJ0cu8C
* src/third_party/androidx: iH0Wh-bfEVnC01NIkBa7J6LWO35OT6leWNTqP1PKJ6sC..fxep2qUxHMuSadHbR8ufKuYVmB9SKknNkkBDLneqqhwC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/6d3a4756c7..65730c4295
* src/third_party/depot_tools: 0e40b92d9e..259976c748
* src/third_party/freetype/src: ca76683b78..a07ca46cd0
* src/third_party/libaom/source/libaom: https://aomedia.googlesource.com/aom.git/+log/4f632e5b6d..0eeb62d344
* src/third_party/libc++abi/src: 8806fb8bb2..7451ba4b85
* src/third_party/nasm: 7fc833e889..f477acb104
* src/third_party/perfetto: 2d7122e93a..805d611c93
* src/third_party/r8: jhySaAcbymFyscnhmoW9tqZ4z0tvqR-bR48EzVILKq0C..Deex61FDXcnUcwzjKHy_-EIsIgHjWot2d7dcvIsk3BQC
* src/tools: 9db0dc9c4a..1be790cb8e
* src/tools/luci-go: git_revision:0ffd60c8bd4fa542fb8d7c6a60ead9b96dc4387a..git_revision:a7b7f319032d68f1cf0e710e695a84957d3b11dc
* src/tools/luci-go: git_revision:0ffd60c8bd4fa542fb8d7c6a60ead9b96dc4387a..git_revision:a7b7f319032d68f1cf0e710e695a84957d3b11dc
DEPS diff: fd0452ac3a..49983e8c01/DEPS

No update to Clang.

BUG=None

Change-Id: I68e07a600dac4cddaec50bc6489b3790127f5582
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/333401
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41481}
2024-01-08 14:42:12 +00:00
Christoffer Dewerin
771b524606 Revert "Delete pc/peerconnection build target"
This reverts commit 18a42e3272.

Reason for revert: Breaks downstream project.

Original change's description:
> Delete pc/peerconnection build target
>
> It is not useful any more.
>
> Bug: webrtc:13634, b/238176207
> Change-Id: I3dd4ebca355bb828c6c3c30392333d9fe03a478c
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267821
> Commit-Queue: Harald Alvestrand <hta@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#41427}

Bug: webrtc:13634, b/238176207
Change-Id: Ib53e0b0cc81ac218e3c19e4c652ffe0b19155c22
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/332220
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Christoffer Dewerin <jansson@google.com>
Commit-Queue: Christoffer Dewerin <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#41430}
2023-12-21 12:40:44 +00:00
Harald Alvestrand
18a42e3272 Delete pc/peerconnection build target
It is not useful any more.

Bug: webrtc:13634, b/238176207
Change-Id: I3dd4ebca355bb828c6c3c30392333d9fe03a478c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267821
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41427}
2023-12-21 09:32:50 +00:00
Danil Chapovalov
151003d341 Deprecate RtcEventLogFactory constructor taking unused parameter
Bug: webrtc:15656
Change-Id: I22ed4cca4c0ce7ebf9c533ed7434617bf0a0f4a3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/330120
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41338}
2023-12-07 21:46:56 +00:00
Rashad Sookram
2bfff4ea6d
Revert changes to enable echo detection 2023-12-04 17:15:35 -05:00