Commit graph

37076 commits

Author SHA1 Message Date
Mirko Bonadei
082d270b31 Remove leftover from previous cleanup.
See https://webrtc-review.googlesource.com/c/src/+/269180.

A default ctor was left behind in the version without logs enabled.

Bug: None
Change-Id: I27826928fe702c1d50f6ed823def9f5f0bb9aee8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269248
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37594}
2022-07-22 11:03:07 +00:00
webrtc-version-updater
1e3ab4878f Update WebRTC code version (2022-07-22T04:05:13).
Bug: None
Change-Id: Ifcd9a4f5f241d78f039515117c8f16ee459a58af
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269262
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37593}
2022-07-22 05:51:16 +00:00
chromium-webrtc-autoroll
8bacdb5cb4 Roll chromium_revision 3da4dee071..3123edb9d3 (1026992:1027099)
Change log: 3da4dee071..3123edb9d3
Full diff: 3da4dee071..3123edb9d3

Changed dependencies
* src/base: a6feb8b11a..f818b8017b
* src/build: 4d3cf60e6a..d98ebc53dd
* src/buildtools: d4d55fbf05..a657f8c643
* src/buildtools/third_party/libc++/trunk: 88bf407048..3e55cfbd1a
* src/ios: 23f5789a11..c14e4a2c77
* src/testing: 3516657cdb..9222b02eb9
* src/third_party: 3b97867316..4dec558726
* src/third_party/breakpad/breakpad: c4c43b80ea..afc8daa2de
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/dd1a8cd9c4..b0098bb784
* src/tools: b909595fc6..7a17048dd4
DEPS diff: 3da4dee071..3123edb9d3/DEPS

No update to Clang.

BUG=None

Change-Id: I2cf6575b5de3303eb340d79f68d212faff9b1b94
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269261
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37592}
2022-07-22 04:32:27 +00:00
chromium-webrtc-autoroll
15087b2137 Roll chromium_revision 0f7279573c..3da4dee071 (1026859:1026992)
Change log: 0f7279573c..3da4dee071
Full diff: 0f7279573c..3da4dee071

Changed dependencies
* src/base: 3d3a5fc325..a6feb8b11a
* src/build: 918b804ee4..4d3cf60e6a
* src/ios: b6b463b851..23f5789a11
* src/testing: aa10da843b..3516657cdb
* src/third_party: 0ec74d4211..3b97867316
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4c50669a2f..dd1a8cd9c4
* src/third_party/perfetto: c223598255..361efbf9aa
* src/tools: d903290acb..b909595fc6
DEPS diff: 0f7279573c..3da4dee071/DEPS

No update to Clang.

BUG=None

Change-Id: Id05424764b5aba18c54ddbb3007131dd6f7d1172
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269226
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37591}
2022-07-21 22:36:55 +00:00
Austin Orion
de4fd2f9ef WindowCapturerWinGdi shouldn't deliver SUCCESS and nullptr.
Consumers expect the frame to be valid if Result::SUCCESS is delivered.
If the frame is nullptr, we should deliver ERROR_TEMPORARY instead.

Bug: webrtc:14265
Change-Id: If94a3ead38d7657d7b90bbe046256be697312216
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269223
Commit-Queue: Mark Foltz <mfoltz@chromium.org>
Reviewed-by: Mark Foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#37590}
2022-07-21 21:03:24 +00:00
chromium-webrtc-autoroll
32632a80e3 Roll chromium_revision abe412afe7..0f7279573c (1026730:1026859)
Change log: abe412afe7..0f7279573c
Full diff: abe412afe7..0f7279573c

Changed dependencies
* src/base: 468bdcb9c7..3d3a5fc325
* src/build: bed2979286..918b804ee4
* src/ios: 0b68b671ca..b6b463b851
* src/testing: fc01b2b000..aa10da843b
* src/third_party: 24f89f2000..0ec74d4211
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/abcd8ba23e..4c50669a2f
* src/third_party/depot_tools: 39e33e6eca..0ba2fd429d
* src/tools: f6d83033bb..d903290acb
DEPS diff: abe412afe7..0f7279573c/DEPS

No update to Clang.

BUG=None

Change-Id: I2326e2d0fbe39ade721d18a7a83f09b3b3973ae5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269224
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37589}
2022-07-21 18:25:44 +00:00
Artem Titov
1031a4f54c Introduce method to simplify creation of ideal emulated network
Bug: b/239799175
Change-Id: I3b082cdeea7748b2f642a864598916bcadf3ec39
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269240
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37588}
2022-07-21 14:32:17 +00:00
Diep Bui
9804aa5f6a Avoid fraction_loss overflowing when packet loss is negative in send_side_bandwidth_estimation.cc.
Update an affected unit test by the change in goog_cc.

Bug: webrtc:14272
Change-Id: I83e97530c861b126bed876d57f6d4f91aa45de7e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269002
Reviewed-by: Jakob Ivarsson‎ <jakobi@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Diep Bui <diepbp@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37587}
2022-07-21 14:31:04 +00:00
chromium-webrtc-autoroll
dc5cf31cad Roll chromium_revision 17f3d023e1..abe412afe7 (1026586:1026730)
Change log: 17f3d023e1..abe412afe7
Full diff: 17f3d023e1..abe412afe7

Changed dependencies
* src/base: 8b89bf39bb..468bdcb9c7
* src/build: be25fb2945..bed2979286
* src/buildtools: a4506d5d63..d4d55fbf05
* src/ios: be664f05e1..0b68b671ca
* src/testing: 426cc41296..fc01b2b000
* src/third_party: 6f9af62c05..24f89f2000
* src/third_party/depot_tools: 6967a96b04..39e33e6eca
* src/third_party/harfbuzz-ng/src: c88a6a9ec3..fa471043fc
* src/tools: 5837d28649..f6d83033bb
DEPS diff: 17f3d023e1..abe412afe7/DEPS

No update to Clang.

BUG=None

Change-Id: I91d62538675077619335af67cb2ed503f70ce9f8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269220
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37586}
2022-07-21 12:56:34 +00:00
Byoungchan Lee
e044ec572a Don't print warning for tasks running 1ms earlier than planned.
Bug: webrtc:12889
Change-Id: I33faa986130f2d7ae049466c303ef29b643d97ca
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268920
Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37585}
2022-07-21 11:44:35 +00:00
Mirko Bonadei
5afcc9afae Remove deprecated LogMessage ctor.
This ctor has been deprecated for a while and it should be unused
by WebRTC clients.

Bug: None
Change-Id: I7d33ae24eefafe48924011f55fb53150b717d593
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269180
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37584}
2022-07-21 10:33:15 +00:00
Danil Chapovalov
be5258e61d Optimize adding many consecutive missing packets to rtcp TransportFeedback
Bug: chromium:1342840
Change-Id: I894157af2ed4f8b9dc97ccb8613cbf18db09f95a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269100
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37583}
2022-07-21 10:15:25 +00:00
Mirko Bonadei
054ea47379 Move common test flags to a separate library.
This enables the possibility to use these flags from other main
functions.

Bug: b/217701950, b/238157120
Change-Id: I6e9f09c4be39b2ac690c8e6b6da380ef3c81f460
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269140
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37582}
2022-07-21 09:52:54 +00:00
Mirko Bonadei
507e3bc406 Remove redundant close().
Bug: None
Change-Id: I975f14a4308530e37cc3faba67d8545ed3feffa8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269005
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37581}
2022-07-21 09:49:14 +00:00
webrtc-version-updater
5892265e5b Update WebRTC code version (2022-07-21T04:04:55).
Bug: None
Change-Id: I0954f52ca42a0435383eb6c3a607c06ea93a4d57
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269041
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37580}
2022-07-21 05:58:35 +00:00
chromium-webrtc-autoroll
094856f22c Roll chromium_revision c792190b02..17f3d023e1 (1026401:1026586)
Change log: c792190b02..17f3d023e1
Full diff: c792190b02..17f3d023e1

Changed dependencies
* src/base: 5a0537725a..8b89bf39bb
* src/build: c3ca167fb9..be25fb2945
* src/ios: 8fa48df2d3..be664f05e1
* src/testing: 266df76833..426cc41296
* src/third_party: cf8e76aecf..6f9af62c05
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/7528f03c8a..b95124305a
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/45c6b725b5..abcd8ba23e
* src/third_party/depot_tools: 7298625c85..6967a96b04
* src/third_party/fuchsia-sdk/sdk: version:9.20220720.1.1..version:9.20220720.2.1
* src/third_party/lss: https://chromium.googlesource.com/linux-syscall-support.git/+log/3bb6859795..0d6435b731
* src/tools: 3520d10448..5837d28649
DEPS diff: c792190b02..17f3d023e1/DEPS

No update to Clang.

BUG=None

Change-Id: I55767050a9eebba3dceea16daca9e39fae45f370
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269122
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37579}
2022-07-21 02:28:21 +00:00
chromium-webrtc-autoroll
983cc2d992 Roll chromium_revision 1b992fc712..c792190b02 (1026226:1026401)
Change log: 1b992fc712..c792190b02
Full diff: 1b992fc712..c792190b02

Changed dependencies
* src/base: 311317bc94..5a0537725a
* src/build: ac02acec7e..c3ca167fb9
* src/ios: daa442d05b..8fa48df2d3
* src/testing: 84daac4837..266df76833
* src/third_party: c337bbeacc..cf8e76aecf
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ab2ff5cdd4..45c6b725b5
* src/third_party/depot_tools: f3edc50445..7298625c85
* src/tools: 3d196512c1..3520d10448
DEPS diff: 1b992fc712..c792190b02/DEPS

No update to Clang.

BUG=None

Change-Id: Id560257148573ab86bdb6abd0fdd4a14ea68e2b4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269022
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37578}
2022-07-20 20:33:03 +00:00
Alessio Bazzica
d9f1208de7 AgcManagerDirect parametrized unit tests
It is now easier to fully test `AgcManagerDirect` with different values
for the used field trials. In particular, this CL adds tests for the
field trial named `WebRTC-Audio-2ndAgcMinMicLevelExperiment`.

1. `UnmutingRaisesTooLowVolume` and `MicVolumeIsLimited`
The expectations for the lowest input volume are not hard-coded anymore
since the parametrized tests use different values for the enforced
minimum.

2. `RecoveryAfterManualLevelChangeBelowMin`
The recovery behavior after manual input volume change depends on
whether the minimum input volume is overridden. When that's the case,
the minimum volume is applied immediately after the manual adjustment.
Hence, the existing test is left and a parametrized version of it has been added to test the "instant recovery" behavior. The latter test is
skipped when the minimum input volume is not overridden since that case
is covered by the existing test.

Bug: chromium:1275566
Change-Id: Ib0d4427b32b88f33138d4062b365916a3c47a406
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268900
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Reviewed-by: Hanna Silen <silen@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37577}
2022-07-20 15:44:13 +00:00
chromium-webrtc-autoroll
fb6cbd9201 Roll chromium_revision bfeef78a75..1b992fc712 (1026121:1026226)
Change log: bfeef78a75..1b992fc712
Full diff: bfeef78a75..1b992fc712

Changed dependencies
* src/base: 3f1fcf1796..311317bc94
* src/build: 60d303b648..ac02acec7e
* src/ios: 2339fd25bc..daa442d05b
* src/testing: 8c72edbc17..84daac4837
* src/third_party: f36ed1a4e4..c337bbeacc
* src/third_party/fuchsia-sdk/sdk: version:9.20220719.3.1..version:9.20220720.1.1
* src/third_party/perfetto: ac8e40ad9e..c223598255
* src/tools: 529818811b..3d196512c1
DEPS diff: bfeef78a75..1b992fc712/DEPS

No update to Clang.

BUG=None

Change-Id: Ia669717d5dd9f73b4aac6122c6e98a0edc09d3a8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269020
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37576}
2022-07-20 14:40:53 +00:00
Niels Möller
daddfee8c5 Delete tests with 4 temporal layers
Using 4 temporal layers is not quite supported: Not advertised, no
integration tests. When transitioning to configuration via scalability
mode, there are no corresponding modes defined. So delete these two
tests; they can be added back if/when support for corresponding
scalability modes are added.

Bug: webrtc:11607
Change-Id: I97f55dc95d6513ccf65fa887757a62e9c8659be7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269003
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37575}
2022-07-20 14:05:13 +00:00
Byoungchan Lee
10a7d23be5 Fix degradation_preference setting being ignored using RtpSender.SetParameters.
RtpSenderBase::SetParametersInternal stores init_parameters_
if media_channel_ does not exist. When RtpSenderBase::SetSsrc is called,
init_parameters_ is used to set the initial encoding parameters and
degradation_preference. However, if no encoding parameter is specified,
degradation_preference will not be set.

This CL modifies the RtpSender so that degradation_preference is not
ignored even in this case.

Bug: webrtc:14279
Change-Id: I7e95ecdf5fcb19037e4f118981d1314d78ffca5a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268960
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com>
Cr-Commit-Position: refs/heads/main@{#37574}
2022-07-20 13:48:27 +00:00
Ali Tofigh
714e3cbb48 Adopt absl::string_view in modules/audio_coding/
Bug: webrtc:13579
Change-Id: Ifec66fb6ba9724d18539de7245a358c2d13c7939
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268547
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Ali Tofigh <alito@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37573}
2022-07-20 13:34:23 +00:00
Niels Möller
761072f68e Cleanup configuration of max reordering threshold
Call SetMaxReorderingThreshold only when setting a non-default value,
and never for rtx streams.

Bug: webrtc:10198, webrtc:10669
Change-Id: I44b76f7fdd623c90d256a229648cefc409f57c11
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269001
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37572}
2022-07-20 13:04:53 +00:00
Danil Chapovalov
3c06cfc96a Update TaskQueueWin implementation to absl::AnyInvocable
Bug: webrtc:14245
Change-Id: I4203f4dbbdc9c2ee4a6440942215341182f180db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269000
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37571}
2022-07-20 12:49:44 +00:00
Niels Möller
07d80675e2 Move test utilities into more specific build targets
Move audio- and video-specific utilities to audio_test_common (newly
added target) and video_test_common.

Bug: webrtc:10198
Change-Id: Ia10fa5c0a51d9b1f37db4964984d22fc5b269bb1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268980
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37570}
2022-07-20 10:14:03 +00:00
Alessio Bazzica
866caeb62c AgcManagerDirect ctor API and doc string improved
Bug: chromium:1275566
Change-Id: Iedc8f5cbbf65fbf018da9df1aaa1f8ade1bbc063
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268840
Reviewed-by: Hanna Silen <silen@webrtc.org>
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37569}
2022-07-20 09:39:24 +00:00
Danil Chapovalov
ba5700171f Update TaskQueueStdlib implementation to absl::AnyInvocable
Bug: webrtc:14245
Change-Id: Ic0c55cbb4dbdd31359bbe15f1acd7a2b7e9e61f7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268901
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37568}
2022-07-20 09:38:21 +00:00
Ivo Creusen
1a84b565ac Implement RTCInboundRTPStreamStats.JitterBufferMinimumDelay
This metric was recently added to the standard (see https://w3c.github.io/webrtc-stats/#dom-rtcinboundrtpstreamstats-jitterbufferminimumdelay). This CL implements it for audio streams.

Bug: webrtc:14141
Change-Id: I79d918639cd12361ebbc28c2be41549e33fa7e2a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262770
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Jakob Ivarsson‎ <jakobi@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Ivo Creusen <ivoc@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37567}
2022-07-20 09:14:03 +00:00
Zhaoliang Ma
e7696f771d Plumb color space from VP8/VP9/H264 encoder
Bug: None
Change-Id: If771d9486bde01d5a2775d904a01ecf3953e75df
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268944
Commit-Queue: Zhaoliang Ma <zhaoliang.ma@intel.com>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37566}
2022-07-20 09:08:41 +00:00
Danil Chapovalov
c05a1be5b4 Migrate remaining webrtc usage of TaskQueueBase to absl::AnyInvocable
Bug: webrtc:14245
Change-Id: I8de2c23da5fbdfc0b1efbbe07fb6e8de744424a3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268191
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37565}
2022-07-20 08:15:08 +00:00
Daniel.L (Byoungchan Lee)
489f648ea3 Remove the deprecated BasicNetworkManager constructor
Bug: webrtc:13145
Change-Id: I43696aea7256d3fe94a11514ea6d81e3c3ac5f57
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268780
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com>
Auto-Submit: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37564}
2022-07-20 08:14:04 +00:00
Danil Chapovalov
30c2a31309 Update TaskQueueLibevent implementation to absl::AnyInvocable
Bug: webrtc:14245, webrtc:12889
Change-Id: I1aa20e3d5645c270abd1bee0c45c6982e799eaa4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268767
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37563}
2022-07-20 07:55:43 +00:00
chromium-webrtc-autoroll
ed7526c3f1 Roll chromium_revision 3a2eeb8205..bfeef78a75 (1026014:1026121)
Change log: 3a2eeb8205..bfeef78a75
Full diff: 3a2eeb8205..bfeef78a75

Changed dependencies
* src/base: d3414cf807..3f1fcf1796
* src/build: 7aa22279f0..60d303b648
* src/ios: efe24addca..2339fd25bc
* src/testing: 06fcab2d92..8c72edbc17
* src/third_party: d4f2a774b5..f36ed1a4e4
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/0c6b8d6722..ab2ff5cdd4
* src/third_party/depot_tools: 56101e1c90..f3edc50445
* src/third_party/fuchsia-sdk/sdk: version:9.20220719.2.1..version:9.20220719.3.1
* src/tools: d976fbfb8e..529818811b
DEPS diff: 3a2eeb8205..bfeef78a75/DEPS

No update to Clang.

BUG=None

Change-Id: I012dc21acf7a97ad056c44242b385b1b03493586
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268943
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37562}
2022-07-20 06:33:56 +00:00
webrtc-version-updater
22d10fc605 Update WebRTC code version (2022-07-20T04:04:42).
Bug: None
Change-Id: Ia4908a791a9cefbabef68e2b8a7af1517c6fc15e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268942
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37561}
2022-07-20 06:32:53 +00:00
chromium-webrtc-autoroll
c1611082e3 Roll chromium_revision ada88c87de..3a2eeb8205 (1025896:1026014)
Change log: ada88c87de..3a2eeb8205
Full diff: ada88c87de..3a2eeb8205

Changed dependencies
* src/base: cc9cb205fe..d3414cf807
* src/build: 9e6a9a9613..7aa22279f0
* src/ios: 4c00d7f74e..efe24addca
* src/third_party: 256411515b..d4f2a774b5
* src/third_party/depot_tools: 90191b14c2..56101e1c90
* src/tools: 72c1516005..d976fbfb8e
DEPS diff: ada88c87de..3a2eeb8205/DEPS

No update to Clang.

BUG=None

Change-Id: Iabc9267c80e35f9b6d193c5d4404458114172864
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268886
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37560}
2022-07-20 00:28:12 +00:00
chromium-webrtc-autoroll
e947f5bb83 Roll chromium_revision 3f8fc6e359..ada88c87de (1025382:1025896)
Change log: 3f8fc6e359..ada88c87de
Full diff: 3f8fc6e359..ada88c87de

Changed dependencies
* src/base: d28c12571a..cc9cb205fe
* src/build: 55fee0e565..9e6a9a9613
* src/buildtools: 5cee6a2f1c..a4506d5d63
* src/buildtools/third_party/libc++/trunk: b1269813ea..88bf407048
* src/ios: ec94f41124..4c00d7f74e
* src/testing: 4a2ba06460..06fcab2d92
* src/third_party: 2fa6453891..256411515b
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/1240e973d5..0c6b8d6722
* src/third_party/depot_tools: 8168f76753..90191b14c2
* src/third_party/fuchsia-sdk/sdk: version:8.20220713.3.1..version:9.20220719.2.1
* src/third_party/lss: https://chromium.googlesource.com/linux-syscall-support.git/+log/32a80cda3c..3bb6859795
* src/third_party/perfetto: 761031a428..ac8e40ad9e
* src/tools: 2cfda2e9bf..72c1516005
DEPS diff: 3f8fc6e359..ada88c87de/DEPS

No update to Clang.

BUG=None

Change-Id: I73a4af4e5235b550bb05c1192fd53b73aba812c5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268883
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37559}
2022-07-19 20:52:03 +00:00
Tommi
9095e0e469 [TCPConnection] Check for valid port_ in OnClose and OnConnect.
Bug: chromium:1341261, chromium:1316996
Change-Id: I10931e731d2228f13f2df15419a8649e3e726cf0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268860
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37558}
2022-07-19 15:56:43 +00:00
Diep Bui
38b3cf0223 Add lower/upper link capacity to the outgoing bitrate graph.
Bug: webrtc:14273
Change-Id: I8d9f1ac0d41b74a226abdff00f420d6b0624b73c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250442
Commit-Queue: Diep Bui <diepbp@google.com>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37557}
2022-07-19 13:22:32 +00:00
Alessio Bazzica
7d4116855a AgcManagerDirect unit tests refactoring
Stop using TEST_F; that will make it easier to switch to parametric
tests that are needed to correctly test `AgcManagerDirect`.

"Avoid fixtures where reasonable."
Source: https://abseil.io/tips/122

Bug: chromium:1275566
Change-Id: I2d73a0913eb2349144f63bd17ab4d6efa245e472
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268766
Reviewed-by: Hanna Silen <silen@webrtc.org>
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37556}
2022-07-19 12:46:42 +00:00
Bruno Pitrus
99465b1395 Add missing header to fix build error when using linux system libraries
Change-Id: I4fc04563c2cfe36fa2352f72f2ae61d47972f025
Bug: webrtc:11226
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268194
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org>
Auto-Submit: Bruno Pitrus <brunopitrus@hotmail.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37555}
2022-07-19 12:25:42 +00:00
Mirko Bonadei
5ed127e9af Clobber win bots
Bug: None
Change-Id: I8e57ee9e8bf6b4681f3a00efee352eb499e6cd81
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268861
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37554}
2022-07-19 11:34:02 +00:00
Danil Chapovalov
5286dcfab6 Migrate rtc_base and rtc_tools to absl::AnyInvocable based TaskQueueBase interface
Bug: webrtc:14245
Change-Id: I71abe3db7a23ad33bd175297e23fa8e927fa9628
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268768
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37553}
2022-07-19 10:57:42 +00:00
chromium-webrtc-autoroll
049dde6c8e Roll chromium_revision 5695b2c377..3f8fc6e359 (1025266:1025382)
Change log: 5695b2c377..3f8fc6e359
Full diff: 5695b2c377..3f8fc6e359

Changed dependencies
* src/base: fb3ebaf860..d28c12571a
* src/build: 9c1be2c8e6..55fee0e565
* src/buildtools/third_party/libunwind/trunk: 49191c55bb..955e2ff5fb
* src/ios: e73edfcb1e..ec94f41124
* src/testing: 5ebeb35b96..4a2ba06460
* src/third_party: cad0ef7a7d..2fa6453891
* src/tools: a8e81b2b7d..2cfda2e9bf
DEPS diff: 5695b2c377..3f8fc6e359/DEPS

No update to Clang.

BUG=None

Change-Id: Idedbdf07dc6897d67c81fa48209e2253fb0aecd9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268800
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37552}
2022-07-18 21:11:32 +00:00
chromium-webrtc-autoroll
07e8336c7e Roll chromium_revision add3adc6ef..5695b2c377 (1025088:1025266)
Change log: add3adc6ef..5695b2c377
Full diff: add3adc6ef..5695b2c377

Changed dependencies
* src/base: d4b5cb4bf4..fb3ebaf860
* src/build: 662b56d3bf..9c1be2c8e6
* src/ios: 7f23991c90..e73edfcb1e
* src/testing: b2094e8934..5ebeb35b96
* src/third_party: 7a861a1ab4..cad0ef7a7d
* src/third_party/perfetto: 9882c50ee9..761031a428
* src/tools: 094a0e9120..a8e81b2b7d
DEPS diff: add3adc6ef..5695b2c377/DEPS

No update to Clang.

BUG=None

Change-Id: I3c44d95358d4cc0f2fc3fe33b9014d5a43662ff1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268750
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#37551}
2022-07-18 16:27:02 +00:00
Niels Möller
253f36f88e Delete rtp_sender_ check in ModuleRtpRtcpImpl2::SetSendingMediaStatus
Analogous to https://webrtc-review.googlesource.com/c/src/+/267845/

Bug: webrtc:10198
Change-Id: Ib7d5e9b2a456486a419c61e7b2ce36df8960c67a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268762
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Jakob Ivarsson‎ <jakobi@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37550}
2022-07-18 14:28:31 +00:00
Danil Chapovalov
03f8b8a241 In video replace non-owning pointer to rtc::TaskQueue with non-owning pointer to TaskQueueBase
rtc::TaskQueue is a simple wrapper over TaskQueueBase and adds no
extra features when task queue is used without passing ownership.

Reducing usage of the internal rtc::TaskQueue wrapper gives users more flexibility how TaskQueueBase* is stored.

Bug: webrtc:14169
Change-Id: If5c8827544c843502c7dfcef775ac558de79ec3a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268189
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37549}
2022-07-18 13:59:32 +00:00
Niels Möller
ee3ad9f2ce Make ChannelSend::OnUplinkPacketLossRate public
And delete a friend declaration.

Bug: webrtc:10198
Change-Id: Ie3a79418602ec078f68e70c17ef37bb4d79fb36a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268765
Commit-Queue: Jakob Ivarsson‎ <jakobi@webrtc.org>
Reviewed-by: Jakob Ivarsson‎ <jakobi@webrtc.org>
Auto-Submit: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37548}
2022-07-18 13:42:01 +00:00
Artem Titov
208129fb53 [PCLF] Add ability to use fixed frame reate for video dump
Bug: b/237997865
Change-Id: I4e93db1f8a0ac84d8d1c014073cbcd0f58482203
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268763
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37547}
2022-07-18 13:28:41 +00:00
Artem Titov
bfe9f5c5b1 [PCLF] Remove old VideoQualityAnalyzerInjectionHelper ctor without clock
Bug: b/237997865
Change-Id: I7ac5e086d29801cfc0617731c51076e38d365274
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268764
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37546}
2022-07-18 13:00:31 +00:00
Niels Möller
f2d090a0de Add temporary method SimulcastStream::SetNumberOfTemporalLayers
Similar to https://webrtc-review.googlesource.com/c/src/+/267843, it
turns out we need the setter method too to transition downstream code.

Bug: webrtc:11607
Change-Id: I50df5e9c5d9301717d527089de61fcf783267ee1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/268760
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37545}
2022-07-18 12:19:52 +00:00