This is a follow-up CL to stop building 'all' on iOS bots since they
will end up building invalid Abseil build targets.
Original CL: https://webrtc-review.googlesource.com/70140.
Bug: webrtc:8821
Change-Id: I58e4dbc10377f670ce80552a9b695607b81da284
Reviewed-on: https://webrtc-review.googlesource.com/71280
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22960}
It seems iOS trybots are the only ones that build "all". This causes
problems when using Abseil because some targets in
//third_party/abseil-cpp fail to build (because they depend on CCTZ).
Bug: webrtc:8821
Change-Id: I017ecb0527a7e3f3c59f41053fa1878d16cbe4e9
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/70140
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22890}
The code which triggered the memcheck failure is gone.
Bug: webrtc:5989
Change-Id: I35decfae1af4e988724ababa58c41fca7a2c4a67
Reviewed-on: https://webrtc-review.googlesource.com/69261
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22821}
We control it in the WebRTC code hosting so why not autoroll it?
Bug: None
No-Try: True
TBR: phoglund@webrtc.org
Change-Id: I8b7d6d3b76de145b5b89d80d5d089d585c5f233b
Reviewed-on: https://webrtc-review.googlesource.com/66360
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22703}
jsr305 is necessary dependency for Nullable annotations.
Also adds a flag to release_aar.py to specify the build directory
manually. This makes it easier to test the script without full
recompilation.
Bug: webrtc:8881
Change-Id: Ib4b8cd4592ced9c92ca2810928bcbb6173d2164e
Reviewed-on: https://webrtc-review.googlesource.com/65081
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org>
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22671}
Just adds the annotation to base_java for now to check that this does
not break any downstream targets.
Bug: webrtc:8881
Change-Id: I9425020e36be5e52447cec592a4474a9eb09b5bd
Reviewed-on: https://webrtc-review.googlesource.com/51960
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22526}
It is actually fine to use streams in testonly code. This CL relaxes
the presubmit check in order allow streams usage in tests.
Bug: webrtc:8982
Change-Id: I18bbf079e804815956cd94ac761cc13022c0761e
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/61701
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#22482}
This is a reland of 4bbc150b18
Now using rtc_source_set to be able to generate runtime deps
Original change's description:
> Split perf-test-specific resources in low_bandwidth_audio_test
>
> Bug: chromium:755660
> Change-Id: I7c60a47b26ad86892218497f28a09a04574077e6
> Reviewed-on: https://webrtc-review.googlesource.com/61961
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#22439}
No-Try: True
Bug: chromium:755660
Change-Id: I66eda6f016c98e2a8a99f230d9e0323cc09e4976
Reviewed-on: https://webrtc-review.googlesource.com/62020
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22450}
It's been unused for a while and starting to be a maintainance burden.
Bug: webrtc:8943
Change-Id: Ie49d6b06bdeb002496007725009ea194b8130f2b
Reviewed-on: https://webrtc-review.googlesource.com/60160
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Kári Helgason <kthelgason@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22339}
Depends on Chromium to roll: https://crrev.com/c/924114
This will clobber all Android builds once, since after this, we can't
make Android-specific landmines anymore.
Bug: chromium:756691
Change-Id: Ic7588329e567e3f6e596b04de8f990dc720eb153
Reviewed-on: https://webrtc-review.googlesource.com/54721
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#22091}
This should be seen as a temporary workaround because we will likely
want to roll these together with Chromium and drop 'Android CIPD Ensure'
like in crrev.com/b59866870a96d6dd39cf573e304ca551848520b9
but it's difficult to update a Python-syntax file like that.
Bug: chromium:755920
No-Try: True
TBR: phoglund@webrtc.org
Change-Id: Ifc508c48ea29ce570cf624d783fa22381ea03fd4
Reviewed-on: https://webrtc-review.googlesource.com/54902
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22088}
This ensures that .vpython makes it to our swarm bots. I believe this
will solve a problem where psutil is missing when the catapult devil
forwarder tries to import it.
Our .vpython already specifies psutil as being used by catapult, so
I don't think we need to change anything there.
Bug: None
Change-Id: Iee8a08f22d128bca3fd52f9476604d47efe16652
Reviewed-on: https://webrtc-review.googlesource.com/52940
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22010}
It could be the git outage is over, let's see.
TBR=oprypin@webrtc.org
Bug: None
Change-Id: I8eeeba9e8c040d212e1d43b2561a2fa6057dfdbb
Reviewed-on: https://webrtc-review.googlesource.com/52261
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21993}
When we run webrtc_perf_tests with gtest-parallel, each test is run
individually, and this results in the file with the perf results being
overwritten each time.
To avoid this, we won't use gtest-parallel when running webrtc_perf_tests,
so we will simply run the binary directly.
TBR=phoglund@chromium.org
Bug: chromium:755660
Change-Id: I24db36e512fcf604a3de2adf4d0b4325b2c3d1ae
Reviewed-on: https://webrtc-review.googlesource.com/49340
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21982}
Adds a new test_type 'raw' to run tests on swarming without wrapping it
on gtest-parallel.
This will be used to run webrtc_perf_tests directly.
Bug: chromium:755660
Change-Id: I8558faadf242d1db1ad3e13083941886c92b1bd9
Reviewed-on: https://webrtc-review.googlesource.com/49360
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21962}
Update frame_analyzer binary, so that it includes changes to the
perf flags.
Bug: chromium:755660
Change-Id: I9e30cd83b807d2d4fa74a677dc5a69f8985a4ce2
Reviewed-on: https://webrtc-review.googlesource.com/48622
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21946}
Add a PRESUBMIT test to make sure new valgrind runtime dependencies are
listed in tools_webrtc/valgrind/valgrind-webrtc.gni, so that they are
isolated and uploaded to swarming.
TBR=phoglund@webrtc.org
Bug: webrtc:7249
Change-Id: I090b790da0b6dd7c1e76c20f96e40df9000cbd62
Reviewed-on: https://webrtc-review.googlesource.com/42740
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21933}
Translate --isolate-script-test-perf-output to --chartjson_result_file
and pass it to the test.
That way we can use Chromium's recipe code to report results to the
Perf dashboard.
TBR=phoglund@webrtc.org
Bug: chromium:807737
Change-Id: I2d3479fe29431cc1a8faf9a73b054a5f4ec610a4
Reviewed-on: https://webrtc-review.googlesource.com/47121
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21894}
This is a reland of 1175ecd095.
Original change's description:
> Make it possible to run video_quality_loopback_test in swarming.
>
> I made two changes to video_quality_loopback_test to make it possible
> to run it on swarming.
>
> 1. We need to know the path to frame_analyzer when we're generating
> the build files, and it must be already present.
> I made frame_analyzer a resource, so it's downloaded to a known path
> before generating the build files.
> 2. The .zip files for apprtc and golang are downloaded and isolated.
> The script now extracts them and installs AppRTC.
>
> Passing task:
> https://chromium-swarm.appspot.com/task?id=3b230bcc04128210
>
> Bug: chromium:755660
> Change-Id: I34090897402421d5b7e29f21fbed354551197f92
> Reviewed-on: https://webrtc-review.googlesource.com/40920
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#21716}
Bug: chromium:755660
Change-Id: Ie3ca62d64b4fe856485287b7d9d3d9e3f75dc091
Reviewed-on: https://webrtc-review.googlesource.com/42860
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21733}
This reverts commit 1175ecd095.
Reason for revert: Breaks the bots.
Original change's description:
> Make it possible to run video_quality_loopback_test in swarming.
>
> I made two changes to video_quality_loopback_test to make it possible
> to run it on swarming.
>
> 1. We need to know the path to frame_analyzer when we're generating
> the build files, and it must be already present.
> I made frame_analyzer a resource, so it's downloaded to a known path
> before generating the build files.
> 2. The .zip files for apprtc and golang are downloaded and isolated.
> The script now extracts them and installs AppRTC.
>
> Passing task:
> https://chromium-swarm.appspot.com/task?id=3b230bcc04128210
>
> Bug: chromium:755660
> Change-Id: I34090897402421d5b7e29f21fbed354551197f92
> Reviewed-on: https://webrtc-review.googlesource.com/40920
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#21716}
TBR=phoglund@webrtc.org,ehmaldonado@webrtc.org
Change-Id: Id25d26adc547ff6f9ab178601e37527459c8b5ef
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:755660
Reviewed-on: https://webrtc-review.googlesource.com/42800
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21723}
This allows the script to be reliably run on the bots.
Bug: webrtc:8365
Change-Id: Ie4f216403c1f4fabe8db07f261fe06d1e64be0ae
Reviewed-on: https://webrtc-review.googlesource.com/42720
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21717}
I made two changes to video_quality_loopback_test to make it possible
to run it on swarming.
1. We need to know the path to frame_analyzer when we're generating
the build files, and it must be already present.
I made frame_analyzer a resource, so it's downloaded to a known path
before generating the build files.
2. The .zip files for apprtc and golang are downloaded and isolated.
The script now extracts them and installs AppRTC.
Passing task:
https://chromium-swarm.appspot.com/task?id=3b230bcc04128210
Bug: chromium:755660
Change-Id: I34090897402421d5b7e29f21fbed354551197f92
Reviewed-on: https://webrtc-review.googlesource.com/40920
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21716}
This used to be used by the linter, but now it's actually using
build/android/AndroidManifest.xml to determine the minimum SDK
level we support.
Remove this file to avoid confusion.
Bug: None
Change-Id: I2ea60854d52276877ae9d51a9c1f379cfaa3ed5d
Reviewed-on: https://webrtc-review.googlesource.com/40661
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21677}
These features are supported via desugar, but we started getting lint errors:
"Static interface method requires API level 24 (current min is 16)"
60990c11ce
Bug: webrtc:8084
Change-Id: Iba8b5825a52bd57da7ee4ab52cde2d7bd9ebce30
Reviewed-on: https://webrtc-review.googlesource.com/40421
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21672}
