mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-20 09:07:52 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
36476 commits 2 branches 92 tags 416 MiB
Commit graph

480 commits

Author SHA1 Message Date
Niels Möller
7c8c4db8ea Add rtc::make_ref_counted to api/ 
This cl adds a forwarding header, a build target, and migrates headers
in api/ to use it.

Moving actual implementation, will follow, in
https://webrtc-review.googlesource.com/c/src/+/265390.

Bug: webrtc:12701
Change-Id: Id950725d7d054de8a83b3800b9c9a6437344de86
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265660
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37200}
 2022-06-13 15:53:27 +00:00
Niels Möller
10da2b5357 Delete unused test class DummyPeerConnection 
Introduced in https://webrtc-review.googlesource.com/c/src/+/152820
but never used.

Bug: None
Change-Id: I8888db9e0cad39a6eb073e8f662b5ad2690d03e5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265409
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37173}
 2022-06-10 07:29:54 +00:00
Jonas Oreland
6545516a14 RtpSenderInterface::SetEncoderSelector 
This cl/ adds a way of setting an EncoderSelector on a specific
RtpSenderInterface. This makes it possible to easily use different
EncoderSelector on different streams within the same or different PeerConnections.

The cl/ is almost identical to the impl. of RtpSenderInterface::SetFrameEncryptor.

Iff a EncoderSelector is set on the RtpSender, it will take precedence
over the VideoEncoderFactory::GetEncoderSelector.

Bug: webrtc:14122
Change-Id: Ief4f7c06df7f1ef4ce3245de304a48e9de0ad587
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264542
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37150}
 2022-06-08 11:06:52 +00:00
Björn Terelius
b22cabcf76 Add AbslParse functions for TimeMode enum. (This allows creation of TimeMode ABSL_FLAGs.) 
Bug: webrtc:14145
Change-Id: Id79c4411ba4443a3ee8a0da3990c36955cc9aa35
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264821
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Auto-Submit: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37090}
 2022-06-02 10:07:16 +00:00
Artem Titov
7c3219265e [PCLF] Add ToString function to VideoSubscription 
Bug: b/231394729
Change-Id: I1bdebf5eb266d566452b98e2bf52f08b609c427d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264700
Auto-Submit: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37087}
 2022-06-02 09:12:37 +00:00
Artem Titov
bccb452eb6 [PCLF] Add ToString function for VideoResolution 
Bug: b/231394729
Change-Id: Iac803440153d368f0c2ea143e64fe347323eeeef
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264556
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37082}
 2022-06-01 21:40:56 +00:00
Artem Titov
fd8ed05cee [PCLF] Add equals method for VideoSubscription 
Bug: b/231394729
Change-Id: I0957d96640e962d331f05c9541c36e8420e9f5aa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264557
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37075}
 2022-06-01 12:36:45 +00:00
Erik Språng
f3f3a61167 Remove legacy PacedSender. 
The new TaskQueuePacedSender has been default-on in code since M97, and
there are no further usages of it that I can find. Let's clean this up!

The PacingController and associated tests will be cleaned up in a
follow-up cl.

Bug: webrtc:10809
Change-Id: I0cb888602939add953415977ee79ff0b3878fea5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258025
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36890}
 2022-05-13 20:31:06 +00:00
Florent Castelli
b5671da00d [PCLF] Remove previously replaced configuration options 
VideoSimulcastConfig::encoding_params and VideoConfig::min/max_encode_bitrate_bps
were replaced by VideoConfig::encoding_params.
All usage of the previous options has been updated to the new option.

Bug: webrtc:11607
Change-Id: I52cd9efa6e640929485da7aa1e61d15a1a693b1d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261949
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36865}
 2022-05-12 14:26:53 +00:00
Florent Castelli
8c6d88ff5c api: Add MockDtmfSender 
Similar mocks are used internally, there should only be one in WebRTC.

Bug: None
Change-Id: Ic5163ae0c554c602344a0d25d17c3f0d46fc2e95
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261955
Auto-Submit: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36864}
 2022-05-12 13:11:15 +00:00
Florent Castelli
a63b6b7d40 [PCLF] Allow configuring RtpEncodingParameters with singlecast 
With the encoding parameters in the SimulcastConfig objects, it wasn't
possible to configure explicit encoding parameters when using singlecast,
required for example to use the spec standard SVC API.

Bug: webrtc:11607
Change-Id: I92b1446e772e2ecec93379dc91a3da159b8bc209
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260002
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36731}
 2022-05-02 10:30:14 +00:00
Rasmus Brandt
e890e36c99 PCLF: Reserve vector before pushing. 
Bug: None
Change-Id: I961f555085032330028b426e46a2c4ac576a2b03
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260283
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36686}
 2022-04-28 09:49:34 +00:00
Artem Titov
a92d051e0f [PCLF] Introduce API to safely mutate ConfigurableParams in TestPeer 
Bug: b/213863770
Change-Id: I90b7b5cd55ac5a8ebee5d790205a4fa6700dfff4
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260117
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36668}
 2022-04-27 11:00:11 +00:00
Harald Alvestrand
e2c780ea24 Reland "Add canonical mock for MediaStreamInterface" 
This reverts commit fc61750523.

Reason for revert: Fixed downstream project.

Original change's description:
> Revert "Add canonical mock for MediaStreamInterface"
>
> This reverts commit e217217bf3.
>
> Reason for revert: break upstream project (name collision)
>
> Original change's description:
> > Add canonical mock for MediaStreamInterface
> >
> > Needed to let upstream APIs integrate changes more easily.
> >
> > Bug: webrtc:13980
> > Change-Id: I6cd46f75d56597c10e08d0d66e16089516f5129c
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259821
> > Commit-Queue: Harald Alvestrand <hta@webrtc.org>
> > Reviewed-by: Niels Moller <nisse@webrtc.org>
> > Cr-Commit-Position: refs/heads/main@{#36613}
>
> Bug: webrtc:13980
> Change-Id: I18b91327225e0f844af5dd86c9b4ca8d6301d03e
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259860
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Harald Alvestrand <hta@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#36614}

Bug: webrtc:13980
Change-Id: I84dbe5ec754389d30e5d22f9f9553fd9e9ee5bd5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260115
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36660}
 2022-04-26 17:23:45 +00:00
Florent Castelli
c3e6e3a3e8 Remove dependency on rtc_base_approved from most targets 
Bug: webrtc:9838
Change-Id: Ibd0199803597eff48ca139a5cecdc3209c62c5d2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259873
Auto-Submit: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36643}
 2022-04-25 12:15:30 +00:00
Florent Castelli
ed4aadc0a2 Move copy_on_write_buffer out of rtc_base_approved 
Bug: webrtc:9838
Change-Id: Ib9a9cd3bc868e716315594c436df7e2cce0d9a5a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259311
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36636}
 2022-04-24 09:51:50 +00:00
Harald Alvestrand
fc61750523 Revert "Add canonical mock for MediaStreamInterface" 
This reverts commit e217217bf3.

Reason for revert: break upstream project (name collision)

Original change's description:
> Add canonical mock for MediaStreamInterface
>
> Needed to let upstream APIs integrate changes more easily.
>
> Bug: webrtc:13980
> Change-Id: I6cd46f75d56597c10e08d0d66e16089516f5129c
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259821
> Commit-Queue: Harald Alvestrand <hta@webrtc.org>
> Reviewed-by: Niels Moller <nisse@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#36613}

Bug: webrtc:13980
Change-Id: I18b91327225e0f844af5dd86c9b4ca8d6301d03e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259860
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36614}
 2022-04-22 10:01:47 +00:00
Harald Alvestrand
e217217bf3 Add canonical mock for MediaStreamInterface 
Needed to let upstream APIs integrate changes more easily.

Bug: webrtc:13980
Change-Id: I6cd46f75d56597c10e08d0d66e16089516f5129c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259821
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36613}
 2022-04-22 09:15:39 +00:00
Artem Titov
50dc7301a0 [PCLF] Remove VideoSubscription::Resolution 
Bug: b/213863770
Change-Id: I65cf68a8d5101f3ce416b7163c062c78e8a1ef87
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259506
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36600}
 2022-04-21 09:39:15 +00:00
Artem Titov
7017a13597 [PCLF] Move Resolution from VideoSubscription to the fixture. 
Move VideoSubscription::Resolution to the fixture class and rename it to
the VideoResolution. It should be then integrated into other video
related classes.

Bug: b/213863770
Change-Id: Ifd391f840ef8de43bbac66d23df3ecf7258b3943
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259523
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Reviewed-by: Taylor Brandstetter <deadbeef@google.com>
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36594}
 2022-04-20 20:00:24 +00:00
Artem Titov
83962d9182 [PCLF] Add GetMaxResolution among resolutions 
Bug: b/213863770
Change-Id: I5f90cc5345be8630a2ededf93e1648d4c9bb1be2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259504
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36593}
 2022-04-20 18:10:14 +00:00
Artem Titov
0d510529e7 [PCLF] Introduce API to subscribe to particular streams 
Bug: b/213863770
Change-Id: If858686cd265ad48b4ea8be246651eff65fad4f3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258981
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36570}
 2022-04-19 12:18:20 +00:00
Artem Titarenko
21f12d592a Add rtc_offer_answer_options to peer_connection_quality_test_params. 
And use it to generate SDP offers.

Bug: b/203195868
Change-Id: I6f04c92dcef42e2d406d954c2e2ee6e845bcbac1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258795
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Artem Titarenko <artit@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36551}
 2022-04-14 12:42:39 +00:00
Tomas Gunnarsson
af3406ed99 Change MockRtpSender to not inherit from RefCountedObject. 
Bug: webrtc:12701
Change-Id: I415e4d6c2507398eccb163b5f6914db00ecf7e45
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256100
Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36352}
 2022-03-28 09:58:50 +00:00
Niels Möller
9dde120d65 Reject double RefCountedObject inheritance in rtc::make_ref_counted. 
Bug: webrtc:12701
Change-Id: Ie45707e3266e6a27cae073f824a1c77707d77000
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256240
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36281}
 2022-03-21 16:31:21 +00:00
Tomas Gunnarsson
493718ea47 Make MockRtpTransceiver not inherit from RefCountedObject 
Bug: webrtc:12701
Change-Id: Ia43c943cbf96ef7d745dfea79ecca6e52e8bc3b6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256104
Reviewed-by: Niels Moller <nisse@webrtc.org>
Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36279}
 2022-03-21 14:09:02 +00:00
Tomas Gunnarsson
b3517fea83 Remove RefCountedObject dependency from FakeFrameDecryptor 
Bug: webrtc:12701
Change-Id: I705007948eed7b8300f02a61307e8f4b3410e666
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256108
Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36276}
 2022-03-21 09:43:12 +00:00
Tomas Gunnarsson
82c94af48f Revert "Make MockPeerConnectionInterface not inherit from RefCountedObject" 
This reverts commit d67903d284.

Reason for revert: A downstream issue needs to be fixed.

Original change's description:
> Make MockPeerConnectionInterface not inherit from RefCountedObject
>
> Bug: webrtc:12701
> Change-Id: I51fb7caf12b97d70f35af12703104112f9fdfaff
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256107
> Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org>
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Commit-Queue: Harald Alvestrand <hta@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#36267}

Bug: webrtc:12701
Change-Id: I25e2d6004d257dd0b1d17fb1f7726d04d29e6eed
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256109
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36271}
 2022-03-20 18:48:02 +00:00
Tomas Gunnarsson
d67903d284 Make MockPeerConnectionInterface not inherit from RefCountedObject 
Bug: webrtc:12701
Change-Id: I51fb7caf12b97d70f35af12703104112f9fdfaff
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256107
Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36267}
 2022-03-19 16:17:27 +00:00
Artem Titov
7e04b49bb8 [PCLF] Add ability to provide audio processor and mixer 
Bug: b/196034093
Change-Id: Ia444acfcf3f3c40e4a3affd61ed9c107470ef013
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253880
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36148}
 2022-03-08 09:35:11 +00:00
Artem Titov
003e6e99b3 [PCLF] Add ability to specify custom PortAllocator flags 
Bug: b/196034093
Change-Id: Ia1838c5c9ace096d7e77e31f7f2ad6b6352fd1ea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252100
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Jonas Oreland <jonaso@google.com>
Reviewed-by: Jonas Oreland <jonaso@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36060}
 2022-02-23 15:27:27 +00:00
Sergey Silkin
a6bab608df Report encode/decode latency 
Bug: none
Change-Id: If36ee02ee762718b1c1b6f84cd22cb866ba0d51b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251863
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36024}
 2022-02-17 12:17:42 +00:00
Artem Titov
df2b264ac0 [PCLF] Remove deprecated APIs 
Bug: b/213863770
Change-Id: I69c0a9983831b7d59e24dc800a5f0d198cb40747
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251820
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36017}
 2022-02-16 14:23:59 +00:00
Sergey Silkin
0b02d637c0 Calculate max/avg encode/decode latency in codec tests 
Bug: none
Change-Id: Ie42461dd06b1764c99308393477921ea25319ab4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251687
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36007}
 2022-02-15 18:14:41 +00:00
Artem Titov
b92d3e6ef9 [PCLF] Move FEC and bitrate mulitplier into per peer configs 
Bug: b/213863770
Change-Id: Idcf37150e769db18d4a12baa1057840d521b8e1f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251761
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36006}
 2022-02-15 18:10:31 +00:00
Harald Alvestrand
93dd763360 Remove deprecated RemoveTrack interface 
Bug: webrtc:9534
Change-Id: I970e6fd43284d9159897d5214fff9992cd26e171
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247371
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35856}
 2022-01-31 14:08:57 +00:00
Ali Tofigh
c98687a2ef Replace "(const override)" with "(const, override)" in GMOCKs 
Just applied a short sed script. See bug description for
the motiviation for this change.

This is the command that was used to generate the changes:
$ find . -type f \( -iname '*.cc' -o -iname '*.h' \) -print0 | \
      xargs -0 sed -i -e 's/(const override)/(const, override)/'

Bug: webrtc:13090
Change-Id: Iec7d280f9d55263a972dbb3bd644ebfcd2eb38cf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249088
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Ali Tofigh <alito@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35801}
 2022-01-26 10:59:40 +00:00
Harald Alvestrand
4f19950660 Reland "Remove some default implementations in api/rtp_transcever_interface" 
This reverts commit 226a2e32d0.

Reason for revert: Downstream fixed (will submit when true)

Original change's description:
> Revert "Remove some default implementations in api/rtp_transcever_interface"
>
> This reverts commit 40941ee72d.
>
> Reason for revert: breaks downstream project
>
> Original change's description:
> > Remove some default implementations in api/rtp_transcever_interface
> >
> > Bug: webrtc:11839
> > Change-Id: I6ddc0468e75bc346e12fc3dc64236ca2ab52e708
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244504
> > Reviewed-by: Henrik Boström <hbos@webrtc.org>
> > Commit-Queue: Harald Alvestrand <hta@webrtc.org>
> > Cr-Commit-Position: refs/heads/main@{#35701}
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: webrtc:11839
> Change-Id: I8a3eb0a279b28ed8b55745af97596c4a853669be
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247186
> Reviewed-by: Björn Terelius <terelius@webrtc.org>
> Owners-Override: Artem Titov <titovartem@webrtc.org>
> Commit-Queue: Artem Titov <titovartem@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#35713}

# Not skipping CQ checks because this is a reland.

Bug: webrtc:11839
Change-Id: Ie25f1a5fdb4ef8ebf200780755a69dc09dd28ccb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247189
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35737}
 2022-01-19 11:32:24 +00:00
Artem Titov
226a2e32d0 Revert "Remove some default implementations in api/rtp_transcever_interface" 
This reverts commit 40941ee72d.

Reason for revert: breaks downstream project

Original change's description:
> Remove some default implementations in api/rtp_transcever_interface
>
> Bug: webrtc:11839
> Change-Id: I6ddc0468e75bc346e12fc3dc64236ca2ab52e708
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244504
> Reviewed-by: Henrik Boström <hbos@webrtc.org>
> Commit-Queue: Harald Alvestrand <hta@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#35701}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: webrtc:11839
Change-Id: I8a3eb0a279b28ed8b55745af97596c4a853669be
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247186
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Owners-Override: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35713}
 2022-01-17 17:57:20 +00:00
Harald Alvestrand
40941ee72d Remove some default implementations in api/rtp_transcever_interface 
Bug: webrtc:11839
Change-Id: I6ddc0468e75bc346e12fc3dc64236ca2ab52e708
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244504
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35701}
 2022-01-16 15:28:42 +00:00
Niels Möller
961f382458 Update api/ to not use implicit T* --> scoped_refptr<T> conversion 
Bug: webrtc:13464
Change-Id: I5dc292fefd27bfd43574f3e0c63c0e1da6dddcae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244091
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35667}
 2022-01-12 11:26:05 +00:00
Harald Alvestrand
09a0d0171c Deprecate RemoveTrack (old signature) 
This also removes all internal usage of RemoveTrack, and changes
the replacement function to RemoveTrackOrError rather than RemoveTrackNew.

Bug: webrtc:9534
Change-Id: Idf7bb17495686de77c70428dcbfb12278328ce59
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244094
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35624}
 2022-01-04 20:44:07 +00:00
Niels Möller
707e5a0cd7 Make test framework create portallocator with an explicit PacketSocketFactory. 
Bug: webrtc:13145
Change-Id: I04575517b1e215a2204611415f728c358c8d64fe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/238660
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35408}
 2021-11-23 15:00:33 +00:00
Niels Möller
45e15e3343 Prepare for migrating to new AddPeer method 
Bug: webrtc:13145
Change-Id: I089d518e55cb8df32ddf3c587f82376226c18e9a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/238761
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35406}
 2021-11-23 13:04:44 +00:00
Niels Möller
f47a724168 New struct PeerNetworkDependencies 
Preparation to make landing of
https://webrtc-review.googlesource.com/c/src/+/238660
easier.

Bug: webrtc:13145
Change-Id: I314a53cc634f842e5df009d0802b214aa6f8728b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/238663
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35403}
 2021-11-23 08:37:36 +00:00
Sergey Silkin
984cf9b837 Explicitly set encoder and decoder format in codec tests. 
This allows to differentiate and test codecs of the same type but
different implementations/settings.

Bug: none
Change-Id: I74f799b36411e63387513133ffc19a7f0c45d550
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/238165
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35396}
 2021-11-22 08:18:25 +00:00
Artem Titov
be9c40f0b4 Fix documentation for VideoQualityAnalyzerInterface::GetStreamLabel 
Bug: b/205824594
Change-Id: I76eff28984446ed94d701129d63f2a1643f9d983
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/238161
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35365}
 2021-11-17 11:38:33 +00:00
Niels Möller
13d163654a Delete support for has_internal_source 
Bug: webrtc:12875
Change-Id: I9683e71e1fe5b24802033ffcb32a531ca685fc6f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179220
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35353}
 2021-11-16 11:29:40 +00:00
Artem Titov
d3251968d1 Prepare to rename RTC_NOTREACHED to RTC_DCHECK_NOTREACHED 
Add implementation of RTC_DCHECK_NOTREACHED equal to the RTC_NOTREACHED.
The new macros will replace the old one when old one's usage will be
removed. The idea of the renaming to provide a clear signal that this
is debug build only macros and will be stripped in the production build.

Bug: webrtc:9065
Change-Id: I4c35d8b03e74a4b3fd1ae75dba2f9c05643101db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/237802
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35348}
 2021-11-15 21:44:59 +00:00
Niels Möller
5e7a3aedf1 Let EmulatedNetworkManagerInterface own and expose a PacketSocketFactory 
So that applications don't need to construct it from the exposed
network_thread.

The EmulatedNetworkManagerInterface::network_thread() accessor is currently
used as a way to get to emulation's SocketServer, and should be deleted
when applications of the emulation framework have migrated away from
that usage.

Bug: webrtc:13145
Change-Id: I3efa55d117cad8ac601c48a9d2d2aa62a121f9c9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231649
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#34964}
 2021-09-10 13:14:03 +00:00