Commit graph

40253 commits

Author SHA1 Message Date
philipel
b071871aa0 Remove unused ALR experiment settings from VideoStreamEncoder.
Bug: none
Change-Id: Ie468de940656be7dd307cc529be6c3904c275144
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/316920
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40571}
2023-08-18 15:11:26 +00:00
Danil Chapovalov
c146b5f77b Represent unset VideoPlayoutDelay with nullopt rather than special value
Remove support for setting one limit without another limit
because related rtp header extension doesn't support such values.

Start morphing VideoPlayouDelay into a class and stricter type: add accessors returning TimeDelta

Bug: webrtc:13756
Change-Id: If0dd02620528dc870b015beeff3a8103e04022ee
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315921
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40570}
2023-08-18 13:17:50 +00:00
Danil Chapovalov
0250b69fd4 Delete unused constructor of FakeNetworkPipe
Bug: None
Change-Id: I960f9d3988e10fa22f3379d071818ad44e36d456
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/316861
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40569}
2023-08-18 13:07:10 +00:00
chromium-webrtc-autoroll
44e54a75a7 Roll chromium_revision 4b024ef0b5..a7b5beaadc (1185015:1185128)
Change log: 4b024ef0b5..a7b5beaadc
Full diff: 4b024ef0b5..a7b5beaadc

Changed dependencies
* src/base: 0a8c04c3f5..d9efc47419
* src/ios: ddb9c93802..94de5001c2
* src/testing: be1a5077d7..fa612350fe
* src/third_party: c6d7f3b75f..d340287120
* src/third_party/androidx: YtxST43XGbOdsTrMQ9G2B1PyDBR9phkvg90LUOWcRTUC..y7ID7CNpHQ3VnHGUztRLKlv8JTS4qY5gaKrbVpDuXAEC
* src/tools: f5f4d48512..a0222e8a2b
DEPS diff: 4b024ef0b5..a7b5beaadc/DEPS

No update to Clang.

BUG=None

Change-Id: I135e212ce5a6e24d5a9b93fe44714a3502db370d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/316900
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40568}
2023-08-18 13:01:40 +00:00
Magnus Jedvert
70483a59aa Add unscaled getWidth/Height to TextureBuffer interface
Bug: b/289762633
Change-Id: I36a8c108ca03d464cd4dd08441dc9b64077343c1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/316860
Commit-Queue: Magnus Jedvert <magjed@webrtc.org>
Reviewed-by: Fabian Bergmark <fabianbergmark@google.com>
Cr-Commit-Position: refs/heads/main@{#40567}
2023-08-18 12:04:32 +00:00
Danil Chapovalov
31251fa817 Delete deprecated RTPSender::SetCsrcs
Bug: None
Change-Id: I0ce16dc51fa8aa9dcb1f3e96e62f05be11e3cba2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315941
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40566}
2023-08-18 11:50:02 +00:00
webrtc-version-updater
68dafcb6c1 Update WebRTC code version (2023-08-18T04:05:33).
Bug: None
Change-Id: I4d734b29dea09c4278de565510bda49cf4b6fcc6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/316780
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40565}
2023-08-18 05:51:18 +00:00
chromium-webrtc-autoroll
dce991342c Roll chromium_revision 80b8365885..4b024ef0b5 (1184627:1185015)
Change log: 80b8365885..4b024ef0b5
Full diff: 80b8365885..4b024ef0b5

Changed dependencies
* src/base: 0d5be5363a..0a8c04c3f5
* src/build: 265775b08f..e9f9f56b0d
* src/ios: dd905d9768..ddb9c93802
* src/testing: a3c4634ec7..be1a5077d7
* src/third_party: 767aa06a0e..c6d7f3b75f
* src/third_party/androidx: 65tEj77ONRpxW_6QA0rYm8nEEupr5COOwasM14Jln5YC..YtxST43XGbOdsTrMQ9G2B1PyDBR9phkvg90LUOWcRTUC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/8bcfe7164c..2c0142037d
* src/third_party/depot_tools: 07289ce941..978f43dd52
* src/third_party/freetype/src: a20de84e16..a9793feace
* src/third_party/libaom/source/libaom: https://aomedia.googlesource.com/aom.git/+log/0716dc8e2d..ca708d66b6
* src/third_party/libc++abi/src: 4c1ff08698..6a8358a142
* src/third_party/perfetto: 029945afde..41e25ff82a
* src/third_party/r8: _xu0hxSo_cEnMJPA-S-noLhx1IRAhNKER0h_icp-hSYC..tDdXJHu3mdHCZRM7rVC6e0OajNZJy8FGLqu9ItFtnUwC
* src/tools: 81ab8780f3..f5f4d48512
DEPS diff: 80b8365885..4b024ef0b5/DEPS

No update to Clang.

BUG=None

Change-Id: If868b6035e056d55655f6fff313119c8111a7f4c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/316723
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40564}
2023-08-18 03:02:50 +00:00
Johannes Kron
e5af52e1f2 Make DesktopFrameCGImage::CreateFromCGImage() public
CreateFromCGImage() is needed to be called directly when we move away
from using the deprecated API that is used in CreateForWindow().

Bug: chromium:1471931
Change-Id: I28a2972a2a995103829fd9aff4bc1137a8b424b0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315324
Reviewed-by: Mark Foltz <mfoltz@chromium.org>
Commit-Queue: Mark Foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#40563}
2023-08-18 01:12:17 +00:00
chromium-webrtc-autoroll
a39d7643ef Roll chromium_revision 9f26c488cf..80b8365885 (1184507:1184627)
Change log: 9f26c488cf..80b8365885
Full diff: 9f26c488cf..80b8365885

Changed dependencies
* src/base: f3839990a5..0d5be5363a
* src/build: 4439c8aa49..265775b08f
* src/buildtools: a5ad157866..c4a369c9b6
* src/ios: 56c0c04c95..dd905d9768
* src/testing: 5c72848aae..a3c4634ec7
* src/third_party: 64d70d72af..767aa06a0e
* src/third_party/androidx: GwPHeH5nDbKXURzYxNpCMayK7NE1pOW-GpMPLDYGKK8C..65tEj77ONRpxW_6QA0rYm8nEEupr5COOwasM14Jln5YC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/49dd56f508..8bcfe7164c
* src/tools: 45989d4f1a..81ab8780f3
DEPS diff: 9f26c488cf..80b8365885/DEPS

No update to Clang.

BUG=None

Change-Id: I793db7d567a9cfff1cf6168c55dbb5619ba994b0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/316560
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40562}
2023-08-17 10:46:16 +00:00
Qiu Jianlin
69e2637787 Fix playout delay logging typo.
Bug: webrtc:15420
Change-Id: I095a954acb478d811797b7149bd29dcb25587973
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/316460
Commit-Queue: Jianlin Qiu <jianlin.qiu@intel.com>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40561}
2023-08-17 10:18:52 +00:00
webrtc-version-updater
4f89506e53 Update WebRTC code version (2023-08-17T04:03:59).
Bug: None
Change-Id: Id79968e07b7a694ce1c1f4066b6724dc281ed5e9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/316441
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40560}
2023-08-17 05:46:27 +00:00
chromium-webrtc-autoroll
6cb8b4fbfb Roll chromium_revision c7e600fcc1..9f26c488cf (1184329:1184507)
Change log: c7e600fcc1..9f26c488cf
Full diff: c7e600fcc1..9f26c488cf

Changed dependencies
* src/base: be6204b68b..f3839990a5
* src/build: f090abe967..4439c8aa49
* src/ios: d11fd27b46..56c0c04c95
* src/testing: e14a17b3a4..5c72848aae
* src/third_party: 33cd7d2d5a..64d70d72af
* src/third_party/androidx: 72OrhoxRCpPaLpIr0nDrlhaTfN8VorgC81HCZrVo5sMC..GwPHeH5nDbKXURzYxNpCMayK7NE1pOW-GpMPLDYGKK8C
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/180066d66d..b8e012e1ff
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/8474745739..49dd56f508
* src/third_party/perfetto: 42a117e9cd..029945afde
* src/tools: 05d9644800..45989d4f1a
DEPS diff: c7e600fcc1..9f26c488cf/DEPS

No update to Clang.

BUG=None

Change-Id: Ic97819c4c9258c2e2896dfbe6d19e7b33240891a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/316420
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40559}
2023-08-17 03:03:00 +00:00
chromium-webrtc-autoroll
ee15bea056 Roll chromium_revision b88d5ed17e..c7e600fcc1 (1183080:1184329)
Change log: b88d5ed17e..c7e600fcc1
Full diff: b88d5ed17e..c7e600fcc1

Changed dependencies
* src/base: d0b8dae9ef..be6204b68b
* src/build: 193968ce60..f090abe967
* src/ios: 7e0aee308c..d11fd27b46
* src/testing: 5c2c8d4893..e14a17b3a4
* src/third_party: 6bdc9cc54a..33cd7d2d5a
* src/third_party/android_build_tools/manifest_merger: d1tFnzOW6H5xoDN7WWsMuAiHuhkl0kXijQGiO7IU1VQC..Nc9kYyTsw69N7yKSw_Sc2fJtUJ2zXUhSGjXbIkDVXuIC
* src/third_party/android_sdk/public: EWnL2r7oV5GtE9Ef7GyohyFam42wtMtEKYU4dCb3U1YC..Sy00LuyBIUJdRGYKwg0zjWH8eAIUvgnnNiPkI8etaZYC
* src/third_party/androidx: WJvGTaSHCNCpZEeWzwMyZeGT_2FtDXGwqMbKoHUNxfsC..72OrhoxRCpPaLpIr0nDrlhaTfN8VorgC81HCZrVo5sMC
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/e4acd6cb56..180066d66d
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/91aa9652fe..8474745739
* src/third_party/freetype/src: 3829fdaae5..a20de84e16
* src/third_party/libaom/source/libaom: https://aomedia.googlesource.com/aom.git/+log/92fb72a64e..0716dc8e2d
* src/third_party/libc++abi/src: 3cede154a6..4c1ff08698
* src/third_party/perfetto: 2a5d21f5fb..42a117e9cd
* src/third_party/r8: 8aJvD7uHZ0Ek4sQy5vAbHUXWujgCHOVsAsJ137sXslkC.._xu0hxSo_cEnMJPA-S-noLhx1IRAhNKER0h_icp-hSYC
* src/third_party/turbine: HFp7iOu-n4-CdEasFTQZvD1Vg1L-q1URqRTOM-iZ2AMC..ZlMS4BOYyYmbU8BuBDGyW7QrkvZ_-pTkm4lH4jKjTi4C
* src/tools: c8d2e387fb..05d9644800
DEPS diff: b88d5ed17e..c7e600fcc1/DEPS

Clang version changed llvmorg-18-init-1174-g2532b68f:llvmorg-17-init-16420-g0c545a44
Details: b88d5ed17e..c7e600fcc1/tools/clang/scripts/update.py

BUG=None

Change-Id: Id3ec14143fa40ff9cd0f67777c7c7143baa36107
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/316360
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40558}
2023-08-16 20:42:17 +00:00
Philipp Hancke
1e42d83db4 Make VCMReceiveCallback::FrameToRender pure virtual again
after the downstream tests have been updated.

BUG=webrtc:14728

Change-Id: I9cf7eb607f8b26acf985d90625e55bac257a2606
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/316220
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40557}
2023-08-16 10:44:28 +00:00
webrtc-version-updater
ff2462e54a Update WebRTC code version (2023-08-16T04:02:29).
Bug: None
Change-Id: I50b22b6398341cf7ca0ade948990473bad8dfe9d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/316281
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40556}
2023-08-16 05:32:42 +00:00
Tony Herre
392e4714e7 Remove deprecated TransformableAudioFrameInterface::getHeader() method
Fixed: chromium:1456628
Change-Id: I12ea08070578de846f042c64f2808b55de1603a8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315960
Auto-Submit: Tony Herre <herre@google.com>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40555}
2023-08-15 16:31:02 +00:00
Harald Alvestrand
d43af9172b Remove internal overrides using old SendRtp and SendRtcp interfaces.
This CL takes away all usages except for Android code.

Low-Coverage-Reason: Refactoring old code
Bug: webrtc:15410
Change-Id: I66bed6a4a2787b4177a82e599b48623ca67cd235
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315940
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40554}
2023-08-15 13:20:21 +00:00
Philipp Hancke
5165743926 Reland "Fix definition of keyframes decoded statistics"
This is a reland of commit 0e37f5ebd4
with backward compability added to allow downstream tests to migrate to the new signature.

Original change's description:
> Fix definition of keyframes decoded statistics
>
> which are defined to be measured after decoding, not before:
>   https://w3c.github.io/webrtc-stats/#dom-rtcinboundrtpstreamstats-keyframesdecoded
>
> BUG=webrtc:14728
>
> Change-Id: I0a83dde278e1ebe8acf787bdac729af369a1ecf8
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315520
> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
> Commit-Queue: Philipp Hancke <phancke@microsoft.com>
> Reviewed-by: Henrik Boström <hbos@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#40545}

BUG=webrtc:14728

Change-Id: I4cf52bb22ba8244155b4fa8c367b9c0306a77590
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/316120
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#40553}
2023-08-15 12:09:46 +00:00
Mirko Bonadei
48852c40f4 Drop email recipients from lkgr finder.
Bug: chromium:1472663
Change-Id: I49f096ef8e8f37624f5d8595e99d0e30f642482f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315980
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40552}
2023-08-15 08:39:43 +00:00
webrtc-version-updater
c2da2e2baf Update WebRTC code version (2023-08-15T04:12:47).
Bug: None
Change-Id: I6099bac933382b418dbe3fa0fc6fae2fa0cf4013
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/316101
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40551}
2023-08-15 05:46:23 +00:00
Mirko Bonadei
2dbf6e09c1 Revert "Fix definition of keyframes decoded statistics"
This reverts commit 0e37f5ebd4.

Reason for revert: Breaks downstream tests (non backwards compatible change)

Original change's description:
> Fix definition of keyframes decoded statistics
>
> which are defined to be measured after decoding, not before:
>   https://w3c.github.io/webrtc-stats/#dom-rtcinboundrtpstreamstats-keyframesdecoded
>
> BUG=webrtc:14728
>
> Change-Id: I0a83dde278e1ebe8acf787bdac729af369a1ecf8
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315520
> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
> Commit-Queue: Philipp Hancke <phancke@microsoft.com>
> Reviewed-by: Henrik Boström <hbos@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#40545}

BUG=webrtc:14728
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Change-Id: Idd31fbe6b7173e4bcdfaabfc1704ec6513e80ebe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315961
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40550}
2023-08-14 17:12:56 +00:00
chromium-webrtc-autoroll
b2be55d5fa Roll chromium_revision ba4f77cde1..b88d5ed17e (1182677:1183080)
Change log: ba4f77cde1..b88d5ed17e
Full diff: ba4f77cde1..b88d5ed17e

Changed dependencies
* src/base: d9acc724da..d0b8dae9ef
* src/build: cc06100153..193968ce60
* src/buildtools: a9a6f0c49d..a5ad157866
* src/ios: a9aec568a0..7e0aee308c
* src/testing: 971c08a002..5c2c8d4893
* src/third_party: 6bbad2076c..6bdc9cc54a
* src/third_party/androidx: 4wCy8XSvFxkpCWEnr_nTfYLER2pqB8ZC1mHzilXgBH0C..WJvGTaSHCNCpZEeWzwMyZeGT_2FtDXGwqMbKoHUNxfsC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/598916632c..91aa9652fe
* src/third_party/libc++abi/src: cc2a32ba83..3cede154a6
* src/third_party/perfetto: 6eda20974c..2a5d21f5fb
* src/third_party/r8: gAkFIrXkgbLOsddL5MkR5JZs0IR02MvXqPL9v075pm8C..8aJvD7uHZ0Ek4sQy5vAbHUXWujgCHOVsAsJ137sXslkC
* src/tools: 95c8180c3f..c8d2e387fb
DEPS diff: ba4f77cde1..b88d5ed17e/DEPS

No update to Clang.

BUG=None

Change-Id: Ic15bb1c4b5c4c9ec4779ee66224072953af90d2f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315865
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40549}
2023-08-14 15:03:19 +00:00
Markus Handell
ed2ce81f27 RtpSenderEgress: make potential crash more explicit.
Fixed: chromium:1472676
Change-Id: I1701b65e05c13c95392da90e6642e4eb6fe133ec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315920
Commit-Queue: Markus Handell <handellm@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40548}
2023-08-14 14:54:53 +00:00
Danil Chapovalov
4c17e2dbce Refactor csrcs managment in RtpSender
contributing sources are usually decided per packet, and thus having persistent member for csrcs makes them less natural to use.

Bug: None
Change-Id: I804d58ace574368f8cdd4356a15471110e530744
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291334
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40547}
2023-08-14 13:30:33 +00:00
Andrey Volykhin
6b51e728e6 fec: Skip traversal the list of recovered packets if possible
Do not traverse the list of recovered media packets
if none of them was recovered through FEC recovery procedure.

Bug: None
Change-Id: Ib3aa59c946919fab08f0e20fcf279b1b8032d0e3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315320
Commit-Queue: Erik Språng <sprang@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Auto-Submit: Andrei Volykhin <andrey.volykhin@lge.com>
Cr-Commit-Position: refs/heads/main@{#40546}
2023-08-14 13:21:14 +00:00
Philipp Hancke
0e37f5ebd4 Fix definition of keyframes decoded statistics
which are defined to be measured after decoding, not before:
  https://w3c.github.io/webrtc-stats/#dom-rtcinboundrtpstreamstats-keyframesdecoded

BUG=webrtc:14728

Change-Id: I0a83dde278e1ebe8acf787bdac729af369a1ecf8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315520
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40545}
2023-08-14 12:13:38 +00:00
webrtc-version-updater
1b1f712247 Update WebRTC code version (2023-08-12T04:04:01).
Bug: None
Change-Id: Id5868e12f6a05a8e8f6b6345cbf964a732f87a53
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315449
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40544}
2023-08-12 05:54:18 +00:00
chromium-webrtc-autoroll
0bd0897641 Roll chromium_revision d6e852857c..ba4f77cde1 (1182529:1182677)
Change log: d6e852857c..ba4f77cde1
Full diff: d6e852857c..ba4f77cde1

Changed dependencies
* fuchsia_version: version:14.20230804.1.1..version:14.20230811.1.1
* src/base: 440a61ff76..d9acc724da
* src/build: 4fb90f22dd..cc06100153
* src/ios: 92e615fe8e..a9aec568a0
* src/testing: 19386a696a..971c08a002
* src/third_party: aa4cb2f252..6bbad2076c
* src/third_party/androidx: 86kTZYjTlSuqFy1h1q3jlp7fbNNBnXGfXfN3MNj7Zw8C..4wCy8XSvFxkpCWEnr_nTfYLER2pqB8ZC1mHzilXgBH0C
* src/third_party/perfetto: fcc0512ebf..6eda20974c
* src/third_party/r8: c5gwBJlApOcrNvnktaZlEXQ168Ig5dECf1tJyt5fcjwC..gAkFIrXkgbLOsddL5MkR5JZs0IR02MvXqPL9v075pm8C
* src/tools: be158fa0f4..95c8180c3f
DEPS diff: d6e852857c..ba4f77cde1/DEPS

No update to Clang.

BUG=None

Change-Id: I10178e785a74ac00e6aaa69b24cf03cc1eb31d6f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315562
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40543}
2023-08-11 18:26:45 +00:00
chromium-webrtc-autoroll
0a740a90af Roll chromium_revision b5f5329314..d6e852857c (1182406:1182529)
Change log: b5f5329314..d6e852857c
Full diff: b5f5329314..d6e852857c

Changed dependencies
* src/base: 690397edbb..440a61ff76
* src/ios: 80bd7ef727..92e615fe8e
* src/testing: 3ec40913ae..19386a696a
* src/third_party: cbb8f87abb..aa4cb2f252
* src/third_party/androidx: JLRSURseZMZWEttHS8Pehsc7-j2e_NxgX7NXKRvrggsC..86kTZYjTlSuqFy1h1q3jlp7fbNNBnXGfXfN3MNj7Zw8C
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/e758fe642e..598916632c
* src/third_party/perfetto: 0d2cb0a16d..fcc0512ebf
* src/tools: 0b7a2d2c38..be158fa0f4
DEPS diff: b5f5329314..d6e852857c/DEPS

No update to Clang.

BUG=None

Change-Id: I6a144b619ef17ff769a87683400040b898db35d4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315501
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40542}
2023-08-11 13:04:08 +00:00
MohamedRisaldarTA
b9876488e9 Exposed Adapter types for Android
This avoids the need of hard coding the values to use networkIgnoreMask  on Android platform.

Bug: None
Change-Id: Ib5e860913cec2c6d41cfa1b778cb122d0bfe1300
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/311780
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40541}
2023-08-11 08:29:14 +00:00
webrtc-version-updater
721b9083d2 Update WebRTC code version (2023-08-11T04:02:03).
Bug: None
Change-Id: I8e8451b840ab19294e7857d28d8df8786aa005c8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315405
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40540}
2023-08-11 05:20:50 +00:00
chromium-webrtc-autoroll
497eacf8ac Roll chromium_revision ac89fd7158..b5f5329314 (1182099:1182406)
Change log: ac89fd7158..b5f5329314
Full diff: ac89fd7158..b5f5329314

Changed dependencies
* src/base: d41eb34c45..690397edbb
* src/ios: 5652eb3b98..80bd7ef727
* src/testing: 7aeb8a694f..3ec40913ae
* src/third_party: fd0b09c952..cbb8f87abb
* src/third_party/androidx: kDNf6TnwWRTkykitS9yM0-gAWzgp3HCwvyK4_KvDMkEC..JLRSURseZMZWEttHS8Pehsc7-j2e_NxgX7NXKRvrggsC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/0b39a694c0..e758fe642e
* src/third_party/perfetto: e50c712c99..0d2cb0a16d
* src/tools: 69942cf117..0b7a2d2c38
* src/tools/luci-go: git_revision:e608c1f557fceae8eb6cf35ae2ad6f4908e35245..git_revision:77c9b09de8f234ae9c47d9d865a5d860ff390ed0
* src/tools/luci-go: git_revision:e608c1f557fceae8eb6cf35ae2ad6f4908e35245..git_revision:77c9b09de8f234ae9c47d9d865a5d860ff390ed0
DEPS diff: ac89fd7158..b5f5329314/DEPS

No update to Clang.

BUG=None

Change-Id: I28b85ed31e86d3022f8b4c25f692b52785862b56
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315404
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40539}
2023-08-11 03:10:36 +00:00
Danil Chapovalov
24e704f148 Cleanup calculating time between RTCP reports
Move that calculation into dedicated function, move comment why it is calculated the way it is into the same function.
Cleanup that comment - remove parts unused by current code, in particular remove description of code that was deleted a while ago
Use more strict types for the calculation to make it clearer.
Replace DCHECK result can't be zero with a clamp to ensure it can't be zero, because with large bitrates it may.

Reland of https://webrtc-review.googlesource.com/c/src/+/315143

Bug: None
Change-Id: I41ce383a2f19d489e4cae0b1bf1f720e0ffdd17a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315460
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40538}
2023-08-10 20:40:15 +00:00
chromium-webrtc-autoroll
92ce470747 Roll chromium_revision 80c35b98ae..ac89fd7158 (1180373:1182099)
Change log: 80c35b98ae..ac89fd7158
Full diff: 80c35b98ae..ac89fd7158

Changed dependencies
* reclient_version: re_client_version:0.111.0.1ccaa23-gomaip..re_client_version:0.112.0.ffc95d4-gomaip
* src/base: 4845bf859d..d41eb34c45
* src/build: c14d86f2ac..4fb90f22dd
* src/buildtools/linux64: git_revision:811d332bd90551342c5cbd39e133aa276022d7f8..git_revision:cc56a0f98bb34accd5323316e0292575ff17a5d4
* src/buildtools/mac: git_revision:811d332bd90551342c5cbd39e133aa276022d7f8..git_revision:cc56a0f98bb34accd5323316e0292575ff17a5d4
* src/buildtools/reclient: re_client_version:0.111.0.1ccaa23-gomaip..re_client_version:0.112.0.ffc95d4-gomaip
* src/buildtools/win: git_revision:811d332bd90551342c5cbd39e133aa276022d7f8..git_revision:cc56a0f98bb34accd5323316e0292575ff17a5d4
* src/ios: af5e59ca5c..5652eb3b98
* src/testing: 43317e989d..7aeb8a694f
* src/third_party: 3b06b3cc29..fd0b09c952
* src/third_party/android_build_tools/bundletool: 2PJKytTLILAjCO3G7sCO27FO48XB9qrRTHp420zr5G0C..2RPwohwtc6on0_96oFxokeEvnC1LbLrGuyCAw00k62AC
* src/third_party/androidx: fKq4SHYaZsLkQtDQsKxkn2xysI5m1pLftMfADDOXsywC..kDNf6TnwWRTkykitS9yM0-gAWzgp3HCwvyK4_KvDMkEC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/220cbb13b5..0b39a694c0
* src/third_party/depot_tools: 6d0c235dae..07289ce941
* src/third_party/libc++abi/src: d4760c0af9..cc2a32ba83
* src/third_party/perfetto: 446adf5b7b..e50c712c99
* src/third_party/r8: dbml4pnGIsEBy3dFYki-S8IYt4jxxqZXaUDwtY3Q-SgC..c5gwBJlApOcrNvnktaZlEXQ168Ig5dECf1tJyt5fcjwC
* src/tools: e3244f7e27..69942cf117
DEPS diff: 80c35b98ae..ac89fd7158/DEPS

Clang version changed llvmorg-17-init-16420-g0c545a44:llvmorg-18-init-1174-g2532b68f
Details: 80c35b98ae..ac89fd7158/tools/clang/scripts/update.py

BUG=None

Change-Id: I5c700d33ef49910fd1044a7209fe87deb0e22a6c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315401
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40537}
2023-08-10 17:06:11 +00:00
Sergey Silkin
c252a40b47 Use layer/encode target resolution in DropDueToSize
It used input frame resolution before this change which caused unnecessary resolution adaptations when resolution scaling is used.

Found that initial frame dropping was always enabled for AV1 SVC. After fixing DropDueToSize the AV1 SVC tests [1] started to fail ("number of encoded temporal layers is less than expected") on bots. The tests encode 1850x1110 in L3T3 for 5s using the default 300kbps start bitrate. Before the fix the initial frame dropping kicked in and reduced the resolution to a level that let encoder to generate all temporal layers. After the fix the resolution stayed at 1850x1110 and encoder dropped all T1 and T2 layer frames. Mitigated this by increasing test duration from 5 to 10s. This gives enough time for BWE to ramp up and for encoder to generate (stop dropping) all temporal layers.

[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/pc/test/svc_e2e_tests.cc;l=460;bpv=1

Bug: chromium:1466809
Change-Id: I16802689e234f8fc16f891f024d5f644985de01c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315142
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40536}
2023-08-10 15:11:08 +00:00
Danil Chapovalov
3b75c39d59 Revert "Cleanup calculating time between RTCP reports"
This reverts commit 762f193ca4.

Reason for revert: breaks downstream test

Original change's description:
> Cleanup calculating time between RTCP reports
>
> Move that calculation into dedicated function, move comment why it is calculated the way it is into the same function.
> Cleanup that comment - remove parts unused by current code, in particular remove description of code that was deleted a while ago
> Use more strict types for the calculation to make it clearer.
> Replace DCHECK result can't be zero with a clamp to ensure it can't be zero, because with large bitrates it may.
>
> Bug: None
> Change-Id: Ie8c6b9720095cd1cc3f9814b9df16700119337c5
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315143
> Reviewed-by: Åsa Persson <asapersson@webrtc.org>
> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#40529}

Bug: None
Change-Id: I8c83013523120a84f236e8efa0d122363e7a228b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315381
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40535}
2023-08-10 14:18:52 +00:00
Mirko Bonadei
da705cea9b Fix reclient download hook in DEPS.
Follow-up of https://chromium-review.googlesource.com/c/chromium/src/+/4717550.

Bug: None
Change-Id: Iff721366a1cf5f5e24b4c0f686e9b85e3dc9aff7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315322
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40534}
2023-08-10 12:19:30 +00:00
Danil Chapovalov
490f0b82d7 Cleanup usage of csrcs in RtpSenderVideoFrameTransform
CSRCs are decided on a per frame bases, thus keeping a constant copy of
csrcs inside the rtp sender transform delegate is confusing: when transform delegate is created, csrcs list is always empty.

Bug: None
Change-Id: Id94acc76857a47ad9a1dd8254648ab9cb5d6d31d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/311840
Reviewed-by: Tony Herre <herre@google.com>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40533}
2023-08-10 10:30:29 +00:00
Björn Terelius
51f6a20d1d Roll chromium_revision 6b95b8aa08..80c35b98ae (1175249:1180373)
Manually
 - update the path to libc++, libunwind, and android_toolchain
 - update paths to licence files
 - add missing arg `use_perfetto_trace_processor`
 - use C++20 for android compilation (due to dependency on //base from the JNI generator)
 - only test on Android sdk version (21) due to non-hermetic test `TCPChannelClientTest`

Change log: 6b95b8aa08..80c35b98ae
Full diff: 6b95b8aa08..80c35b98ae

Changed dependencies
* fuchsia_version: version:13.20230714.0.1..version:14.20230804.1.1
* reclient_version: re_client_version:0.110.0.43ec6b1-gomaip..re_client_version:0.111.0.1ccaa23-gomaip
* src/base: dcfe245ca1..4845bf859d
* src/build: b74cdc4550..c14d86f2ac
* src/buildtools: 16be42a9ff..a9a6f0c49d
* src/buildtools/linux64: git_revision:fae280eabe5d31accc53100137459ece19a7a295..git_revision:811d332bd90551342c5cbd39e133aa276022d7f8
* src/buildtools/mac: git_revision:fae280eabe5d31accc53100137459ece19a7a295..git_revision:811d332bd90551342c5cbd39e133aa276022d7f8
* src/buildtools/reclient: re_client_version:0.110.0.43ec6b1-gomaip..re_client_version:0.111.0.1ccaa23-gomaip
* src/buildtools/win: git_revision:fae280eabe5d31accc53100137459ece19a7a295..git_revision:811d332bd90551342c5cbd39e133aa276022d7f8
* src/ios: 51a637843f..af5e59ca5c
* src/testing: b946312a89..43317e989d
* src/third_party: 93b5f4c408..3b06b3cc29
* src/third_party/android_build_tools/manifest_merger: 8fr-1Vf_pfxN9ulzWVaZvIXggDgWDs-0dtlGA1Sue48C..d1tFnzOW6H5xoDN7WWsMuAiHuhkl0kXijQGiO7IU1VQC
* src/third_party/androidx: y7rF_rx56mD3FGhMiqnlbQ6HOqHJ95xUFNX1m-_a988C..fKq4SHYaZsLkQtDQsKxkn2xysI5m1pLftMfADDOXsywC
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/b98ce18c5b..e4acd6cb56
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/84e3795d98..220cbb13b5
* src/third_party/clang-format/script: f97059df7f..e5337933f2
* src/third_party/depot_tools: 54e86436a8..6d0c235dae
* src/third_party/ffmpeg: 881c5c3f64..0ba3773340
* src/third_party/fontconfig/src: 06929a556f..2fb3419a92
* src/third_party/freetype/src: 9e3c5d7e18..3829fdaae5
* src/third_party/icu: e8c3bc9ea9..de4ce0071e
* src/third_party/jdk: IivIDwNBf73mf7UwCOBceRUuDdtizMCgSOQDfUGHArsC..GCFtf5t6M4HlrHj6NXedHbpHp2xjgognF8ptNci4478C
* src/third_party/libaom/source/libaom: https://aomedia.googlesource.com/aom.git/+log/af2b02ce05..92fb72a64e
* src/third_party/libunwind/src: 6c0013015b..b113f23e4c
* src/third_party/libvpx/source/libvpx: 9ad950a9c4..e1c124f896
* src/third_party/perfetto: ab16995d92..446adf5b7b
* src/third_party/r8: O1BBWiBTIeNUcraX8STMtQXVaCleu6SJJjWCcnfhPLkC..dbml4pnGIsEBy3dFYki-S8IYt4jxxqZXaUDwtY3Q-SgC
* src/third_party/turbine: 2I2Nz480QsuCxpQ1lMfbigX8l5HAhX3_ykWU4TKRGo4C..HFp7iOu-n4-CdEasFTQZvD1Vg1L-q1URqRTOM-iZ2AMC
* src/tools: 4057b98943..e3244f7e27
* src/tools/luci-go: git_revision:f02582af78f530a7bbfe2f059fa5d211c9517756..git_revision:e608c1f557fceae8eb6cf35ae2ad6f4908e35245
* src/tools/luci-go: git_revision:f02582af78f530a7bbfe2f059fa5d211c9517756..git_revision:e608c1f557fceae8eb6cf35ae2ad6f4908e35245
DEPS diff: 6b95b8aa08..80c35b98ae/DEPS

No update to Clang.

BUG=b/295113672, b/294976628

Change-Id: I1ce70f570843bc98c480abba7babfa34c1e869e0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315181
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40532}
2023-08-10 07:50:10 +00:00
Björn Terelius
d3844565c4 Change FakeEncoder::kImplementationName from const char* to constexpr char*
Bug: b/295113672
Change-Id: I33f447c907e807bd45a4379e39fc051625afd851
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315260
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40531}
2023-08-09 17:37:00 +00:00
Palak Agarwal
86162d94d5 Implement setMetadata for receiver encoded video frames
This change adds a new function to RTPFrameObject to allow setting the
RTPVideoHeader from VideoFrameMetadata.

The setMetadata function in TransformableVideoReceiverFrame disallows
changing anything other than frameID and dependencies.

Change-Id: I74e55ffbe1f426b660c2e243b20358c6a6cc2ffd
Bug: chromium:1464853
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/314963
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Palak Agarwal <agpalak@google.com>
Reviewed-by: Tony Herre <herre@google.com>
Cr-Commit-Position: refs/heads/main@{#40530}
2023-08-09 10:01:58 +00:00
Danil Chapovalov
762f193ca4 Cleanup calculating time between RTCP reports
Move that calculation into dedicated function, move comment why it is calculated the way it is into the same function.
Cleanup that comment - remove parts unused by current code, in particular remove description of code that was deleted a while ago
Use more strict types for the calculation to make it clearer.
Replace DCHECK result can't be zero with a clamp to ensure it can't be zero, because with large bitrates it may.

Bug: None
Change-Id: Ie8c6b9720095cd1cc3f9814b9df16700119337c5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315143
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40529}
2023-08-09 09:14:41 +00:00
Philipp Hancke
240e783d7f Stop using invalid payload type 200 in audio/red unit test
and fix the follow-up mistake in the test

BUG=None

Change-Id: Id7a20769cc1d03dd8154564f948e8138ff8c4e74
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315220
Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org>
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40528}
2023-08-09 08:13:52 +00:00
webrtc-version-updater
63dc56cff0 Update WebRTC code version (2023-08-09T04:14:38).
Bug: None
Change-Id: I89a37f08b61c2da90ed10b9a2d21feb19df4e537
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315240
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40527}
2023-08-09 05:59:27 +00:00
Sergey Silkin
8efd93dd76 Encoder type agnostic resolution based fallback
WebRTC-Video-EncoderFallbackSettings/resolution_threshold_px:X sets resolution threshold to switch from primary to fallback encoder. When the field trial is present, VP8-specific resolution based fallback settings, provided by WebRTC-VP8-Forced-Fallback-Encoder-v2, are ignored.

Bug: none
Change-Id: I8f2e28438547f3896c7fc288ed6634720328f3a0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/314760
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40526}
2023-08-08 14:18:31 +00:00
Danil Chapovalov
277fb3cd0e Cleanup RtpSender unittest to use Timestamp instead of plain int
Bug: webrtc:13757
Change-Id: I0893805a8e4bc66c0c6cff232576387c2ee60b8b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315182
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Åsa Persson <asapersson@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40525}
2023-08-08 14:07:45 +00:00
Philipp Hancke
82e5f91a2b audio: fix handling of RED packets where the primary encoding is too large
by falling back to the primary encoding. This can happen with
opus stereo packets at the maximum bitrate which results in
1276 encoded bytes.

BUG=chromium:1470261

Change-Id: I3fd9bb30773963a519bbb5da44fe71db5dec2bd7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315141
Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40524}
2023-08-08 13:40:26 +00:00
Philipp Hancke
7bd90baca8 Remove templating from RtpTransceiver
as part of the overall motion to remove subtypes of cricket::Codec.
Also update surrounding code to use LOG_AND_RETURN_ERROR.

BUG=webrtc:15214

Change-Id: I7e4a416be662e2e10e351e11d20442ce562d7428
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315080
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40523}
2023-08-08 12:09:28 +00:00
webrtc-version-updater
c479e46618 Update WebRTC code version (2023-08-08T04:02:52).
Bug: None
Change-Id: Id31d7cfb54c95986ae1cd156b80d4033b4e579b0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/315200
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#40522}
2023-08-08 05:26:14 +00:00