Commit graph

58 commits

Author SHA1 Message Date
Christoffer Dewerin
36ecffa129 Revert "Temporary disable sharding on Fuchsia bots."
This reverts commit 5dbc4a45bc.

Reason for revert: Sharding should now work on fuchsia + no new generated starlark files have been uploaded since.

Original change's description:
> Temporary disable sharding on Fuchsia bots.
>
> Change-Id: I248ef19317de9a93751641e8bf0cab80a42a35f7
> Bug: b/338087169
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349840
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#42230}

Bug: b/338087169
Change-Id: I25f29a64a4a2ca40afb0ac9fbbc2a821c3ca4551
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350182
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#42282}
2024-05-13 08:53:13 +00:00
Jeremy Leconte
042973f624 Regenerate infra/specs json files.
* ios_runtime_cache_15_5 has been removed from Chromium config, adding it back in mixins_webrtc.pyl.
* The order of the arguments in the json file has been changed.
* Seems using 'remove_mixins' is now required to get the same behavior as before.

Change-Id: Ia252aaa6458f8c9caed5ead3b641bb85cd1917e8
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350362
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Christoffer Dewerin <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42279}
2024-05-13 07:22:45 +00:00
Jeremy Leconte
5dbc4a45bc Temporary disable sharding on Fuchsia bots.
Change-Id: I248ef19317de9a93751641e8bf0cab80a42a35f7
Bug: b/338087169
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349840
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42230}
2024-05-06 07:45:58 +00:00
Jeremy Leconte
8bfc3e99a6 Fix variant name for iOS simulator 17.4.
Change-Id: I66b00b360d8eace858046d73f40c7eac57375e7d
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/339843
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#41753}
2024-02-16 11:01:54 +00:00
Jeremy Leconte
199fd755bd Run video_codec_perf_tests using the quick mode on Android try bots.
Change-Id: I02678b033815f843e4aee1585ef64c4d9b7e7b14
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334220
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#41535}
2024-01-16 10:07:48 +00:00
Jeremy Leconte
293af4b5e0 Upgrade iOS simulator configuration.
Change-Id: I458417c94659188f26feac6237d066acce5ac3dd
Bug: b/319049739
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/333780
Commit-Queue: Jeremy Leconte <jleconte@webrtc.org>
Reviewed-by: Christoffer Dewerin <jansson@google.com>
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41473}
2024-01-08 11:00:27 +00:00
Mirko Bonadei
b875b8b98b Rename xcode_parallelization to xcodebuild_sim_runner.
Bug: b/315770061
Change-Id: I7910a2885130655c8e81131537019137c0e61463
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/330960
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41352}
2023-12-11 14:00:26 +00:00
Christoffer Jansson
dfb54b5747 Remove video_capture_tests
Bug: b/312914606
Change-Id: I449647ba0158d947a6cff401139cf92ec05b23b4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/330562
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Christoffer Dewerin <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#41349}
2023-12-11 10:35:44 +00:00
Christoffer Jansson
d63cd63819 Use 8 shards for svc tests on android
Bug: webrtc:15538
Change-Id: Ib794bd6e0c8b43636da47bd662cf47ba40bd7576
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322701
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Auto-Submit: Christoffer Jansson <jansson@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#40890}
2023-10-09 09:55:49 +00:00
Mirko Bonadei
b01cd19fd7 Switch svc_tests from using Pixel 2 to Pixel 3a.
Bug: webrtc:15538
Change-Id: I4c7dbd0bccf25f3d90b006c71b96bf7aa7fd8c68
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/322600
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40880}
2023-10-06 10:34:33 +00:00
Jeremy Leconte
283c3df2ac Fix TCPChannelClientTest.java when running on multiple shards.
Change-Id: I57947d5801cc9545939a9d38d546424829583a07
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/311240
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#40391}
2023-07-03 13:28:59 +00:00
Florent Castelli
d797cb6ca7 Remove all split channels related code
Bug: webrtc:13931
Change-Id: I93b8ca0ba1ec15bf260236bbc914b41fbb30aa58
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/310680
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40376}
2023-06-29 09:32:04 +00:00
Jeremy Leconte
b15a9f01fc Fix perf tests.
Turns out it's not possible to run the same perf tests on all os:
--save_worst_frame doesn't work on Fuchsia bots:
https://chromium-swarm.appspot.com/task?id=6294b51713605710
video_codec perf tests fail on iOS:
https://chrome-swarming.appspot.com/task?id=629455defc12bc10

Change-Id: I5cd490f5728b6046615ba217c65fd2b125a9e4a7
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/307480
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#40209}
2023-06-02 13:03:20 +00:00
Jeremy Leconte
b29ee5bc8f Run the same perf tests on all platforms.
Change-Id: I49ac9921d92e3ff81569b162c64c96559565ae62
Bug: b/284448060
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/307021
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#40204}
2023-06-02 08:35:00 +00:00
Jeremy Leconte
b18463409b Run webrtc_perf_tests on Fuchsia os.
Currently a specific target is running on Fuchsia which is a copy paste of webrtc_perf_tests.

Change-Id: Ib1fd5dc898f50c43f2bcd45e73c278d3547ce813
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/306963
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#40176}
2023-05-30 09:56:44 +00:00
Jeremy Leconte
2bb686dbc0 Stop running low_bandwith_audio_tests.
Change-Id: I55fff58d35787d0ff332fa750749c75d9f6a9b70
Bug: b/284448060
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/306740
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40159}
2023-05-26 14:51:41 +00:00
Sergey Silkin
0328190ab3 Add video_codec_perf_tests to desktop and android perf test suites
Followed instructions in https://webrtc.googlesource.com/src/+/refs/heads/main/g3doc/add-new-test-binary.md

Bug: webrtc:14852
Change-Id: I4cdc7d55270de7b24723a89b8e3bb0d392d0e788
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/305600
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40118}
2023-05-23 12:13:29 +00:00
Mirko Bonadei
2f7071a57a Add webrtc_nonparallel_tests to Fuchsia bots.
Bug: None
Change-Id: Icdb18969dda11a045232bea0f8eaa476bb474f69
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/297720
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39562}
2023-03-15 08:44:59 +00:00
Harald Alvestrand
ff16f5f88e Add a new test binary to check if split-channel works
This test (and binary) will be used to verify that the field trial
for enabling split-MediaChannel works in both "off" and "on" modes,
so that it can be run as a field trial. It is intended to be deleted
once the conversion to split-MediaChannel is complete.

Bug: webrtc:13931
Change-Id: If62d19be9b2f205067b86dc859946279442fdd58
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/296322
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Emil Lundmark <lndmrk@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#39493}
2023-03-07 11:14:31 +00:00
Christoffer Jansson
0c1c9720d8 Fix gtest-output and resultdb for fuchsia
Bug: b/232740856
Change-Id: I37b5a10d3292aca0b4dca98cb04613db17bb6188
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291115
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#39195}
2023-01-25 14:27:38 +00:00
Christoffer Jansson
73918995a4 Add Fuchsia perf output and fix upload
Bug: b/263477303
Change-Id: Ifabfd1c015788e944d1b78ba2a0454c29426c5e3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290993
Commit-Queue: Christoffer Jansson <jansson@google.com>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#39140}
2023-01-18 14:10:56 +00:00
Jeremy Leconte
83fd843535 Add a ios_x64_dbg_simulator try bot.
The goal of this bot is to replace ios_sim_x64_dbg_ios(12, 13 and 14).

Change-Id: I6d8f5004a9440f5fd8cb96730dc2dbb4abba2e61
Bug: b/264630045
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290893
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39086}
2023-01-12 14:07:37 +00:00
Jeremy Leconte
6419537b3b [iOS sim] Run modules_unittests on 12 cores.
Change-Id: If85ff709a55920cc914213edad5ed63826f6c5f3
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/287121
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38849}
2022-12-08 13:43:23 +00:00
Jeremy Leconte
d0eaa54104 Reland "Add working Perf tests for Fuchsia"
This is a reland of commit d8d86bd332

Original change's description:
> Add working Perf tests for Fuchsia
>
> Utilize VM in perf pool for Fuchsia (separate CL)
>
> Bug: b/232740856
> Change-Id: Ia69f72bbf2046db3bc9b1e5edabda6cc4a339fe6
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285721
> Reviewed-by: Jeremy Leconte <jleconte@google.com>
> Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#38787}

Bug: b/232740856
Change-Id: I3ae8b17990157bde4a08fd8a98379cffd2c38148
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285881
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38802}
2022-12-02 20:35:28 +00:00
Jeremy Leconte
cb885923d8 Revert "Add working Perf tests for Fuchsia"
This reverts commit d8d86bd332.

Reason for revert: Seems this causes an issue with the dimensions ?
  File "/b/s/w/ir/kitchen-checkout/recipe_engine/recipe_modules/swarming/api.py", line 463, in with_dimensions
    assert isinstance(k, basestring) and (isinstance(v, basestring)

Original change's description:
> Add working Perf tests for Fuchsia
>
> Utilize VM in perf pool for Fuchsia (separate CL)
>
> Bug: b/232740856
> Change-Id: Ia69f72bbf2046db3bc9b1e5edabda6cc4a339fe6
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285721
> Reviewed-by: Jeremy Leconte <jleconte@google.com>
> Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#38787}

Bug: b/232740856
Change-Id: Ibedff26cfe38fae0eb36158d5cd9f2bdfded319f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285800
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Auto-Submit: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Jeremy Leconte <jleconte@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38790}
2022-12-01 17:06:20 +00:00
Christoffer Jansson
d8d86bd332 Add working Perf tests for Fuchsia
Utilize VM in perf pool for Fuchsia (separate CL)

Bug: b/232740856
Change-Id: Ia69f72bbf2046db3bc9b1e5edabda6cc4a339fe6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285721
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38787}
2022-12-01 14:02:47 +00:00
Jeremy Leconte
370ca9c52c Enable sharding for fuchsia bots.
* Add '--quick' argument to 'low_bandwidth_audio_test' even though it doesn't look like it makes much timing difference.
* Add sharding for 'svc_tests' and 'video_engine_tests'.

Change-Id: I6e3357954d18ad03ea9f62912dd77e0e1a74b97d
Bug: webrtc:14713
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285100
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38748}
2022-11-28 19:39:08 +00:00
Christoffer Jansson
569af3e80f [Fuchsia] - Add more tests that pass locally
Create bugs and add comments for failures.

Bug: b/232740856
Change-Id: Ic81477de73c3e848569dbd0c63c1a44542b90821
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285081
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#38744}
2022-11-28 09:16:51 +00:00
Christoffer Jansson
f1fa7058b6 Add Fuchsia mixin, disable unsupported absl calls for fuchsia
Add a few tests to get started on debugging.

The goal of this CL is to get the Fuchsia bots running the tests without infra specific issues. After landing this, failures will be in test framework files (e.g. test/testsupport folder) and WebRTC code.

Bug: b/232740856
Change-Id: I332607fe875334769e7dadf6696d878a23a7e69f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/280440
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Reviewed-by: Andrey Logvin <landrey@google.com>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38596}
2022-11-09 16:36:05 +00:00
Jeremy Leconte
d957836794 Use gtest_parallel for PipeWire tests.
This CL will also make PipeWire tests retried 3 times in case of failures.

Change-Id: I9c66351f7ee171e29266fe4b8dcd52ca282c8f6d
Bug: webrtc:14644
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282820
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38595}
2022-11-09 15:37:58 +00:00
Jeremy Leconte
bbd5fbf4f5 [iOS] Run SVC tests on 12 cores machines
Change-Id: I8e8bda835504ac1440c7d65bfc62ecbb619fce54
Bug: None
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/281161
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Auto-Submit: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38504}
2022-10-31 11:12:21 +00:00
Jan Grulich
1264dc165b PipeWire capturer: add initial test for SharedScreenCastStream
This test created another PipeWire stream we can connect to with
SharedScreenCastStream and recieve frames from there. This is an
initial version, where I test whether we can successfuly connect
and disconnect, receive frames and it also tests DesktopFrameQueue.

In the future I will add tests to test mouse cursor and try to
come up with some corner cases and possible scenarios.

Bug: webrtc:13429
Change-Id: Ib2a749207085c6324ffe3d5cc8f2f9c631fa6459
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256267
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Reviewed-by: Mark Foltz <mfoltz@chromium.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Jan Grulich <grulja@gmail.com>
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38431}
2022-10-18 13:10:53 +00:00
Jeremy Leconte
1ab4e873e4 Run svc_tests on 4 shards.
The tests are sometimes hiting timeouts on msan runs:
https://chromium-swarm.appspot.com/task?id=5d02a893ec864210

Change-Id: I16f15f3ab5750bdcc37a1cd1e32846adb2fb7602
Bug: webrtc:11607
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273343
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#37935}
2022-08-29 20:24:04 +00:00
Jeremy Leconte
5414cce0a1 Migrate iOS and Mac tests from mac-11 to mac-12 machines
Also remove unused mixins.

Bug: b/233192409
Change-Id: I959916b98cebd417088fb7804dc1f44f64134555
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/272241
Reviewed-by: Christoffer Jansson <jansson@google.com>
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37826}
2022-08-18 14:41:56 +00:00
Austin Orion
81797744fd Reland "Wait for frames to arrive in WgcCapturer instead of returning nothing."
This reverts commit dd32562f24.

Reason for revert: Updated the original change to dynamically load
the CoreMessaging.dll instead of statically linking with the .lib.

Original change's description:
> Revert "Wait for frames to arrive in WgcCapturer instead of returning nothing."
>
> This reverts commit 93bb305149.
>
> Reason for revert: It breaks a test while rolling into Chromium,
> see https://webrtc-review.googlesource.com/c/src/+/261780/21#message-4a96e33bfb475f19a618be82bbe72951b23085ef for details.
>
> Original change's description:
> > Wait for frames to arrive in WgcCapturer instead of returning nothing.
> >
> > We're seeing a high instance of "first capture failed" in Chromium when
> > using WGC. We can reduce this by waiting for frames to arrive if there
> > are none in the frame pool instead of returning a temporary error.
> >
> > I've set the maximum time to wait for a frame to 50ms. If no frame
> > arrives before 50ms has elapsed, we will return a temporary error.
> > Added a new test, FirstCaptureSucceeds, to verify that this is working
> > as expected.
> >
> > As part of this I updated the name of the `kCreateFreeThreadedFailed`
> > enum value to `kCreateFramePoolFailed`. The value remains the same
> > since they both report failures in frame pool creation.
> >
> > I also increased `kNumBuffers` from 1 to 2, so that the frame pool can
> > store two frames. This should prevent us from having to wait on the
> > event as frequently. This will increase the latency between capture
> > and display, however. High frame rate applications should not be
> > noticeably affected.
> >
> > Additionally, we uncovered a bug in the OS that prevents window capture
> > when there are displays attached, but none of them are active. Added
> > a new check to `IsWgcSupported` to cover this scenario.
> >
> > Finally, some issues with other WGC tests blocked moving the TryBots
> > to a newer version of Windows. This CL fixes those issues and updates
> > the TryBot configuration.
> >
> > bug: chromium:1314868
> > Change-Id: Id9c4d5ee98621e682ef04864c3848d50e761cdb7
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261780
> > Reviewed-by: Alexander Cooper <alcooper@chromium.org>
> > Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
> > Commit-Queue: Austin Orion <auorion@microsoft.com>
> > Reviewed-by: Jeremy Leconte <jleconte@google.com>
> > Cr-Commit-Position: refs/heads/main@{#37404}
>
> Change-Id: If237df4826fe20b6fe2ca4b57253623321bf33c5
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267460
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#37408}

Change-Id: I6cc2becd9ed363782ab2f326f58d9401bc8fb820
Bug: chromium:1314868
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267902
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Austin Orion <auorion@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#37470}
2022-07-06 20:28:26 +00:00
Mirko Bonadei
dd32562f24 Revert "Wait for frames to arrive in WgcCapturer instead of returning nothing."
This reverts commit 93bb305149.

Reason for revert: It breaks a test while rolling into Chromium,
see https://webrtc-review.googlesource.com/c/src/+/261780/21#message-4a96e33bfb475f19a618be82bbe72951b23085ef for details.

Original change's description:
> Wait for frames to arrive in WgcCapturer instead of returning nothing.
>
> We're seeing a high instance of "first capture failed" in Chromium when
> using WGC. We can reduce this by waiting for frames to arrive if there
> are none in the frame pool instead of returning a temporary error.
>
> I've set the maximum time to wait for a frame to 50ms. If no frame
> arrives before 50ms has elapsed, we will return a temporary error.
> Added a new test, FirstCaptureSucceeds, to verify that this is working
> as expected.
>
> As part of this I updated the name of the `kCreateFreeThreadedFailed`
> enum value to `kCreateFramePoolFailed`. The value remains the same
> since they both report failures in frame pool creation.
>
> I also increased `kNumBuffers` from 1 to 2, so that the frame pool can
> store two frames. This should prevent us from having to wait on the
> event as frequently. This will increase the latency between capture
> and display, however. High frame rate applications should not be
> noticeably affected.
>
> Additionally, we uncovered a bug in the OS that prevents window capture
> when there are displays attached, but none of them are active. Added
> a new check to `IsWgcSupported` to cover this scenario.
>
> Finally, some issues with other WGC tests blocked moving the TryBots
> to a newer version of Windows. This CL fixes those issues and updates
> the TryBot configuration.
>
> bug: chromium:1314868
> Change-Id: Id9c4d5ee98621e682ef04864c3848d50e761cdb7
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261780
> Reviewed-by: Alexander Cooper <alcooper@chromium.org>
> Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
> Commit-Queue: Austin Orion <auorion@microsoft.com>
> Reviewed-by: Jeremy Leconte <jleconte@google.com>
> Cr-Commit-Position: refs/heads/main@{#37404}

Change-Id: If237df4826fe20b6fe2ca4b57253623321bf33c5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267460
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37408}
2022-07-02 07:41:21 +00:00
Austin Orion
93bb305149 Wait for frames to arrive in WgcCapturer instead of returning nothing.
We're seeing a high instance of "first capture failed" in Chromium when
using WGC. We can reduce this by waiting for frames to arrive if there
are none in the frame pool instead of returning a temporary error.

I've set the maximum time to wait for a frame to 50ms. If no frame
arrives before 50ms has elapsed, we will return a temporary error.
Added a new test, FirstCaptureSucceeds, to verify that this is working
as expected.

As part of this I updated the name of the `kCreateFreeThreadedFailed`
enum value to `kCreateFramePoolFailed`. The value remains the same
since they both report failures in frame pool creation.

I also increased `kNumBuffers` from 1 to 2, so that the frame pool can
store two frames. This should prevent us from having to wait on the
event as frequently. This will increase the latency between capture
and display, however. High frame rate applications should not be
noticeably affected.

Additionally, we uncovered a bug in the OS that prevents window capture
when there are displays attached, but none of them are active. Added
a new check to `IsWgcSupported` to cover this scenario.

Finally, some issues with other WGC tests blocked moving the TryBots
to a newer version of Windows. This CL fixes those issues and updates
the TryBot configuration.

bug: chromium:1314868
Change-Id: Id9c4d5ee98621e682ef04864c3848d50e761cdb7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261780
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Commit-Queue: Austin Orion <auorion@microsoft.com>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#37404}
2022-07-01 17:42:20 +00:00
Florent Castelli
90b74389a2 SVC: Add end to end tests for VP8 and VP9
The tests check that the various scalability mode are supported
and the frames are marked properly by the encoder with their
spatial and temporal index.
The same information is then checked on the receiving side.

A new member is added on EncodedImage to store the temporal index,
and is filled by the encoders and retreived by the ref finder
objects on the decoding side.

Bug: webrtc:11607
Change-Id: I7522f6a6fc5402244cab0c4c64b544ce09bc5204
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260189
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37303}
2022-06-22 11:07:01 +00:00
Jeremy Leconte
72b5dbc44b Don't run quick perf tests on baremetal machines.
Baremetal machines have webcams and it makes it confusing wether webrtc_perf_tests require cameras to run.

Change-Id: I1f3dc05c976ed008079f990b9a55f3310ea73dda
Bug: b/235780120
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265641
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#37189}
2022-06-13 08:55:57 +00:00
Christoffer Jansson
5ca01b5a5b Use ios_perf_test for M1 arm64 perf tester
Bug: b/232347569
Change-Id: I16fa752ee81d3a331ce2c2d4fe2f4bd9b28a5597
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/263481
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36987}
2022-05-24 14:59:12 +00:00
Jeremy Leconte
fb9ae767aa Reland "Run iOS tests on multiple shards."
This is a reland of commit 5a71f15858

Original change's description:
> Run iOS tests on multiple shards.
>
> Bug: b/230824012
> Change-Id: I6d27a8ed2c07eb76972b3bbe3679f6346ba58e06
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261306
> Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
> Commit-Queue: Jeremy Leconte <jleconte@google.com>
> Cr-Commit-Position: refs/heads/main@{#36796}

Bug: b/230824012
Change-Id: I4a8627e87a6f22953238a28a714af3a97de065b9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261724
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36883}
2022-05-13 13:49:44 +00:00
Jeremy Leconte
58d774ba78 Revert "Run iOS tests on multiple shards."
This reverts commit 5a71f15858.

Reason for revert: Turns out all the tests are running on all the shards.

Original change's description:
> Run iOS tests on multiple shards.
>
> Bug: b/230824012
> Change-Id: I6d27a8ed2c07eb76972b3bbe3679f6346ba58e06
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261306
> Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
> Commit-Queue: Jeremy Leconte <jleconte@google.com>
> Cr-Commit-Position: refs/heads/main@{#36796}

Bug: b/230824012
Change-Id: Id353501f07156ccc109abf94e6d2a22014a5e767
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261562
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36807}
2022-05-09 07:40:54 +00:00
Jeremy Leconte
5a71f15858 Run iOS tests on multiple shards.
Bug: b/230824012
Change-Id: I6d27a8ed2c07eb76972b3bbe3679f6346ba58e06
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261306
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36796}
2022-05-06 09:55:41 +00:00
Jeremy Leconte
95897aea2f Run peerconnection_unittests on multiple shards.
The shards were removed with https://webrtc-review.googlesource.com/c/src/+/261262 as an experiment.

It turns out the new test target slow_peer_connection_unittests doesn't take much time compared to peerconnection_unittests.
slow_peer_connection_unittests: 7min
peerconnection_unittests: 35min
https://chromium-swarm.appspot.com/tasklist?f=parent_task_id-tag%3A5aad344b2285be11&st=1651756987488

Bug: webrtc:14025
Change-Id: Iaaf2b476ea6fdc419c5b14beb8040c5a0d973952
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261264
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36785}
2022-05-05 15:10:29 +00:00
Harald Alvestrand
f8f7b70050 Create a "slow peerconnection unittests" target
This CL moves all tests that take more than 5 seconds into the new target.

Bug: webrtc:14025
Change-Id: I760d1a270b399b581f41606647740466f6b87e7c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261262
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36782}
2022-05-05 14:40:38 +00:00
Jeremy Leconte
2dad0a1668 Re-enable XCTests sdk_unittests on simulators.
Bug: webrtc:12244
Change-Id: Id5cd44e93cd0221e09380d05da510b05c22e143f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259773
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36699}
2022-04-28 19:58:31 +00:00
Jeremy Leconte
72efd91d1f Re-enable XCTests apprtcmobile_tests on simulators.
Bug: webrtc:12244
Change-Id: Idca6bcc1505b0b9ceadfafbe128d64d53800f34a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260280
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36684}
2022-04-28 08:31:03 +00:00
Jeremy Leconte
424cc65a4a Centralized test command argument in .pyl configuration.
* Remove args from gn_isolate_map.pyl
* Set idempotent to false for performance tests

Bug: webrtc:13899
Change-Id: Icde80af02070e024c1292721db9c0b8a4d906343
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258685
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36531}
2022-04-12 10:43:05 +00:00
Jeremy Leconte
dad78f8cff Move the readline-timeout to the iOS device instead of simulator.
Also increase the timeout over 10 minutes and increase the bot timeout.
https://chrome-swarming.appspot.com/task?id=5a2118b0119c3b10

Bug: b/228402401
Change-Id: Idf652fd7fa2fc6670011df254836444dfaf553a8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258420
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36508}
2022-04-08 20:50:25 +00:00
Jeremy Leconte
bf11a202de Add the 'more configs' and the 'libfuzzer' bots to waterfalls.pyl.
Bug: webrtc:13899
Change-Id: I453d228fc250bf5f6ac1313c9c30f15bec36a191
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258130
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36472}
2022-04-07 07:17:43 +00:00