Remove custom android warning suppression file because looks like it
is not used anymore.
Bug: None
Change-Id: I09f8936a5e82e42f3d0c1e21f20ff4812ce1b8ae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180582
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31811}
This is a reland of 8df59bc74e
Relanding as is for testing.
Original change's description:
> Test luci.notifier.
>
> This CL will be reverted as soon as we verify that the fix applied in
> https://webrtc-review.googlesource.com/c/src/+/179062 works.
>
> Bug: None
> Change-Id: I1ef48f8e69d5592154b154de1700858aea4c32c4
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179063
> Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31703}
TBR=jleconte@webrtc.org
No-Try: True
Bug: None
Change-Id: Ib83eeb57d41f20cdfd54271f59d22f932e3b96b3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179086
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31707}
This reverts commit 8df59bc74e.
Reason for revert: Let's turn the bot green and the try to turn it
read again since the notification comes only on status change.
Original change's description:
> Test luci.notifier.
>
> This CL will be reverted as soon as we verify that the fix applied in
> https://webrtc-review.googlesource.com/c/src/+/179062 works.
>
> Bug: None
> Change-Id: I1ef48f8e69d5592154b154de1700858aea4c32c4
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179063
> Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31703}
TBR=mbonadei@webrtc.org,jleconte@webrtc.org
Change-Id: I91e6debfbcb18bc840ca02a91ff736724ea9bbd1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179085
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31706}
The K Nexus 5 bot has been upgraded to Android M, this CL fixes the
following error:
MBErr: Builder name "Perf Android32 (M Nexus5)" not found under
masters[client.webrtc.perf]
No-Try: True
Bug: webrtc:11768
Change-Id: Ie45535d622028c4d2dc553205f383b1a920c4ecc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178879
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31678}
This is a reland of bfb6124a73
Reland with no changes, the revert was just a test.
Original change's description:
> Add possibility to expand strings in the autoroller.
>
> Starting from crrev.com/c/2265498, the Chromium DEPS file has a new
> function Str(), which seems to just expand to the string it wraps.
>
> This causes the following error:
>
> NameError: name 'Str' is not defined
>
> In //tools_webrtc/autoroller/roll_deps.py.
>
> This CL adds a way to expand the string.
>
> No-Try: True
> Bug: None
> Change-Id: I4cdb43410edeed72b393f200314c0ee7eea9cb2a
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178865
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31661}
TBR=jleconte@webrtc.org
No-Try: True
Bug: None
Change-Id: I616f7ef2ef68f9a9cb6c5e2ca332d860a750b239
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178900
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31677}
This reverts commit bfb6124a73.
Reason for revert: Testing Autoroller notifications. I will reland this later.
Original change's description:
> Add possibility to expand strings in the autoroller.
>
> Starting from crrev.com/c/2265498, the Chromium DEPS file has a new
> function Str(), which seems to just expand to the string it wraps.
>
> This causes the following error:
>
> NameError: name 'Str' is not defined
>
> In //tools_webrtc/autoroller/roll_deps.py.
>
> This CL adds a way to expand the string.
>
> No-Try: True
> Bug: None
> Change-Id: I4cdb43410edeed72b393f200314c0ee7eea9cb2a
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178865
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31661}
TBR=mbonadei@webrtc.org,jleconte@webrtc.org
Change-Id: I69f75da132d6b838b96a559712ad4c0da929021c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178877
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31673}
Starting from crrev.com/c/2265498, the Chromium DEPS file has a new
function Str(), which seems to just expand to the string it wraps.
This causes the following error:
NameError: name 'Str' is not defined
In //tools_webrtc/autoroller/roll_deps.py.
This CL adds a way to expand the string.
No-Try: True
Bug: None
Change-Id: I4cdb43410edeed72b393f200314c0ee7eea9cb2a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178865
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31661}
Removes usage of Chromium's //third_party/pymock in favor of the version
provided by vpython. This is so that the third_party version can
eventually be removed.
TBR=aleloi@webrtc.org
Bug: chromium:1094489
Change-Id: I68511e11ed1e517c2b6d3bb832090a3c27e480e5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/177921
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Alex Loiko <aleloi@google.com>
Cr-Commit-Position: refs/heads/master@{#31568}
While working on bugs.webrtc.org/11680 I discovered this which is
unused.
Bug: webrtc:11680
Change-Id: I43d984ee9b8a66ccc360bc24e5e1e105bc8cc049
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/177420
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31539}
WebRTC filenames use underscores to separate words so the ssl roots
file is rtc_base/ssl_roots.h instead of rtc_base/sslroots.h.
Bug: chromium:978779
Change-Id: I2fa11c38a566e177775deb3d42230d956efc8ccc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173800
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31132}
This CL moves the two OOURA implementations present in the WebRTC tree
in one place.
No functional change is expected.
TBR=kwiberg@webrtc.org
No-Try: True
Bug: webrtc:11509
Change-Id: I330a9ec57e3dc65c9c8b43edd4bb295c55920efa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173682
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31106}
Adding gn isolate configs for //:voip_unittests in order to run it on
bots.
Bug: webrtc:11251
Change-Id: I00636cb136db116a3b90a7aad4c55c4e4697534b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172804
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30993}
This CL should fix the following error:
MBErr: target "android_examples_junit_tests" not found in //testing/buildbot/gn_isolate_map.pyl
target "android_sdk_junit_tests" not found in //testing/buildbot/gn_isolate_map.pyl
TBR=phoglund@webrtc.org
No-Try: True
Bug: webrtc:11262
Change-Id: Ib1d05401fc9170fe3025e971a1148c4e4cac9506
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172083
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30930}
This CL should fix the following error:
MBErr: target "apprtcmobile_tests" not found in //testing/buildbot/gn_isolate_map.pyl
target "sdk_unittests" not found in //testing/buildbot/gn_isolate_map.pyl
target "sdk_framework_unittests" not found in //testing/buildbot/gn_isolate_map.pyl
It looks like the MB analyze wrapper around GN requires the targets to be
in the gn_isolate_map.pyl in order to retrieve the target label.
I am not sure the type is correct.
TBR=phoglund@webrtc.org
Bug: webrtc:11262
Change-Id: I28ab5aa3cb3962ef56f1b85dfc367c377aca06cc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172081
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30928}
We need this because there is a current bug in Abseil flags.
Bug: chromium:1051927
Change-Id: I0446fadad709abf4aecda1ff5c0d4f7f6218879e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/171880
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30910}
Unfortunately it turns out the Android test runner requires
the isolated script flag to be in its current form, or it
doesn't work. This means we have to keep translating the
flag name.
We can get rid of the isolated_script_test_output flag
at least.
Tbr: mbonadei@webrtc.org
Bug: chromium:1051927
Change-Id: I4fdbff980e65332b757b1c95aa6587328411c0ed
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/171809
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30907}
Since we're now calling the shots of what flags get passed in the
recipes, we can just pass the right ones right away and remove all
the flag renaming.
--isolated-script-test-output is no longer passed, so we can just
remove it. The recipe is currently passing
--isolated-script-perf-test-output but I will start passing the
underscore version shortly.
Bug: chromium:1051927
Change-Id: I571090e62f79ea17c793295df7f5abb21f45d207
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/171681
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30878}
It's better to set this to the right value in the C++ API rather
than the hack in catapult_uploader.py.
Bug: chromium:1029452
Change-Id: Ia942ff22f8422874cd226e6a7fdce20333ac4a50
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170632
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30817}
The problem that has stopped the uploads from working is likely that
json.dump writes -Infinity when encountering float('-inf'), but not
all JSON parsers handle that. Notably, the dashboard JSON library
doesn't when running in compressing mode.
I think the real fix is to land the float->double CL for the histogram
proto - I think we will not get float('inf') values then. Apply
this hack in the meantime.
Also remove allbins and story hacks, they're likely worse than the
defaults anyway.
Bug: chromium:1029452
Tbr: mbonadei@webrtc.org
Change-Id: I98e36307cc144bbe6878ba9d93c0a609cab71418
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170626
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30808}
To avoid confusion what we're actually uploading. The out file is
for debugging.
Bug: chromium:1029452
Change-Id: I6856a8466b58bb4b8d2eac35df7c629af7002b2c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170441
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30791}
We need to modify sys.path before we import anything from catapult.
Unfortunately we need to modify it according to --outdir, so it needs
to happen at runtime rather than import time.
I try to split the script into a main which just sets up command line
args and sys.path and then imports the main script. This makes it less
likely that future maintainers will import something too early.
Bug: chromium:1029452
Change-Id: I16bf6257269ab8ab90dd74bff7880de8b5fb8071
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170341
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30788}
Let's see if this makes the perf dashboard accept the upload.
The proper fix requires some catapult work + a couple rolls.
Tbr: mbonadei@webrtc.org
Bug: chromium:1029452
Change-Id: I5fb94a08784620a423c4bd7a5bb6dc7f7c05cdc9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170363
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30786}
This partially reverts commit 7427fc6560.
Turns out proto importing is broken on the catapult side. A fix is
coming. Until then I'll have to use the old JSON way.
Bug: chromium:1029452
Change-Id: Ib5c43d721fe6c4e2639a0d518f4fa69b42b6c388
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170230
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30761}
The catapult code has learned how to deserialize protos, so we don't
need JSON as a middle step.
Also, set summary options to false for now to avoid polluting the
dashboard with _avg, _count for each metric. We don't use those
anyway. The durable solution is to set these from the histogram
writer, but catapult doesn't read the summary options correctly
from the proto yet.
Bug: chromium:1029452
Change-Id: I59d300fd34d36df836064ff41f6d0bf75bd6695e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170104
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30737}
I'll hold on to the root OWNER for a bit longer for convenience.
Bug: None
Change-Id: I13303ba726fed612adc74008eeaaeadf9595e084
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170047
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30727}
