After recently changing .pylintrc (see [1]) we discovered that
the presubmit check always checks all the python files when just
one python file gets updated.
This CL moves all these files one step closer to what the linter
wants.
Autogenerated with:
# Added all the files under pylint control to ~/Desktop/to-reformat
cat ~/Desktop/to-reformat | xargs sed -i '1i\\'
git cl format --python --full
This is part 1 out of 2. The second part will fix function names and
will not be automated.
[1] - https://webrtc-review.googlesource.com/c/src/+/186664
No-Presubmit: True
Bug: webrtc:12114
Change-Id: Idfec4d759f209a2090440d0af2413a1ddc01b841
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/190980
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32530}
This is a reland of 8df59bc74e
Relanding as is for testing.
Original change's description:
> Test luci.notifier.
>
> This CL will be reverted as soon as we verify that the fix applied in
> https://webrtc-review.googlesource.com/c/src/+/179062 works.
>
> Bug: None
> Change-Id: I1ef48f8e69d5592154b154de1700858aea4c32c4
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179063
> Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31703}
TBR=jleconte@webrtc.org
No-Try: True
Bug: None
Change-Id: Ib83eeb57d41f20cdfd54271f59d22f932e3b96b3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179086
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31707}
This reverts commit 8df59bc74e.
Reason for revert: Let's turn the bot green and the try to turn it
read again since the notification comes only on status change.
Original change's description:
> Test luci.notifier.
>
> This CL will be reverted as soon as we verify that the fix applied in
> https://webrtc-review.googlesource.com/c/src/+/179062 works.
>
> Bug: None
> Change-Id: I1ef48f8e69d5592154b154de1700858aea4c32c4
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179063
> Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31703}
TBR=mbonadei@webrtc.org,jleconte@webrtc.org
Change-Id: I91e6debfbcb18bc840ca02a91ff736724ea9bbd1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179085
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31706}
This is a reland of bfb6124a73
Reland with no changes, the revert was just a test.
Original change's description:
> Add possibility to expand strings in the autoroller.
>
> Starting from crrev.com/c/2265498, the Chromium DEPS file has a new
> function Str(), which seems to just expand to the string it wraps.
>
> This causes the following error:
>
> NameError: name 'Str' is not defined
>
> In //tools_webrtc/autoroller/roll_deps.py.
>
> This CL adds a way to expand the string.
>
> No-Try: True
> Bug: None
> Change-Id: I4cdb43410edeed72b393f200314c0ee7eea9cb2a
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178865
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31661}
TBR=jleconte@webrtc.org
No-Try: True
Bug: None
Change-Id: I616f7ef2ef68f9a9cb6c5e2ca332d860a750b239
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178900
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31677}
This reverts commit bfb6124a73.
Reason for revert: Testing Autoroller notifications. I will reland this later.
Original change's description:
> Add possibility to expand strings in the autoroller.
>
> Starting from crrev.com/c/2265498, the Chromium DEPS file has a new
> function Str(), which seems to just expand to the string it wraps.
>
> This causes the following error:
>
> NameError: name 'Str' is not defined
>
> In //tools_webrtc/autoroller/roll_deps.py.
>
> This CL adds a way to expand the string.
>
> No-Try: True
> Bug: None
> Change-Id: I4cdb43410edeed72b393f200314c0ee7eea9cb2a
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178865
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31661}
TBR=mbonadei@webrtc.org,jleconte@webrtc.org
Change-Id: I69f75da132d6b838b96a559712ad4c0da929021c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178877
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31673}
Starting from crrev.com/c/2265498, the Chromium DEPS file has a new
function Str(), which seems to just expand to the string it wraps.
This causes the following error:
NameError: name 'Str' is not defined
In //tools_webrtc/autoroller/roll_deps.py.
This CL adds a way to expand the string.
No-Try: True
Bug: None
Change-Id: I4cdb43410edeed72b393f200314c0ee7eea9cb2a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178865
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31661}
When the assertion triggers, manual action is likely needed. This
CL changes the error message to make it more clear.
No-Try: True
Bug: webrtc:11369
Change-Id: I7d8b04deef7638e715b12e6dceeee9cc2ce2cc66
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168761
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30553}
This is done to un-break the roller script, so other deps can be rolled for now.
Example failure: https://ci.chromium.org/p/webrtc/builders/luci.webrtc.cron/Auto-roll%20-%20WebRTC%20DEPS/3040
chromium/buildtools is obsolete, to be replaced with chromium/src/buildtools when the subtree mirror is available.
No-Try: True
Bug: chromium:927867
Change-Id: I340b7d0a79dcb68d9c9e321c2da20476005625f2
Reviewed-on: https://webrtc-review.googlesource.com/c/121701
Commit-Queue: Artem Titarenko <artit@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Artem Titarenko <artit@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26580}
FFmpeg hasn't been rolled since [1] in order to avoid to break MSVC
trybots (//third_party/ffmpeg dropped MSVC support, in theory it is
possible to bring the support back but some work is needed every time
//third_party/ffmpeg gets updated).
Not rolling //third_party/ffmpeg is not enough to keep the Chromium
Roll working because -Wstring-plus-int becomes more chatty with clang 350768
and it has been suppressed in //third_party/ffmpeg/BUILD.gn [2].
Since WebRTC needs to update clang, //third_party/ffmpeg needs to be
updated. The only way to do it without fixing MSVC errors in
//third_party/ffmpeg is to enforce rtc_use_h264=False when MSVC is used.
PSA: https://groups.google.com/forum/#!topic/discuss-webrtc/cfkPPq5nvNE.
[1] - https://webrtc-review.googlesource.com/78402
[2] - https://chromium-review.googlesource.com/c/chromium/third_party/ffmpeg/+/1376376
Bug: webrtc:9213
Change-Id: I36bd7fb2db21012760e4ff7a791d81350e402ec0
Reviewed-on: https://webrtc-review.googlesource.com/c/116982
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26257}
The presubmit lint checks require GN but it is not downloaded because runhooks is avoided on the autoroller bot.
The trybots in Gerrit UI should catch the same errors anyway, if they somehow happen.
Also minor cleanup of obsolete flag
No-Try: True
Bug: chromium:836566
Change-Id: I8bf03b8e155343f723c6fdda37210d9161da984c
Reviewed-on: https://webrtc-review.googlesource.com/c/103620
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24967}
This is to help debug a depot_tools auth problem and can be reverted
once it is solved.
Bug: skia:8394
Change-Id: I3c713fce6c6ba6edbd2498d95938b48a28eff588
Reviewed-on: https://webrtc-review.googlesource.com/101160
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Yves Gerey <yvesg@webrtc.org>
Commit-Queue: Eric Boren <borenet@google.com>
Cr-Commit-Position: refs/heads/master@{#24781}
It's ok for some WebRTC dependencies not to be Chromium dependencies.
Explicitly list them instead of relying of CIDP discrimination.
Bug: chromium:855108
Change-Id: I2dafce488b28409cbce7e0c3167d92f48859084f
Reviewed-on: https://webrtc-review.googlesource.com/101000
Commit-Queue: Yves Gerey <yvesg@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24774}
Until now, only revision changes were automatically rolled.
This CL detect new and removed dependencies in third_party/android_deps.
Change-Id: I4f83b7308be577115cc3ed57edd9881496428173
Bug: chromium:855108
Reviewed-on: https://webrtc-review.googlesource.com/100021
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24773}
This CL removes some assumptions that were making it difficult to
upload a patch from the directory //third_party/webrtc in a
Chromium checkout.
Bug: webrtc:9705
Change-Id: I227ca492d5cf03875474ffd4d31abf387f947e5e
Reviewed-on: https://webrtc-review.googlesource.com/97600
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24549}
Run compile_lite instead, which affords some protection
at least.
Bug: webrtc:9615
Change-Id: I348d535ba2c0dd6cd438be1a90da5b3f64c17c93
Reviewed-on: https://webrtc-review.googlesource.com/93467
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24262}
`gclient setdep` was changed in https://chromium-review.googlesource.com/1123940
to support any prefix as well, but note that that was a backwards incompatible
change, because it now requires the prefix to be passed. So we just stop stripping
the prefix in this CL.
Also clarify the error when a CIPD dep is present in WebRTC and missing in Chromium.
No-Try: True
TBR: phoglund@webrtc.org
Bug: webrtc:9470, chromium:858978
Change-Id: I5e42bbda04db37a628a0ac1de69667b9a30dd793
Reviewed-on: https://webrtc-review.googlesource.com/86280
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23814}
This goes back to using a subtree mirror of Chromium's third_party directory (managed by gclient).
The related scripts for syncing the files are also deleted.
The plan is to solve the conflict by creating third_party directories in subdirectories of WebRTC rather than the repo root.
Bug: webrtc:8366
Change-Id: I0b9f6a86c6d4075e2fa12c2db19aa54682ddb11f
Reviewed-on: https://webrtc-review.googlesource.com/85300
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23757}
After last update in a chromium repo ffmpeg support for MSVC was broken.
So for now we will freeze rolling of ffmpeg and continue it after
we'll restore of MSVC or we'll find a way around to keep MSVC support
in the WebRTC.
Change-Id: Ie7de7e6d367946f3ad77a81d6121dd704a56ca24
Bug: webrtc:9213
Reviewed-on: https://webrtc-review.googlesource.com/78402
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23379}
