After recently changing .pylintrc (see [1]) we discovered that
the presubmit check always checks all the python files when just
one python file gets updated.
This CL moves all these files one step closer to what the linter
wants.
Autogenerated with:
# Added all the files under pylint control to ~/Desktop/to-reformat
cat ~/Desktop/to-reformat | xargs sed -i '1i\\'
git cl format --python --full
This is part 1 out of 2. The second part will fix function names and
will not be automated.
[1] - https://webrtc-review.googlesource.com/c/src/+/186664
No-Presubmit: True
Bug: webrtc:12114
Change-Id: Idfec4d759f209a2090440d0af2413a1ddc01b841
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/190980
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32530}
Removes usage of Chromium's //third_party/pymock in favor of the version
provided by vpython. This is so that the third_party version can
eventually be removed.
TBR=aleloi@webrtc.org
Bug: chromium:1094489
Change-Id: I68511e11ed1e517c2b6d3bb832090a3c27e480e5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/177921
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Alex Loiko <aleloi@google.com>
Cr-Commit-Position: refs/heads/master@{#31568}
This is done to un-break the roller script, so other deps can be rolled for now.
Example failure: https://ci.chromium.org/p/webrtc/builders/luci.webrtc.cron/Auto-roll%20-%20WebRTC%20DEPS/3040
chromium/buildtools is obsolete, to be replaced with chromium/src/buildtools when the subtree mirror is available.
No-Try: True
Bug: chromium:927867
Change-Id: I340b7d0a79dcb68d9c9e321c2da20476005625f2
Reviewed-on: https://webrtc-review.googlesource.com/c/121701
Commit-Queue: Artem Titarenko <artit@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Artem Titarenko <artit@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26580}
Use mock.patch instead of setattr, deemed hackish and less robust.
As an additional benefit, mock is explictly activated and precisely scoped.
Bug: chromium:855108
Change-Id: I3644bb6773a4b95e50aa5b671292e108af1fd2e9
Reviewed-on: https://webrtc-review.googlesource.com/101660
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Yves Gerey <yvesg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24804}
It's ok for some WebRTC dependencies not to be Chromium dependencies.
Explicitly list them instead of relying of CIDP discrimination.
Bug: chromium:855108
Change-Id: I2dafce488b28409cbce7e0c3167d92f48859084f
Reviewed-on: https://webrtc-review.googlesource.com/101000
Commit-Queue: Yves Gerey <yvesg@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24774}
Until now, only revision changes were automatically rolled.
This CL detect new and removed dependencies in third_party/android_deps.
Change-Id: I4f83b7308be577115cc3ed57edd9881496428173
Bug: chromium:855108
Reviewed-on: https://webrtc-review.googlesource.com/100021
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24773}
`gclient setdep` was changed in https://chromium-review.googlesource.com/1123940
to support any prefix as well, but note that that was a backwards incompatible
change, because it now requires the prefix to be passed. So we just stop stripping
the prefix in this CL.
Also clarify the error when a CIPD dep is present in WebRTC and missing in Chromium.
No-Try: True
TBR: phoglund@webrtc.org
Bug: webrtc:9470, chromium:858978
Change-Id: I5e42bbda04db37a628a0ac1de69667b9a30dd793
Reviewed-on: https://webrtc-review.googlesource.com/86280
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23814}
This goes back to using a subtree mirror of Chromium's third_party directory (managed by gclient).
The related scripts for syncing the files are also deleted.
The plan is to solve the conflict by creating third_party directories in subdirectories of WebRTC rather than the repo root.
Bug: webrtc:8366
Change-Id: I0b9f6a86c6d4075e2fa12c2db19aa54682ddb11f
Reviewed-on: https://webrtc-review.googlesource.com/85300
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23757}
Change structure of chromium owned dependencies file to JSON to
simplify work with it in different tools. Also add tool to check in
new chromium owned dep with single command like this:
./tools_webrtc/autoroller/checkin_chromium_dep.py -d <dep name>
Introduce separate file with list of webrtc owned dependencies.
Bug: webrtc:8366
Change-Id: I30a828af34cd105ce7e6bc76d6b5889e6bf7574d
Reviewed-on: https://webrtc-review.googlesource.com/76840
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23270}
For example, --cq-over=100 means that "Roll chromium_revision
(524047:524105)" would not be submitted because the revision
difference is below 100. The CL will still be uploaded and tested.
This will be used in the periodic run of the autoroller to prevent
committing too frequently but keep the test runs at the same rate,
as a rudimentary version of an FYI waterfall of DEPS rolls.
TBR=phoglund@webrtc.org
Bug: webrtc:8688
Change-Id: Ie46e154ddee390648d3d0c0fbb24ec93676bb275
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/36320
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21454}
This broke WebRTC's presubmit
e79ddeaabf%5E%21/
GClientKeywords has been removed and replaced with a more direct substitution.
BUG=None
NOTRY=True
Review-Url: https://codereview.webrtc.org/2989603002
Cr-Commit-Position: refs/heads/master@{#19126}
