3 commits

Author	SHA1	Message	Date
Anders Klemets	a764999e3f	Don't try to load kernel32.dll in RWLockWin class ... The RWLockWin::Create() function returns NULL on some Windows platforms because it cannot load kernel32.dll. This causes a crash. RWLockWin tries to load kernel32.dll to check if the Slim Reader/Writer Lock APIs are present in kernel32.dll but on newer Windows platforms, kernel32.dll does not exist and the APIs are exported by kernelbase.dll instead. The fix is quite simple: There is no need to try to load any DLL to check if the Slim Reader/Writer Lock APIs are present, because these APIs are always present in all Windows versions since Windows Vista. I am removing the code that attempts to load kernel32.dll. This prevents the crash on platforms that use kernelbase.dll. If the WINUWP preprocessor symbol is defined, RWLockWin was already doing the right thing. But this issue is not limited to WINUWP and in some scenarios, building for WINUWP is not the right solution because it causes other problems. So, my fix is essentially to use the WINUWP code path for all Windows builds. The only version of Windows which does not have the Slim Reader/Writer Lock APIs is Windows XP (and older ones, of course.) However, since the current code does not fall back to an alternative implementation when the Slim Reader/Writer Lock APIs are missing, WebRTC is already broken on such old versions of Windows. Bug: webrtc:11186 Change-Id: I34aad066e18b924792d47c244ecee00669e86c4d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161472 Commit-Queue: Tommi <tommi@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30044}	2019-12-09 18:45:03 +00:00
Jonas Olsson	a4d873786f	Format almost everything. ... This CL was generated by running git ls-files | grep -P "(\.h|\.cc)$" | grep -v 'sdk/' | grep -v 'rtc_base/ssl_' | \ grep -v 'fake_rtc_certificate_generator.h' | grep -v 'modules/audio_device/win/' | \ grep -v 'system_wrappers/source/clock.cc' | grep -v 'rtc_base/trace_event.h' | \ grep -v 'modules/audio_coding/codecs/ilbc/' | grep -v 'screen_capturer_mac.h' | \ grep -v 'spl_inl_mips.h' | grep -v 'data_size_unittest.cc' | grep -v 'timestamp_unittest.cc' \ | xargs clang-format -i ; git cl format Most of these changes are clang-format grouping and reordering includes differently. Bug: webrtc:9340 Change-Id: Ic83ddbc169bfacd21883e381b5181c3dd4fe8a63 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144051 Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#28505}	2019-07-08 13:45:15 +00:00
Karl Wiberg	2b85792b01	Move rw_lock_wrapper.h to rtc_base/synchronization/ ... This moves it from an API directory (system_wrappers/include/) to a non-API directory, which is exactly what we want for utilities like this. BUG=webrtc:8445 NOPRESUBMIT=true Change-Id: Ie2879aca5fc1667e4222499d2a8fc2bba9ae2425 Reviewed-on: https://webrtc-review.googlesource.com/21328 Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22587}	2018-03-23 19:47:08 +00:00

Renamed from system_wrappers/source/rw_lock_win.h (Browse further)