4 commits

Author	SHA1	Message	Date
Tommi	a98cea863d	Remove the PendingTaskSafetyFlag::Pointer type add ScopedTaskSafety. ... ScopedTaskSafety simplifies usage of PendingTaskSafetyFlag, so this CL also includes ToQueuedTask support for ScopedTaskSafety and test updates. This is following up on feedback in the following CL: https://webrtc-review.googlesource.com/c/src/+/174262 Change-Id: Idd38dfc1914b24a05fdc4ad256b409dcf1795fc0 Bug: none Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174740 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31241}	2020-05-13 14:17:39 +00:00
Tommi	3c5450e693	Add support for PendingTaskSafetyFlag to ToQueuedTask. ... This keeps usage of ToQueuedTask consistent and avoids callers having to add additional boiler plate when using the safety flag. From this: tq->PostTask(ToQueuedTask([safety = my_safety_flag_]() { if (!safety->alive()) return; Foo(); }); to this: tq->PostTask(ToQueuedTask(my_safety_flag_, []() { Foo(); }); Bug: none Change-Id: I205af56a64dd9839eb845321083d533140d614ca Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174262 Commit-Queue: Tommi <tommi@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31161}	2020-05-04 18:20:10 +00:00
Mirko Bonadei	317a1f09ed	Use std::make_unique instead of absl::make_unique. ... WebRTC is now using C++14 so there is no need to use the Abseil version of std::make_unique. This CL has been created with the following steps: git grep -l absl::make_unique | sort | uniq > /tmp/make_unique.txt git grep -l absl::WrapUnique | sort | uniq > /tmp/wrap_unique.txt git grep -l "#include <memory>" | sort | uniq > /tmp/memory.txt diff --new-line-format="" --unchanged-line-format="" \ /tmp/make_unique.txt /tmp/wrap_unique.txt | sort | \ uniq > /tmp/only_make_unique.txt diff --new-line-format="" --unchanged-line-format="" \ /tmp/only_make_unique.txt /tmp/memory.txt | \ xargs grep -l "absl/memory" > /tmp/add-memory.txt git grep -l "\babsl::make_unique\b" | \ xargs sed -i "s/\babsl::make_unique\b/std::make_unique/g" git checkout PRESUBMIT.py abseil-in-webrtc.md cat /tmp/add-memory.txt | \ xargs sed -i \ 's/#include "absl\/memory\/memory.h"/#include <memory>/g' git cl format # Manual fix order of the new inserted #include <memory> cat /tmp/only_make_unique | xargs grep -l "#include <memory>" | \ xargs sed -i '/#include "absl\/memory\/memory.h"/d' git ls-files | grep BUILD.gn | \ xargs sed -i '/\/\/third_party\/abseil-cpp\/absl\/memory/d' python tools_webrtc/gn_check_autofix.py \ -m tryserver.webrtc -b linux_rel # Repead the gn_check_autofix step for other platforms git ls-files | grep BUILD.gn | \ xargs sed -i 's/absl\/memory:memory/absl\/memory/g' git cl format Bug: webrtc:10945 Change-Id: I3fe28ea80f4dd3ba3cf28effd151d5e1f19aff89 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153221 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29209}	2019-09-17 15:47:29 +00:00
Danil Chapovalov	3b548ddb1c	Move rtc::NewClosure into own build target as ToQueuedTask ... to make it usable without need to depend on rtc_task_queue Bug: webrtc:10191 Change-Id: I2ae1445cf5d498aa6928d66b6823f2f940987767 Reviewed-on: https://webrtc-review.googlesource.com/c/125084 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Sebastian Jansson <srte@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26942}	2019-03-04 09:00:38 +00:00