Commit graph

6 commits

Author SHA1 Message Date
Mirko Bonadei
8cc6695652 Reformat python files checked by pylint (part 1/2).
After recently changing .pylintrc (see [1]) we discovered that
the presubmit check always checks all the python files when just
one python file gets updated.

This CL moves all these files one step closer to what the linter
wants.

Autogenerated with:

# Added all the files under pylint control to ~/Desktop/to-reformat
cat ~/Desktop/to-reformat | xargs sed -i '1i\\'
git cl format --python --full

This is part 1 out of 2. The second part will fix function names and
will not be automated.

[1] - https://webrtc-review.googlesource.com/c/src/+/186664

No-Presubmit: True
Bug: webrtc:12114
Change-Id: Idfec4d759f209a2090440d0af2413a1ddc01b841
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/190980
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32530}
2020-10-30 10:13:11 +00:00
Mirko Bonadei
09dcafdd21 Revert "Always create output_dir in setup_apprtc.py."
This reverts commit 52a8da38f9.

Reason for revert: It doesn't solve the problem.

Original change's description:
> Always create output_dir in setup_apprtc.py.
> 
> This should probably fix [1]. It only happens on Windows bots and from
> the error it looks like if output_dir is missing, the unzipping just
> fails.
> 
> [1] - https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Win%20Builder/4027
> 
> Bug: None
> Change-Id: I2f0abe90898d6d15525b46fd74635e2a3150cb37
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151307
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#29064}

TBR=phoglund@webrtc.org,mbonadei@webrtc.org

Change-Id: If8d93033dcb871476f23c1597f24efcd2e20cfb2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151420
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29067}
2019-09-04 18:19:12 +00:00
Mirko Bonadei
52a8da38f9 Always create output_dir in setup_apprtc.py.
This should probably fix [1]. It only happens on Windows bots and from
the error it looks like if output_dir is missing, the unzipping just
fails.

[1] - https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Win%20Builder/4027

Bug: None
Change-Id: I2f0abe90898d6d15525b46fd74635e2a3150cb37
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151307
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29064}
2019-09-04 13:50:00 +00:00
Oleh Prypin
8058fbbd6b Bypass browser join confirmation in prebuilt AppRTC
This is still needed by Chromium tests.
Copied from https://webrtc.googlesource.com/webrtc.DEPS/+/76533443ed95184aa45dc3b4af383fc301a53f80/copy_apprtc.py

Bug: webrtc:7602
Change-Id: I17f0159fe43176df95ad2e27ff330650d6645d67
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/66680
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22718}
2018-04-04 08:14:29 +00:00
Oleh Prypin
8730135f26 Use sys.executable to launch another Python script
To make setup_apprtc.py work on Windows

Bug: webrtc:7602
Change-Id: I17c19c1cb8b2b71dafd90ae5f8be80e50c3397e9
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/66660
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22715}
2018-04-04 07:06:29 +00:00
Mirko Bonadei
bb547203bf Moving src/webrtc into src/.
In order to eliminate the WebRTC Subtree mirror in Chromium, 
WebRTC is moving the content of the src/webrtc directory up
to the src/ directory.

NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=tommi@webrtc.org

Bug: chromium:611808
Change-Id: Iac59c5b51b950f174119565bac87955a7994bc38
Reviewed-on: https://webrtc-review.googlesource.com/1560
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19845}
2017-09-15 04:25:06 +00:00
Renamed from webrtc/rtc_tools/testing/setup_apprtc.py (Browse further)