Commit graph

13 commits

Author SHA1 Message Date
Yves Gerey
ea766fa7a2 Support e.g. --workers=2x to use two workers per core.
This is mostly useful for tests performing a lot of I/O and sleeping,
when you don't know on which architecture they end up running.

The syntax can also be used to reduce CPU load (e.g. --workers=0.5x).

Bug: webrtc:9717
Change-Id: I26b4552576b1dd56a69c2223da39f4bb1115bbf6
Reviewed-on: https://webrtc-review.googlesource.com/101643
Commit-Queue: Yves Gerey <yvesg@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24830}
2018-09-25 15:09:29 +00:00
Oleh Prypin
69c0222108 Allow mixing gtest and non-gtest args in gtest-parallel-wrapper
No-Try: True
Bug: chromium:776681
Change-Id: I412a63e4ea897512b6c7012b9eb6ec5c3cf06314
Reviewed-on: https://webrtc-review.googlesource.com/78287
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23369}
2018-05-23 14:19:20 +00:00
Mirko Bonadei
738d11b975 Always create output_dir before invoking gtest-parallel.
TBR=phoglund@webrtc.org

Bug: None
Change-Id: I7c62da5d4c65e6d9e7ab9caf99c84f28f669c739
Reviewed-on: https://webrtc-review.googlesource.com/54422
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22077}
2018-02-19 12:17:14 +00:00
Edward Lemur
0c15a09293 Don't use gtest-parallel when running webrtc_perf_tests.
When we run webrtc_perf_tests with gtest-parallel, each test is run
individually, and this results in the file with the perf results being
overwritten each time.

To avoid this, we won't use gtest-parallel when running webrtc_perf_tests,
so we will simply run the binary directly.

TBR=phoglund@chromium.org

Bug: chromium:755660
Change-Id: I24db36e512fcf604a3de2adf4d0b4325b2c3d1ae
Reviewed-on: https://webrtc-review.googlesource.com/49340
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21982}
2018-02-12 13:10:04 +00:00
Edward Lemur
0501e1cd97 Pass chartjson_result_file to gtest_parallel tests.
Translate --isolate-script-test-perf-output to --chartjson_result_file
and pass it to the test.
That way we can use Chromium's recipe code to report results to the
Perf dashboard.

TBR=phoglund@webrtc.org

Bug: chromium:807737
Change-Id: I2d3479fe29431cc1a8faf9a73b054a5f4ec610a4
Reviewed-on: https://webrtc-review.googlesource.com/47121
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21894}
2018-02-05 16:37:01 +00:00
Edward Lemur
c2b6cf3db9 Store test artifacts for swarming perf tests.
A '--store-test-artifacts' flag is introduced in
gtest-parallel-wrapper.py to make it possible for test running on
swarming to save test artifacts to the swarming output dir.

Bug: chromium:755660
Change-Id: I6bc1fbf210c1f224f3a7186c5444ae063a6af222
Reviewed-on: https://webrtc-review.googlesource.com/7840
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@google.com>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20221}
2017-10-10 13:06:38 +00:00
ehmaldonado
6e6289dc42 Update gtest-parallel-wrapper.py to deal with changes in gtest-parallel.
Needed after 7676778438

BUG=None

Review-Url: https://codereview.webrtc.org/3011103002
Cr-Commit-Position: refs/heads/master@{#19749}
2017-09-08 14:25:51 +00:00
ehmaldonado
c4eee32b83 Rename isolated-script-test-chartjson-output to isolated-script-test-perf-output.
This is needed after the flag was renamed in
3e6978a8c0

BUG=webrtc:8215
NOTRY=True

Review-Url: https://codereview.webrtc.org/3005213002
Cr-Commit-Position: refs/heads/master@{#19721}
2017-09-07 07:34:17 +00:00
oprypin
51d49b4983 Reland of Stop silently accepting unsupported flags in test binaries (patchset #1 id:1 of https://codereview.webrtc.org/3002963002/ )
Reason for revert:
Relanding without changes.
Problem with unused flags was fixed in
https://codereview.webrtc.org/2998143002/

Original issue's description:
> Revert of Stop silently accepting unsupported flags in test binaries (patchset #5 id:150001 of https://codereview.webrtc.org/2968003003/ )
>
> Reason for revert:
> Causes failures on perf bots
> https://luci-milo.appspot.com/buildbot/client.webrtc.perf/Mac%2010.11/3567
>
> Original issue's description:
> > Stop silently accepting unsupported flags in test binaries
> >
> > Instead explicitly ignore only the flags we know should be ignored.
> >
> > BUG=webrtc:7568
> >
> > Review-Url: https://codereview.webrtc.org/2968003003
> > Cr-Commit-Position: refs/heads/master@{#19412}
> > Committed: a2782f6f5d
>
> TBR=kjellander@webrtc.org,henrika@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7568
>
> Review-Url: https://codereview.webrtc.org/3002963002
> Cr-Commit-Position: refs/heads/master@{#19413}
> Committed: d64072c598

TBR=kjellander@webrtc.org,henrika@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:7568

Review-Url: https://codereview.webrtc.org/2999383002
Cr-Commit-Position: refs/heads/master@{#19455}
2017-08-22 17:55:47 +00:00
oprypin
d64072c598 Revert of Stop silently accepting unsupported flags in test binaries (patchset #5 id:150001 of https://codereview.webrtc.org/2968003003/ )
Reason for revert:
Causes failures on perf bots
https://luci-milo.appspot.com/buildbot/client.webrtc.perf/Mac%2010.11/3567

Original issue's description:
> Stop silently accepting unsupported flags in test binaries
>
> Instead explicitly ignore only the flags we know should be ignored.
>
> BUG=webrtc:7568
>
> Review-Url: https://codereview.webrtc.org/2968003003
> Cr-Commit-Position: refs/heads/master@{#19412}
> Committed: a2782f6f5d

TBR=kjellander@webrtc.org,henrika@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7568

Review-Url: https://codereview.webrtc.org/3002963002
Cr-Commit-Position: refs/heads/master@{#19413}
2017-08-18 14:22:36 +00:00
oprypin
a2782f6f5d Stop silently accepting unsupported flags in test binaries
Instead explicitly ignore only the flags we know should be ignored.

BUG=webrtc:7568

Review-Url: https://codereview.webrtc.org/2968003003
Cr-Commit-Position: refs/heads/master@{#19412}
2017-08-18 14:12:20 +00:00
ehmaldonado
f549dffa7b Fix gtest-parallel-wrapper
It doesn't work when '--' is not part of the command line.
It executed "gtest-parallel gtest-parallel-wrapper.py executable_name"
instead of "gtets-parallel executable_name".

NOTRY=True
TBR=kjellander@webrtc.org
BUG=None

Review-Url: https://codereview.webrtc.org/2982133002
Cr-Commit-Position: refs/heads/master@{#19077}
2017-07-18 15:16:18 +00:00
Henrik Kjellander
90fd7d84fd Rename tools-webrtc -> tools_webrtc
This aligns with established naming convention for all
other directories.

BUG=webrtc:7593
NOTRY=True
NOTREECHECKS=True
R=ehmaldonado@webrtc.org, mbonadei@webrtc.org
TBR=henrika@webrtc.org

Review-Url: https://codereview.webrtc.org/2864213004 .
Cr-Commit-Position: refs/heads/master@{#18059}
2017-05-09 06:30:13 +00:00
Renamed from tools-webrtc/gtest-parallel-wrapper.py (Browse further)