Commit graph

645 commits

Author SHA1 Message Date
Florent Castelli
023be3c977 Data Channel Benchmarking tool
Create a server using:
./data_channel_benchmark --server --port 12345
Start the flow of data from the server to a client using:
./data_channel_benchmark --port 12345 --transfer_size 100
The throughput is reported on the server console.

The negotiation does not require a 3rd party server and is done over a
gRPC transport. No TURN server is configured, so both peers need to be
reachable using STUN only.

Bug: webrtc:13288
Change-Id: Iac9a96cf390ab465ea45a46bf0b40950c56dfceb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/235661
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36206}
2022-03-15 16:18:16 +00:00
Byoungchan Lee
2e7579aed2 Remove unused bazel related code
They are no longer used after
https://chromium-review.googlesource.com/c/chromium/src/+/3016508 and
https://chromium-review.googlesource.com/c/chromium/src/+/3206870.

Bug: None
Change-Id: Id5d3def2d902886bc8ffd5512e2820943cac41bf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/255540
Auto-Submit: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36204}
2022-03-15 11:35:09 +00:00
Jeremy Leconte
fa577c5eb6 Fix file open mode issue for the uploader.
This is a forward fix for https://webrtc-review.googlesource.com/c/src/+/255320.
The error is the following:
https://logs.chromium.org/logs/webrtc-internal/buildbucket/cr-buildbucket/8819696929332742321/+/u/webrtc_perf_tests_Dashboard_upload/stdout

Bug: webrtc:13806
Change-Id: I1ccba1be69edf0b1023c1d197d2033bdc718f64b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/255420
Owners-Override: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36196}
2022-03-14 19:34:46 +00:00
Jeremy Leconte
fa2c945f73 Fix type issue for the uploader.
This is a forward fix for https://webrtc-review.googlesource.com/c/src/+/255320.
The error is the following:
https://logs.chromium.org/logs/webrtc/buildbucket/cr-buildbucket/8819700229708372817/+/u/low_bandwidth_audio_perf_test_Dashboard_upload/stdout

Bug: webrtc:13806
Change-Id: Ia7d5362d1131d9bab41a9112946a4c84e509d98f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/255382
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36195}
2022-03-14 17:22:35 +00:00
Jeremy Leconte
2c4a4472a5 Prepare uploader to be used as a 'merge script'.
* Don't exit by throwing exceptions.
* Rely on a dataclass instead of argument list.
* Prepare to remove arg wait_upload because it's always true.
* Remove unused args wait_timeout_sec and wait_timeout_secwait_polling_period_sec.

Bug: webrtc:13806
Change-Id: I0879fa7fd22c72f5b174f8823bdd51d49f1f140b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/255320
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36193}
2022-03-14 14:42:28 +00:00
Ilya Nikolaevskiy
7c453589a9 Revert "Avoid using lld when compiling iin iOS with bitcode"
This reverts commit b7ba602765.

Reason for revert: Speculative revert as this seems to break the downstream project.

Original change's description:
> Avoid using lld when compiling iin iOS with bitcode
>
> The resulting framework's LLVM __bundle segment is empty otherwise.
>
> Bug: webrtc:13774
> Change-Id: I235a3005f8e0d68168f29108be0f7c5b7914182b
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253140
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#36178}

Bug: webrtc:13774
Change-Id: Ib05469827783d8db5e48ab9c33b31fcebd14b52a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/255302
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36186}
2022-03-14 10:29:55 +00:00
Saúl Ibarra Corretgé
b7ba602765 Avoid using lld when compiling iin iOS with bitcode
The resulting framework's LLVM __bundle segment is empty otherwise.

Bug: webrtc:13774
Change-Id: I235a3005f8e0d68168f29108be0f7c5b7914182b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253140
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36178}
2022-03-11 11:26:24 +00:00
Harald Alvestrand
c2a2bef4f7 Add a header-reduction argument to IWYU
This allows to delete non-needed headers from .h files.
Ran this on peer_connection.cc to demonstrate.

Bug: none
Change-Id: I69ce48be25a9778297e521282898c6ac31e7ea6c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/254600
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36170}
2022-03-10 12:25:12 +00:00
Jeremy Leconte
a5f3c20f2d Fix warning 'Build argument has no effect: ios_build_chrome'.
Same warning for ios_use_goma_rbe.
https://logs.chromium.org/logs/webrtc/buildbucket/cr-buildbucket/8820359174215951313/+/u/generate_build_files/stdout

Bug: webrtc:13556
Change-Id: I5342644d1f620d293a9a7f541ac59803dedf4d67
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253840
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36142}
2022-03-07 13:02:53 +00:00
Jeremy Leconte
7befe8e5e4 Remove reference to an old branch.
Bug: webrtc:13788
Change-Id: I628b27f3b26aaaf77824cdadca0089e43f0e976b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253781
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36139}
2022-03-07 08:27:23 +00:00
Saúl Ibarra Corretgé
fabc3a5aa7 Add script to generate ssl_roots.h from Mozilla's CA bundle
Bug: webrtc:11710
Change-Id: I6eac35a111f89f3c74ce8c2ffc0ab607ad881be2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253220
Reviewed-by: Christoffer Jansson <jansson@google.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36131}
2022-03-04 13:50:58 +00:00
Harald Alvestrand
c24a2189d7 Update IWYU tool with a mapping file
Also apply IWYU to all .cc files in pc/, and correct BUILD file to match.
Note: Some files came out wrong when iwyu was applied. These are not included.

Bug: none
Change-Id: Ib5ea46b8fcc505414d0447cca7218ad3afc2e321
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252280
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36064}
2022-02-24 11:05:06 +00:00
Christoffer Jansson
3b393ec991 Fixes escaped line breaks
Bug: webrtc:13607
Change-Id: I24c252ecb6d443abb8206e752bdff73ee5084807
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252260
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#36056}
2022-02-23 09:08:30 +00:00
Christoffer Jansson
36cf4787d0 Remove binary mode
Realized I could actually test this fully locally using:
vpython3 roll_deps.py --dry-run -i

No-Try: True
Bug: webrtc:13607
Change-Id: Ibd4d8c002f76b3524da22056a34645178c66687a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252064
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#36051}
2022-02-22 13:22:46 +00:00
Christoffer Jansson
e20a5247f0 another decode...
I went through more thoroghly this time I think I gotem all

Bug: webrtc:13607
Change-Id: I0e8773903bff16e807cc32a1a6f0177d43543e44
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252062
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#36050}
2022-02-22 12:53:17 +00:00
Christoffer Jansson
f1e4a66e94 Fix py3 compatibility for webrtc_version_updater
Bug: webrtc:13607
Change-Id: I5890dc86286b0a6ece793655bcda15315d415b39
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252060
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#36046}
2022-02-22 10:59:46 +00:00
Christoffer Jansson
c8f0502f0f Fix typo - Parenthesis was in the wrong place.
No-Try: True
Bug: webrtc:13607
Change-Id: Iba13bcf94f7a89cdc0e124d42e879b9c900a56cc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252003
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#36043}
2022-02-22 08:09:14 +00:00
Jeremy Leconte
7a5978e4cd Revert "Add the possibility to output a json gtest output to the perf tests."
This reverts commit cbfa235b35.

Reason for revert: iOS bots will use flags_compatibility with isolated_script_test_output but not gtest_output.

Original change's description:
> Add the possibility to output a json gtest output to the perf tests.
>
> We use the Chromium existing flag isolated_script_test_output that we translate into gtest_output.
> This is because the Chromium flag has the same purpose as gtest_output and is already provided in the recipe modules.
>
> No-Presubmit: True
> Bug: b/197492097
> Change-Id: Ia432a85b0e0ab32008b39ffe751d11aefb9b24ea
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251041
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Jeremy Leconte <jleconte@google.com>
> Cr-Commit-Position: refs/heads/main@{#35937}

No-Presubmit: True
Bug: b/197492097
Change-Id: I94e75328570f89011fbb0daf035f0072b8ea2f7d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252040
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36042}
2022-02-22 07:57:34 +00:00
Christoffer Jansson
694eae7064 Decode/encode data to utf-8
Currently blocking the chromium to webrtc roller

Bug: webrtc:13607
Change-Id: I02237b266d4f2a2fdec2975b9e67d1c4b2099a48
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252001
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#36041}
2022-02-21 19:53:34 +00:00
Christoffer Jansson
c13caac2d5 Fix urllib import + add test
Unblocks the chromium to webrtc roller.

Bug: webrtc:13607
Change-Id: I877d8d25624bdc924425ef338f392ce7686207f2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251984
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#36038}
2022-02-21 16:24:34 +00:00
Jeremy Leconte
d15f3e1220 Prepare the code to run ios tests with the standalone recipe.
The flags isolated-script-test-output and isolated-script-test-perf-output need to be consumed by the tests.

The generated .app folder in added in the data list of the gni file.
This will make it available in the runtime_deps file and thus will be populated to the swarming tasks.

Bug: webrtc:13556
Change-Id: I2c75774b847d9f686c3abc00ba0400bbc3fcefae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/240520
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Christoffer Jansson <jansson@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36029}
2022-02-18 12:57:42 +00:00
Christoffer Jansson
1b083a998b Encode data for compression + add initial tests
Bug: webrtc:13607
Change-Id: I3bbec5558e676ca45125fad3fdbd10cc47c84601
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251390
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#36003}
2022-02-15 14:24:11 +00:00
Jeremy Leconte
63472e5aea Replace dump_json_test_results flag by isolated-script-test-output.
This is because it's the default flag used in the recipes to dump a json output.
This CL also fixes some python3 lint issues in mb.py.

Bug: webrtc:13594
Change-Id: I9275b5da0963f801d3191703c2eb72d90befb5d7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/248142
Reviewed-by: Christoffer Jansson <jansson@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#35986}
2022-02-14 08:55:01 +00:00
Christoffer Jansson
e6aa6a8740 Set file mode in the argparse argument
Bug: webrtc:13607
Change-Id: I7943761933e0e110ff16b65284d8b36644b5c4ea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251381
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#35970}
2022-02-10 09:02:26 +00:00
Harald Alvestrand
981c572eab Updated apply-iwyu to autogenerate compile_commands.json
Also deleted iwyu script that was not maintained, and deleted
some options that made the script more complex.

Bug: none
Change-Id: I39d8eaa37f12c72ddc127ae145e6a3a80f328316
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251384
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35966}
2022-02-09 14:30:57 +00:00
Christoffer Jansson
c98fb2ca0f Use binary mode for proto ingestion
Bug: webrtc:13607
Change-Id: Id0385f74215360ff604641a50ce9f599c87abb5e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251327
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#35960}
2022-02-09 07:19:35 +00:00
Christoffer Jansson
409ac89b43 decode strings to utf-8 and use universal_newlines for subprocess
Bug: webrtc:13607
Change-Id: I4d8df7488b819b477cd0ae5553c0eb8a7adfb179
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251343
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#35955}
2022-02-08 17:42:25 +00:00
Christoffer Jansson
4e8a773b4b tools_webrtc dir converted to py3 + top level PRESUBMIT script
Bug: webrtc:13607
Change-Id: Ib018e43ea977cc24dd71048e68e3343741f7f31b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249083
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#35953}
2022-02-08 14:42:26 +00:00
Jeremy Leconte
cbfa235b35 Add the possibility to output a json gtest output to the perf tests.
We use the Chromium existing flag isolated_script_test_output that we translate into gtest_output.
This is because the Chromium flag has the same purpose as gtest_output and is already provided in the recipe modules.

No-Presubmit: True
Bug: b/197492097
Change-Id: Ia432a85b0e0ab32008b39ffe751d11aefb9b24ea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251041
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#35937}
2022-02-07 20:59:33 +00:00
Harald Alvestrand
0d4af12cab Add back --no_fwd_decls to iwyu run
Applies IWYU to pc/peer_connection.cc as test.

Bug: webrtc:13532
Change-Id: Iec453fdf6525c6376cb73dd1199326a8e1a21ff6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249986
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35845}
2022-01-31 10:26:17 +00:00
Christoffer Jansson
a4290a7909 add m1 try bots
Any Mac builder should be able to compile ARM64 builds when using target_cpu=arm64

Bug: chromium:1238267
Change-Id: I72dac3b6f170f09d5c158ec11650e0cff7b9e638
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249790
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#35838}
2022-01-31 08:28:29 +00:00
Jeremy Leconte
e006b7d103 Fix print error when migrating to python3.
This is causing errors on the ci:
https://ci.chromium.org/p/webrtc/builders/ci/Win32%20Release%20%28Clang%29/24047

No-Presubmit: True
Bug: webrtc:13607
Change-Id: I05c85d5d67ab71ef971899a60daffa2c10b72305
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249783
Reviewed-by: Christoffer Jansson <jansson@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#35823}
2022-01-28 10:45:55 +00:00
Mirko Bonadei
5d9ae8635c Switch Swarming commands to py3.
Thanks to machenbach@ for the heads up.

WebRTC's MB was generating a Swarming command that was using vpython
(defaulting on python2 on some platforms). This CL switches that to
vpython3 (fixing gtest-parallel-wrapper.py to be python3 compliant).

No-Presubmit: True
Bug: webrtc:13607
Change-Id: Icfa7d23b81e30cebfe8243d4ba65284955593465
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249604
Reviewed-by: Christoffer Jansson <jansson@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35821}
2022-01-28 08:17:05 +00:00
Byoungchan Lee
e286a7bbf7 Modify apply-iwyu to utilize compile_commands.json
Bug: webrtc:13532
Change-Id: I06e5987469e732296deb1eefd317e2478add98b8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/246040
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: (Daniel.L) Byoungchan Lee <daniel.l@hpcnt.com>
Cr-Commit-Position: refs/heads/main@{#35674}
2022-01-12 23:08:22 +00:00
Jeremy Leconte
994bf454ec Revert of flag simplification.
In order to unify WebRTC recipes with Chromium recipes this CL tries to revert the old CL https://webrtc-review.googlesource.com/c/src/+/171681.
This CL was already partially reverted (https://webrtc-review.googlesource.com/c/src/+/171809).
In upcoming CLs, the added flag dump_json_test_results will be removed in order to use isolated-script-test-output instead.

Bug: webrtc:13556
Change-Id: I3144498b9a5cbaa56c23b3b8adbac2229ad63c37
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245602
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#35666}
2022-01-12 10:53:12 +00:00
Christoffer Jansson
cf00059db6 Remove Win8
Bug: chromium:1281336
Change-Id: I490ec704d8f006301ab41dc3380983075032285e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245483
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#35656}
2022-01-11 10:27:54 +00:00
Jeremy Leconte
67b0a4476b Remove perf test isac_fix_test.
Bug: b/210641670
Change-Id: If562d1b2aa3486a51efffb4dec471ed7064c5261
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/241360
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#35533}
2021-12-14 16:52:58 +00:00
Mirko Bonadei
d80a21d2f1 Relax gn check test.
See the report at https://bugs.chromium.org/p/gn/issues/detail?id=271.

Bug: None
Change-Id: I6ddc12fc83f8f8eca985af9237e0b736814574fb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/240522
Reviewed-by: Christoffer Jansson <jansson@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35516}
2021-12-10 09:33:01 +00:00
Jeremy Leconte
f22c78b01a Fix mb.py presubmit issues.
* Add a config file for python formatting (.style.yapf).
* Change the default indentation from 4 spaces to 2 spaces.
* Run 'git cl format --python' on a few python files.

Bug: webrtc:13413
Change-Id: Ia71135131276c2c499b00032d57ad16ee5200a5c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/238982
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Christoffer Jansson <jansson@google.com>
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#35500}
2021-12-08 08:53:00 +00:00
Jeremy Leconte
a2e3d80cf6 Revert "Reland "Use gtest_parallel with 1 worker for webrtc_perf_tests.""
This reverts commit c31fc2a941.

Reason for revert: Fix is not working properly.

Original change's description:
> Reland "Use gtest_parallel with 1 worker for webrtc_perf_tests."
>
> This is a reland of 258ed1a38a
>
> Original change's description:
> > Use gtest_parallel with 1 worker for webrtc_perf_tests.
> >
> > This will enable test results to be uploaded to ResultDB.
> >
> > Bug: b/197492097
> > Change-Id: Iec28520c4cd8f35fcff2cbd105a4b851ef41b9fc
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239641
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > Reviewed-by: Christoffer Jansson <jansson@google.com>
> > Commit-Queue: Jeremy Leconte <jleconte@google.com>
> > Cr-Commit-Position: refs/heads/main@{#35458}
>
> Bug: b/197492097
> No-Presubmit: True
> Change-Id: Iea90f5698c83791d39c0f6da666c1d1eb274edd3
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239645
> Commit-Queue: Jeremy Leconte <jleconte@google.com>
> Reviewed-by: Andrey Logvin <landrey@webrtc.org>
> Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
> Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org>
> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#35483}

TBR=mbonadei@webrtc.org,gustaf@webrtc.org,jansson@google.com,jansson@webrtc.org,jakobi@webrtc.org,landrey@webrtc.org,jleconte@google.com,jleconte@webrtc.org,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: Iee9b67db99545a1e6c707bc03faaf55afc90cbbf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/197492097
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/240182
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35486}
2021-12-07 12:04:08 +00:00
Jeremy Leconte
c31fc2a941 Reland "Use gtest_parallel with 1 worker for webrtc_perf_tests."
This is a reland of 258ed1a38a

Original change's description:
> Use gtest_parallel with 1 worker for webrtc_perf_tests.
>
> This will enable test results to be uploaded to ResultDB.
>
> Bug: b/197492097
> Change-Id: Iec28520c4cd8f35fcff2cbd105a4b851ef41b9fc
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239641
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Christoffer Jansson <jansson@google.com>
> Commit-Queue: Jeremy Leconte <jleconte@google.com>
> Cr-Commit-Position: refs/heads/main@{#35458}

Bug: b/197492097
No-Presubmit: True
Change-Id: Iea90f5698c83791d39c0f6da666c1d1eb274edd3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239645
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org>
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35483}
2021-12-07 10:08:16 +00:00
Christoffer Jansson
833b095694 add more owners to mb
Bug: None
Change-Id: I24616c391b61264e4509f20ffd6d1accd7f3bab9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239843
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35480}
2021-12-06 16:46:16 +00:00
Nidhi Jaju
2394977f74 CodeHealth: Python3 migration for tools_webrtc/mb/
This CL includes:
* set Pylint to 2.7 in tools_webrtc/mb/PRESUBMIT.py
* fix some style warnings caused by scripts in tools_webrtc/mb/
* pass skip_shebang_check=True within tools_webrtc/mb/PRESUBMIT.py

Bug: chromium:1262287, chromium:1262352
Change-Id: Iae4f111942d724db6a7f4585c97a7c26c1e6ccc0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239660
Commit-Queue: Nidhi Jaju <nidhijaju@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35477}
2021-12-06 12:59:57 +00:00
Jeremy Leconte
a642df2598 Revert "Use gtest_parallel with 1 worker for webrtc_perf_tests."
This reverts commit 258ed1a38a.

Reason for revert: This cl breaks the dumping of the perf proto histogram.

Original change's description:
> Use gtest_parallel with 1 worker for webrtc_perf_tests.
>
> This will enable test results to be uploaded to ResultDB.
>
> Bug: b/197492097
> Change-Id: Iec28520c4cd8f35fcff2cbd105a4b851ef41b9fc
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239641
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Christoffer Jansson <jansson@google.com>
> Commit-Queue: Jeremy Leconte <jleconte@google.com>
> Cr-Commit-Position: refs/heads/main@{#35458}

TBR=mbonadei@webrtc.org,jansson@google.com,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com,jleconte@webrtc.org

Change-Id: Ic4ab03d0e7f8bc1ce799d30e74420200d2f8f224
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/197492097
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239644
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Christoffer Jansson <jansson@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#35463}
2021-12-02 13:16:00 +00:00
Jeremy Leconte
258ed1a38a Use gtest_parallel with 1 worker for webrtc_perf_tests.
This will enable test results to be uploaded to ResultDB.

Bug: b/197492097
Change-Id: Iec28520c4cd8f35fcff2cbd105a4b851ef41b9fc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239641
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Christoffer Jansson <jansson@google.com>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#35458}
2021-12-02 10:40:46 +00:00
Jeremy Leconte
59b8a46d3f Fix low_bandwidth_audio_test on Windows bots.
Bug: b/197492097
Change-Id: I29ae4d699c3c928f9d22da8cf9026c462f3afa7e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239540
Reviewed-by: Christoffer Jansson <jansson@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#35452}
2021-12-01 13:04:52 +00:00
Junji Watanabe
8d89f461c9 Remove --isolated from mb.py
This option is not supported now.

Bug: chromium:1271841
Change-Id: I27dd1531589ac497ef345fff41897a087ace4362
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239461
Reviewed-by: Takuto Ikuta <tikuta@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Junji Watanabe <jwata@google.com>
Cr-Commit-Position: refs/heads/main@{#35449}
2021-12-01 06:15:41 +00:00
Mirko Bonadei
b55c299f4d Avoid TBR in DEPS autoroller (use CC instead).
No-Presubmit: True
No-Try: True
Bug: None
Change-Id: I71c71de4ff9cfb1b9e59620b56a13ff4e94639eb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239361
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35430}
2021-11-29 12:54:01 +00:00
Takuto Ikuta
9345bee860 DEPS: use python3
Bug: chromium:1208028
Change-Id: I1117855556e4a9e7cbaf54764c8a23c5b8581ded
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239160
Auto-Submit: Takuto Ikuta <tikuta@google.com>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35426}
2021-11-29 07:27:52 +00:00
Mirko Bonadei
4e8e36c745 Try to fix the version updated bot.
No-Presubmit: True
Bug: webrtc:13373
Change-Id: I30418f760cda6be31c75ff7e59311cb59c1874c9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/238805
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35415}
2021-11-24 13:04:06 +00:00