Commit graph

18 commits

Author SHA1 Message Date
Mirko Bonadei
abac56b866 Compile frame_analyzer instead of using a prebuilt version.
Bug: webrtc:9665
Change-Id: I589128d3f18a68a42094dacd910cd614a075a460
Reviewed-on: https://webrtc-review.googlesource.com/99823
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24717}
2018-09-13 08:59:45 +00:00
Sami Kalliomäki
0673bc9204 Revert CLs affecting video quality toolchain.
Speculatively fixes Chromium test for cut: crbug.com/877968

Reverts CLs:
https://webrtc-review.googlesource.com/c/src/+/94772
https://webrtc-review.googlesource.com/c/src/+/95648
https://webrtc-review.googlesource.com/c/src/+/94773
https://webrtc-review.googlesource.com/c/src/+/96000
https://webrtc-review.googlesource.com/c/src/+/95949

Revert "Add Y4mFileReader"

This reverts commit 404be7f302.

Revert "Remove SequencedTaskChecker from Y4mFileReader"

This reverts commit 1b5e5db842.

Revert "Add tool for aliging video files"

This reverts commit b2c0e8f60f.

Revert "Reland "Update video_quality_analysis to align videos instead of using barcodes""

This reverts commit 9bb55fc09b.

Revert "Fix a bug in barcode_decoder.py"

This reverts commit 5c2de6b3ce.

TBR=magjed@webrtc.org, phoglund@webrtc.org, phensman@webrtc.org

Bug: chromium:877968, webrtc:9642
Change-Id: I784d0598fd0370eec38d758b9fa0b38e4b3423be
Reviewed-on: https://webrtc-review.googlesource.com/96320
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24458}
2018-08-27 16:50:54 +00:00
Magnus Jedvert
9bb55fc09b Reland "Update video_quality_analysis to align videos instead of using barcodes"
This is a reland of d65e143801

The binary for frame_analyzer.cpp is precompiled and stored in the cloud, so it
won't automatically pick up change to the source file. Therefore, restore all
old code to be backwards compatible.

Original change's description:
> Update video_quality_analysis to align videos instead of using barcodes
>
> This CL is a follow-up to the previous CL
> https://webrtc-review.googlesource.com/c/src/+/94773 that added generic
> logic for aligning videos. This will allow us to easily extend
> video_quality_analysis with new sophisticated video quality metrics.
> Also, we can use any kind of video that does not necessarily need to
> contain bar codes. Removing the need to decode barcodes also leads to a
> big speedup for the tests.
>
> Bug: webrtc:9642
> Change-Id: I74b0d630b3e1ed44781ad024115ded3143e28f50
> Reviewed-on: https://webrtc-review.googlesource.com/94845
> Reviewed-by: Paulina Hensman <phensman@webrtc.org>
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Commit-Queue: Magnus Jedvert <magjed@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#24423}

TBR=phensman@webrtc.org,phoglund@webrtc.org

Bug: webrtc:9642
Change-Id: Id8d129ce103284504c67690f8363c03eaae3eee7
Reviewed-on: https://webrtc-review.googlesource.com/96000
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Magnus Jedvert <magjed@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24429}
2018-08-24 13:21:18 +00:00
Sami Kalliomäki
d54f5f5c76 Rename rtc_instrumentation_test_apk targets to end with _test_apk.
This matches Chromium pattern of naming instrumentation test apks with
a name ending in _test_apk. The old naming confuses generate_gradle.py.

Renames:
 - AppRTCMobileTest
   -> AppRTCMobile_test_apk
 - AppRTCMobileTestStubbedVideoIO
   -> AppRTCMobile_stubbed_video_io_test_apk
 - libjingle_peerconnection_android_unittest
   -> android_instrumentation_test_apk

Bug: webrtc:9588
TBR: phoglund
Change-Id: Idb82dc4bd089bc7c90e9373f7c3d572f9fd2d95a
Reviewed-on: https://webrtc-review.googlesource.com/92380
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24184}
2018-08-03 12:44:40 +00:00
Oleh Prypin
1e90845f9e Fix AppRTC paths in video_quality_loopback_test.py
Forgotten in https://webrtc-review.googlesource.com/c/src/+/66680

No-Try: True
TBR: phoglund@webrtc.org
Bug: webrtc:7602
Change-Id: I07f3a7b75a6fe1d287b47c619a4fb44253dc8436
Reviewed-on: https://webrtc-review.googlesource.com/66783
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22731}
2018-04-04 12:36:00 +00:00
Edward Lesmes
9599fd4414 Make num-retries default a string.
TBR=phoglund@webrtc.org

Bug: chromium:755660
Change-Id: I770a79a78721a312b603aec40d23689245a48001
Reviewed-on: https://webrtc-review.googlesource.com/61343
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22392}
2018-03-12 21:19:51 +00:00
Edward Lesmes
5b9c6840b1 Add num-retries flag to Android perf tests.
Add a flag to Android perf tests, so we can specify the number of
retries.

Bug: chromium:755660
Change-Id: Ic498373421b7e0fdf779a4659a0c79d47a59fbde
Reviewed-on: https://webrtc-review.googlesource.com/61103
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22390}
2018-03-12 19:51:09 +00:00
Edward Lemur
71d766eb4b Pass the right flag to Android video quality test.
Pass --isolated-script-test-output instead of --chartjson-result-file.

TBR=phoglund@webrtc.org

Bug: chromium:755660
Change-Id: I6b55a4461428526de77bf192600de81b8cc029b2
Reviewed-on: https://webrtc-review.googlesource.com/48180
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21909}
2018-02-06 11:09:49 +00:00
Edward Lemur
d5e17d6831 Don't run video_quality_loopback_test from the src dir.
When executed on swarming, the script is run from //out/<android build dir>,
so it's better to keep that convention.

Given that all paths are given, cwd doesn't seem to be needed.

TBR=phoglund@webrtc.org

Bug: chromium:755660
Change-Id: Iabf6603983ff88b1281e8113da1aad3320967b72
Reviewed-on: https://webrtc-review.googlesource.com/46142
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21843}
2018-02-01 13:27:41 +00:00
Edward Lemur
21a35bc188 Ignore Chromium-specific flags on video_quality_loopback_test.
TBR=phoglund@webrtc.org

Bug: chromium:755660
Change-Id: I71409a569995708bc4c54b9bbcb2a119feed4be9
Reviewed-on: https://webrtc-review.googlesource.com/46524
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21827}
2018-01-31 13:50:09 +00:00
Edward Lemur
2e5966b3d3 Store video_quality_loopback_test perf results in Chart JSON format.
Adds a flag to store the perf results in a JSON file using the Chart
JSON format [1].

[1] https://github.com/catapult-project/catapult/blob/master/dashboard/docs/data-format.md

TBR=phoglund@webrtc.org

Bug: chromium:755660
Change-Id: I6a896654a4a558df217ddefa4e8a52a487cdbebd
Reviewed-on: https://webrtc-review.googlesource.com/43180
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21809}
2018-01-30 16:48:59 +00:00
Edward Lemur
70ba9b453c Reland "Make it possible to run video_quality_loopback_test in swarming."
This is a reland of 1175ecd095.

Original change's description:
> Make it possible to run video_quality_loopback_test in swarming.
> 
> I made two changes to video_quality_loopback_test to make it possible
> to run it on swarming.
> 
> 1. We need to know the path to frame_analyzer when we're generating
>    the build files, and it must be already present.
>    I made frame_analyzer a resource, so it's downloaded to a known path
>    before generating the build files.
> 2. The .zip files for apprtc and golang are downloaded and isolated.
>    The script now extracts them and installs AppRTC.
> 
> Passing task:
>  https://chromium-swarm.appspot.com/task?id=3b230bcc04128210
> 
> Bug: chromium:755660
> Change-Id: I34090897402421d5b7e29f21fbed354551197f92
> Reviewed-on: https://webrtc-review.googlesource.com/40920
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#21716}

Bug: chromium:755660
Change-Id: Ie3ca62d64b4fe856485287b7d9d3d9e3f75dc091
Reviewed-on: https://webrtc-review.googlesource.com/42860
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21733}
2018-01-23 13:03:17 +00:00
Edward Lemur
9c1848952e Revert "Make it possible to run video_quality_loopback_test in swarming."
This reverts commit 1175ecd095.

Reason for revert: Breaks the bots.

Original change's description:
> Make it possible to run video_quality_loopback_test in swarming.
> 
> I made two changes to video_quality_loopback_test to make it possible
> to run it on swarming.
> 
> 1. We need to know the path to frame_analyzer when we're generating
>    the build files, and it must be already present.
>    I made frame_analyzer a resource, so it's downloaded to a known path
>    before generating the build files.
> 2. The .zip files for apprtc and golang are downloaded and isolated.
>    The script now extracts them and installs AppRTC.
> 
> Passing task:
>  https://chromium-swarm.appspot.com/task?id=3b230bcc04128210
> 
> Bug: chromium:755660
> Change-Id: I34090897402421d5b7e29f21fbed354551197f92
> Reviewed-on: https://webrtc-review.googlesource.com/40920
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#21716}

TBR=phoglund@webrtc.org,ehmaldonado@webrtc.org

Change-Id: Id25d26adc547ff6f9ab178601e37527459c8b5ef
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:755660
Reviewed-on: https://webrtc-review.googlesource.com/42800
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21723}
2018-01-22 16:12:10 +00:00
Edward Lemur
1175ecd095 Make it possible to run video_quality_loopback_test in swarming.
I made two changes to video_quality_loopback_test to make it possible
to run it on swarming.

1. We need to know the path to frame_analyzer when we're generating
   the build files, and it must be already present.
   I made frame_analyzer a resource, so it's downloaded to a known path
   before generating the build files.
2. The .zip files for apprtc and golang are downloaded and isolated.
   The script now extracts them and installs AppRTC.

Passing task:
 https://chromium-swarm.appspot.com/task?id=3b230bcc04128210

Bug: chromium:755660
Change-Id: I34090897402421d5b7e29f21fbed354551197f92
Reviewed-on: https://webrtc-review.googlesource.com/40920
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21716}
2018-01-22 14:40:28 +00:00
Henrik Kjellander
ec57e05410 Update scripts to use DEPS-pinned depot_tools
Always use gn.py in depot_tools instead of just gn.
The https://cs.chromium.org/chromium/src/build/find_depot_tools.py
is looking up the DEPS-pinned copy in third_party/depot_tools
and adds it to the path when add_depot_tools_to_path() is called.

Similar use:
 

https: //cs.chromium.org/search/?q=%22find_depot_tools.add_depot_tools_to_path()%22&sq=package:chromium&type=cs
Bug: webrtc:8393
Change-Id: I3cfa3d96b4d0f60e8099e556876bc94340b1bbb5
Reviewed-on: https://webrtc-review.googlesource.com/12540
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@google.com>
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20333}
2017-10-18 12:06:19 +00:00
Henrik Kjellander
cb3b1c13f7 video_quality_loopback_test.py: Fix relative path to root.
This was missed in https://webrtc-review.googlesource.com/1575

BUG=chromium:611808
NOTRY=True
TBR=mbonadei@webrtc.org

Change-Id: Ie5b891d8071a70a510f114d8d0ab2dd6a8547b3c
Reviewed-on: https://webrtc-review.googlesource.com/1840
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19877}
2017-09-18 04:26:15 +00:00
Henrik Kjellander
9d8ce7c7fa video_quality_loopback_test.py: Fix paths to root.
Now that webrtc/* is moved to the root, this needs to be updated.

BUG=chromium:611808
NOTRY=True
TBR=mbonadei@webrtc.org

Change-Id: I947628886fb949972501e81e010bbdb9e9099872
Reviewed-on: https://webrtc-review.googlesource.com/1575
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19854}
2017-09-15 11:09:00 +00:00
Mirko Bonadei
bb547203bf Moving src/webrtc into src/.
In order to eliminate the WebRTC Subtree mirror in Chromium, 
WebRTC is moving the content of the src/webrtc directory up
to the src/ directory.

NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=tommi@webrtc.org

Bug: chromium:611808
Change-Id: Iac59c5b51b950f174119565bac87955a7994bc38
Reviewed-on: https://webrtc-review.googlesource.com/1560
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19845}
2017-09-15 04:25:06 +00:00
Renamed from webrtc/examples/androidtests/video_quality_loopback_test.py (Browse further)