Commit graph

4 commits

Author SHA1 Message Date
Patrik Höglund
ac086af9d8 Make orphan check understand public headers.
Bug: webrtc:8277
Change-Id: Id3450185f1bf9e78e4dac10cf4df217f35e02514
Reviewed-on: https://webrtc-review.googlesource.com/4723
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20061}
2017-10-02 07:49:59 +00:00
mbonadei
26c26345c3 Fixing check_orphan_headers on Windows
There were too many assumptions of the fact that the check was running
on Linux.

BUG=webrtc:7635
NOTRY=True

Review-Url: https://codereview.webrtc.org/2878733004
Cr-Commit-Position: refs/heads/master@{#18120}
2017-05-12 09:06:16 +00:00
mbonadei
84ab581e0b Supporting orphan headers check on ios_framework_bundle
ios_framework_bundle does not have 'sources' but 'common_objc_headers'
and it was causins a couple of false positives.

BUG=webrtc:7514
NOTRY=True

Review-Url: https://codereview.webrtc.org/2872303003
Cr-Commit-Position: refs/heads/master@{#18084}
2017-05-10 15:04:34 +00:00
mbonadei
74973ed847 Adding PRESUBMIT check on orphan headers files.
We want all .h files to be tracked by a GN target. This CL adds a
presubmit check to ensure that newly added targets are tracked by
GN.

In this CL we add a directory called 'presubmit_checks_lib' so we
can avoid to put everything in PRESUBMIT.py (especially if we want
to test some checks). I tried to use 'tools-webrtc' but it is not
easy to include a python module from a directory with '-' in the
name.

BUG=webrtc:7514

Review-Url: https://codereview.webrtc.org/2872493002
Cr-Commit-Position: refs/heads/master@{#18069}
2017-05-09 14:58:05 +00:00