Mirko Bonadei
b301b58b3f
Rename CI Android testers.
...
This makes it easier to update devices in th e future (avoiding multiple
CLs to change names, etc..).
Bug: b/259076774
Change-Id: I20ae940823978fbae84495d266345e4990184130
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283720
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38650}
2022-11-16 15:38:21 +00:00
Jeremy Leconte
e085366aca
Fix some minor issues with the android bots.
...
* Use the same logdog_butler as Chromium instead of redefining one.
* Use luci-auth to prevent "local auth - HTTP 400" errors.
Change-Id: I2a0d1393f9f0e1e41b2bcc9a9fec2c50c19675f3
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283520
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38637}
2022-11-16 09:09:25 +00:00
Jeremy Leconte
d957836794
Use gtest_parallel for PipeWire tests.
...
This CL will also make PipeWire tests retried 3 times in case of failures.
Change-Id: I9c66351f7ee171e29266fe4b8dcd52ca282c8f6d
Bug: webrtc:14644
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282820
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38595}
2022-11-09 15:37:58 +00:00
Christoffer Jansson
119fb1910a
Add Pixel2 and Pixel5 arm32 perf tester
...
Bug: b/257916734
Change-Id: I733e3d451daa47fa25d370f5d2fff7c9b1f5b8db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282560
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38584}
2022-11-08 12:44:18 +00:00
Christoffer Jansson
ddae5e6fae
Add Pixel5 perf config
...
Bug: b/257916734
Change-Id: I7a9fc7db85cf7742b7de0ce4c2dc4d25548050f2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282220
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38566}
2022-11-07 15:50:51 +00:00
Junji Watanabe
1d490cb4bf
[infra] Fix debug_bot_arm to have use_goma=true
...
Linux Debug (ARM) builder is still using Goma.
https://ci.chromium.org/ui/p/webrtc/builders/ci/Linux32%20Debug%20(ARM)/18995/overview
`Override MB config to use reclient` step fails to replace use_goma=true with use_remoteexec=true because there is no use_goma=true in this builder's mb config.
I don't know why the builder uses Goma without use_goma=true.
But, maybe this is due to the default setting or some recipe logic.
Bug: b:239908030
Change-Id: Iabf0c857144769e842c5f4080fe01339841d8c0c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/281820
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
Cr-Commit-Position: refs/heads/main@{#38550}
2022-11-04 08:01:31 +00:00
Junji Watanabe
4349137885
[infra] Remove reclient shadow builders for CI
...
Keeping shadow builders may cause worker pool saturation.
Bug: b:239908030
Change-Id: I5c0272c7a1772df143290cbaa2083c93a4c96c52
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/280320
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Reviewed-by: Christoffer Jansson <jansson@google.com>
Reviewed-by: Takuto Ikuta <tikuta@google.com>
Cr-Commit-Position: refs/heads/main@{#38462}
2022-10-25 07:56:06 +00:00
Jeremy Leconte
f30bf5b746
Add flags_compatibility script for fuchsia bots.
...
Change-Id: Ic57f23e16945f83027d9152a70943f43a2282dfd
Bug: b/232740856
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277222
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38277}
2022-10-03 14:05:29 +00:00
Christoffer Jansson
fb409c975f
Do not use gtest_parallell for fuchsia
...
Bug: b/232740856
Change-Id: If1191c1e90b7eb18acd8e393f3927ddee4b92b34
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277181
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#38234}
2022-09-28 12:31:14 +00:00
Junji Watanabe
5ff51ee283
Migrate Linux64 Release (Libfuzzer) to use reclient
...
All CI builders on Linux with standlone.py recipe have already been migrated to reclient.
This is the only remaining Linux builder with libfuzzer.py recipe.
Test:
[pass] https://ci.chromium.org/swarming/task/5d4962978d596a10
Bug: b/239908030
Change-Id: I861ded5672f2296f61d42b1f4678cd5602d50030
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/275061
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Takuto Ikuta <tikuta@google.com>
Cr-Commit-Position: refs/heads/main@{#38057}
2022-09-12 07:52:59 +00:00
Christoffer Jansson
7fc45e1701
Use target_os="fuchsia"
...
Bug: b/232740856
Change-Id: I1e8a204cff0a256ba5aeba9b3077d314b6fe105e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/274408
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38030}
2022-09-07 15:09:25 +00:00
Christoffer Jansson
a45a7cbc0d
Add fuchsia bot
...
No-Try: true
Bug: b/232740856
Change-Id: I5b4c9b41395466e68e00a7e63fffb26eb31d8313
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/274401
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38028}
2022-09-07 12:44:00 +00:00
Junji Watanabe
808b951ab9
Migrate Andorid32 (M Nexus5X) builder to use reclient
...
We have already confirmed that reclient has better performance for Android builds.
Bug: b/239908030
Change-Id: I6a83f48a6b4f6024053a0f60c6650d5d931f40d3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/274420
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38024}
2022-09-07 07:21:22 +00:00
Junji Watanabe
cb6154346a
Migrate Linux64 Release builder to use recilent
...
The reclient shadow builder already shows better performance than goma builds.
Bug: b/239908030
Change-Id: Idf6488a45beedbd6ef63fca10ddb8ae3a8ef98de
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/274201
Reviewed-by: Takuto Ikuta <tikuta@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38023}
2022-09-07 03:28:22 +00:00
Junji Watanabe
4680f3370d
Add reclient shadow builders to mb_config.pyl
...
Bug: b:243628179
Change-Id: Ic1b1e42f9c11ba049addaca42cf7fa8a98cbd87a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273124
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Junji Watanabe <jwata@google.com>
Cr-Commit-Position: refs/heads/main@{#37917}
2022-08-26 13:25:29 +00:00
Junji Watanabe
5800f36632
Add mb_config for Linux64 Release (reclient) builder
...
Bug: b/243628179
Change-Id: I2072261fe87d83979044f6b95b6635a0d993f39e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/272864
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37898}
2022-08-25 06:52:42 +00:00
Jeremy Leconte
3d38cd3c41
Migrate mb script to python3.
...
Change-Id: Ief72dd7f9c5ca65c6ce67d1784c6d8321554a07a
Bug: b/216091827
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271294
Reviewed-by: Evan Shrubsole <eshr@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#37809}
2022-08-17 13:50:43 +00:00
Jeremy Leconte
35fc144e01
Rename 'iOS64 Sim Debug (iOS 14.0)' bot.
...
Change-Id: I83bb0dfd0edcc199c2e44d2627bb6945514a6c84
Bug: b/228171822
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264941
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37104}
2022-06-03 07:17:27 +00:00
Christoffer Jansson
353d5b243a
Remove crosscompile for Perf Mac M1 Arm64 12
...
Since the Perf tester is actually compiling histogram code, it needs
to have it's own native OS gclient and GN config. The Builder has already
built and cached the MacOS arm64 binaries to be tested for M1.
I got confused and thought the tester was also compiling something for
the bot it shards to.
Bug: b/232347569
Change-Id: I0468945a04905d2d647626229af77c00d1f632fd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/263200
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36969}
2022-05-23 09:54:48 +00:00
Christoffer Jansson
bf2d75d86f
Add specific mac arm64 mb config
...
Trying to solve https://ci.chromium.org/ui/p/webrtc/builders/perf/Perf%20Mac%20M1%20Arm64%2012/1/overview
Bug: b/230719743
Change-Id: I43e0206548fe6223552909a23748e3eea678e2a9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261902
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36837}
2022-05-10 13:08:31 +00:00
Christoffer Jansson
598044f9ee
Add M1 perf bot
...
Companion CL: https://chromium-review.googlesource.com/c/chromium/tools/build/+/3634362
Bug: b/230719743
Change-Id: I52babb62dddbcadeb2854720c3c022ee3e04dbec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260321
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36829}
2022-05-10 08:10:20 +00:00
Jeremy Leconte
4ef2de6290
Remove the iOS internal try bots.
...
Bug: b/230708129
Change-Id: Ic4315997af0c01c5f5d987d13d88ada7d76ab0ea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260191
Reviewed-by: Mirko Bonadei <mbonadei@google.com>
Commit-Queue: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36770}
2022-05-05 07:20:49 +00:00
Jeremy Leconte
55c55c3c43
Reorder mb_config.pyl to fix 'mb.py validate'
...
This is a follow up of this CL: https://crrev.com/c/3611486 .
Bug: b/231404336
Change-Id: I3b6f4b780aa1939b6b2d0f1d08d1746a3a6f86dc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261080
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36752}
2022-05-04 08:31:29 +00:00
Christoffer Jansson
b45d4deb3b
Rename MacOS perf bot to 11 to reflect OS version
...
Bug: b/227442116
Change-Id: I80cf745a3a38d08c833864d2f8e4533776be2585
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260460
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36702}
2022-04-29 09:24:13 +00:00
Jeremy Leconte
7c94291c58
Remove reference to //base in mb_unittest.py
...
Also remove tests in //tools_webrtc/mb/mb_unittest.py that are testing exclusively code in //tools/mb/mb.py.
Bug: webrtc:13662
Change-Id: Ifdfbe26c11f7c315e307856b1d3ab06483d57641
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260041
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36651}
2022-04-26 07:44:44 +00:00
Jeremy Leconte
e288161529
Don't use windows path in mb.py
...
Swarming Windows bots translate the path to Windows path.
https://chromium-swarm.appspot.com/task?id=5a5a3b202f930010
Bug: webrtc:13475
Change-Id: I21589e67057174651d467f4f78e33bdd21a4e1c5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259302
Reviewed-by: Christoffer Jansson <jansson@google.com>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36571}
2022-04-19 12:24:26 +00:00
Jeremy Leconte
424cc65a4a
Centralized test command argument in .pyl configuration.
...
* Remove args from gn_isolate_map.pyl
* Set idempotent to false for performance tests
Bug: webrtc:13899
Change-Id: Icde80af02070e024c1292721db9c0b8a4d906343
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258685
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36531}
2022-04-12 10:43:05 +00:00
Jeremy Leconte
f5fd25ca04
Remove duplicate gn_isolate_map.pyl
...
The other one is in the //infra/specs folder.
Bug: webrtc:13899
Change-Id: Idbf3c888b60741aa8a35d25bd3b7deb4f1a81a95
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258682
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36525}
2022-04-11 15:53:08 +00:00
Jeremy Leconte
ac5cf78801
Add mb.py to pylint check of the root PRESUBMIT.py.
...
This now possible because of https://webrtc-review.googlesource.com/c/src/+/256972
Bug: webrtc:13605
Change-Id: Ie5c058c5ff459dde05c90f757a1df8bd53f35ccc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257281
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Christoffer Jansson <jansson@google.com>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36390}
2022-03-31 10:24:02 +00:00
Jeremy Leconte
81635f33ef
Make tools_webrtc/mb inherit from tools/mb (3rd attempt).
...
Previous attempts:
https://webrtc-review.googlesource.com/c/src/+/256809
https://webrtc-review.googlesource.com/c/src/+/256970
Bug: webrtc:13867
Change-Id: I5dc268b711dc17016a5d673f2b3ec733c9cff4f2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256972
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36367}
2022-03-29 12:07:30 +00:00
Jeremy Leconte
bddfa1d9de
Prepare the code to inherit from chromium's mb.py (3rd attempt).
...
Basically try to make low_bandwidth_audio_perf_test target work with chromium's mb.
Bug: webrtc:13867
Change-Id: If111e2b0f4f82935062d6321f4d16cc72c77d572
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256975
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36364}
2022-03-29 10:11:51 +00:00
Jeremy Leconte
137173c296
Revert "Reland "Make tools_webrtc/mb inherit from tools/mb.""
...
This reverts commit aa0d4061ba
.
Reason for revert: All green except for the android bots compiling low_bandwidth_audio_perf_test.
https://ci.chromium.org/ui/p/webrtc/builders/ci/Android32%20Builder%20arm/12133/overview
Original change's description:
> Reland "Make tools_webrtc/mb inherit from tools/mb."
>
> This is a reland of commit 7a324b977c
>
> Original change's description:
> > Make tools_webrtc/mb inherit from tools/mb.
> >
> > Bug: webrtc:13867
> > Change-Id: I33e998d260454d16120b09fedecf0c25d2654611
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256809
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > Commit-Queue: Jeremy Leconte <jleconte@google.com>
> > Cr-Commit-Position: refs/heads/main@{#36347}
>
> Bug: webrtc:13867
> Change-Id: I8fe4424771876ea725f5c9a3c5d13b2f6ad83917
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256970
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Jeremy Leconte <jleconte@google.com>
> Cr-Commit-Position: refs/heads/main@{#36361}
Bug: webrtc:13867
Change-Id: I69948eb028a57b915feba1037e71e82e2d8bc7c7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256971
Auto-Submit: Jeremy Leconte <jleconte@google.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36362}
2022-03-29 07:14:04 +00:00
Jeremy Leconte
aa0d4061ba
Reland "Make tools_webrtc/mb inherit from tools/mb."
...
This is a reland of commit 7a324b977c
Original change's description:
> Make tools_webrtc/mb inherit from tools/mb.
>
> Bug: webrtc:13867
> Change-Id: I33e998d260454d16120b09fedecf0c25d2654611
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256809
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Jeremy Leconte <jleconte@google.com>
> Cr-Commit-Position: refs/heads/main@{#36347}
Bug: webrtc:13867
Change-Id: I8fe4424771876ea725f5c9a3c5d13b2f6ad83917
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256970
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36361}
2022-03-29 07:02:40 +00:00
Jeremy Leconte
145ff4cc45
Prepare the code to inherit from chromium's mb.py.
...
* Don't use 'script' type because it's breaking mb gen.
* Simplify 'raw' type command generation.
Bug: webrtc:13867
Change-Id: I68486c5010c84e41297daafdf11ab63bbca58d4b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256862
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36351}
2022-03-28 09:52:30 +00:00
Jeremy Leconte
ad3f490946
Revert "Make tools_webrtc/mb inherit from tools/mb."
...
This reverts commit 7a324b977c
.
Reason for revert: Some failures like this one:
https://ci.chromium.org/p/webrtc/builders/ci/Linux64%20Builder/12121
Original change's description:
> Make tools_webrtc/mb inherit from tools/mb.
>
> Bug: webrtc:13867
> Change-Id: I33e998d260454d16120b09fedecf0c25d2654611
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256809
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Jeremy Leconte <jleconte@google.com>
> Cr-Commit-Position: refs/heads/main@{#36347}
Bug: webrtc:13867
Change-Id: If11473f31c8c5f365018f464b413220b2730ee7a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256960
Auto-Submit: Jeremy Leconte <jleconte@google.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36348}
2022-03-28 07:22:50 +00:00
Jeremy Leconte
7a324b977c
Make tools_webrtc/mb inherit from tools/mb.
...
Bug: webrtc:13867
Change-Id: I33e998d260454d16120b09fedecf0c25d2654611
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256809
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36347}
2022-03-28 07:10:00 +00:00
Jeremy Leconte
d8654cf636
Prepare the code to inherit from chromium's mb.py.
...
Type 'additional_compile_target' are not meant to be tests.
Type 'raw' has no usage for xctests.
Explicitly set dcheck_always_on=false.
Bug: webrtc:13867
Change-Id: Ie47c300609ff5054d36110e8ee6c7a059ec452da
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256805
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36336}
2022-03-25 13:01:24 +00:00
Jeremy Leconte
3f82d02742
mb: decode process output for Python3
...
CL from chromium's mb:
https://chromium-review.googlesource.com/c/chromium/src/+/3321055
Bug: webrtc:13839
Change-Id: Ie90eceaff8c824aa23bc27149dc88b9ac4cd1936
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256006
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36244}
2022-03-18 07:53:01 +00:00
Jeremy Leconte
a5f3c20f2d
Fix warning 'Build argument has no effect: ios_build_chrome'.
...
Same warning for ios_use_goma_rbe.
https://logs.chromium.org/logs/webrtc/buildbucket/cr-buildbucket/8820359174215951313/+/u/generate_build_files/stdout
Bug: webrtc:13556
Change-Id: I5342644d1f620d293a9a7f541ac59803dedf4d67
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253840
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36142}
2022-03-07 13:02:53 +00:00
Jeremy Leconte
d15f3e1220
Prepare the code to run ios tests with the standalone recipe.
...
The flags isolated-script-test-output and isolated-script-test-perf-output need to be consumed by the tests.
The generated .app folder in added in the data list of the gni file.
This will make it available in the runtime_deps file and thus will be populated to the swarming tasks.
Bug: webrtc:13556
Change-Id: I2c75774b847d9f686c3abc00ba0400bbc3fcefae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/240520
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Christoffer Jansson <jansson@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36029}
2022-02-18 12:57:42 +00:00
Jeremy Leconte
63472e5aea
Replace dump_json_test_results flag by isolated-script-test-output.
...
This is because it's the default flag used in the recipes to dump a json output.
This CL also fixes some python3 lint issues in mb.py.
Bug: webrtc:13594
Change-Id: I9275b5da0963f801d3191703c2eb72d90befb5d7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/248142
Reviewed-by: Christoffer Jansson <jansson@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#35986}
2022-02-14 08:55:01 +00:00
Christoffer Jansson
4e8a773b4b
tools_webrtc dir converted to py3 + top level PRESUBMIT script
...
Bug: webrtc:13607
Change-Id: Ib018e43ea977cc24dd71048e68e3343741f7f31b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249083
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#35953}
2022-02-08 14:42:26 +00:00
Christoffer Jansson
a4290a7909
add m1 try bots
...
Any Mac builder should be able to compile ARM64 builds when using target_cpu=arm64
Bug: chromium:1238267
Change-Id: I72dac3b6f170f09d5c158ec11650e0cff7b9e638
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249790
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#35838}
2022-01-31 08:28:29 +00:00
Mirko Bonadei
5d9ae8635c
Switch Swarming commands to py3.
...
Thanks to machenbach@ for the heads up.
WebRTC's MB was generating a Swarming command that was using vpython
(defaulting on python2 on some platforms). This CL switches that to
vpython3 (fixing gtest-parallel-wrapper.py to be python3 compliant).
No-Presubmit: True
Bug: webrtc:13607
Change-Id: Icfa7d23b81e30cebfe8243d4ba65284955593465
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249604
Reviewed-by: Christoffer Jansson <jansson@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35821}
2022-01-28 08:17:05 +00:00
Christoffer Jansson
cf00059db6
Remove Win8
...
Bug: chromium:1281336
Change-Id: I490ec704d8f006301ab41dc3380983075032285e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245483
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#35656}
2022-01-11 10:27:54 +00:00
Jeremy Leconte
67b0a4476b
Remove perf test isac_fix_test.
...
Bug: b/210641670
Change-Id: If562d1b2aa3486a51efffb4dec471ed7064c5261
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/241360
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#35533}
2021-12-14 16:52:58 +00:00
Jeremy Leconte
f22c78b01a
Fix mb.py presubmit issues.
...
* Add a config file for python formatting (.style.yapf).
* Change the default indentation from 4 spaces to 2 spaces.
* Run 'git cl format --python' on a few python files.
Bug: webrtc:13413
Change-Id: Ia71135131276c2c499b00032d57ad16ee5200a5c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/238982
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Christoffer Jansson <jansson@google.com>
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#35500}
2021-12-08 08:53:00 +00:00
Jeremy Leconte
a2e3d80cf6
Revert "Reland "Use gtest_parallel with 1 worker for webrtc_perf_tests.""
...
This reverts commit c31fc2a941
.
Reason for revert: Fix is not working properly.
Original change's description:
> Reland "Use gtest_parallel with 1 worker for webrtc_perf_tests."
>
> This is a reland of 258ed1a38a
>
> Original change's description:
> > Use gtest_parallel with 1 worker for webrtc_perf_tests.
> >
> > This will enable test results to be uploaded to ResultDB.
> >
> > Bug: b/197492097
> > Change-Id: Iec28520c4cd8f35fcff2cbd105a4b851ef41b9fc
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239641
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > Reviewed-by: Christoffer Jansson <jansson@google.com>
> > Commit-Queue: Jeremy Leconte <jleconte@google.com>
> > Cr-Commit-Position: refs/heads/main@{#35458}
>
> Bug: b/197492097
> No-Presubmit: True
> Change-Id: Iea90f5698c83791d39c0f6da666c1d1eb274edd3
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239645
> Commit-Queue: Jeremy Leconte <jleconte@google.com>
> Reviewed-by: Andrey Logvin <landrey@webrtc.org>
> Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
> Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org>
> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#35483}
TBR=mbonadei@webrtc.org ,gustaf@webrtc.org,jansson@google.com,jansson@webrtc.org,jakobi@webrtc.org,landrey@webrtc.org,jleconte@google.com,jleconte@webrtc.org,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
Change-Id: Iee9b67db99545a1e6c707bc03faaf55afc90cbbf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/197492097
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/240182
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35486}
2021-12-07 12:04:08 +00:00
Jeremy Leconte
c31fc2a941
Reland "Use gtest_parallel with 1 worker for webrtc_perf_tests."
...
This is a reland of 258ed1a38a
Original change's description:
> Use gtest_parallel with 1 worker for webrtc_perf_tests.
>
> This will enable test results to be uploaded to ResultDB.
>
> Bug: b/197492097
> Change-Id: Iec28520c4cd8f35fcff2cbd105a4b851ef41b9fc
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239641
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Christoffer Jansson <jansson@google.com>
> Commit-Queue: Jeremy Leconte <jleconte@google.com>
> Cr-Commit-Position: refs/heads/main@{#35458}
Bug: b/197492097
No-Presubmit: True
Change-Id: Iea90f5698c83791d39c0f6da666c1d1eb274edd3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239645
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org>
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35483}
2021-12-07 10:08:16 +00:00
Nidhi Jaju
2394977f74
CodeHealth: Python3 migration for tools_webrtc/mb/
...
This CL includes:
* set Pylint to 2.7 in tools_webrtc/mb/PRESUBMIT.py
* fix some style warnings caused by scripts in tools_webrtc/mb/
* pass skip_shebang_check=True within tools_webrtc/mb/PRESUBMIT.py
Bug: chromium:1262287, chromium:1262352
Change-Id: Iae4f111942d724db6a7f4585c97a7c26c1e6ccc0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239660
Commit-Queue: Nidhi Jaju <nidhijaju@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35477}
2021-12-06 12:59:57 +00:00