Commit graph

9 commits

Author SHA1 Message Date
Florent Castelli
523b67d69b Use the condensed library name when fixing "foo:foo" dependencies
The styleguide prefers using condensed library nam "foo" instead of
"foo:foo" whenever possible. The script would address absolute and
relative paths in other directories but not the ones in the current
directory.

Bug: None
Change-Id: Ibc7850cd26edfe8fb864ce5baa2f460a95a7c96d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266489
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37315}
2022-06-23 12:57:39 +00:00
Florent Castelli
81acd03f89 tools: Better dependency fixing
Lines like 'deps = [ "foo" ]' would fail to be fixed.
Just insert the new dependencies in front and let the formatter have fun
with this after.

Bug: None
Change-Id: I747925cd0a1de93715a00b9ff3490b555f237e97
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257906
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36429}
2022-04-04 17:59:58 +00:00
Florent Castelli
48ad72e9eb tools: Fix gn_check_autofix.py with Python3
Bug: None
Change-Id: Ib81f02823cae4a10697566d5889d4814a0184503
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257903
Auto-Submit: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36425}
2022-04-04 13:23:56 +00:00
Christoffer Jansson
3b393ec991 Fixes escaped line breaks
Bug: webrtc:13607
Change-Id: I24c252ecb6d443abb8206e752bdff73ee5084807
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252260
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#36056}
2022-02-23 09:08:30 +00:00
Christoffer Jansson
4e8a773b4b tools_webrtc dir converted to py3 + top level PRESUBMIT script
Bug: webrtc:13607
Change-Id: Ib018e43ea977cc24dd71048e68e3343741f7f31b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249083
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#35953}
2022-02-08 14:42:26 +00:00
Mirko Bonadei
8cc6695652 Reformat python files checked by pylint (part 1/2).
After recently changing .pylintrc (see [1]) we discovered that
the presubmit check always checks all the python files when just
one python file gets updated.

This CL moves all these files one step closer to what the linter
wants.

Autogenerated with:

# Added all the files under pylint control to ~/Desktop/to-reformat
cat ~/Desktop/to-reformat | xargs sed -i '1i\\'
git cl format --python --full

This is part 1 out of 2. The second part will fix function names and
will not be automated.

[1] - https://webrtc-review.googlesource.com/c/src/+/186664

No-Presubmit: True
Bug: webrtc:12114
Change-Id: Idfec4d759f209a2090440d0af2413a1ddc01b841
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/190980
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32530}
2020-10-30 10:13:11 +00:00
Sebastian Jansson
82a5100eb5 Replacing /target:target with /target in BUILD autofix.
Bug: webrtc:9883
Change-Id: I8aac57f6223548965078e104fff1f3da44092669
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/155580
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29379}
2019-10-04 10:07:42 +00:00
Yves Gerey
14dfe7f288 [GN] Fix dependency rebasing in BUILD.gn files.
This CL ensures we properly points to deps shared with chromium,
e.g. '//third_party/abseil-cpp...' and not '../third_party/abseil-cpp...'

NB: This is only applied to dependencies which were missing,
    and doesn't fix existing ones.

Bug: webrtc:10037
Change-Id: If4bbb00df39401c65def9d56e36e5feb5d67b9dd
Reviewed-on: https://webrtc-review.googlesource.com/c/111600
Commit-Queue: Yves Gerey <yvesg@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25762}
2018-11-22 17:21:42 +00:00
Henrik Kjellander
90fd7d84fd Rename tools-webrtc -> tools_webrtc
This aligns with established naming convention for all
other directories.

BUG=webrtc:7593
NOTRY=True
NOTREECHECKS=True
R=ehmaldonado@webrtc.org, mbonadei@webrtc.org
TBR=henrika@webrtc.org

Review-Url: https://codereview.webrtc.org/2864213004 .
Cr-Commit-Position: refs/heads/master@{#18059}
2017-05-09 06:30:13 +00:00
Renamed from tools-webrtc/gn_check_autofix.py (Browse further)