Commit graph

26 commits

Author SHA1 Message Date
Artem Titov
4e199e9f08 Mark DirectTransport subclasses ctors as deprecated and switch from them
Bug: webrtc:9630
Change-Id: I6e7bf898fd95ef76758458e759d9f9aa381f89e1
Reviewed-on: https://webrtc-review.googlesource.com/94843
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24345}
2018-08-20 12:05:05 +00:00
Artem Titov
46c4e60939 Introduce SimulatedNetworkReceiverInterface.
Introduce SimulatedNetworkReceiverInterface and switch DirectTransport
on this interface. Also switch part of related users on
DefaultNetworkSimulationConfig.

This two changes united into single CL to prevent work duplication.
Most changes were done because of stop including fake_network_pipe.h
into direct_transport.h, so splitting this into 2 CLs will require
first fix all imports of fake_network_pipe.h and then replace them
on new API imports again.

Bug: webrtc:9630
Change-Id: I87d4a6ff1bab72d04a9871a40441f4fbe028f4e6
Reviewed-on: https://webrtc-review.googlesource.com/94762
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24336}
2018-08-20 07:23:41 +00:00
Karl Wiberg
918f50c5d1 Use absl::make_unique and absl::WrapUnique directly
Instead of going through our wrappers in ptr_util.h.

This CL was generated by the following script:

  git grep -l ptr_util | xargs perl -pi -e 's,#include "rtc_base/ptr_util.h",#include "absl/memory/memory.h",'
  git grep -l MakeUnique | xargs perl -pi -e 's,\b(rtc::)?MakeUnique\b,absl::make_unique,g'
  git grep -l WrapUnique | xargs perl -pi -e 's,\b(rtc::)?WrapUnique\b,absl::WrapUnique,g'
  git checkout -- rtc_base/ptr_util{.h,_unittest.cc}
  git cl format

Followed by manually adding dependencies on
//third_party/abseil-cpp/absl/memory until `gn check` stopped
complaining.

Bug: webrtc:9473
Change-Id: I89ccd363f070479b8c431eb2c3d404a46eaacc1c
Reviewed-on: https://webrtc-review.googlesource.com/86600
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23850}
2018-07-05 10:59:49 +00:00
Yves Gerey
665174fdbb Reformat the WebRTC code base
Running clang-format with chromium's style guide.

The goal is n-fold:
 * providing consistency and readability (that's what code guidelines are for)
 * preventing noise with presubmit checks and git cl format
 * building on the previous point: making it easier to automatically fix format issues
 * you name it

Please consider using git-hyper-blame to ignore this commit.

Bug: webrtc:9340
Change-Id: I694567c4cdf8cee2860958cfe82bfaf25848bb87
Reviewed-on: https://webrtc-review.googlesource.com/81185
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23660}
2018-06-19 14:00:39 +00:00
Edward Lesmes
9599fd4414 Make num-retries default a string.
TBR=phoglund@webrtc.org

Bug: chromium:755660
Change-Id: I770a79a78721a312b603aec40d23689245a48001
Reviewed-on: https://webrtc-review.googlesource.com/61343
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22392}
2018-03-12 21:19:51 +00:00
Edward Lesmes
5b9c6840b1 Add num-retries flag to Android perf tests.
Add a flag to Android perf tests, so we can specify the number of
retries.

Bug: chromium:755660
Change-Id: Ic498373421b7e0fdf779a4659a0c79d47a59fbde
Reviewed-on: https://webrtc-review.googlesource.com/61103
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22390}
2018-03-12 19:51:09 +00:00
Artem Titov
3faa832247 Separate test/fake_audio_device on API and implementation. Step 2.
Switch WebRTC internal usage of FakeAudioDevice on TestAudioDeviceModule.

Bug: webrtc:8946
Change-Id: I96b8b5d3b475d2197662e9007f836bd71f8ed04d
Reviewed-on: https://webrtc-review.googlesource.com/60521
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22388}
2018-03-12 16:14:39 +00:00
Artem Titov
6723cdc8a4 Revert "Separate test/fake_audio_device on API and implementation."
This reverts commit 8ea5f9ae5b.

Reason for revert: breaks downstream project

Original change's description:
> Separate test/fake_audio_device on API and implementation.
> 
> Adding ability of injecting audio in end to end tests, that are using
> WebRTC. For this purpose as a 1st step test/fake_audio_device will
> be moved to production part of WebRTC source code and renamed to
> test_audio_device_module. Old header is replaced with alias to the
> new one and will be deleted after a while.
> 
> Change-Id: I5284d1dd46ce9bf86cf43268e855520606fa8c5c
> 
> Bug: webrtc:8946
> Change-Id: I5284d1dd46ce9bf86cf43268e855520606fa8c5c
> Reviewed-on: https://webrtc-review.googlesource.com/58086
> Commit-Queue: Artem Titov <titovartem@webrtc.org>
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#22289}

TBR=kwiberg@webrtc.org,titovartem@webrtc.org

Change-Id: I88d9c4f09cc576ed7c9182dcf0a873d25a8bab54
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:8946
Reviewed-on: https://webrtc-review.googlesource.com/59720
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22291}
2018-03-05 15:36:23 +00:00
Artem Titov
8ea5f9ae5b Separate test/fake_audio_device on API and implementation.
Adding ability of injecting audio in end to end tests, that are using
WebRTC. For this purpose as a 1st step test/fake_audio_device will
be moved to production part of WebRTC source code and renamed to
test_audio_device_module. Old header is replaced with alias to the
new one and will be deleted after a while.

Change-Id: I5284d1dd46ce9bf86cf43268e855520606fa8c5c

Bug: webrtc:8946
Change-Id: I5284d1dd46ce9bf86cf43268e855520606fa8c5c
Reviewed-on: https://webrtc-review.googlesource.com/58086
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22289}
2018-03-05 14:30:42 +00:00
Edward Lemur
ed7b4ff9e3 Use isolated-script-test-perf-output on low_bandwidth_audio_test.
Instead of chartjson-result-file, since that's the flag passed by the recipe.

TBR=phoglund@webrtc.org

Bug: chromium:807737
Change-Id: I3a679ab7e5c0a446e675d0f4647344cc4194b357
Reviewed-on: https://webrtc-review.googlesource.com/46541
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21858}
2018-02-01 20:35:24 +00:00
Edward Lemur
d8b041cc54 Ignore extra arguments in low_bandwidth_audio_test.
R=phoglund@webrtc.org
TBR=solenberg@webrtc.org

Bug: chromium:755660
Change-Id: I39488f6905875bdc08b006619b972d3f1af2fce1
Reviewed-on: https://webrtc-review.googlesource.com/39924
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21641}
2018-01-16 14:07:54 +00:00
Edward Lemur
b4017712c5 Store JSON perf results for low_bandwidth_audio_test.
Bug: chromium:755660
Change-Id: I87c19f8dde14772e75f93c723f11408702ca8c8e
Reviewed-on: https://webrtc-review.googlesource.com/39515
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21615}
2018-01-15 15:24:09 +00:00
Ivo Creusen
56d460902e Use the new AudioProcessing statistics everywhere.
The new interface uses optionals instead of default values, and only values that are actually used are included. To make it easy to add/remove stats in the future, the struct itself is copied around on all layers, instead of copying the values one by one. This CL also fixes a bug which caused several APM statistics to get stuck at a fixed level when there are no more receive streams (after some period where there were receive streams). Since APM doesn't know this happens, an argument was added to the GetStats call to pass this information down to APM.

Bug: webrtc:8563, b/67926135
Change-Id: I96cc008353355bb520c4523f5c5379860f73ee24
Reviewed-on: https://webrtc-review.googlesource.com/25621
Commit-Queue: Ivo Creusen <ivoc@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20877}
2017-11-24 18:17:39 +00:00
Karl Wiberg
e40468ba3d Move some numeric utility code from rtc_base/ to rtc_base/numerics/
Specifically, I'm moving

  safe_compare.h
  safe_conversions.h
  safe_minmax.h

They shouldn't be part of the API, and moving them to an appropriate
subdirectory of rtc_base/ is a good way to keep track of that.

BUG=webrtc:8445

Change-Id: I458531aeb30bcf4291c4bec3bf22a2fffbf054ff
Reviewed-on: https://webrtc-review.googlesource.com/20860
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20829}
2017-11-22 11:21:47 +00:00
Oskar Sundbom
2707fb2782 Optional: Use nullopt and implicit construction in /audio
Changes places where we explicitly construct an Optional to instead use
nullopt or the requisite value type only.

This CL was uploaded by git cl split.

R=solenberg@webrtc.org

Bug: None
Change-Id: I03562600978bdedb9dc93a34aeb0561c66f54aae
Reviewed-on: https://webrtc-review.googlesource.com/23617
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org>
Commit-Queue: Oskar Sundbom <ossu@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20731}
2017-11-17 15:56:17 +00:00
Edward Lemur
88b23f6662 Fix flag name in low_bandwidth_audio_test.py
TBR=kjellander@webrtc.org, oprypin@webrtc.org

No-Try: true
Bug: chromium:755660
Change-Id: I6bf5dda5374cae16da54aa10e77b136c638e1975
Reviewed-on: https://webrtc-review.googlesource.com/6442
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20148}
2017-10-04 17:26:14 +00:00
Edward Lemur
7e3b5697d9 Ignore swarming arguments in low_bandwidth_audio_test.py
Needed because swarming adds --isolated-script-test-output and --isolated-script-test-perf-output

See for example:
https://chromium-swarm.appspot.com/task?id=39006c763bebf710

No-Try: true
Bug: chromium:755660
Change-Id: Iff9fb3441200f760c511a67211fbc4a1272717b4
Reviewed-on: https://webrtc-review.googlesource.com/6362
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20146}
2017-10-04 16:19:44 +00:00
Edward Lemur
b0250f0504 Reland "Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script."
This is a reland of f4898a6509
Original change's description:
> Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script.
> 
> They should've been downloaded already.
> 
> NOTRY=True
> 
> Bug: chromium:755660
> Change-Id: I8ecb355f06026a38bd9377633e2be6c55d7c6452
> Reviewed-on: https://webrtc-review.googlesource.com/5620
> Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
> Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#20109}

No-Try: true
Bug: chromium:755660
Change-Id: I391130545eee5d4928101f87ac4a4e0945d665a1
Reviewed-on: https://webrtc-review.googlesource.com/6380
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20140}
2017-10-04 13:03:24 +00:00
Edward Lemur
45a0b36d3f Revert "Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script."
Reason for revert: Breaks windows bot.
https://build.chromium.org/p/client.webrtc.perf/builders/Win7/builds/3804

TBR=kjellander@webrtc.org,phoglund@webrtc.org,ehmaldonado@webrtc.org,oprypin@webrtc.org

Change-Id: I0f2221b66c4f7dcf0a6f03004e5acc24c77ba8b0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:755660
Reviewed-on: https://webrtc-review.googlesource.com/6001
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20117}
2017-10-03 14:00:15 +00:00
Edward Lemur
f4898a6509 Reland "Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script."
This reverts commit bb1222f3ad.

Reason for revert: Fixing

Original change's description:
> Revert "Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script."
> 
> This reverts commit 2019698455.
> 
> Reason for revert: Fails on Mac
> https://build.chromium.org/p/client.webrtc.perf/builders/Mac%2010.11/builds/4070
> 
> Original change's description:
> > Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script.
> > 
> > They should've been downloaded already.
> > 
> > NOTRY=True
> > 
> > Bug: chromium:755660
> > Change-Id: I8ecb355f06026a38bd9377633e2be6c55d7c6452
> > Reviewed-on: https://webrtc-review.googlesource.com/5620
> > Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
> > Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
> > Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#20109}
> 
> TBR=kjellander@webrtc.org,phoglund@webrtc.org,ehmaldonado@webrtc.org,oprypin@webrtc.org
> 
> Change-Id: I0cfc1d0b398587a023af528536e7d995c6de1413
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:755660
> Reviewed-on: https://webrtc-review.googlesource.com/5940
> Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
> Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#20112}

No-Try: true
Bug: chromium:755660
Change-Id: Idbf30003c78c4093afcaf99dc0c5bb3468cdcf6d
Reviewed-on: https://webrtc-review.googlesource.com/5941
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20113}
2017-10-03 12:49:51 +00:00
Edward Lemur
bb1222f3ad Revert "Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script."
This reverts commit 2019698455.

Reason for revert: Fails on Mac
https://build.chromium.org/p/client.webrtc.perf/builders/Mac%2010.11/builds/4070

Original change's description:
> Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script.
> 
> They should've been downloaded already.
> 
> NOTRY=True
> 
> Bug: chromium:755660
> Change-Id: I8ecb355f06026a38bd9377633e2be6c55d7c6452
> Reviewed-on: https://webrtc-review.googlesource.com/5620
> Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
> Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#20109}

TBR=kjellander@webrtc.org,phoglund@webrtc.org,ehmaldonado@webrtc.org,oprypin@webrtc.org

Change-Id: I0cfc1d0b398587a023af528536e7d995c6de1413
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:755660
Reviewed-on: https://webrtc-review.googlesource.com/5940
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20112}
2017-10-03 12:33:52 +00:00
Edward Lemur
2019698455 Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script.
They should've been downloaded already.

NOTRY=True

Bug: chromium:755660
Change-Id: I8ecb355f06026a38bd9377633e2be6c55d7c6452
Reviewed-on: https://webrtc-review.googlesource.com/5620
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20109}
2017-10-03 11:25:10 +00:00
solenberg
4652e86c0c Disable flaky AudioStats.NoLoss test.
BUG=none

Review-Url: https://codereview.webrtc.org/3013783002
Cr-Commit-Position: refs/heads/master@{#19928}
2017-09-22 13:07:56 +00:00
Henrik Kjellander
5a6aa4f05d Fix path to root in low_bandwidth_audio_test.py
BUG=chromium:611808
TBR=solenberg@webrtc.org
NOTRY=True
NOPRESUBMIT=True
NOTREECHECKS=True

Change-Id: Iba2b0851ee99916b9809231b4b27046315fd8565
Reviewed-on: https://webrtc-review.googlesource.com/1569
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19849}
2017-09-15 08:29:11 +00:00
Mirko Bonadei
92ea95e34a Fixing WebRTC after moving from src/webrtc to src/
In https://webrtc-review.googlesource.com/c/src/+/1560 we moved WebRTC
from src/webrtc to src/ (in order to preserve an healthy git history).
This CL takes care of fixing header guards, #include paths, etc...

NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=tommi@webrtc.org


Bug: chromium:611808
Change-Id: Iea91618212bee0af16aa3f05071eab8f93706578
Reviewed-on: https://webrtc-review.googlesource.com/1561
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19846}
2017-09-15 05:02:56 +00:00
Mirko Bonadei
bb547203bf Moving src/webrtc into src/.
In order to eliminate the WebRTC Subtree mirror in Chromium, 
WebRTC is moving the content of the src/webrtc directory up
to the src/ directory.

NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=tommi@webrtc.org

Bug: chromium:611808
Change-Id: Iac59c5b51b950f174119565bac87955a7994bc38
Reviewed-on: https://webrtc-review.googlesource.com/1560
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19845}
2017-09-15 04:25:06 +00:00