http://crrev.com/9f8b8eb2 introduced deps conditional on a variable,
we don't need to support this, so we just continue when we encounter
a dict.
NOTRY=True
Bug: None
Change-Id: I9ce22cbfd1b3ae02b4a48c9c8312a08a904f9291
Reviewed-on: https://webrtc-review.googlesource.com/2688
Reviewed-by: Charu Jain <charujain@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19930}
Even with the right credentials in place, git-cl will default to
using autogenerated GCE credentials when on a GCE machine. Tell
it to use the appropriate .gitcookies every time.
TBR=ehmaldonado@webrtc.org, kjellander@webrtc.org
NOTRY=True
Bug: chromium:765231
Change-Id: I761db91dde7db0c945e50e961c5687c835602dc4
Reviewed-on: https://webrtc-review.googlesource.com/1700
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19879}
In https://webrtc-review.googlesource.com/c/src/+/1560 we moved WebRTC
from src/webrtc to src/ (in order to preserve an healthy git history).
This CL takes care of fixing header guards, #include paths, etc...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=tommi@webrtc.org
Bug: chromium:611808
Change-Id: Iea91618212bee0af16aa3f05071eab8f93706578
Reviewed-on: https://webrtc-review.googlesource.com/1561
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19846}
Rietveld has been having problems since the migration.
NOTRY=True
Bug: chromium:738330
Change-Id: I54538eee9f5734fac731702fb592580afcae3fae
Reviewed-on: https://webrtc-review.googlesource.com/1231
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19834}
Submitting this no_op change using chromium account to test changes related to non-googler and update last reviewed revision
BUG=None
TBR=kjellander@google.com
NOTRY=True
Review-Url: https://codereview.webrtc.org/3012023002
Cr-Commit-Position: refs/heads/master@{#19724}
This is done to make UBSan testing more convenient in integration with projects using WebRTC
Some blacklist entries were obsolete so don't need a replacement
Also fix one of the warnings (thanks, kwiberg@)
BUG=webrtc:8189, webrtc:5486, webrtc:5491
Review-Url: https://codereview.webrtc.org/3009123002
Cr-Commit-Position: refs/heads/master@{#19682}
The warnings were (all signed integer overflow):
webrtc/common_audio/signal_processing/levinson_durbin.c:46:25
12 * 268435456 cannot be represented in type 'int'
webrtc/modules/audio_processing/aecm/aecm_core.cc:930:69
522240 * 6115 cannot be represented in type 'int'
webrtc/modules/audio_processing/aecm/aecm_core_c.cc:455:36
72293096 * 50 cannot be represented in type 'int'
webrtc/modules/pacing/alr_detector.cc:70:48
1000000000 * 65 cannot be represented in type 'int'
webrtc/modules/rtp_rtcp/source/rtp_sender.cc:947:20
1929277286 + 321546521 cannot be represented in type 'int'
BUG=webrtc:8195
Review-Url: https://codereview.webrtc.org/3005003002
Cr-Commit-Position: refs/heads/master@{#19670}
Instead explicitly ignore only the flags we know should be ignored.
BUG=webrtc:7568
Review-Url: https://codereview.webrtc.org/2968003003
Cr-Commit-Position: refs/heads/master@{#19412}
Reason for revert:
The credentials for the linux_internal bot are fixed now.
Original issue's description:
> Reland of move linux_internal from the autoroller CQ. (patchset #1 id:1 of https://codereview.webrtc.org/2990233002/ )
>
> Reason for revert:
> linux_internal buildbucket is broken
>
> Original issue's description:
> > Revert of Remove linux_internal from the autoroller CQ. (patchset #1 id:1 of https://codereview.webrtc.org/2985933002/ )
> >
> > Reason for revert:
> > linux_internal now checks that the CL is authored by a googler before executing the tests
> >
> > Original issue's description:
> > > Remove linux_internal from the autoroller CQ.
> > >
> > > The CQ no longer has permission to schedule builds in linux_internal.
> > >
> > > NOTRY=True
> > > TBR=kjellander@webrtc.org
> > > BUG=None
> > >
> > > Review-Url: https://codereview.webrtc.org/2985933002
> > > Cr-Commit-Position: refs/heads/master@{#19178}
> > > Committed: 5ba9730265
> >
> > TBR=mbonadei@webrtc.org,kjellander@webrtc.org,nodir@chromium.org
> > BUG=None
> > NOTRY=True
> >
> > Review-Url: https://codereview.webrtc.org/2990233002
> > Cr-Commit-Position: refs/heads/master@{#19240}
> > Committed: 367aaa7ca5
>
> TBR=mbonadei@webrtc.org,kjellander@webrtc.org,nodir@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=None
>
> Review-Url: https://codereview.webrtc.org/2997523002
> Cr-Commit-Position: refs/heads/master@{#19260}
> Committed: 81cf5bbff9TBR=mbonadei@webrtc.org,kjellander@webrtc.org,nodir@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=None
Review-Url: https://codereview.webrtc.org/3001523002
Cr-Commit-Position: refs/heads/master@{#19312}
Reason for revert:
linux_internal buildbucket is broken
Original issue's description:
> Revert of Remove linux_internal from the autoroller CQ. (patchset #1 id:1 of https://codereview.webrtc.org/2985933002/ )
>
> Reason for revert:
> linux_internal now checks that the CL is authored by a googler before executing the tests
>
> Original issue's description:
> > Remove linux_internal from the autoroller CQ.
> >
> > The CQ no longer has permission to schedule builds in linux_internal.
> >
> > NOTRY=True
> > TBR=kjellander@webrtc.org
> > BUG=None
> >
> > Review-Url: https://codereview.webrtc.org/2985933002
> > Cr-Commit-Position: refs/heads/master@{#19178}
> > Committed: 5ba9730265
>
> TBR=mbonadei@webrtc.org,kjellander@webrtc.org,nodir@chromium.org
> BUG=None
> NOTRY=True
>
> Review-Url: https://codereview.webrtc.org/2990233002
> Cr-Commit-Position: refs/heads/master@{#19240}
> Committed: 367aaa7ca5TBR=mbonadei@webrtc.org,kjellander@webrtc.org,nodir@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=None
Review-Url: https://codereview.webrtc.org/2997523002
Cr-Commit-Position: refs/heads/master@{#19260}
Reason for revert:
linux_internal now checks that the CL is authored by a googler before executing the tests
Original issue's description:
> Remove linux_internal from the autoroller CQ.
>
> The CQ no longer has permission to schedule builds in linux_internal.
>
> NOTRY=True
> TBR=kjellander@webrtc.org
> BUG=None
>
> Review-Url: https://codereview.webrtc.org/2985933002
> Cr-Commit-Position: refs/heads/master@{#19178}
> Committed: 5ba9730265TBR=mbonadei@webrtc.org,kjellander@webrtc.org,nodir@chromium.org
BUG=None
NOTRY=True
Review-Url: https://codereview.webrtc.org/2990233002
Cr-Commit-Position: refs/heads/master@{#19240}
Chromium roll into WebRTC is failing because of a memcheck error.
The tool suggests to add this suppression:
{
<insert_a_suppression_name_here>
Memcheck:Uninitialized
fun:vfprintf
fun:vsnprintf
fun:snprintf
fun:_ZN7testing9internal220PrintBytesInObjectToEPKhmPSo
fun:_ZN7testing8internal14Default...
fun:_ZN7testing8internal20MatchPrint...
fun:_ZNK7testing8internal29Predicate...
}
This CL tries to remove some duplication using a more generic pattern.
BUG=webrtc:6773
NOTRY=True
Review-Url: https://codereview.webrtc.org/2991643002
Cr-Commit-Position: refs/heads/master@{#19132}
This broke WebRTC's presubmit
e79ddeaabf%5E%21/
GClientKeywords has been removed and replaced with a more direct substitution.
BUG=None
NOTRY=True
Review-Url: https://codereview.webrtc.org/2989603002
Cr-Commit-Position: refs/heads/master@{#19126}
It doesn't work when '--' is not part of the command line.
It executed "gtest-parallel gtest-parallel-wrapper.py executable_name"
instead of "gtets-parallel executable_name".
NOTRY=True
TBR=kjellander@webrtc.org
BUG=None
Review-Url: https://codereview.webrtc.org/2982133002
Cr-Commit-Position: refs/heads/master@{#19077}
I'm unsure what caused this to start occurring, but I don't believe it's
webrtc's fault, so I'm adding a suppression for now.
BUG=webrtc:7973
TBR=kjellander@webrtc.org
NOTRY=true
Review-Url: https://codereview.webrtc.org/2977723003
Cr-Commit-Position: refs/heads/master@{#18981}
Leaving compatibility script in webrtc/tools/compare_videos.py to
avoid breaking our video quality tests in Chromium.
Forwarding GN targets are left in webrtc/tools/BUILD.gn.
BUG=webrtc:7855
NOTRY=True
NOPRESUBMIT=True
Review-Url: https://codereview.webrtc.org/2965593002
Cr-Commit-Position: refs/heads/master@{#18848}
This failed on the Memcheck bot due to different stack signature.
Widening the suppression should fix that.
BUG=webrtc:5988
TBR=pthatcher@webrtc.org
Change-Id: Ia448d0f157d650e3ab6d4b02b3acbac91c62d1cd
Reviewed-on: https://chromium-review.googlesource.com/553377
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18818}
This is needed after 6776518bea
It wasn't detected since it was a build-only change,
the TSan trybot wasn't run.
BUG=webrtc:7634
NOTRY=True
TBR=kwiberg@webrtc.org
Change-Id: Idb8e71bc302349a55b729174e01c4824f707a8d7
Reviewed-on: https://chromium-review.googlesource.com/553358
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18817}
A seen in https://codereview.webrtc.org/2956153004/ the CQ
is picky about the ending ;, so this CL removes it.
BUG=None
TBR=ehmaldonado@webrtc.org
NOTRY=True
Change-Id: I5e6359f0966f171c98225a982da042cc7147f765
Reviewed-on: https://chromium-review.googlesource.com/552138
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18807}
This will make this bot be triggered for autoroll CLs.
BUG=None.
TBR=ehmaldonado@webrtc.org
NOTRY=True
Change-Id: I6d8920a4c10a5dee36e5cb93a1e3cb6e3a2ed7ae
Reviewed-on: https://chromium-review.googlesource.com/551717
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18798}
Tests that still need to be enabled:
* apprtcmobile_tests
* audio_decoder_unittests
* rtc_media_unittests
* rtc_unittests
* webrtc_nonparallel_tests
Bug: webrtc:7155
Change-Id: Ic3bc91224dff8b32dc71e356a4ba04b386c92a0f
Reviewed-on: https://chromium-review.googlesource.com/541368
Commit-Queue: Oleh Prypin <oprypin@chromium.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18775}
Update the name of the trybot as well.
BUG=webrtc:7853
NOTRY=True
TBR=ehmaldonado@webrtc.org
Change-Id: I296ee78b0a61b5a335e3bb794cbec72d85c15970
Reviewed-on: https://chromium-review.googlesource.com/547955
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18751}
This makes it possible to enable GCC compilation in our
main waterfall.
BUG=webrtc:7853
NOTRY=True
Change-Id: I99075c6f582e9b471eb7a4a2ea709bac67ceba86
Reviewed-on: https://chromium-review.googlesource.com/544998
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18721}
This fixes a bug where the generated license for the framework was missing all third party dependencies.
Bug: None
Change-Id: I81331f7f4d32e3302ce6ce0430272904820ce6d6
Reviewed-on: https://chromium-review.googlesource.com/530689
Commit-Queue: Kári Tristan Helgason <kthelgason@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18556}
After landing https://chromium-review.googlesource.com/528173
only one test needs to be disabled: VirtualSocketServerTest.delay_v4
BUG=webrtc:7727
NOTRY=True
TESTED=gn gen out/x64-Debug --args='target_os="ios" ios_enable_code_signing=false is_component_build=false target_cpu="x64"'
ninja -C out/x64-Debug webrtc_nonparallel_tests
out/x64-Debug/iossim -d "iPhone 6s" -s 10.3 out/x64-Debug/webrtc_nonparallel_tests.app
Review-Url: https://codereview.webrtc.org/2909073002
Cr-Commit-Position: refs/heads/master@{#18519}
Reason for revert:
According to crbug.com/726706 this is now fixed so let's give it a try.
Original issue's description:
> Disable Goma for Linux32 (ARM) bots.
>
> This config is having issues to build reliably on Goma.
>
> BUG=chromium:726706
> TBR=mbonadei@webrtc.org
>
> Review-Url: https://codereview.webrtc.org/2911893002 .
> Cr-Commit-Position: refs/heads/master@{#18295}
> Committed: 3a343ad329TBR=mbonadei@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:726706
Review-Url: https://codereview.webrtc.org/2910963002
Cr-Commit-Position: refs/heads/master@{#18299}
Identical to Chromium's code search builders with the exception
that is_component_build=true is not set, as it doesn't have any
effect on WebRTC builds.
Adding strip_absolute_paths_from_debug_symbols=true to the
minimal_symbols mixin as recently changed in Chromium.
BUG=chromium:699463
NOTRY=True
Review-Url: https://codereview.webrtc.org/2892723002
Cr-Commit-Position: refs/heads/master@{#18192}
Reason for revert:
This depends on another CL that has been reverted.
Original issue's description:
> Update build_ios_libs.py to new GN target names.
>
> TBR=kjellander@webrtc.org
> NOTRY=true
> BUG=None
>
> Review-Url: https://codereview.webrtc.org/2888903002
> Cr-Commit-Position: refs/heads/master@{#18175}
> Committed: c3f110a1f9
TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None
Review-Url: https://codereview.webrtc.org/2886873007
Cr-Commit-Position: refs/heads/master@{#18183}
This will avoid failing with a non-zero exit code when git commit
fails due to no changes to be rolled.
BUG=None
NOTRY=True
Review-Url: https://codereview.webrtc.org/2883833003
Cr-Commit-Position: refs/heads/master@{#18146}
Since we now have a directory for this kind of checks, let's move this
to that location.
BUG=None
NOTRY=True
Review-Url: https://codereview.webrtc.org/2870393006
Cr-Commit-Position: refs/heads/master@{#18122}
There were too many assumptions of the fact that the check was running
on Linux.
BUG=webrtc:7635
NOTRY=True
Review-Url: https://codereview.webrtc.org/2878733004
Cr-Commit-Position: refs/heads/master@{#18120}
We want to use stable gradle releases for testing.
BUG=webrtc:7608
NOTRY=True
Review-Url: https://codereview.webrtc.org/2877723002
Cr-Commit-Position: refs/heads/master@{#18094}
ios_framework_bundle does not have 'sources' but 'common_objc_headers'
and it was causins a couple of false positives.
BUG=webrtc:7514
NOTRY=True
Review-Url: https://codereview.webrtc.org/2872303003
Cr-Commit-Position: refs/heads/master@{#18084}
We want all .h files to be tracked by a GN target. This CL adds a
presubmit check to ensure that newly added targets are tracked by
GN.
In this CL we add a directory called 'presubmit_checks_lib' so we
can avoid to put everything in PRESUBMIT.py (especially if we want
to test some checks). I tried to use 'tools-webrtc' but it is not
easy to include a python module from a directory with '-' in the
name.
BUG=webrtc:7514
Review-Url: https://codereview.webrtc.org/2872493002
Cr-Commit-Position: refs/heads/master@{#18069}
