Commit graph

22 commits

Author SHA1 Message Date
Mirko Bonadei
bd33ce2620 Reland "Add wrapper to normalize flags."
This is a reland of 642a49d1eb

The change has the same effect but is now implemented through mb, rather than specifying a 'script', so that Android's special handling is not skipped.

Original change's description:
> Add wrapper to normalize flags.
>
> Bug: None
> Change-Id: I9d43602cc66198a29dbc0e7586d948ee76c5ec84
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145204
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#28532}

Bug: webrtc:10616
Change-Id: I60ebd4891dbe8de18c653f8af88181ea966307de
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145409
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28572}
2019-07-16 08:34:58 +00:00
Oleh Prypin
d7e2fb3309 mb: Implement 'quiet' flag in mb lookup
This is a partial port of https://chromium-review.googlesource.com/1576022
Needed because recipes assume the flag exists.

Example error (unnoticed until now because it's silently ignored):
https://logs.chromium.org/logs/webrtc/buildbucket/cr-buildbucket.appspot.com/8911948550157608800/+/steps/lookup_GN_args/0/stdout

Bug: chromium:955062
Change-Id: Id3707903dd5747c13bba05df76f799fb523a6faa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/139248
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28123}
2019-05-31 11:51:15 +00:00
Oleh Prypin
82ac240040 mb: Generate gn args from mb_config rather than tools_webrtc/ios
Bug: webrtc:10253
Change-Id: I3ed7b7fd11d31c3697e637b477db7e9ec9677237
Reviewed-on: https://webrtc-review.googlesource.com/c/120404
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26483}
2019-01-31 08:48:44 +00:00
Oleh Prypin
5bb1afd5c3 Revert "Switch to logdog binary provided by IMPLIED_CIPD_BINARIES"
This reverts commit e05d720f1c.

Reason for revert: Cannot find logdog at that path

Original change's description:
> Switch to logdog binary provided by IMPLIED_CIPD_BINARIES
> 
> https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/swarming/api.py?q=IMPLIED_CIPD_BINARIES
> to stop having to specify it in
> https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/webrtc/steps.py?q=ANDROID_CIPD_PACKAGES
> 
> Bug: chromium:755660
> Change-Id: I1c69b0bada145ce830c4f62d6e99cc928cd29024
> Reviewed-on: https://webrtc-review.googlesource.com/c/114426
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#26015}

TBR=mbonadei@webrtc.org,oprypin@webrtc.org

Change-Id: I6ab6a9c4b53e1d2eb90d0294706ca71700f79177
No-Try: true
Bug: chromium:755660
Reviewed-on: https://webrtc-review.googlesource.com/c/114428
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26018}
2018-12-14 16:13:26 +00:00
Oleh Prypin
e05d720f1c Switch to logdog binary provided by IMPLIED_CIPD_BINARIES
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/swarming/api.py?q=IMPLIED_CIPD_BINARIES
to stop having to specify it in
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/webrtc/steps.py?q=ANDROID_CIPD_PACKAGES

Bug: chromium:755660
Change-Id: I1c69b0bada145ce830c4f62d6e99cc928cd29024
Reviewed-on: https://webrtc-review.googlesource.com/c/114426
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26015}
2018-12-14 14:46:48 +00:00
Yves Gerey
2e0c655bc6 [Sanitizers] Don't retry failed tests.
bug: webrtc:9849
Change-Id: I916c407b91e78934da8cf1be2de43c906549305a
Reviewed-on: https://webrtc-review.googlesource.com/c/104720
Commit-Queue: Yves Gerey <yvesg@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25701}
2018-11-19 18:14:16 +00:00
Mirko Bonadei
264bee8bab Remove memcheck.
Since the linux_memcheck trybot is no more, this CL removes all the
code needed to make it work.

Bug: webrtc:7737, webrtc:8356, webrtc:9570
Change-Id: I09a9467b8bf895146a3384c2c915b54662721af6
Reviewed-on: https://webrtc-review.googlesource.com/90863
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24201}
2018-08-07 07:40:08 +00:00
Oleh Prypin
69c0222108 Allow mixing gtest and non-gtest args in gtest-parallel-wrapper
No-Try: True
Bug: chromium:776681
Change-Id: I412a63e4ea897512b6c7012b9eb6ec5c3cf06314
Reviewed-on: https://webrtc-review.googlesource.com/78287
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23369}
2018-05-23 14:19:20 +00:00
Oleh Prypin
739b8169ef Reland "Add support for launching webcam software for use in recipes"
This is a reland of cd469a4ce5
With vpython specified

Original change's description:
> Add support for launching webcam software for use in recipes
>
> * Copy ensure_webcam_is_running.py from recipes repo
> * Turn it into a wrapper that can launch another script
>   (fix_python_path is copied from test_env.py as _ForcePythonInterpreter)
> * Support it in mb.py
> * Add it to video_capture_unittests
>
> No-Try: True
> Bug: chromium:755660
> Change-Id: I376724a77e443620724add7818592e9368d02079
> Reviewed-on: https://webrtc-review.googlesource.com/77320
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#23275}

No-Try: True
Bug: chromium:755660
Change-Id: Ibf4fbe3fea4b003a23b12332b3a6078a2db99a8d
Reviewed-on: https://webrtc-review.googlesource.com/77460
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23279}
2018-05-17 11:42:21 +00:00
Oleh Prypin
e62e18fe13 Revert "Add support for launching webcam software for use in recipes"
This reverts commit cd469a4ce5.

Reason for revert: ImportError: No module named psutil

Original change's description:
> Add support for launching webcam software for use in recipes
> 
> * Copy ensure_webcam_is_running.py from recipes repo
> * Turn it into a wrapper that can launch another script
>   (fix_python_path is copied from test_env.py as _ForcePythonInterpreter)
> * Support it in mb.py
> * Add it to video_capture_unittests
> 
> No-Try: True
> Bug: chromium:755660
> Change-Id: I376724a77e443620724add7818592e9368d02079
> Reviewed-on: https://webrtc-review.googlesource.com/77320
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#23275}

TBR=phoglund@webrtc.org,oprypin@webrtc.org

Change-Id: I611e49e1c8d8668fe405e462ec4b83e364c3d6e7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:755660
Reviewed-on: https://webrtc-review.googlesource.com/77440
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23278}
2018-05-17 11:24:01 +00:00
Oleh Prypin
cd469a4ce5 Add support for launching webcam software for use in recipes
* Copy ensure_webcam_is_running.py from recipes repo
* Turn it into a wrapper that can launch another script
  (fix_python_path is copied from test_env.py as _ForcePythonInterpreter)
* Support it in mb.py
* Add it to video_capture_unittests

No-Try: True
Bug: chromium:755660
Change-Id: I376724a77e443620724add7818592e9368d02079
Reviewed-on: https://webrtc-review.googlesource.com/77320
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23275}
2018-05-17 11:13:01 +00:00
Oleh Prypin
b708e93ad0 Bring mb up to date with Chromium's changes
Bug: None
Change-Id: I87abffb0bba6ee945447f3e651a505d7602fa15d
Reviewed-on: https://webrtc-review.googlesource.com/62641
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22488}
2018-03-19 11:17:41 +00:00
Patrik Höglund
91861a5e61 Add .vpython to WebRTC bot isolates.
This ensures that .vpython makes it to our swarm bots. I believe this
will solve a problem where psutil is missing when the catapult devil
forwarder tries to import it.

Our .vpython already specifies psutil as being used by catapult, so
I don't think we need to change anything there.

Bug: None
Change-Id: Iee8a08f22d128bca3fd52f9476604d47efe16652
Reviewed-on: https://webrtc-review.googlesource.com/52940
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22010}
2018-02-14 08:28:14 +00:00
Edward Lemur
2b67f5c65f MB: Add a way to run tests on swarming without using gtest-parallel.
Adds a new test_type 'raw' to run tests on swarming without wrapping it
on gtest-parallel.

This will be used to run webrtc_perf_tests directly.

Bug: chromium:755660
Change-Id: I8558faadf242d1db1ad3e13083941886c92b1bd9
Reviewed-on: https://webrtc-review.googlesource.com/49360
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21962}
2018-02-08 19:37:19 +00:00
Edward Lemur
98d4036f5a Make it possible to run low_bandwidth_audio_test on Android swarming.
R=phoglund@webrtc.org, solenberg@webrtc.org

Bug: chromium:755660
Change-Id: I8755a9c9df92fe8157c870cc7519130291441b25
Reviewed-on: https://webrtc-review.googlesource.com/39780
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21634}
2018-01-16 11:42:17 +00:00
Henrik Kjellander
ec57e05410 Update scripts to use DEPS-pinned depot_tools
Always use gn.py in depot_tools instead of just gn.
The https://cs.chromium.org/chromium/src/build/find_depot_tools.py
is looking up the DEPS-pinned copy in third_party/depot_tools
and adds it to the path when add_depot_tools_to_path() is called.

Similar use:
 

https: //cs.chromium.org/search/?q=%22find_depot_tools.add_depot_tools_to_path()%22&sq=package:chromium&type=cs
Bug: webrtc:8393
Change-Id: I3cfa3d96b4d0f60e8099e556876bc94340b1bbb5
Reviewed-on: https://webrtc-review.googlesource.com/12540
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@google.com>
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20333}
2017-10-18 12:06:19 +00:00
Edward Lemur
59c7db8e12 Remove --target-devices-file
As was done in https://chromium-review.googlesource.com/704191

Bug: None
Change-Id: I3e7a5f9e5e2111ddba9218faec15858b86fcab19
Reviewed-on: https://webrtc-review.googlesource.com/7612
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20198}
2017-10-09 09:17:17 +00:00
Edward Lemur
2011075a58 MB: Add support for isolating scripts + isolate low_bandwidth_audio_test.py.
NOTRY=True

Bug: chromium:755660
Change-Id: I92de99cd1e3dd206f6cd366dbfd1c8c211d37cc7
Reviewed-on: https://webrtc-review.googlesource.com/4420
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20089}
2017-10-02 16:57:09 +00:00
Edward Lemur
beffdd4c6a MB: Make it possible to specify timeout.
webrtc_perf_tests needs more than 15 min to run.

NOTRY=True

Bug: chromium:755660
Change-Id: Ibabfae3679206105d585c35f80b839f0046f9ccc
Reviewed-on: https://webrtc-review.googlesource.com/4021
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19996}
2017-09-27 11:49:06 +00:00
ehmaldonado
34623ce83a WebRTC: Save logcat output to isolated outputs.
NOTRY=True
BUG=chromium:717417

Review-Url: https://codereview.webrtc.org/3008343002
Cr-Commit-Position: refs/heads/master@{#19748}
2017-09-08 14:03:13 +00:00
ehmaldonado
a7507ebb1c Roll chromium_revision faace60759..b895cae903 (470521:470551)
Also, add third_party/gtest-parallel/gtest_parallel.py as a swarming
dependency.

Change log: faace60759..b895cae903
Full diff: faace60759..b895cae903

Changed dependencies:
* src/base: 3527b70975..1923248197
* src/ios: 1423885de8..7ae2aeeb51
* src/testing: 8a6aee5860..ac8e76c707
* src/third_party/gtest-parallel: c3e4b0a6d1..605f146238
* src/tools: 3847c42e2c..e7226f9d0d
* src/webrtc/examples/androidtests/third_party/gradle: fed75fbb7b..47ecd621bd
DEPS diff: faace60759..b895cae903/DEPS

No update to Clang.

TBR=
BUG=None

patch from issue 2869393002 at patchset 1 (http://crrev.com/2869393002#ps1)

Review-Url: https://codereview.webrtc.org/2871213002
Cr-Commit-Position: refs/heads/master@{#18087}
2017-05-10 20:40:29 +00:00
Henrik Kjellander
90fd7d84fd Rename tools-webrtc -> tools_webrtc
This aligns with established naming convention for all
other directories.

BUG=webrtc:7593
NOTRY=True
NOTREECHECKS=True
R=ehmaldonado@webrtc.org, mbonadei@webrtc.org
TBR=henrika@webrtc.org

Review-Url: https://codereview.webrtc.org/2864213004 .
Cr-Commit-Position: refs/heads/master@{#18059}
2017-05-09 06:30:13 +00:00
Renamed from tools-webrtc/mb/mb.py (Browse further)