Commit graph

9 commits

Author SHA1 Message Date
Mirko Bonadei
cb459ca6e2 Remove double declaration of cricket::kH264CodecName.
This symbol is declared in two places and clang-cl complains if they
disagree on the visibility (see [1]), since this declaration is
redundant this CL just removes it.

[1] - https://ci.chromium.org/p/chromium/builders/try/win_chromium_compile_dbg_ng/432927

Bug: webrtc:9419
Change-Id: If2f04beff8fd757ec2019c3588c82b6971f012c3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159029
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29729}
2019-11-07 15:24:45 +00:00
Elad Alon
80f53b785b Extend WebRTC-Video-MinVideoBitrate to experiment per-codec
The experiment was extended to support per-codec minimum bitrates
for the following codecs:
 * VP8
 * VP9
 * H.264

The old semantic meaning for the field trial is retained, in that
specifying "br:" applies a minimum bitrate to all codecs. If "br:"
is not specified, the per-codec minimum config is consulted.

Bug: webrtc:11024
Change-Id: I89630262c7710771d5e25d039fe35f0bd217b58a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156171
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Reviewed-by: Ying Wang <yinwa@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29450}
2019-10-11 15:34:33 +00:00
Ying Wang
4271afbc30 Fix the bug and reland "Make min video target bitrate configurable."
This reverts commit 7e896d0162.

Reason for revert: Fixed the bug and submit again.

Original change's description:
> Revert "Make min video target bitrate configurable."
>
> This reverts commit a471e797bc.
>
> Reason for revert: This CL adds a new symbol to .data instead of .rodata and the symbol should be a constant.
>
> Original change's description:
> > Make min video target bitrate configurable.
> >
> > Change-Id: I5adf1e675be2114b648878078a8f2e6808c390c7
> > Bug: webrtc:10915
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150331
> > Commit-Queue: Ying Wang <yinwa@webrtc.org>
> > Reviewed-by: Niels Moller <nisse@webrtc.org>
> > Reviewed-by: Erik Språng <sprang@webrtc.org>
> > Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#28959}
>
> TBR=nisse@webrtc.org,sprang@webrtc.org,crodbro@webrtc.org,yinwa@webrtc.org
>
> Change-Id: I90f23c2c849a6ec518710bbcbdd8e9eb249e9de8
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:10915
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150534
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#28967}

TBR=mbonadei@webrtc.org,nisse@webrtc.org,sprang@webrtc.org,crodbro@webrtc.org,yinwa@webrtc.org

Change-Id: Ieef4972502e3c1e5a6e80d8909718dd312486a8e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10915
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150537
Reviewed-by: Ying Wang <yinwa@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Ying Wang <yinwa@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28971}
2019-08-27 11:12:12 +00:00
Mirko Bonadei
7e896d0162 Revert "Make min video target bitrate configurable."
This reverts commit a471e797bc.

Reason for revert: This CL adds a new symbol to .data instead of .rodata and the symbol should be a constant.

Original change's description:
> Make min video target bitrate configurable.
> 
> Change-Id: I5adf1e675be2114b648878078a8f2e6808c390c7
> Bug: webrtc:10915
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150331
> Commit-Queue: Ying Wang <yinwa@webrtc.org>
> Reviewed-by: Niels Moller <nisse@webrtc.org>
> Reviewed-by: Erik Språng <sprang@webrtc.org>
> Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#28959}

TBR=nisse@webrtc.org,sprang@webrtc.org,crodbro@webrtc.org,yinwa@webrtc.org

Change-Id: I90f23c2c849a6ec518710bbcbdd8e9eb249e9de8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10915
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150534
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28967}
2019-08-27 07:28:44 +00:00
Ying Wang
a471e797bc Make min video target bitrate configurable.
Change-Id: I5adf1e675be2114b648878078a8f2e6808c390c7
Bug: webrtc:10915
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150331
Commit-Queue: Ying Wang <yinwa@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28959}
2019-08-26 14:21:31 +00:00
Johannes Kron
d38a2b860b Increase the UDP receive buffer for video
Lost packets have been seen in high-bitrate applications and increasing
the UDP receive buffer reduced the problems.

Bug: b/115713113
Change-Id: I671f528afeaea525150fdc2013f2b245778e5d16
Reviewed-on: https://webrtc-review.googlesource.com/c/107580
Commit-Queue: Johannes Kron <kron@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25328}
2018-10-24 07:54:12 +00:00
Åsa Persson
45bbc8ac19 Change forced software encoder fallback for VP8 to be only based on resolution and not bitrate.
Switches from VP8 HW to VP8 SW for resolutions <= max_pixels. 

|<- min_pixels  VP8 SW  max_pixels ->|  VP8 HW  |

Bug: webrtc:6634
Change-Id: Ib324df2b8418659c29d999259c0ed47448310696
Reviewed-on: https://webrtc-review.googlesource.com/7362
Commit-Queue: Åsa Persson <asapersson@webrtc.org>
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20646}
2017-11-13 10:58:42 +00:00
Mirko Bonadei
92ea95e34a Fixing WebRTC after moving from src/webrtc to src/
In https://webrtc-review.googlesource.com/c/src/+/1560 we moved WebRTC
from src/webrtc to src/ (in order to preserve an healthy git history).
This CL takes care of fixing header guards, #include paths, etc...

NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=tommi@webrtc.org


Bug: chromium:611808
Change-Id: Iea91618212bee0af16aa3f05071eab8f93706578
Reviewed-on: https://webrtc-review.googlesource.com/1561
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19846}
2017-09-15 05:02:56 +00:00
Mirko Bonadei
bb547203bf Moving src/webrtc into src/.
In order to eliminate the WebRTC Subtree mirror in Chromium, 
WebRTC is moving the content of the src/webrtc directory up
to the src/ directory.

NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=tommi@webrtc.org

Bug: chromium:611808
Change-Id: Iac59c5b51b950f174119565bac87955a7994bc38
Reviewed-on: https://webrtc-review.googlesource.com/1560
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19845}
2017-09-15 04:25:06 +00:00
Renamed from webrtc/media/engine/constants.h (Browse further)