2 commits

Author	SHA1	Message	Date
Henrik Boström	e574a31c50	[Perfect Negotiation] Fire onnegotiationneeded when chain is empty. ... This CL generates "negotiationneeded" events if negotiation is needed when the Operations Chain becomes empty. This is only implemented in Unified Plan to avoid Plan B regressions (the event is pretty useless in Plan B as it fires repeatedly). In order to implement the spec-compliant behavior of only firing the event when the chain is empty, this CL introduces PeerConnectionObserver::OnNegotiationNeededEvent() and PeerConnectionInterface::ShouldFireNegotiationNeededEvent() to allow validating the event before firing it. This is needed because the event must not be fired until a task has been posted and subsequently chained operations could invalidate it in the meantime. Test coverage is added for both legacy and modern "negotiationneeded" events. Bug: chromium:1060083 Change-Id: I1dbaa8f6ddb1c6e7c8abd8da3b92efcb64060383 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180620 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31989}	2020-08-25 09:56:39 +00:00
Henrik Boström	27c293665e	Implement an OperationsChain, to be used by PeerConnection in follow-up. ... This allows asynchronous tasks to be queued to be executed in order. The class is motivated by the "operations chain" in the spec: https://w3c.github.io/webrtc-pc/#dfn-operations-chain In a follow-up CL I intend to use this in PeerConnection's CreateOffer(), CreateAnswer() SetLocalDescription() and SetRemoteDescription() and unblock https://crbug.com/980885. For background, motivation, requirements and implementation notes, see https://docs.google.com/document/d/1XLwNN2kUIGGTwz9LQ0NwJNkcybi9oKnynUEZB1jGA14/edit?usp=sharing Bug: webrtc:11019 Change-Id: I982e4a1c0e77fa62096c16deed459d9d9e9b63f0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156120 Reviewed-by: Steve Anton <steveanton@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29582}	2019-10-23 09:33:16 +00:00