Commit graph

22 commits

Author SHA1 Message Date
henrika
5641fbb5ec Add support for saving local audio input to file in AppRTCMobile
Uses new WebRtcAudioRecordSamplesReadyCallback which was added recently in
https://webrtc-review.googlesource.com/c/src/+/49981.

This CL:
- Serves as a test of new WebRtcAudioRecordSamplesReadyCallback.
- Useful for debugging purposes since it records the most native raw audio.

Bug: None
Change-Id: I57375cbf237c171e045b0bdb05f7ae1401930fbc
Reviewed-on: https://webrtc-review.googlesource.com/53120
Commit-Queue: Henrik Andreassson <henrika@webrtc.org>
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22128}
2018-02-21 14:09:56 +00:00
Qingsi Wang
a4e72b7914 Add RtcEventLog to AppRTCMobile with preference setting.
Enable diagnostic packet and event recording as in the "webrtc-internal"
setting in Chromium.

Bug: webrtc:8859
Change-Id: I1d4a19e0dd60133cdd0d4e18a55780623b65653c
Reviewed-on: https://webrtc-review.googlesource.com/49541
Commit-Queue: Qingsi Wang <qingsi@google.com>
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21987}
2018-02-12 19:12:05 +00:00
Edward Lemur
71d766eb4b Pass the right flag to Android video quality test.
Pass --isolated-script-test-output instead of --chartjson-result-file.

TBR=phoglund@webrtc.org

Bug: chromium:755660
Change-Id: I6b55a4461428526de77bf192600de81b8cc029b2
Reviewed-on: https://webrtc-review.googlesource.com/48180
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21909}
2018-02-06 11:09:49 +00:00
Edward Lemur
d5e17d6831 Don't run video_quality_loopback_test from the src dir.
When executed on swarming, the script is run from //out/<android build dir>,
so it's better to keep that convention.

Given that all paths are given, cwd doesn't seem to be needed.

TBR=phoglund@webrtc.org

Bug: chromium:755660
Change-Id: Iabf6603983ff88b1281e8113da1aad3320967b72
Reviewed-on: https://webrtc-review.googlesource.com/46142
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21843}
2018-02-01 13:27:41 +00:00
Edward Lemur
21a35bc188 Ignore Chromium-specific flags on video_quality_loopback_test.
TBR=phoglund@webrtc.org

Bug: chromium:755660
Change-Id: I71409a569995708bc4c54b9bbcb2a119feed4be9
Reviewed-on: https://webrtc-review.googlesource.com/46524
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21827}
2018-01-31 13:50:09 +00:00
Edward Lemur
2e5966b3d3 Store video_quality_loopback_test perf results in Chart JSON format.
Adds a flag to store the perf results in a JSON file using the Chart
JSON format [1].

[1] https://github.com/catapult-project/catapult/blob/master/dashboard/docs/data-format.md

TBR=phoglund@webrtc.org

Bug: chromium:755660
Change-Id: I6a896654a4a558df217ddefa4e8a52a487cdbebd
Reviewed-on: https://webrtc-review.googlesource.com/43180
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21809}
2018-01-30 16:48:59 +00:00
Edward Lemur
70ba9b453c Reland "Make it possible to run video_quality_loopback_test in swarming."
This is a reland of 1175ecd095.

Original change's description:
> Make it possible to run video_quality_loopback_test in swarming.
> 
> I made two changes to video_quality_loopback_test to make it possible
> to run it on swarming.
> 
> 1. We need to know the path to frame_analyzer when we're generating
>    the build files, and it must be already present.
>    I made frame_analyzer a resource, so it's downloaded to a known path
>    before generating the build files.
> 2. The .zip files for apprtc and golang are downloaded and isolated.
>    The script now extracts them and installs AppRTC.
> 
> Passing task:
>  https://chromium-swarm.appspot.com/task?id=3b230bcc04128210
> 
> Bug: chromium:755660
> Change-Id: I34090897402421d5b7e29f21fbed354551197f92
> Reviewed-on: https://webrtc-review.googlesource.com/40920
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#21716}

Bug: chromium:755660
Change-Id: Ie3ca62d64b4fe856485287b7d9d3d9e3f75dc091
Reviewed-on: https://webrtc-review.googlesource.com/42860
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21733}
2018-01-23 13:03:17 +00:00
Edward Lemur
9c1848952e Revert "Make it possible to run video_quality_loopback_test in swarming."
This reverts commit 1175ecd095.

Reason for revert: Breaks the bots.

Original change's description:
> Make it possible to run video_quality_loopback_test in swarming.
> 
> I made two changes to video_quality_loopback_test to make it possible
> to run it on swarming.
> 
> 1. We need to know the path to frame_analyzer when we're generating
>    the build files, and it must be already present.
>    I made frame_analyzer a resource, so it's downloaded to a known path
>    before generating the build files.
> 2. The .zip files for apprtc and golang are downloaded and isolated.
>    The script now extracts them and installs AppRTC.
> 
> Passing task:
>  https://chromium-swarm.appspot.com/task?id=3b230bcc04128210
> 
> Bug: chromium:755660
> Change-Id: I34090897402421d5b7e29f21fbed354551197f92
> Reviewed-on: https://webrtc-review.googlesource.com/40920
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#21716}

TBR=phoglund@webrtc.org,ehmaldonado@webrtc.org

Change-Id: Id25d26adc547ff6f9ab178601e37527459c8b5ef
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:755660
Reviewed-on: https://webrtc-review.googlesource.com/42800
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21723}
2018-01-22 16:12:10 +00:00
Edward Lemur
1175ecd095 Make it possible to run video_quality_loopback_test in swarming.
I made two changes to video_quality_loopback_test to make it possible
to run it on swarming.

1. We need to know the path to frame_analyzer when we're generating
   the build files, and it must be already present.
   I made frame_analyzer a resource, so it's downloaded to a known path
   before generating the build files.
2. The .zip files for apprtc and golang are downloaded and isolated.
   The script now extracts them and installs AppRTC.

Passing task:
 https://chromium-swarm.appspot.com/task?id=3b230bcc04128210

Bug: chromium:755660
Change-Id: I34090897402421d5b7e29f21fbed354551197f92
Reviewed-on: https://webrtc-review.googlesource.com/40920
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21716}
2018-01-22 14:40:28 +00:00
Magnus Jedvert
6062f372c7 Android: Fix warnings
TBR=sakal@webrtc.org

Bug: webrtc:6597,webrtc:8534
Change-Id: I39f96d9e0e6d604051b1cc13368dd44fc82b30b0
Reviewed-on: https://webrtc-review.googlesource.com/23622
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Commit-Queue: Magnus Jedvert <magjed@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20719}
2017-11-16 18:25:33 +00:00
Edward Lemur
82752c4d25 Roll chromium_revision f93b8b19f2..adf969a7cb (513366:514871) and more.
MORE:
-----
* Get rid of canary in gradle_project_test. This follows http://crrev.com/a959a6cf
* Switch Android binary deps to be managed by CIPD. This mirrors http://crrev.com/b80cf484

CHROMIUM ROLL:
--------------
Change log: f93b8b19f2..adf969a7cb
Full diff: f93b8b19f2..adf969a7cb

Changed dependencies:
* src/base: eec763edae..a7b41d733d
* src/build: 4ef2624fab..f157e447ed
* src/buildtools: 3275a099f3..73ddd64be6
* src/ios: 9e4709d134..4aa21e3299
* src/testing: a8c077a658..fc66e396f9
* src/third_party: 3bd34f929d..7b30c21c2c
* src/third_party/android_tools: https://chromium.googlesource.com/android_tools.git/+log/ca0bd08387..4a9623af57
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/664e99a648..6cc352e216
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/14715602e0..af046c52f1
* src/third_party/depot_tools: 70dea4270e..c4ccb4b623
* src/third_party/ffmpeg: f9e8b42758..c33a5ee8e7
* src/third_party/icu: 21d33b1a09..b31896655a
* src/tools: b512b7250b..29a3411140
* src/tools/swarming_client: 5da404cf35..6fd3c7b6eb
DEPS diff: f93b8b19f2..adf969a7cb/DEPS

Clang version changed 315613:317263
Details: f93b8b19f2..adf969a7cb/tools/clang/scripts/update.py

TBR=phoglund@webrtc.org, sakal@webrtc.org
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Bug: webrtc:8501
Change-Id: I28b0e78748e2441247d7d3b7976eec957ac47726
Reviewed-on: https://webrtc-review.googlesource.com/21400
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20603}
2017-11-08 21:42:48 +00:00
Mirko Bonadei
12251b6386 Adding @SuppressWarnings(NoSynchronizedMethodCheck).
In https://chromium-review.googlesource.com/c/chromium/src/+/750645
Chromium started to use an ErrorProne plugin to discourage synchronized
public methods (an encourage the usage of synchronized blocks).

In order to unblock the Chromium Roll we can suppress these warnings
and decide if we want to align with Chromium on this check or ask
them to make it optional.

More details in the bug.

TBR=magjed@webrtc.org

Bug: webrtc:8491
Change-Id: Ie77a324e54aab44a4f59853959549f1d21f884a0
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/20060
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20569}
2017-11-06 17:48:38 +00:00
Sami Kalliomäki
9828bebee6 Fix/suppress all javac warnings.
This is done in preparation to make all javac warnings into errors for
WebRTC targets.

Bug: webrtc:6597
Change-Id: I402043157bd75943adf0de52111e5a1bb179c6d1
Reviewed-on: https://webrtc-review.googlesource.com/15104
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org>
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20450}
2017-10-26 15:11:36 +00:00
Sami Kalliomäki
2729c16143 Fix some Android lint warnings in AppRTCMobile.
Bug: webrtc:6597
Change-Id: I73e304ff03a5fcb166ff7bca61319904ef495426
Reviewed-on: https://webrtc-review.googlesource.com/15322
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20439}
2017-10-26 07:34:54 +00:00
Henrik Kjellander
90d46c472d Add phoglund@ to various OWNERS and remove kjellander@
TBR=henrika@webrtc.org

Bug: webrtc:8363
Change-Id: Ibcb3e8d40a93542ea0825faf92a6db11dc5a0c13
Notry: True
Reviewed-on: https://webrtc-review.googlesource.com/7606
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20344}
2017-10-19 09:21:12 +00:00
Henrik Kjellander
ec57e05410 Update scripts to use DEPS-pinned depot_tools
Always use gn.py in depot_tools instead of just gn.
The https://cs.chromium.org/chromium/src/build/find_depot_tools.py
is looking up the DEPS-pinned copy in third_party/depot_tools
and adds it to the path when add_depot_tools_to_path() is called.

Similar use:
 

https: //cs.chromium.org/search/?q=%22find_depot_tools.add_depot_tools_to_path()%22&sq=package:chromium&type=cs
Bug: webrtc:8393
Change-Id: I3cfa3d96b4d0f60e8099e556876bc94340b1bbb5
Reviewed-on: https://webrtc-review.googlesource.com/12540
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@google.com>
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20333}
2017-10-18 12:06:19 +00:00
Sami Kalliomäki
d189a7cbb7 Add Android Studio project for AppRTCMobile that builds against AAR.
This project can be used for testing the AAR before publishing. Removes
dependency to Chromium from the tests to support Android Studio.

Bug: webrtc:8365
Change-Id: I7568a3f636fd7d478d274b4766f33ab00f28a6f0
Reviewed-on: https://webrtc-review.googlesource.com/7608
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20269}
2017-10-13 08:46:27 +00:00
Henrik Kjellander
cb3b1c13f7 video_quality_loopback_test.py: Fix relative path to root.
This was missed in https://webrtc-review.googlesource.com/1575

BUG=chromium:611808
NOTRY=True
TBR=mbonadei@webrtc.org

Change-Id: Ie5b891d8071a70a510f114d8d0ab2dd6a8547b3c
Reviewed-on: https://webrtc-review.googlesource.com/1840
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19877}
2017-09-18 04:26:15 +00:00
Henrik Kjellander
9d8ce7c7fa video_quality_loopback_test.py: Fix paths to root.
Now that webrtc/* is moved to the root, this needs to be updated.

BUG=chromium:611808
NOTRY=True
TBR=mbonadei@webrtc.org

Change-Id: I947628886fb949972501e81e010bbdb9e9099872
Reviewed-on: https://webrtc-review.googlesource.com/1575
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19854}
2017-09-15 11:09:00 +00:00
Henrik Kjellander
e4f900d5cf gradle_project_test.py: Fix calculation of checkout root dir.
BUG=chromium:611808
NOTRY=True
NOTREECHECKS=True

Change-Id: I9493a7e171dbd8198eaa4c4723690fafc851e144
Reviewed-on: https://webrtc-review.googlesource.com/1568
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19848}
2017-09-15 07:46:41 +00:00
Mirko Bonadei
92ea95e34a Fixing WebRTC after moving from src/webrtc to src/
In https://webrtc-review.googlesource.com/c/src/+/1560 we moved WebRTC
from src/webrtc to src/ (in order to preserve an healthy git history).
This CL takes care of fixing header guards, #include paths, etc...

NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=tommi@webrtc.org


Bug: chromium:611808
Change-Id: Iea91618212bee0af16aa3f05071eab8f93706578
Reviewed-on: https://webrtc-review.googlesource.com/1561
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19846}
2017-09-15 05:02:56 +00:00
Mirko Bonadei
bb547203bf Moving src/webrtc into src/.
In order to eliminate the WebRTC Subtree mirror in Chromium, 
WebRTC is moving the content of the src/webrtc directory up
to the src/ directory.

NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=tommi@webrtc.org

Bug: chromium:611808
Change-Id: Iac59c5b51b950f174119565bac87955a7994bc38
Reviewed-on: https://webrtc-review.googlesource.com/1560
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19845}
2017-09-15 04:25:06 +00:00