Commit graph

4 commits

Author SHA1 Message Date
tschumim
9d11764344 Reimplemeted "Test and fix for huge bwe drop after alr state"
BUG=webrtc:7746

Test and fix for huge bwe drop after alr state.

BUG=webrtc:7746

Review-Url: https://codereview.webrtc.org/2931873002
Cr-Commit-Position: refs/heads/master@{#18692}
Committed: 37aa8ba616

patch from issue 2931873002 at patchset 320001 (http://crrev.com/2931873002#ps320001)

Review-Url: https://codereview.webrtc.org/2970653004
Cr-Commit-Position: refs/heads/master@{#19055}
2017-07-17 08:41:41 +00:00
terelius
e75d96b5bd Revert of Test and fix for huge bwe drop after alr state. (patchset #13 id:320001 of https://codereview.webrtc.org/2931873002/ )
Reason for revert:
Resetting the estimate means that we need to start gathering data from scratch again. The combination of
1) DelayBasedEstimator not reacting to overuse unless there is a valid estimate of the acknowledged bitrate, and
2) AcknowledgedBitrateEstimator needing a significant amount of time/data to obtain an provide an estimate
causes poor performance in simulations/tests. It is not clear whether this will affect real networks negatively, but I suggest reverting this to be on the safe side.
See also https://bugs.chromium.org/p/webrtc/issues/detail?id=7884

Original issue's description:
> Test and fix for huge bwe drop after alr state.
>
> BUG=webrtc:7746
>
> Review-Url: https://codereview.webrtc.org/2931873002
> Cr-Commit-Position: refs/heads/master@{#18692}
> Committed: 37aa8ba616

TBR=solenberg@webrtc.org,kwiberg@webrtc.org,minyue@webrtc.org,holmer@chromium.org,philipel@webrtc.org,oprypin@webrtc.org,holmer@google.com,stefan@webrtc.org,tschumim@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:7746

Review-Url: https://codereview.webrtc.org/2964213002
Cr-Commit-Position: refs/heads/master@{#18866}
2017-06-30 15:11:44 +00:00
tschumim
37aa8ba616 Test and fix for huge bwe drop after alr state.
BUG=webrtc:7746

Review-Url: https://codereview.webrtc.org/2931873002
Cr-Commit-Position: refs/heads/master@{#18692}
2017-06-21 06:42:30 +00:00
kjellander@webrtc.org
80174583bd Replace old resources download script with depot_tools
With help from hinoka@, we're now using a more efficient approach
to download only the files that have changed from Google Storge.

When uploading new resource files, use
upload_to_google_storage.py --bucket chromium-webrtc-resources ./filename
which of course requires gsutil authentication setup.

NOTICE: Before deploying this, svn:ignore should be removed for
the resources folder, or the bots will run into problems with a
non-versioned file being found in the checkout during sync (as
this CL adds resources to version control).

All developers will also need to be informed to wipe their local
resources dir to avoid getting an error during checkout due to the
already existing non-versioned resources directory.

BUG=2294
TEST=locally running gclient runhooks
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2095004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5076 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-04 12:07:57 +00:00