mollyim/webrtc
1
0
Fork 0
mirror of https://github.com/mollyim/webrtc.git synced 2025-05-13 22:00:47 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
20098 commits 2 branches 91 tags 415 MiB
Commit graph

4 commits

Author SHA1 Message Date
Mirko Bonadei
3152afd361 Removing invalid-name from disabled pylint checks. 
It has been introduced in https://webrtc-review.googlesource.com/c/src/+/1566 but now it seems we can remove it since it is not raising any failure.

NOTRY=True

Bug: None
Change-Id: Id82b1b7fba6b5277753eabbf9fb7a722819532f9
Reviewed-on: https://webrtc-review.googlesource.com/8302
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@google.com>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20235}
 2017-10-11 08:06:49 +00:00
Henrik Kjellander
a18a3bf8d6 Fix Python shebang and license for presubmit_test.py 
This was missed during review of https://codereview.webrtc.org/3010153002
Having python2 in the shebang makes it fail presubmit locally on Mac.

Disable 'invalid-name' PyLint rule in 3 places to pass presubmit.

NOTRY=True
NOTREECHECKS=True
TBR=charujain@webrtc.org

Bug: none
Change-Id: I85cc5783ba11774792cd8c2f6c0b4ff47ad89270
Reviewed-on: https://webrtc-review.googlesource.com/1566
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19850}
 2017-09-15 09:22:50 +00:00
kjellander
38c65c8fb4 Update pylintrc to catch more style violations. 
The current PyLint configuration doesn't catch violations
to the Chromium Python Style Guide in a good way.

This change adds mostly the correct style regex for functions
and methods, with most content copied from
https://cs.chromium.org/chromium/tools/depot_tools/pylintrc
and (since the former disables invalid-name)
https://cs.chromium.org/chromium/src/third_party/chromite/pylintrc

Many settings are the defaults, but are now more explicit to make it
easier to find them for our users.

Also convert the previous one-line list of disabled lint check into
a one-per-line list instead.

Add import-error to the list of disabled lint checks.

This CL depends on https://codereview.webrtc.org/2812273002/
to be landed first in order to not produce a lot of errors.

BUG=webrtc:7303
NOTRY=True
TESTED=git cl presubmit passing when tested in
combination with https://codereview.webrtc.org/2812273002/
TBR=niklas.enbom@webrtc.org

Review-Url: https://codereview.webrtc.org/2737963003
Cr-Commit-Position: refs/heads/master@{#17685}
 2017-04-13 05:43:38 +00:00
Henrik Kjellander
57e5fd2e60 PRESUBMIT: Improve PyLint check and add GN format check. 
Add pylintrc file based on
https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/pylintrc
bit tightened up quite a bit (the one in depot_tools is far
more relaxed).

Remove a few excluded directories from pylint check and fixed/
suppressed all warnings generated.

Add GN format check + formatted all GN files using 'gn format'.
Cleanup redundant rules in tools/PRESUBMIT.py

TESTED=Ran 'git cl presubmit -vv', fixed the PyLint violations.
Ran it again with a modification in webrtc/build/webrtc.gni, formatted
all the GN files and ran it again.

R=henrika@webrtc.org, phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/50069004

Cr-Commit-Position: refs/heads/master@{#9274}
 2015-05-25 10:55:50 +00:00