Commit graph

20098 commits

Author SHA1 Message Date
Alessio Bazzica
86f25d3bcd Create links to single experiments in APM-QA exported results.
For each single experiment, a URL is defined by adding a specific anchor.
A URL can be copied using the button beneath the score of the experiment
one would like to share.

This CL also includes a few optimizations and fixes:
- JS and CSS are minified
- Dialog close event listener added, this fixes a small bug preventing
  the play out audio to stop when pressing ESC instead of using the close
  button
- Snackbar notifications added
- Simple unit test for the export module

BUG=webrtc:7218
Change-Id: Iad00ce69094a5968ee0520d105d59656cfafa4e2

TBR=

Change-Id: Iad00ce69094a5968ee0520d105d59656cfafa4e2
Reviewed-on: https://webrtc-review.googlesource.com/7960
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20266}
2017-10-13 07:48:47 +00:00
Åsa Persson
dc182a486a VideoProcessorIntegrationTest: remove arrays in RateProfile and use vector of RateProfiles instead.
Move num_frames from RateProfile to TestConfig struct.

Remove methods: SetRateProfile, AddRateControlThresholds.

Bug: none
Change-Id: I14bcafb8c5b3c1d3b6119417dde038fd82381e3f
Reviewed-on: https://webrtc-review.googlesource.com/8540
Commit-Queue: Åsa Persson <asapersson@webrtc.org>
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20265}
2017-10-13 07:19:56 +00:00
Henrik Lundin
8cd750df1e Enable NetEq's Opus bit-exactness tests for Android
When the test was created, it was disabled for mobile platforms from
the beginning. This is likely a copy-paste from the related
NetEqDecodingTest.TestBitExactness which includes testing codecs not
supported on mobile platforms (e.g., iLBC). This restriction is not
needed for the Opus-only test.

The test remains disabled for iOS, since none of the bots actually run
the relevant test binary on actual iOS devices.

Bug: none
Change-Id: I9071e0e32c83b62c8c7af59ac1cb3e46227f8e8e
Reviewed-on: https://webrtc-review.googlesource.com/8561
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20264}
2017-10-13 07:01:36 +00:00
Henrik Kjellander
44ba5e577a Revert "Use subprocess2 for downloading tools."
This reverts commit 4d39dc3922.

Reason for revert: To benefit from the other fix in crbug.com/773671. Will reland once DEPS rolling is unblocked.

Original change's description:
> Use subprocess2 for downloading tools.
> 
> Change to use exactly the same approach as when gclient hooks
> are executing [1]. It should be safe since it's using the DEPS-pinned
> depot_tools in third_party. Hopefully this solves the race condition
> problems we've been seeing in crbug.com/773671
> 
> [1]: https://cs.chromium.org/chromium/tools/depot_tools/gclient.py?rcl=b3ce73d028b1d44137d533220fd41be31bc31801&l=214
> 
> Bug: chromium:773671
> Change-Id: Ia003dbca394e42556afa1a416fcb4844b960ad6c
> No-try: True
> Reviewed-on: https://webrtc-review.googlesource.com/8820
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#20256}

TBR=kjellander@webrtc.org,mbonadei@webrtc.org

Change-Id: I825d291d6f723cac79a6cc6fc54cd5f9d4877152
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:773671
Reviewed-on: https://webrtc-review.googlesource.com/9080
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20263}
2017-10-13 06:06:37 +00:00
Taylor Brandstetter
b140b9fd69 Keep count of libsrtp clients, and only deinitialize when it goes to 0.
This is the same thing we're doing for usrsctp. Before this CL, the
first SrtpSession to call SetKey would initialize libsrtp, and
ChannelManager's destructor would deinitialize it. This works for an
application that only uses one instance of ChannelManager simultaneously
(or one instance of PeerConnectionFactory), but not one that uses
multiple.

Now, libsrtp is effectively reference-counted, with the first
SrtpSession to take a reference initializing it, and the last to remove
its reference deinitializing it.

This issue was discovered recently due to a change that resulted in
using srtp_update. Without using that method, the issue went unnoticed;
maybe srtp_protect/srtp_unprotect don't require initialization?

Bug: webrtc:8388
Change-Id: If1329360f0b469e454810e62e9b5acfbd4cba100
Reviewed-on: https://webrtc-review.googlesource.com/9000
Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20262}
2017-10-13 05:11:27 +00:00
Jonas Oreland
f0229767d1 Fix bug in recently introduced TurnCustomizer
The problem was that TurnCustomizerMaybeModifyOutgoingStunMessage
was called before the message was constructed. This is now fixed
and tested in TestTurnCustomizer.

BUG=webrtc:8313

Change-Id: Ie9a69cc2ff514796af0da987de733b3db8382883
Reviewed-on: https://webrtc-review.googlesource.com/8840
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20261}
2017-10-13 05:08:26 +00:00
Mirko Bonadei
6188018e1d Using Change.BugsFromDescription to read CL bugs in PRESUBMIT checks.
Since we migrated to Gerrit recently we cannot rely on the BUG= format
for this check because:

* it is deprecated: https://cs.chromium.org/chromium/tools/depot_tools/presubmit_support.py?l=908&rcl=94652a37677488738626b96ff504fc07afbbaa87
* it causes confusion in our users because Gerrit uses Bug: and all the error messages were requiring BUG=

This CL uses a more general API to get the list of bugs from in a CL and
renames BUG= to Bug:.

Bug: None
Change-Id: I7e86fe6d8ca426d9e4bf3bd39021d2a510ec196f
No-Treechecks: True
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/8881
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20260}
2017-10-13 03:48:26 +00:00
Patrik Höglund
69cc48bb8b Revert "Make it possible to isolate bwe_simulations_tests"
This reverts commit 28addd03c1.

Reason for revert: Speculative revert: looks like all win bots turned purple

Original change's description:
> Make it possible to isolate bwe_simulations_tests
> 
> Add missing data dependencies and add it to gn_isolate_map.pyl
> 
> Bug: chromium:749648
> Change-Id: I6b6c1bb2e4d647471a2747042788a691ce2e1e5d
> Reviewed-on: https://webrtc-review.googlesource.com/8721
> Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
> Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#20258}

TBR=kjellander@webrtc.org,ehmaldonado@webrtc.org,stefan@webrtc.org

Change-Id: I8d07560ba3a60b97cf6525723a0f9888a72a1b1d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:749648
Reviewed-on: https://webrtc-review.googlesource.com/8860
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20259}
2017-10-12 11:10:56 +00:00
Edward Lemur
28addd03c1 Make it possible to isolate bwe_simulations_tests
Add missing data dependencies and add it to gn_isolate_map.pyl

Bug: chromium:749648
Change-Id: I6b6c1bb2e4d647471a2747042788a691ce2e1e5d
Reviewed-on: https://webrtc-review.googlesource.com/8721
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20258}
2017-10-12 09:04:24 +00:00
Mirko Bonadei
6697278c8f Fix Gn untracked headers in webrtc/p2p.
This CL is the same CL we had at https://codereview.webrtc.org/3016513002/.
Since we cannot land it with Rietveld anymore let's move the discussion
to Gerrit.

BUG=webrtc:7646
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

No-Try: True
Change-Id: I442660e6dc71612d6bbcf73764bd4c6f65fcb760
Reviewed-on: https://webrtc-review.googlesource.com/7982
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@google.com>
Cr-Commit-Position: refs/heads/master@{#20257}
2017-10-12 08:35:35 +00:00
Henrik Kjellander
4d39dc3922 Use subprocess2 for downloading tools.
Change to use exactly the same approach as when gclient hooks
are executing [1]. It should be safe since it's using the DEPS-pinned
depot_tools in third_party. Hopefully this solves the race condition
problems we've been seeing in crbug.com/773671

[1]: https://cs.chromium.org/chromium/tools/depot_tools/gclient.py?rcl=b3ce73d028b1d44137d533220fd41be31bc31801&l=214

Bug: chromium:773671
Change-Id: Ia003dbca394e42556afa1a416fcb4844b960ad6c
No-try: True
Reviewed-on: https://webrtc-review.googlesource.com/8820
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20256}
2017-10-12 08:30:54 +00:00
Andrii Shyshkalov
4de044f872 Remove Rietveld CQ config.
Rietveld CQ has already been disabled and is no longer supoorted.

TBR=kjellander@webrtc.org

No-Try: True
Bug: chromium:770592
Change-Id: I893d7a4be9a22ece16fc7547549143d480174bcb
Reviewed-on: https://webrtc-review.googlesource.com/8780
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20255}
2017-10-12 05:02:45 +00:00
Elad Alon
15608c6a34 Prevent RtcEventLogTestHelper from crashing
Prevent RtcEventLogTestHelper from crashing; use ASSERT instead (soft-failure in the gtest suite).

Bug: webrtc:8111
Change-Id: Ibaabdaa64d0778af83e9a49485fb880793091d24
Reviewed-on: https://webrtc-review.googlesource.com/8620
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20254}
2017-10-11 18:12:57 +00:00
Elad Alon
9e6565b008 Fix PeerConnectionInterfaceTest_StartAndStopLoggingAfterPeerConnectionClosed
PeerConnectionInterfaceTest_StartAndStopLoggingAfterPeerConnectionClosed was using an invalid file, then checking that StartRtcEventLog returns false. Such a test might return a false positive, since StartRtcEventLog might fail because it was given an invalid file, rather than because the PC was already closed.


Bug: webrtc:8111
Change-Id: I844eb3b948b1406bb6f5cc63928eb26f0fb7b694
Reviewed-on: https://webrtc-review.googlesource.com/8541
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20253}
2017-10-11 17:34:17 +00:00
Per Åhgren
d3d7f44ddf Cleanup in the code for the lag estimation in AEC3
Bug: webrtc:8379
Change-Id: Ic80ce86fc0f4ba42583bd43cb137c6e1c9e6513c
Reviewed-on: https://webrtc-review.googlesource.com/8560
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20252}
2017-10-11 15:11:22 +00:00
Gustaf Ullberg
d8579e0133 EchoControl factory injectable in AudioProcessing.
This CL enables a factory method creating acoustic echo cancellers
that inherit EchoControl to be injected into the audio processing
module. AudioProcessing will call the factory method to create an
instance of the EchoControl subclass when needed. In the event of
sample rate changes, AudioProcessing will recreate the object using
the factory method.

Bug: webrtc:8346
Change-Id: I0c508b4d4cdb35569864cefaa0e3aea2555cc9b9
Reviewed-on: https://webrtc-review.googlesource.com/7742
Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org>
Reviewed-by: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20251}
2017-10-11 14:52:06 +00:00
Niels Möller
5de6b1a211 Delete remnants of support for RFC 5450, extended jitter report.
Bug: None
Change-Id: If8f90734d7a152b4d976465ade9d145a22df4d9f
Reviewed-on: https://webrtc-review.googlesource.com/8500
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Commit-Queue: Stefan Holmer <stefan@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20250}
2017-10-11 14:17:22 +00:00
henrika
5ff64831f9 Removes usage if ID in AudioDeviceImpl.
This CL is a follow-up on https://webrtc-review.googlesource.com/c/src/+/8380

TBR=solenberg

Bug: webrtc:7306
Change-Id: I26cd59d51f15b81d7262b6eb5fc64cbb256c8754
Reviewed-on: https://webrtc-review.googlesource.com/8440
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Commit-Queue: Henrik Andreassson <henrika@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20249}
2017-10-11 14:16:02 +00:00
Åsa Persson
ca0ed63c19 Revert "Remove sent framerate and bitrate calculations from MediaOptimization."
This reverts commit af721b72cc.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Remove sent framerate and bitrate calculations from MediaOptimization.
> 
> Add RateTracker for sent framerate and bitrate in SendStatisticsProxy.
> 
> Store sent frame info in map to solve potential issue where sent framerate statistics could be
> incorrect.
> 
> Bug: webrtc:8375
> Change-Id: I4a6e3956013438a711b8c2e73a8cd90c52dd1210
> Reviewed-on: https://webrtc-review.googlesource.com/7880
> Reviewed-by: Erik Språng <sprang@webrtc.org>
> Commit-Queue: Åsa Persson <asapersson@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#20225}

TBR=asapersson@webrtc.org,sprang@webrtc.org

Change-Id: Ic914f03ff7065ac410ae06b6f82b56a935399b66
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:8375
Reviewed-on: https://webrtc-review.googlesource.com/8480
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Commit-Queue: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20248}
2017-10-11 12:59:15 +00:00
Åsa Persson
18945c35c2 Revert "Reduce max possible size of map that holds encoded frame info."
This reverts commit 2ff7ecfceb.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Reduce max possible size of map that holds encoded frame info.
> 
> Bug: webrtc:8375
> Change-Id: Idc57e68dc44fd73e5c0aa85d82c1e3659d8ea292
> Reviewed-on: https://webrtc-review.googlesource.com/8301
> Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
> Reviewed-by: Erik Språng <sprang@webrtc.org>
> Commit-Queue: Åsa Persson <asapersson@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#20232}

TBR=brandtr@webrtc.org,asapersson@webrtc.org,sprang@webrtc.org

Change-Id: I1dcb7ab588e5ab3eb79bec2c39f615480e31c3bb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:8375
Reviewed-on: https://webrtc-review.googlesource.com/8460
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Commit-Queue: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20247}
2017-10-11 12:58:11 +00:00
henrika
4af7366961 AudioDeviceImpl cleanup
(Making new attempt to land https://webrtc-review.googlesource.com/c/src/+/7601)

TBR=solenberg

Bug: NONE
Change-Id: I0651c47066dbc413b03c899b437d8ac18844a1e6
Reviewed-on: https://webrtc-review.googlesource.com/8380
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Commit-Queue: Henrik Andreassson <henrika@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20246}
2017-10-11 11:55:49 +00:00
Karl Wiberg
c5bb00b6bf PeerConnection end-to-end test with a non-builtin codec
BUG=webrtc:8159

Change-Id: I27f3fc8a6204115c480d70238225b0565c41bd81
Reviewed-on: https://webrtc-review.googlesource.com/6283
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20245}
2017-10-11 11:48:54 +00:00
Gustaf Ullberg
8ffeeb2e34 Deletion of temp files in modules_unittests.
Temporary files created by AudioFormat tests in modules_unittest are
removed after each test case rather than after the whole suite is
finished. This saves disk space on the running device.

Bug: webrtc:8344
Change-Id: Iace3a7a62bb06e15fa596caf32da873944654c9a
Reviewed-on: https://webrtc-review.googlesource.com/8100
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20244}
2017-10-11 11:47:49 +00:00
Autoroller
0c1c6e2d24 Roll chromium_revision c6405066cc..961817f7c1 (507388:507941)
Change log: c6405066cc..961817f7c1
Full diff: c6405066cc..961817f7c1

Changed dependencies:
* src/base: bb89059924..8a2e6ca6a2
* src/build: adaf9e5610..66371a176b
* src/ios: 537db21572..fe5b1b2962
* src/testing: 9ea2ef7b17..8d5bbc677e
* src/third_party: 637781b501..dd57a5da7d
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/a48a6afde0..5430039572
* src/third_party/depot_tools: 8db10a6fb1..cd27f01b1a
* src/third_party/ffmpeg: 1e201feaa3..62ff55193a
* src/third_party/icu: 08cb956852..7f873c45c2
* src/tools: e9d5349db0..c5a868d906
DEPS diff: c6405066cc..961817f7c1/DEPS

No update to Clang.

TBR=buildbot@webrtc.org,
BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I9ef59183ccccd809ecdd5b1bc7cec99a2636ac58
Reviewed-on: https://webrtc-review.googlesource.com/8322
Commit-Queue: WebRTC Buildbot <buildbot@webrtc.org>
Reviewed-by: WebRTC Buildbot <buildbot@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20243}
2017-10-11 11:42:19 +00:00
Per Åhgren
6229d92a52 Removed redundant max operation and corrected comment
Bug: webrtc:8379
Change-Id: I20d0d469a8cc465ca45c18bfde8bbc945cb00e74
Reviewed-on: https://webrtc-review.googlesource.com/8303
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20242}
2017-10-11 11:33:49 +00:00
Bjorn Terelius
fa4c0c768a Print RTCP of unknown RTPFB and PSFB type in rtc_event_log2text.
Bug: None
Change-Id: If51f3d41f0e7b606fc66439b2b7ca4d34a4d206f
Reviewed-on: https://webrtc-review.googlesource.com/7980
Reviewed-by: Elad Alon <eladalon@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20241}
2017-10-11 11:23:32 +00:00
Danil Chapovalov
51e21aaa7a Simplify RtpRtcp interface for REMB
Remove REMB accessor as used for debug checks only.
Merge SetRembData and SetRembStatus(true) eliminating 
state 'remb can be send, but no data available yet'

Bug: None
Change-Id: I4c1c19435657e5cde02a17de90ec6de9f00b7daf
Reviewed-on: https://webrtc-review.googlesource.com/7983
Reviewed-by: Elad Alon <eladalon@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20240}
2017-10-11 11:09:39 +00:00
Peter Hanspers
d931705f84 Fixed threading exception on Mac.
Bug: webrtc:8128
Change-Id: I7bdada77e5937631fa2d8c3020ed56a0e33065f1
Reviewed-on: https://webrtc-review.googlesource.com/7221
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20239}
2017-10-11 10:26:49 +00:00
Kári Tristan Helgason
0a1140e3a0 Updating RTCDeviceType with new iOS devices.
Bug: None
Change-Id: I2b5416fda608039c07037244ce69c299f155ffdc
Reviewed-on: https://webrtc-review.googlesource.com/6900
Reviewed-by: Daniela Jovanoska Petrenko <denicija@webrtc.org>
Commit-Queue: Kári Helgason <kthelgason@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20238}
2017-10-11 10:06:59 +00:00
wjywbs
bef8a5d2ca Fix fat build for ios.
root_build_dir will always be the root build output directory.
root_out_dir is the directory "for the current toolchain".

WebRTC.framework is always in the root output directory.

Bug: webrtc:7507
Change-Id: I30b8eccaac3ed07e40c86acf361ee24a1c20b074
Reviewed-on: https://webrtc-review.googlesource.com/7640
Commit-Queue: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20237}
2017-10-11 09:13:39 +00:00
Mirko Bonadei
4e5b8e67b8 Depending on //third_party/icu on all the platforms.
In https://webrtc-review.googlesource.com/c/src/+/8020 it seems we
are failing because //third_party/icu is not checked out.

I am not sure why it is starting to happen only now, so I am still
investigating but probably this should fix.

Bug: None
Change-Id: Ic92e64d0b34c581c5a408a03d6359ddff40a5a08
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/7963
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@google.com>
Cr-Commit-Position: refs/heads/master@{#20236}
2017-10-11 08:33:09 +00:00
Mirko Bonadei
3152afd361 Removing invalid-name from disabled pylint checks.
It has been introduced in https://webrtc-review.googlesource.com/c/src/+/1566 but now it seems we can remove it since it is not raising any failure.

NOTRY=True

Bug: None
Change-Id: Id82b1b7fba6b5277753eabbf9fb7a722819532f9
Reviewed-on: https://webrtc-review.googlesource.com/8302
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@google.com>
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20235}
2017-10-11 08:06:49 +00:00
Per Åhgren
f9e58227d2 Changed the aggregation of AEC3 matched filter delay estimates
This CL changes the aggregation of the matched filter delay
estimates in AEC3 to using a histogram approach.

Bug: chromium:773541,webrtc:8379
Change-Id: I5322c65858188599397ef5716fecdebc34852e6a
Reviewed-on: https://webrtc-review.googlesource.com/8261
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20234}
2017-10-11 07:52:19 +00:00
Jonas Oreland
bdcee28ee9 TurnCustomizer - an interface for modifying stun messages sent by TurnPort
This patch adds an interface that allows modification of stun messages
sent by TurnPort. A user can inject a TurnCustomizer on the RTCConfig
and the TurnCustomizer will be invoked by TurnPort before sending
message. This allows user to e.g add custom attributes as described
in rtf5389.

BUG=webrtc:8313

Change-Id: I6f4333e9f8ff7fd20f32677be19285f15e1180b6
Reviewed-on: https://webrtc-review.googlesource.com/7618
Reviewed-by: Guido Urdaneta <guidou@webrtc.org>
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20233}
2017-10-11 07:45:29 +00:00
Åsa Persson
2ff7ecfceb Reduce max possible size of map that holds encoded frame info.
Bug: webrtc:8375
Change-Id: Idc57e68dc44fd73e5c0aa85d82c1e3659d8ea292
Reviewed-on: https://webrtc-review.googlesource.com/8301
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20232}
2017-10-11 07:34:30 +00:00
Per Åhgren
1f33a37565 AEC3 tunings to increase the transparency
This CL changes the tuning of AEC3 to increase the transparency.
In particular:
-The present parameters are re-tuned.
-An oversuppression factor is added in the newly added soft-knee in
 the NLP gain. The purpose of this is to avoid fluctuations in the
 residual echo.
-The dynamics of the computed gain are bounded to ensure that the 
 specified gain characteristics are realizable without echo leakage.
 This also adds robustness against echo leakage in frequency regions
 that are poorly estimated.
 This change was needed to avoid echo leakage from the above 
 tunings.

Bug: chromium:773543,webrtc:8378
Change-Id: If8acc41c1423a6a2fa6f8c4daf2735c86f0b529a
Reviewed-on: https://webrtc-review.googlesource.com/8262
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20231}
2017-10-11 07:28:09 +00:00
Taylor Brandstetter
05d9822e55 Disable RampUpTest.UpDownUpTransportSequenceNumberPacketLoss.
It's been disabled on Linux and Mac already, but appears to be flaky
regardless of platform; flakes have been observed on Android and
Windows as well.

TBR=stefan@webrtc.org
NOTRY=True

Bug: webrtc:7919
Change-Id: I193f6836fa3ad3928ed7ac05ade4504fa5e37442
Reviewed-on: https://webrtc-review.googlesource.com/8240
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20230}
2017-10-10 19:16:20 +00:00
Elad Alon
03967cd7bf RtcEventLogOutputFile needs to reset file_ whenever the file is not successfully opened
RtcEventLogOutputFile needs to reset file_ whenever the file is not successfully opened. (The destructor DCHECKs that file_ only exists if it's active, so as to help maintain this.)

Bug: webrtc:8111
Change-Id: I9a375a142af821b3c7183032f0b5d4d612dfa6b8
Reviewed-on: https://webrtc-review.googlesource.com/8080
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20229}
2017-10-10 17:19:18 +00:00
Taylor Brandstetter
ebe36efad7 Update Java MediaStream when native stream's set of tracks changes.
This will handle the scenario where, for example, the initial
offer/answer only negotiates audio, and video is added later (to the
same stream). Previously, there was absolutely no way to get a handle to
the new track without hacking the SDP. Now, the stream will be updated
after setRemoteDescription finishes.

Bug: webrtc:5677
Change-Id: Iea31bb7744da6b82afdaf44c8f74d721298a9474
Reviewed-on: https://webrtc-review.googlesource.com/6261
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20228}
2017-10-10 17:07:28 +00:00
Henrik Boström
933d8b07ea Reland "Added PeerConnectionObserver::OnRemoveTrack."
This reverts commit 6c0c55c318.

Reason for revert:
Fixed the flake.

Original change's description:
> Revert "Added PeerConnectionObserver::OnRemoveTrack."
> 
> This reverts commit ba97ba7af9.
> 
> Reason for revert: The new tests have caused several test failures on the test bots; the method FakeAudioMediaStreamTrack:GetSignalLevel, which is not supposed to be called is sometimes called anyway.
> 
> Original change's description:
> > Added PeerConnectionObserver::OnRemoveTrack.
> > 
> > This corresponds to processing the removal of a remote track step of
> > the spec, with processing the addition of a remote track already
> > covered by OnAddTrack.
> > https://w3c.github.io/webrtc-pc/#processing-remote-mediastreamtracks
> > 
> > Bug: webrtc:8260, webrtc:8315
> > Change-Id: Ica8be92369733eb3cf1397fb60385d45a9b58700
> > Reviewed-on: https://webrtc-review.googlesource.com/4722
> > Commit-Queue: Henrik Boström <hbos@webrtc.org>
> > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
> > Reviewed-by: Steve Anton <steveanton@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#20214}
> 
> TBR=steveanton@webrtc.org,deadbeef@webrtc.org,hbos@webrtc.org
> 
> Change-Id: Id2d9533e27227254769b4280a8ff10a47313e714
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:8260, webrtc:8315
> Reviewed-on: https://webrtc-review.googlesource.com/7940
> Reviewed-by: Alex Loiko <aleloi@webrtc.org>
> Commit-Queue: Alex Loiko <aleloi@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#20218}

TBR=steveanton@webrtc.org,deadbeef@webrtc.org,aleloi@webrtc.org,hbos@webrtc.org

Change-Id: Iab7500bebf98535754b102874259de43831fff6b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:8260, webrtc:8315
Reviewed-on: https://webrtc-review.googlesource.com/8180
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20227}
2017-10-10 17:06:00 +00:00
Danil Chapovalov
b709cf88c0 Remove Call::ParseRtpPacket
Bug: None
Change-Id: I14e589b1570a81c505336a8972c0e10214e2b289
Reviewed-on: https://webrtc-review.googlesource.com/2002
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20226}
2017-10-10 16:29:09 +00:00
Åsa Persson
af721b72cc Remove sent framerate and bitrate calculations from MediaOptimization.
Add RateTracker for sent framerate and bitrate in SendStatisticsProxy.

Store sent frame info in map to solve potential issue where sent framerate statistics could be
incorrect.

Bug: webrtc:8375
Change-Id: I4a6e3956013438a711b8c2e73a8cd90c52dd1210
Reviewed-on: https://webrtc-review.googlesource.com/7880
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20225}
2017-10-10 15:36:08 +00:00
Mirko Bonadei
245660a33d Fix Gn untracked headers in webrtc/call.
This CL is the same CL we had at https://codereview.webrtc.org/3014543002/.
Since we cannot land it with Rietveld anymore let's move the discussion
to Gerrit.

BUG=webrtc:7641
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Change-Id: I5662bec318544b07f476c12ecada997d726e7361
Reviewed-on: https://webrtc-review.googlesource.com/7981
Reviewed-by: Henrik Kjellander <kjellander@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20224}
2017-10-10 15:13:48 +00:00
erikvarga@webrtc.org
c774d5d13a Make the complexity of the square generator configurable.
This adds and extra param to SquareGenerator's constructor that sets the number of squares used. By default, it uses the same value that was previously hard-coded.

Bug: webrtc:8326
Change-Id: Ie7cff94e4a54fd5bb91f981930cad5e624e0e132
Reviewed-on: https://webrtc-review.googlesource.com/6020
Commit-Queue: Erik Varga <erikvarga@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20223}
2017-10-10 15:02:58 +00:00
Karl Wiberg
735a8389f2 Make iSAC build targets and headers that automatically pick fix or float
This will make it easier for users to specify that they want iSAC in
their codec factories, since they'll no longer have to worry about
choosing either the fix or the float implementation.

BUG=webrtc:8343

Change-Id: I5fb713710a8dd86162b5de73a2f0a851947f1411
Reviewed-on: https://webrtc-review.googlesource.com/6540
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org>
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20222}
2017-10-10 14:01:28 +00:00
Edward Lemur
c2b6cf3db9 Store test artifacts for swarming perf tests.
A '--store-test-artifacts' flag is introduced in
gtest-parallel-wrapper.py to make it possible for test running on
swarming to save test artifacts to the swarming output dir.

Bug: chromium:755660
Change-Id: I6bc1fbf210c1f224f3a7186c5444ae063a6af222
Reviewed-on: https://webrtc-review.googlesource.com/7840
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@google.com>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20221}
2017-10-10 13:06:38 +00:00
Mirko Bonadei
cb2bc11e7b Check out the msan instrumented libraries by default.
In order to unblock the chromium roll into WebRTC we have to
uniform the WebRTC DEPS file to the change done in:
https://chromium-review.googlesource.com/c/chromium/src/+/706280.

third_party/instrumented_libraries/scripts/download_binaries.py is
not needed anymore and msan instrumented libraries are downloaded
by default.

Bug: None
Change-Id: I46e7442866be38b366a6d53efa2b81bcd276c919
Reviewed-on: https://webrtc-review.googlesource.com/7863
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Kjellander <kjellander@google.com>
Cr-Commit-Position: refs/heads/master@{#20220}
2017-10-10 12:22:18 +00:00
Niels Möller
6e8785045f Unconditionally link fuzzers with rtc_task_queue_impl.
Bug: webrtc:8166, chromium:770690
Change-Id: I9480720c99308f8a2a3dcf407a07d762249f5a9c
Reviewed-on: https://webrtc-review.googlesource.com/6840
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20219}
2017-10-10 11:45:48 +00:00
Alex Loiko
6c0c55c318 Revert "Added PeerConnectionObserver::OnRemoveTrack."
This reverts commit ba97ba7af9.

Reason for revert: The new tests have caused several test failures on the test bots; the method FakeAudioMediaStreamTrack:GetSignalLevel, which is not supposed to be called is sometimes called anyway.

Original change's description:
> Added PeerConnectionObserver::OnRemoveTrack.
> 
> This corresponds to processing the removal of a remote track step of
> the spec, with processing the addition of a remote track already
> covered by OnAddTrack.
> https://w3c.github.io/webrtc-pc/#processing-remote-mediastreamtracks
> 
> Bug: webrtc:8260, webrtc:8315
> Change-Id: Ica8be92369733eb3cf1397fb60385d45a9b58700
> Reviewed-on: https://webrtc-review.googlesource.com/4722
> Commit-Queue: Henrik Boström <hbos@webrtc.org>
> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
> Reviewed-by: Steve Anton <steveanton@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#20214}

TBR=steveanton@webrtc.org,deadbeef@webrtc.org,hbos@webrtc.org

Change-Id: Id2d9533e27227254769b4280a8ff10a47313e714
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:8260, webrtc:8315
Reviewed-on: https://webrtc-review.googlesource.com/7940
Reviewed-by: Alex Loiko <aleloi@webrtc.org>
Commit-Queue: Alex Loiko <aleloi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20218}
2017-10-10 11:02:00 +00:00
Ilya Nikolaevskiy
3f670e07fe Fix potential crash bug in debug builds
The call to |interframe_delay_max_moving_.Add()| below depends on |now|
non decreasing in consequtive calls. However, if two threads are
competing for the lock it may happen that current thread calculates |now|
before the other thread, yet it will get the lock later. This will result
in decreasing local time in consecutive calls and trigger a DCHECK.

The same also applies to |timing_frame_info_counter_|.

Bug: none
Change-Id: I3376d88d4448c2c105e9227a445b11cd6ba8d341
Reviewed-on: https://webrtc-review.googlesource.com/7861
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20217}
2017-10-10 10:14:47 +00:00