mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-12 13:20:44 +01:00
c848268ab1
This CL is partly a test to see if there's an impact on binary size:
- Not a big difference for binaries (decrease): -776b to -4Kb
- For libraries (libwebrtc.a) it actually increases the size: +40Kb
Secondarily this CL is basically to introduce this pattern to the
code base. In terms of LOC, this makes things slightly more compact.
From:
class Foo {
public:
Foo() {
checker_.Detach();
}
private:
SequenceChecker checker_;
};
To:
class Foo {
public:
Foo() = default;
private:
SequenceChecker checker_{SequenceChecker::kDetached};
};
Bug: none
Change-Id: I59fc34ccea10847e13455a349851ce9a0af458e3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/299020
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39664}
69 lines
2.1 KiB
C++
69 lines
2.1 KiB
C++
/*
|
|
* Copyright 2011 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef API_NOTIFIER_H_
|
|
#define API_NOTIFIER_H_
|
|
|
|
#include <list>
|
|
|
|
#include "api/media_stream_interface.h"
|
|
#include "api/sequence_checker.h"
|
|
#include "rtc_base/checks.h"
|
|
#include "rtc_base/system/no_unique_address.h"
|
|
|
|
namespace webrtc {
|
|
|
|
// Implements a template version of a notifier.
|
|
// TODO(deadbeef): This is an implementation detail; move out of api/.
|
|
template <class T>
|
|
class Notifier : public T {
|
|
public:
|
|
Notifier() = default;
|
|
|
|
virtual void RegisterObserver(ObserverInterface* observer) {
|
|
RTC_DCHECK_RUN_ON(&sequence_checker_);
|
|
RTC_DCHECK(observer != nullptr);
|
|
observers_.push_back(observer);
|
|
}
|
|
|
|
virtual void UnregisterObserver(ObserverInterface* observer) {
|
|
RTC_DCHECK_RUN_ON(&sequence_checker_);
|
|
for (std::list<ObserverInterface*>::iterator it = observers_.begin();
|
|
it != observers_.end(); it++) {
|
|
if (*it == observer) {
|
|
observers_.erase(it);
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
void FireOnChanged() {
|
|
RTC_DCHECK_RUN_ON(&sequence_checker_);
|
|
// Copy the list of observers to avoid a crash if the observer object
|
|
// unregisters as a result of the OnChanged() call. If the same list is used
|
|
// UnregisterObserver will affect the list make the iterator invalid.
|
|
std::list<ObserverInterface*> observers = observers_;
|
|
for (std::list<ObserverInterface*>::iterator it = observers.begin();
|
|
it != observers.end(); ++it) {
|
|
(*it)->OnChanged();
|
|
}
|
|
}
|
|
|
|
protected:
|
|
std::list<ObserverInterface*> observers_ RTC_GUARDED_BY(sequence_checker_);
|
|
|
|
private:
|
|
RTC_NO_UNIQUE_ADDRESS SequenceChecker sequence_checker_{
|
|
SequenceChecker::kDetached};
|
|
};
|
|
|
|
} // namespace webrtc
|
|
|
|
#endif // API_NOTIFIER_H_
|