mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-12 21:30:45 +01:00
abf1e0bd40
memcpy has a bug where it doesn't work with empty slices whose pointer is null. C++ functions in <algorithm> have this bug fixed and, in a good STL, will specialize down to memcpy or memmove anyway. This fixes a bunch of UBSan failures in Chromium, such as https://luci-milo.appspot.com/ui/inv/build-8752767322372882913/test-results?q=RTCEncodedVideoFrameTest.ConstructorCopiesMetadata&sortby=&groupby= See https://davidben.net/2024/01/15/empty-slices.html Bug: chromium:40248746 Change-Id: Ibfb9c4d7b44df53766a16e40fabd0a374140d89c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/344260 Auto-Submit: David Benjamin <davidben@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41989}
105 lines
3.1 KiB
C++
105 lines
3.1 KiB
C++
/*
|
|
* Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "api/video/encoded_image.h"
|
|
|
|
#include <stdlib.h>
|
|
|
|
#include <algorithm>
|
|
|
|
namespace webrtc {
|
|
|
|
EncodedImageBuffer::EncodedImageBuffer(size_t size) : size_(size) {
|
|
buffer_ = static_cast<uint8_t*>(malloc(size));
|
|
}
|
|
|
|
EncodedImageBuffer::EncodedImageBuffer(const uint8_t* data, size_t size)
|
|
: EncodedImageBuffer(size) {
|
|
std::copy_n(data, size, buffer_);
|
|
}
|
|
|
|
EncodedImageBuffer::~EncodedImageBuffer() {
|
|
free(buffer_);
|
|
}
|
|
|
|
// static
|
|
rtc::scoped_refptr<EncodedImageBuffer> EncodedImageBuffer::Create(size_t size) {
|
|
return rtc::make_ref_counted<EncodedImageBuffer>(size);
|
|
}
|
|
// static
|
|
rtc::scoped_refptr<EncodedImageBuffer> EncodedImageBuffer::Create(
|
|
const uint8_t* data,
|
|
size_t size) {
|
|
return rtc::make_ref_counted<EncodedImageBuffer>(data, size);
|
|
}
|
|
|
|
const uint8_t* EncodedImageBuffer::data() const {
|
|
return buffer_;
|
|
}
|
|
uint8_t* EncodedImageBuffer::data() {
|
|
return buffer_;
|
|
}
|
|
size_t EncodedImageBuffer::size() const {
|
|
return size_;
|
|
}
|
|
|
|
void EncodedImageBuffer::Realloc(size_t size) {
|
|
// Calling realloc with size == 0 is equivalent to free, and returns nullptr.
|
|
// Which is confusing on systems where malloc(0) doesn't return a nullptr.
|
|
// More specifically, it breaks expectations of
|
|
// VCMSessionInfo::UpdateDataPointers.
|
|
RTC_DCHECK(size > 0);
|
|
buffer_ = static_cast<uint8_t*>(realloc(buffer_, size));
|
|
size_ = size;
|
|
}
|
|
|
|
EncodedImage::EncodedImage() = default;
|
|
|
|
EncodedImage::EncodedImage(EncodedImage&&) = default;
|
|
EncodedImage::EncodedImage(const EncodedImage&) = default;
|
|
|
|
EncodedImage::~EncodedImage() = default;
|
|
|
|
EncodedImage& EncodedImage::operator=(EncodedImage&&) = default;
|
|
EncodedImage& EncodedImage::operator=(const EncodedImage&) = default;
|
|
|
|
void EncodedImage::SetEncodeTime(int64_t encode_start_ms,
|
|
int64_t encode_finish_ms) {
|
|
timing_.encode_start_ms = encode_start_ms;
|
|
timing_.encode_finish_ms = encode_finish_ms;
|
|
}
|
|
|
|
webrtc::Timestamp EncodedImage::CaptureTime() const {
|
|
return capture_time_ms_ > 0 ? Timestamp::Millis(capture_time_ms_)
|
|
: Timestamp::MinusInfinity();
|
|
}
|
|
|
|
absl::optional<size_t> EncodedImage::SpatialLayerFrameSize(
|
|
int spatial_index) const {
|
|
RTC_DCHECK_GE(spatial_index, 0);
|
|
RTC_DCHECK_LE(spatial_index, spatial_index_.value_or(0));
|
|
|
|
auto it = spatial_layer_frame_size_bytes_.find(spatial_index);
|
|
if (it == spatial_layer_frame_size_bytes_.end()) {
|
|
return absl::nullopt;
|
|
}
|
|
|
|
return it->second;
|
|
}
|
|
|
|
void EncodedImage::SetSpatialLayerFrameSize(int spatial_index,
|
|
size_t size_bytes) {
|
|
RTC_DCHECK_GE(spatial_index, 0);
|
|
RTC_DCHECK_LE(spatial_index, spatial_index_.value_or(0));
|
|
RTC_DCHECK_GE(size_bytes, 0);
|
|
spatial_layer_frame_size_bytes_[spatial_index] = size_bytes;
|
|
}
|
|
|
|
} // namespace webrtc
|