mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 05:40:42 +01:00

Due to a previous refactoring, the SCTP packet header is only added when the first chunk is written. This wasn't reflected in the `bytes_remaining`, which made it add more than could fit within the MTU. Additionally, the maximum packet size must be even divisible by four as padding will be added to chunks that are not even divisble by four (up to three bytes of padding). So compensate for that. Bug: webrtc:12614 Change-Id: I6b57dfbf88d1fcfcbf443038915dd180e796191a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215145 Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Commit-Queue: Victor Boivie <boivie@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33760}
36 lines
1.1 KiB
C++
36 lines
1.1 KiB
C++
/*
|
|
* Copyright (c) 2021 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
#ifndef NET_DCSCTP_COMMON_MATH_H_
|
|
#define NET_DCSCTP_COMMON_MATH_H_
|
|
|
|
namespace dcsctp {
|
|
|
|
// Rounds up `val` to the nearest value that is divisible by four. Frequently
|
|
// used to e.g. pad chunks or parameters to an even 32-bit offset.
|
|
template <typename IntType>
|
|
IntType RoundUpTo4(IntType val) {
|
|
return (val + 3) & ~3;
|
|
}
|
|
|
|
// Similarly, rounds down `val` to the nearest value that is divisible by four.
|
|
template <typename IntType>
|
|
IntType RoundDownTo4(IntType val) {
|
|
return val & ~3;
|
|
}
|
|
|
|
// Returns true if `val` is divisible by four.
|
|
template <typename IntType>
|
|
bool IsDivisibleBy4(IntType val) {
|
|
return (val & 3) == 0;
|
|
}
|
|
|
|
} // namespace dcsctp
|
|
|
|
#endif // NET_DCSCTP_COMMON_MATH_H_
|