mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 13:50:40 +01:00
0e73602a9f
Adding strong types went a little too far as these two types represent the same sequence number. A "request sequence number" is a number, that - when responded to - will be used as "response sequence number". Having them separate added confusion and just a lot of type-casting. Bug: webrtc:12614 Change-Id: I4636ea8f2252023a2d5a9b7033763e1978b1812e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214130 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33789}
94 lines
3.4 KiB
C++
94 lines
3.4 KiB
C++
/*
|
|
* Copyright (c) 2021 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
#include "net/dcsctp/packet/chunk/reconfig_chunk.h"
|
|
|
|
#include <cstdint>
|
|
#include <type_traits>
|
|
#include <vector>
|
|
|
|
#include "api/array_view.h"
|
|
#include "net/dcsctp/packet/parameter/outgoing_ssn_reset_request_parameter.h"
|
|
#include "net/dcsctp/packet/parameter/parameter.h"
|
|
#include "net/dcsctp/packet/tlv_trait.h"
|
|
#include "net/dcsctp/testing/testing_macros.h"
|
|
#include "rtc_base/gunit.h"
|
|
#include "test/gmock.h"
|
|
|
|
namespace dcsctp {
|
|
namespace {
|
|
using ::testing::ElementsAre;
|
|
using ::testing::SizeIs;
|
|
|
|
TEST(ReConfigChunkTest, FromCapture) {
|
|
/*
|
|
RE_CONFIG chunk
|
|
Chunk type: RE_CONFIG (130)
|
|
Chunk flags: 0x00
|
|
Chunk length: 22
|
|
Outgoing SSN reset request parameter
|
|
Parameter type: Outgoing SSN reset request (0x000d)
|
|
Parameter length: 18
|
|
Re-configuration request sequence number: 2270550051
|
|
Re-configuration response sequence number: 1905748638
|
|
Senders last assigned TSN: 2270550066
|
|
Stream Identifier: 6
|
|
Chunk padding: 0000
|
|
*/
|
|
|
|
uint8_t data[] = {0x82, 0x00, 0x00, 0x16, 0x00, 0x0d, 0x00, 0x12,
|
|
0x87, 0x55, 0xd8, 0x23, 0x71, 0x97, 0x6a, 0x9e,
|
|
0x87, 0x55, 0xd8, 0x32, 0x00, 0x06, 0x00, 0x00};
|
|
|
|
ASSERT_HAS_VALUE_AND_ASSIGN(ReConfigChunk chunk, ReConfigChunk::Parse(data));
|
|
|
|
const Parameters& parameters = chunk.parameters();
|
|
EXPECT_THAT(parameters.descriptors(), SizeIs(1));
|
|
ParameterDescriptor desc = parameters.descriptors()[0];
|
|
ASSERT_EQ(desc.type, OutgoingSSNResetRequestParameter::kType);
|
|
ASSERT_HAS_VALUE_AND_ASSIGN(
|
|
OutgoingSSNResetRequestParameter req,
|
|
OutgoingSSNResetRequestParameter::Parse(desc.data));
|
|
EXPECT_EQ(*req.request_sequence_number(), 2270550051u);
|
|
EXPECT_EQ(*req.response_sequence_number(), 1905748638u);
|
|
EXPECT_EQ(*req.sender_last_assigned_tsn(), 2270550066u);
|
|
EXPECT_THAT(req.stream_ids(), ElementsAre(StreamID(6)));
|
|
}
|
|
|
|
TEST(ReConfigChunkTest, SerializeAndDeserialize) {
|
|
Parameters::Builder params_builder =
|
|
Parameters::Builder().Add(OutgoingSSNResetRequestParameter(
|
|
ReconfigRequestSN(123), ReconfigRequestSN(456), TSN(789),
|
|
{StreamID(42), StreamID(43)}));
|
|
|
|
ReConfigChunk chunk(params_builder.Build());
|
|
|
|
std::vector<uint8_t> serialized;
|
|
chunk.SerializeTo(serialized);
|
|
|
|
ASSERT_HAS_VALUE_AND_ASSIGN(ReConfigChunk deserialized,
|
|
ReConfigChunk::Parse(serialized));
|
|
|
|
const Parameters& parameters = deserialized.parameters();
|
|
EXPECT_THAT(parameters.descriptors(), SizeIs(1));
|
|
ParameterDescriptor desc = parameters.descriptors()[0];
|
|
ASSERT_EQ(desc.type, OutgoingSSNResetRequestParameter::kType);
|
|
ASSERT_HAS_VALUE_AND_ASSIGN(
|
|
OutgoingSSNResetRequestParameter req,
|
|
OutgoingSSNResetRequestParameter::Parse(desc.data));
|
|
EXPECT_EQ(*req.request_sequence_number(), 123u);
|
|
EXPECT_EQ(*req.response_sequence_number(), 456u);
|
|
EXPECT_EQ(*req.sender_last_assigned_tsn(), 789u);
|
|
EXPECT_THAT(req.stream_ids(), ElementsAre(StreamID(42), StreamID(43)));
|
|
|
|
EXPECT_EQ(deserialized.ToString(), "RE-CONFIG");
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace dcsctp
|