mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-12 21:30:45 +01:00
28d07ddbfd
Since the code measuring the RTT has been converted to using TimeDelta which internally stores the duration in microseconds, from DurationMs which uses milliseconds, the RTO calculation can use the higher precision to calculate lower non-zero durations on really fast networks such within a data center. Before this CL, which is from the initial drop of dcSCTP, the RTO calculation was done using the algorithm from the paper "V. Jacobson: Congestion avoidance and control", but now we're using the original algorith from https://tools.ietf.org/html/rfc4960#section-6.3.1, which comes from https://datatracker.ietf.org/doc/html/rfc6298#section-2. Two issues were found and corrected: 1. The min RTT variance that is specified in the config file was previously incorrectly divided by 8. That was not its intention, but we're keeping that behaviour as other clients have actually measured a good value to put there. This represents "G" in the "basic algorithm" above, and since that is multiplied with K, which is four, the default value of 220 wouldn't make sense if it wasn't scaled down, as that would make the RTO easily saturate to the RTO_max (800ms). 2. The previous algorithm had large round-off errors (probably because the code used milliseconds), which makes fairly big changes to the calculated RTO in some situations. Bug: webrtc:15593 Change-Id: I95a3e137c2bbbe7bf8b99c016381e9e63fd01d87 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/349000 Reviewed-by: Florent Castelli <orphis@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Victor Boivie <boivie@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42170} |
||
|---|---|---|
| .. | ||
| BUILD.gn | ||
| mock_send_queue.h | ||
| outstanding_data.cc | ||
| outstanding_data.h | ||
| outstanding_data_test.cc | ||
| retransmission_error_counter.cc | ||
| retransmission_error_counter.h | ||
| retransmission_error_counter_test.cc | ||
| retransmission_queue.cc | ||
| retransmission_queue.h | ||
| retransmission_queue_test.cc | ||
| retransmission_timeout.cc | ||
| retransmission_timeout.h | ||
| retransmission_timeout_test.cc | ||
| rr_send_queue.cc | ||
| rr_send_queue.h | ||
| rr_send_queue_test.cc | ||
| send_queue.h | ||
| stream_scheduler.cc | ||
| stream_scheduler.h | ||
| stream_scheduler_test.cc | ||