mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-12 21:30:45 +01:00
cd3d29b6fb
Before this CL, the StreamId class represented either a valid SCTP stream ID, or "nothing", which means that it was a wrapped absl::optional. Since created data channels don't have a SCTP stream ID until it's known whether this peer will use odd or even numbers, the "nothing" value was used for that state. This unfortunately made it a bit hard to work with objects of this type, as one always had to check if it contained a value. And even if a caller would check this, and then pass the StreamId to a different function, that function would have to do the check itself (often as a RTC_DCHECK) since the passed StreamId always could have that state. This CL simply extracts the "absl::optional" part of it, forcing holders to wrap it in an optional type - when it can be "nothing". But allowing the other code to just pass StreamId that can't be "nothing". That simplifies the code a bit, potentially removing some bugs. Bug: chromium:41221056 Change-Id: I93104cdd5d2f5fc1dbeb9d9dfc4cf361f11a9d68 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/342440 Reviewed-by: Florent Castelli <orphis@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Commit-Queue: Victor Boivie <boivie@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41880}
78 lines
3.1 KiB
C++
78 lines
3.1 KiB
C++
/*
|
|
* Copyright 2013 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef PC_SCTP_UTILS_H_
|
|
#define PC_SCTP_UTILS_H_
|
|
|
|
#include <string>
|
|
|
|
#include "api/data_channel_interface.h"
|
|
#include "api/transport/data_channel_transport_interface.h"
|
|
#include "media/base/media_channel.h"
|
|
#include "media/sctp/sctp_transport_internal.h"
|
|
#include "net/dcsctp/public/types.h"
|
|
#include "rtc_base/copy_on_write_buffer.h"
|
|
#include "rtc_base/ssl_stream_adapter.h" // For SSLRole
|
|
|
|
namespace rtc {
|
|
class CopyOnWriteBuffer;
|
|
} // namespace rtc
|
|
|
|
namespace webrtc {
|
|
struct DataChannelInit;
|
|
|
|
// Wraps the `uint16_t` sctp data channel stream id value and does range
|
|
// checking. The class interface is `int` based to ease with DataChannelInit
|
|
// compatibility and types used in `DataChannelController`'s interface. Going
|
|
// forward, `int` compatibility won't be needed and we can either just use
|
|
// this class or the internal dcsctp::StreamID type.
|
|
class StreamId {
|
|
public:
|
|
StreamId() = default;
|
|
explicit StreamId(uint16_t id) : id_(id) {}
|
|
StreamId(const StreamId& sid) = default;
|
|
StreamId& operator=(const StreamId& sid) = default;
|
|
// Provided for compatibility with existing code that hasn't been updated
|
|
// to use `StreamId` directly. New code should not use 'int' for the stream
|
|
// id but rather `StreamId` directly.
|
|
int stream_id_int() const { return static_cast<int>(id_.value()); }
|
|
|
|
bool operator==(const StreamId& sid) const { return id_ == sid.id_; }
|
|
bool operator<(const StreamId& sid) const { return id_ < sid.id_; }
|
|
bool operator!=(const StreamId& sid) const { return !(operator==(sid)); }
|
|
|
|
private:
|
|
dcsctp::StreamID id_;
|
|
};
|
|
|
|
// Read the message type and return true if it's an OPEN message.
|
|
bool IsOpenMessage(const rtc::CopyOnWriteBuffer& payload);
|
|
|
|
bool ParseDataChannelOpenMessage(const rtc::CopyOnWriteBuffer& payload,
|
|
std::string* label,
|
|
DataChannelInit* config);
|
|
|
|
bool ParseDataChannelOpenAckMessage(const rtc::CopyOnWriteBuffer& payload);
|
|
|
|
bool WriteDataChannelOpenMessage(const std::string& label,
|
|
const std::string& protocol,
|
|
absl::optional<Priority> priority,
|
|
bool ordered,
|
|
absl::optional<int> max_retransmits,
|
|
absl::optional<int> max_retransmit_time,
|
|
rtc::CopyOnWriteBuffer* payload);
|
|
bool WriteDataChannelOpenMessage(const std::string& label,
|
|
const DataChannelInit& config,
|
|
rtc::CopyOnWriteBuffer* payload);
|
|
void WriteDataChannelOpenAckMessage(rtc::CopyOnWriteBuffer* payload);
|
|
|
|
} // namespace webrtc
|
|
|
|
#endif // PC_SCTP_UTILS_H_
|