mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-12 21:30:45 +01:00

This adds Perfetto support to WebRTC with a GN flag rtc_use_perfetto. The configuration of perfetto depends on whether or not webrtc is build within Chrome or not. When in Chrome, WebRTC will depend on //third_party/perfetto:libperfetto. When building standalone, specific includes required for Perfetto are exposed with the library webrtc_libperfetto. The perfetto trace API is exposed with a header export in trace_event.h which is used instead of the legacy API. The addition of Perfetto means there are 4 compilation modes for tracing in WebRTC, 1. No tracing implementation. 2. Legacy tracing (AddTraceEvent/GetCategoryEnabled). 3.a. Perfetto statically linked (webrtc_libperfetto). 3.b. Perfetto in Chrome (Chrome's libperfetto). This CL removes the tracing expectations from rtc_stats_integrationtest.cc because those directly used the old API. Integration into Chrome is a follow up CL which depends on https://chromium-review.googlesource.com/c/chromium/src/+/5471691. Tested: Ran Chrome with Perfetto and traces appear. WebRTC Unit test tracing working: https://ui.perfetto.dev/#!?s=04ea2613ea36b814394639a1ec4b60be5b5097527f1a485995ecc13469885468 Bug: webrtc:15917 Change-Id: I537d79dc247c2b759689910c621087286a4d8fdc Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347880 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Evan Shrubsole <eshr@google.com> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/main@{#42166}
75 lines
2.1 KiB
C++
75 lines
2.1 KiB
C++
/*
|
|
* Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "rtc_base/event_tracer.h"
|
|
|
|
#include "rtc_base/synchronization/mutex.h"
|
|
#include "rtc_base/thread_annotations.h"
|
|
#include "rtc_base/trace_event.h"
|
|
#include "test/gtest.h"
|
|
|
|
namespace {
|
|
|
|
class TestStatistics {
|
|
public:
|
|
void Reset() {
|
|
webrtc::MutexLock lock(&mutex_);
|
|
events_logged_ = 0;
|
|
}
|
|
|
|
void Increment() {
|
|
webrtc::MutexLock lock(&mutex_);
|
|
++events_logged_;
|
|
}
|
|
|
|
int Count() const {
|
|
webrtc::MutexLock lock(&mutex_);
|
|
return events_logged_;
|
|
}
|
|
|
|
static TestStatistics* Get() {
|
|
// google.github.io/styleguide/cppguide.html#Static_and_Global_Variables
|
|
static auto& test_stats = *new TestStatistics();
|
|
return &test_stats;
|
|
}
|
|
|
|
private:
|
|
mutable webrtc::Mutex mutex_;
|
|
int events_logged_ RTC_GUARDED_BY(mutex_) = 0;
|
|
};
|
|
|
|
} // namespace
|
|
|
|
namespace webrtc {
|
|
|
|
TEST(EventTracerTest, EventTracerDisabled) {
|
|
{ TRACE_EVENT0("webrtc-test", "EventTracerDisabled"); }
|
|
EXPECT_FALSE(TestStatistics::Get()->Count());
|
|
TestStatistics::Get()->Reset();
|
|
}
|
|
|
|
#if RTC_TRACE_EVENTS_ENABLED && !defined(RTC_USE_PERFETTO)
|
|
TEST(EventTracerTest, ScopedTraceEvent) {
|
|
SetupEventTracer(
|
|
[](const char* /*name*/) {
|
|
return reinterpret_cast<const unsigned char*>("webrtc-test");
|
|
},
|
|
[](char /*phase*/, const unsigned char* /*category_enabled*/,
|
|
const char* /*name*/, unsigned long long /*id*/, int /*num_args*/,
|
|
const char** /*arg_names*/, const unsigned char* /*arg_types*/,
|
|
const unsigned long long* /*arg_values*/,
|
|
unsigned char /*flags*/) { TestStatistics::Get()->Increment(); });
|
|
{ TRACE_EVENT0("test", "ScopedTraceEvent"); }
|
|
EXPECT_EQ(2, TestStatistics::Get()->Count());
|
|
TestStatistics::Get()->Reset();
|
|
}
|
|
#endif
|
|
|
|
} // namespace webrtc
|