mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-12 21:30:45 +01:00

This removes the unused field trials `WebRTC-SimulcastScreenshareUpswitchHysteresisPercent` and `WebRTC-SimulcastScreenshareUpswitchHysteresisPercent` as well as the `video_hysteresis` and `screenshare_hysteresis` parameters in `WebRTC-VideoRateControl`. The hysteresis parameters in `WebRTC-StableTargetRate` are currently left, their future is unclear... Bug: webrtc:9734 Change-Id: I9e6bbe4b630a0501d365bf69e87e65164c500122 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/269207 Reviewed-by: Emil Lundmark <lndmrk@webrtc.org> Auto-Submit: Erik Språng <sprang@webrtc.org> Commit-Queue: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37635}
67 lines
2.3 KiB
C++
67 lines
2.3 KiB
C++
/*
|
|
* Copyright 2019 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "rtc_base/experiments/stable_target_rate_experiment.h"
|
|
|
|
#include "test/field_trial.h"
|
|
#include "test/gtest.h"
|
|
|
|
namespace webrtc {
|
|
|
|
TEST(StableBweExperimentTest, Default) {
|
|
StableTargetRateExperiment config =
|
|
StableTargetRateExperiment::ParseFromFieldTrials();
|
|
EXPECT_FALSE(config.IsEnabled());
|
|
EXPECT_EQ(config.GetVideoHysteresisFactor(), 1.2);
|
|
EXPECT_EQ(config.GetScreenshareHysteresisFactor(), 1.35);
|
|
}
|
|
|
|
TEST(StableBweExperimentTest, EnabledNoHysteresis) {
|
|
webrtc::test::ScopedFieldTrials field_trials(
|
|
"WebRTC-StableTargetRate/enabled:true/");
|
|
|
|
StableTargetRateExperiment config =
|
|
StableTargetRateExperiment::ParseFromFieldTrials();
|
|
EXPECT_TRUE(config.IsEnabled());
|
|
EXPECT_EQ(config.GetVideoHysteresisFactor(), 1.2);
|
|
EXPECT_EQ(config.GetScreenshareHysteresisFactor(), 1.35);
|
|
}
|
|
|
|
TEST(StableBweExperimentTest, EnabledWithHysteresis) {
|
|
webrtc::test::ScopedFieldTrials field_trials(
|
|
"WebRTC-StableTargetRate/"
|
|
"enabled:true,"
|
|
"video_hysteresis_factor:1.1,"
|
|
"screenshare_hysteresis_factor:1.2/");
|
|
|
|
StableTargetRateExperiment config =
|
|
StableTargetRateExperiment::ParseFromFieldTrials();
|
|
EXPECT_TRUE(config.IsEnabled());
|
|
EXPECT_EQ(config.GetVideoHysteresisFactor(), 1.1);
|
|
EXPECT_EQ(config.GetScreenshareHysteresisFactor(), 1.2);
|
|
}
|
|
|
|
TEST(StableBweExperimentTest, HysteresisOverrideVideoRateHystersis) {
|
|
webrtc::test::ScopedFieldTrials field_trials(
|
|
"WebRTC-StableTargetRate/"
|
|
"enabled:true,"
|
|
"video_hysteresis_factor:1.1,"
|
|
"screenshare_hysteresis_factor:1.2/"
|
|
"WebRTC-VideoRateControl/video_hysteresis:1.3,"
|
|
"screenshare_hysteresis:1.4/");
|
|
|
|
StableTargetRateExperiment config =
|
|
StableTargetRateExperiment::ParseFromFieldTrials();
|
|
EXPECT_TRUE(config.IsEnabled());
|
|
EXPECT_EQ(config.GetVideoHysteresisFactor(), 1.1);
|
|
EXPECT_EQ(config.GetScreenshareHysteresisFactor(), 1.2);
|
|
}
|
|
|
|
} // namespace webrtc
|