mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-12 21:30:45 +01:00

This is a reland of commit 7d4634cef7
Original change's description:
> Don't create PacketSocketFactory inside BasicPortAllocatorSession
>
> This extends AlwaysValidPointer to avoid creating a unique_ptr inside it.
>
> Bug: webrtc:13145
> Change-Id: I73a4f18d0a7037b57f575b04b134e4f7eadceb79
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/263240
> Reviewed-by: Jonas Oreland <jonaso@webrtc.org>
> Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com>
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#37048}
Bug: webrtc:13145
Change-Id: Iec8091ada5862cb6aa48d45b2a426c05bda798f9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264826
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Owners-Override: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37138}
129 lines
4 KiB
C++
129 lines
4 KiB
C++
/*
|
|
* Copyright 2004 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "rtc_base/memory/always_valid_pointer.h"
|
|
|
|
#include <string>
|
|
|
|
#include "test/gtest.h"
|
|
|
|
namespace webrtc {
|
|
|
|
TEST(AlwaysValidPointerTest, DefaultToEmptyValue) {
|
|
AlwaysValidPointer<std::string> ptr(nullptr);
|
|
EXPECT_EQ(*ptr, "");
|
|
}
|
|
TEST(AlwaysValidPointerTest, DefaultWithForwardedArgument) {
|
|
AlwaysValidPointer<std::string> ptr(nullptr, "test");
|
|
EXPECT_EQ(*ptr, "test");
|
|
}
|
|
TEST(AlwaysValidPointerTest, DefaultToSubclass) {
|
|
struct A {
|
|
virtual ~A() {}
|
|
virtual int f() = 0;
|
|
};
|
|
struct B : public A {
|
|
int b = 0;
|
|
explicit B(int val) : b(val) {}
|
|
virtual ~B() {}
|
|
int f() override { return b; }
|
|
};
|
|
AlwaysValidPointer<A, B> ptr(nullptr, 3);
|
|
EXPECT_EQ(ptr->f(), 3);
|
|
EXPECT_EQ((*ptr).f(), 3);
|
|
EXPECT_EQ(ptr.get()->f(), 3);
|
|
}
|
|
TEST(AlwaysValidPointerTest, NonDefaultValue) {
|
|
std::string str("keso");
|
|
AlwaysValidPointer<std::string> ptr(&str, "test");
|
|
EXPECT_EQ(*ptr, "keso");
|
|
}
|
|
|
|
TEST(AlwaysValidPointerTest, TakeOverOwnershipOfInstance) {
|
|
std::string str("keso");
|
|
std::unique_ptr<std::string> str2 = std::make_unique<std::string>("kent");
|
|
AlwaysValidPointer<std::string> ptr(std::move(str2), &str);
|
|
EXPECT_EQ(*ptr, "kent");
|
|
EXPECT_EQ(str2, nullptr);
|
|
}
|
|
|
|
TEST(AlwaysValidPointerTest, TakeOverOwnershipFallbackOnPointer) {
|
|
std::string str("keso");
|
|
std::unique_ptr<std::string> str2;
|
|
AlwaysValidPointer<std::string> ptr(std::move(str2), &str);
|
|
EXPECT_EQ(*ptr, "keso");
|
|
}
|
|
|
|
TEST(AlwaysValidPointerTest, TakeOverOwnershipFallbackOnDefault) {
|
|
std::unique_ptr<std::string> str;
|
|
std::string* str_ptr = nullptr;
|
|
AlwaysValidPointer<std::string> ptr(std::move(str), str_ptr);
|
|
EXPECT_EQ(*ptr, "");
|
|
}
|
|
|
|
TEST(AlwaysValidPointerTest,
|
|
TakeOverOwnershipFallbackOnDefaultWithForwardedArgument) {
|
|
std::unique_ptr<std::string> str2;
|
|
AlwaysValidPointer<std::string> ptr(std::move(str2), nullptr, "keso");
|
|
EXPECT_EQ(*ptr, "keso");
|
|
}
|
|
|
|
TEST(AlwaysValidPointerTest, TakeOverOwnershipDoesNotForwardDefaultArguments) {
|
|
std::unique_ptr<std::string> str = std::make_unique<std::string>("kalle");
|
|
std::unique_ptr<std::string> str2 = std::make_unique<std::string>("anka");
|
|
AlwaysValidPointer<std::string> ptr(std::move(str), nullptr, *str2);
|
|
EXPECT_EQ(*ptr, "kalle");
|
|
EXPECT_TRUE(!str);
|
|
EXPECT_EQ(*str2, "anka");
|
|
}
|
|
|
|
TEST(AlwaysValidPointerTest, DefaultToLambda) {
|
|
AlwaysValidPointer<std::string> ptr(
|
|
nullptr, []() { return std::make_unique<std::string>("onkel skrue"); });
|
|
EXPECT_EQ(*ptr, "onkel skrue");
|
|
}
|
|
|
|
TEST(AlwaysValidPointerTest, NoDefaultObjectPassValidPointer) {
|
|
std::string str("foo");
|
|
AlwaysValidPointerNoDefault<std::string> ptr(&str);
|
|
EXPECT_EQ(*ptr, "foo");
|
|
EXPECT_EQ(ptr, &str);
|
|
}
|
|
|
|
TEST(AlwaysValidPointerTest, NoDefaultObjectWithTakeOverOwnership) {
|
|
std::unique_ptr<std::string> str = std::make_unique<std::string>("yum");
|
|
AlwaysValidPointerNoDefault<std::string> ptr(std::move(str));
|
|
EXPECT_EQ(*ptr, "yum");
|
|
std::unique_ptr<std::string> str2 = std::make_unique<std::string>("fun");
|
|
AlwaysValidPointerNoDefault<std::string> ptr2(std::move(str), str2.get());
|
|
EXPECT_EQ(*ptr2, "fun");
|
|
EXPECT_EQ(ptr2, str2.get());
|
|
}
|
|
|
|
#if GTEST_HAS_DEATH_TEST && !defined(WEBRTC_ANDROID)
|
|
|
|
TEST(AlwaysValidPointerTest, NoDefaultObjectPassNullPointer) {
|
|
auto pass_null = []() {
|
|
AlwaysValidPointerNoDefault<std::string> ptr(nullptr);
|
|
};
|
|
EXPECT_DEATH(pass_null(), "");
|
|
}
|
|
|
|
TEST(AlwaysValidPointerTest, NoDefaultObjectPassNullUniquePointer) {
|
|
auto pass_null = []() {
|
|
std::unique_ptr<std::string> str;
|
|
AlwaysValidPointerNoDefault<std::string> ptr(std::move(str));
|
|
};
|
|
EXPECT_DEATH(pass_null(), "");
|
|
}
|
|
|
|
#endif
|
|
|
|
} // namespace webrtc
|