mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-12 21:30:45 +01:00
a9d497b52d
There are two threads involved here, the thread that calls the API functions and the pipwire main loop. Using one race checker for both is wrong and triggers aborts. Use a different race checker for all variables that are used by the pipewire main loop or guarded against concurrent access with the thread_loop_lock. In one case, two RTC_CHECK_RUNS_SERIALIZED() checks are needed, so enhance the macro to generate unique variable names. Bug: webrtc:15181 Change-Id: Ib41514eb7aa98fe85d830461aa0c71e42ba821bd Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/326781 Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41198}
83 lines
2.5 KiB
C++
83 lines
2.5 KiB
C++
/*
|
|
* Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef RTC_BASE_RACE_CHECKER_H_
|
|
#define RTC_BASE_RACE_CHECKER_H_
|
|
|
|
#include "rtc_base/checks.h"
|
|
#include "rtc_base/platform_thread_types.h"
|
|
#include "rtc_base/thread_annotations.h"
|
|
|
|
namespace rtc {
|
|
|
|
namespace internal {
|
|
class RaceCheckerScope;
|
|
} // namespace internal
|
|
|
|
// Best-effort race-checking implementation. This primitive uses no
|
|
// synchronization at all to be as-fast-as-possible in the non-racy case.
|
|
class RTC_LOCKABLE RaceChecker {
|
|
public:
|
|
friend class internal::RaceCheckerScope;
|
|
RaceChecker();
|
|
|
|
private:
|
|
bool Acquire() const RTC_EXCLUSIVE_LOCK_FUNCTION();
|
|
void Release() const RTC_UNLOCK_FUNCTION();
|
|
|
|
// Volatile to prevent code being optimized away in Acquire()/Release().
|
|
mutable volatile int access_count_ = 0;
|
|
mutable volatile PlatformThreadRef accessing_thread_;
|
|
};
|
|
|
|
namespace internal {
|
|
class RTC_SCOPED_LOCKABLE RaceCheckerScope {
|
|
public:
|
|
explicit RaceCheckerScope(const RaceChecker* race_checker)
|
|
RTC_EXCLUSIVE_LOCK_FUNCTION(race_checker);
|
|
|
|
bool RaceDetected() const;
|
|
~RaceCheckerScope() RTC_UNLOCK_FUNCTION();
|
|
|
|
private:
|
|
const RaceChecker* const race_checker_;
|
|
const bool race_check_ok_;
|
|
};
|
|
|
|
class RTC_SCOPED_LOCKABLE RaceCheckerScopeDoNothing {
|
|
public:
|
|
explicit RaceCheckerScopeDoNothing(const RaceChecker* race_checker)
|
|
RTC_EXCLUSIVE_LOCK_FUNCTION(race_checker) {}
|
|
|
|
~RaceCheckerScopeDoNothing() RTC_UNLOCK_FUNCTION() {}
|
|
};
|
|
|
|
} // namespace internal
|
|
} // namespace rtc
|
|
|
|
#define RTC_CHECK_RUNS_SERIALIZED(x) RTC_CHECK_RUNS_SERIALIZED_NEXT(x, __LINE__)
|
|
|
|
#define RTC_CHECK_RUNS_SERIALIZED_NEXT(x, suffix) \
|
|
RTC_CHECK_RUNS_SERIALIZED_IMPL(x, suffix)
|
|
|
|
#define RTC_CHECK_RUNS_SERIALIZED_IMPL(x, suffix) \
|
|
rtc::internal::RaceCheckerScope race_checker##suffix(x); \
|
|
RTC_CHECK(!race_checker##suffix.RaceDetected())
|
|
|
|
#if RTC_DCHECK_IS_ON
|
|
#define RTC_DCHECK_RUNS_SERIALIZED(x) \
|
|
rtc::internal::RaceCheckerScope race_checker(x); \
|
|
RTC_DCHECK(!race_checker.RaceDetected())
|
|
#else
|
|
#define RTC_DCHECK_RUNS_SERIALIZED(x) \
|
|
rtc::internal::RaceCheckerScopeDoNothing race_checker(x)
|
|
#endif
|
|
|
|
#endif // RTC_BASE_RACE_CHECKER_H_
|