mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-12 21:30:45 +01:00

This reverts commit3f87250a4f
. Reason for revert: Downstream is fixed Original change's description: > Revert "Remove RTC_DISALLOW_COPY_AND_ASSIGN usages completely" > > This reverts commit5f0eb93d2a
. > > Reason for revert: Breaks downstream project. I'm going to fix that one and create a reland of this CL after. > > Original change's description: > > Remove RTC_DISALLOW_COPY_AND_ASSIGN usages completely > > > > Bug: webrtc:13555, webrtc:13082 > > Change-Id: Iff2cda6f516739419e97e975e03f77a98f74be03 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249260 > > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > > Reviewed-by: Artem Titov <titovartem@webrtc.org> > > Commit-Queue: (Daniel.L) Byoungchan Lee <daniel.l@hpcnt.com> > > Cr-Commit-Position: refs/heads/main@{#35805} > > TBR=hta@webrtc.org,titovartem@webrtc.org,daniel.l@hpcnt.com,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: I33d497f1132adfe6d151023195a388d9b7d548f9 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:13555, webrtc:13082 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249364 > Reviewed-by: Artem Titov <titovartem@webrtc.org> > Owners-Override: Artem Titov <titovartem@webrtc.org> > Reviewed-by: Andrey Logvin <landrey@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Commit-Queue: Artem Titov <titovartem@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#35807} # Not skipping CQ checks because this is a reland. Bug: webrtc:13555, webrtc:13082 Change-Id: I7ef1ef3b6e3c41b1a96014aa75f003c0fcf33949 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249365 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/main@{#35814}
125 lines
2.7 KiB
C++
125 lines
2.7 KiB
C++
/*
|
|
* Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include <stddef.h>
|
|
#include <stdio.h>
|
|
|
|
#include <memory>
|
|
#include <random>
|
|
|
|
#include "rtc_base/checks.h"
|
|
#include "rtc_base/null_socket_server.h"
|
|
#include "rtc_base/thread.h"
|
|
#include "test/gtest.h"
|
|
|
|
namespace rtc {
|
|
|
|
namespace {
|
|
|
|
#if defined(MEMORY_SANITIZER)
|
|
void UseOfUninitializedValue() {
|
|
int* buf = new int[2];
|
|
std::random_device engine;
|
|
if (buf[engine() % 2]) { // Non-deterministic conditional.
|
|
printf("Externally visible action.");
|
|
}
|
|
delete[] buf;
|
|
}
|
|
|
|
TEST(SanitizersDeathTest, MemorySanitizer) {
|
|
EXPECT_DEATH(UseOfUninitializedValue(), "use-of-uninitialized-value");
|
|
}
|
|
#endif
|
|
|
|
#if defined(ADDRESS_SANITIZER)
|
|
void HeapUseAfterFree() {
|
|
char* buf = new char[2];
|
|
delete[] buf;
|
|
buf[0] = buf[1];
|
|
}
|
|
|
|
TEST(SanitizersDeathTest, AddressSanitizer) {
|
|
EXPECT_DEATH(HeapUseAfterFree(), "heap-use-after-free");
|
|
}
|
|
#endif
|
|
|
|
#if defined(UNDEFINED_SANITIZER)
|
|
// For ubsan:
|
|
void SignedIntegerOverflow() {
|
|
int32_t x = 1234567890;
|
|
x *= 2;
|
|
(void)x;
|
|
}
|
|
|
|
// For ubsan_vptr:
|
|
struct Base {
|
|
virtual void f() {}
|
|
virtual ~Base() {}
|
|
};
|
|
struct Derived : public Base {};
|
|
|
|
void InvalidVptr() {
|
|
Base b;
|
|
auto* d = static_cast<Derived*>(&b); // Bad downcast.
|
|
d->f(); // Virtual function call with object of wrong dynamic type.
|
|
}
|
|
|
|
TEST(SanitizersDeathTest, UndefinedSanitizer) {
|
|
EXPECT_DEATH(
|
|
{
|
|
SignedIntegerOverflow();
|
|
InvalidVptr();
|
|
},
|
|
"runtime error");
|
|
}
|
|
#endif
|
|
|
|
#if defined(THREAD_SANITIZER)
|
|
class IncrementThread : public Thread {
|
|
public:
|
|
explicit IncrementThread(int* value)
|
|
: Thread(std::make_unique<NullSocketServer>()), value_(value) {}
|
|
|
|
IncrementThread(const IncrementThread&) = delete;
|
|
IncrementThread& operator=(const IncrementThread&) = delete;
|
|
|
|
void Run() override {
|
|
++*value_;
|
|
Thread::Current()->SleepMs(100);
|
|
}
|
|
|
|
// Un-protect Thread::Join for the test.
|
|
void Join() { Thread::Join(); }
|
|
|
|
private:
|
|
int* value_;
|
|
};
|
|
|
|
void DataRace() {
|
|
int value = 0;
|
|
IncrementThread thread1(&value);
|
|
IncrementThread thread2(&value);
|
|
thread1.Start();
|
|
thread2.Start();
|
|
thread1.Join();
|
|
thread2.Join();
|
|
// TSan seems to mess with gtest's death detection.
|
|
// Fail intentionally, and rely on detecting the error message.
|
|
RTC_CHECK_NOTREACHED();
|
|
}
|
|
|
|
TEST(SanitizersDeathTest, ThreadSanitizer) {
|
|
EXPECT_DEATH(DataRace(), "data race");
|
|
}
|
|
#endif
|
|
|
|
} // namespace
|
|
|
|
} // namespace rtc
|