webrtc/test/mock_audio_encoder.cc
Sebastian Jansson 5d436ac0bf Removed Die mock from MockAudioEncoder
MockAudioEncoder was calling a mocked Die function on itself in its
destructor. This outputs "Uninteresting mock function call" warning if
the Die call was not expected. This is true even if a NiceMock is used
to suppress the warnings.

The purpose of testing that the destructor is called might be to protect
against memory leaks when audio encoder ownership is transferred using a
raw pointer. However, this case is already covered by msan checks.

Bug: None
Change-Id: I0603c417b4b239027859228e05ebcf83ff5aaf18
Reviewed-on: https://webrtc-review.googlesource.com/56183
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22146}
2018-02-22 12:53:38 +00:00

57 lines
1.7 KiB
C++

/*
* Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
* tree. An additional intellectual property rights grant can be found
* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
#include "test/mock_audio_encoder.h"
namespace webrtc {
MockAudioEncoder::MockAudioEncoder() = default;
MockAudioEncoder::~MockAudioEncoder() = default;
MockAudioEncoder::FakeEncoding::FakeEncoding(
const AudioEncoder::EncodedInfo& info)
: info_(info) {}
MockAudioEncoder::FakeEncoding::FakeEncoding(size_t encoded_bytes) {
info_.encoded_bytes = encoded_bytes;
}
AudioEncoder::EncodedInfo MockAudioEncoder::FakeEncoding::operator()(
uint32_t timestamp,
rtc::ArrayView<const int16_t> audio,
rtc::Buffer* encoded) {
encoded->SetSize(encoded->size() + info_.encoded_bytes);
return info_;
}
MockAudioEncoder::CopyEncoding::~CopyEncoding() = default;
MockAudioEncoder::CopyEncoding::CopyEncoding(
AudioEncoder::EncodedInfo info,
rtc::ArrayView<const uint8_t> payload)
: info_(info), payload_(payload) {}
MockAudioEncoder::CopyEncoding::CopyEncoding(
rtc::ArrayView<const uint8_t> payload)
: payload_(payload) {
info_.encoded_bytes = payload_.size();
}
AudioEncoder::EncodedInfo MockAudioEncoder::CopyEncoding::operator()(
uint32_t timestamp,
rtc::ArrayView<const int16_t> audio,
rtc::Buffer* encoded) {
RTC_CHECK(encoded);
RTC_CHECK_LE(info_.encoded_bytes, payload_.size());
encoded->AppendData(payload_.data(), info_.encoded_bytes);
return info_;
}
} // namespace webrtc