mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-12 21:30:45 +01:00
c14a2cb9cc
which needs to be added to the remote codecs a=fmtp: This also forces SimulcastCastEncoderAdapter to avoid issues with codecs that have native simulcast capability but do require synchronized keyframes. This parameter allows for large-scale experimentation and A/B testing whether the new behavior has advantages. It is to be considered transitional and may be removed again in the future. BUG=webrtc:10107 Change-Id: I81f496c987b2fed7ff3089efb746e7e89e89c033 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/333560 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41805}
130 lines
5 KiB
C++
130 lines
5 KiB
C++
/*
|
|
* Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "video/encoder_rtcp_feedback.h"
|
|
|
|
#include <memory>
|
|
|
|
#include "test/gmock.h"
|
|
#include "test/gtest.h"
|
|
#include "video/test/mock_video_stream_encoder.h"
|
|
|
|
using ::testing::_;
|
|
using ::testing::ElementsAre;
|
|
|
|
namespace webrtc {
|
|
|
|
class VideoEncoderFeedbackKeyframeTestBase : public ::testing::Test {
|
|
public:
|
|
VideoEncoderFeedbackKeyframeTestBase(bool per_layer_pli_handling,
|
|
std::vector<uint32_t> ssrcs)
|
|
: simulated_clock_(123456789),
|
|
encoder_(),
|
|
encoder_rtcp_feedback_(&simulated_clock_,
|
|
per_layer_pli_handling,
|
|
ssrcs,
|
|
&encoder_,
|
|
nullptr) {}
|
|
|
|
protected:
|
|
static const uint32_t kSsrc = 1234;
|
|
static const uint32_t kOtherSsrc = 4321;
|
|
|
|
SimulatedClock simulated_clock_;
|
|
::testing::StrictMock<MockVideoStreamEncoder> encoder_;
|
|
EncoderRtcpFeedback encoder_rtcp_feedback_;
|
|
};
|
|
|
|
class VideoEncoderFeedbackKeyframeTest
|
|
: public VideoEncoderFeedbackKeyframeTestBase {
|
|
public:
|
|
VideoEncoderFeedbackKeyframeTest()
|
|
: VideoEncoderFeedbackKeyframeTestBase(
|
|
/*per_layer_pli_handling=*/false,
|
|
{VideoEncoderFeedbackKeyframeTestBase::kSsrc}) {}
|
|
};
|
|
|
|
TEST_F(VideoEncoderFeedbackKeyframeTest, CreateAndTriggerRequests) {
|
|
EXPECT_CALL(encoder_, SendKeyFrame(_)).Times(1);
|
|
encoder_rtcp_feedback_.OnReceivedIntraFrameRequest(kSsrc);
|
|
}
|
|
|
|
TEST_F(VideoEncoderFeedbackKeyframeTest, TooManyOnReceivedIntraFrameRequest) {
|
|
EXPECT_CALL(encoder_, SendKeyFrame(_)).Times(1);
|
|
encoder_rtcp_feedback_.OnReceivedIntraFrameRequest(kSsrc);
|
|
encoder_rtcp_feedback_.OnReceivedIntraFrameRequest(kSsrc);
|
|
simulated_clock_.AdvanceTimeMilliseconds(10);
|
|
encoder_rtcp_feedback_.OnReceivedIntraFrameRequest(kSsrc);
|
|
|
|
EXPECT_CALL(encoder_, SendKeyFrame(_)).Times(1);
|
|
simulated_clock_.AdvanceTimeMilliseconds(300);
|
|
encoder_rtcp_feedback_.OnReceivedIntraFrameRequest(kSsrc);
|
|
encoder_rtcp_feedback_.OnReceivedIntraFrameRequest(kSsrc);
|
|
encoder_rtcp_feedback_.OnReceivedIntraFrameRequest(kSsrc);
|
|
}
|
|
|
|
class VideoEncoderFeedbackKeyframePerLayerPliTest
|
|
: public VideoEncoderFeedbackKeyframeTestBase {
|
|
public:
|
|
VideoEncoderFeedbackKeyframePerLayerPliTest()
|
|
: VideoEncoderFeedbackKeyframeTestBase(
|
|
/*per_layer_pli_handling=*/true,
|
|
{VideoEncoderFeedbackKeyframeTestBase::kSsrc,
|
|
VideoEncoderFeedbackKeyframeTestBase::kOtherSsrc}) {}
|
|
};
|
|
|
|
TEST_F(VideoEncoderFeedbackKeyframePerLayerPliTest, CreateAndTriggerRequests) {
|
|
EXPECT_CALL(encoder_,
|
|
SendKeyFrame(ElementsAre(VideoFrameType::kVideoFrameKey,
|
|
VideoFrameType::kVideoFrameDelta)))
|
|
.Times(1);
|
|
EXPECT_CALL(encoder_,
|
|
SendKeyFrame(ElementsAre(VideoFrameType::kVideoFrameDelta,
|
|
VideoFrameType::kVideoFrameKey)))
|
|
.Times(1);
|
|
encoder_rtcp_feedback_.OnReceivedIntraFrameRequest(kSsrc);
|
|
encoder_rtcp_feedback_.OnReceivedIntraFrameRequest(kOtherSsrc);
|
|
}
|
|
|
|
TEST_F(VideoEncoderFeedbackKeyframePerLayerPliTest,
|
|
TooManyOnReceivedIntraFrameRequest) {
|
|
EXPECT_CALL(encoder_,
|
|
SendKeyFrame(ElementsAre(VideoFrameType::kVideoFrameKey,
|
|
VideoFrameType::kVideoFrameDelta)))
|
|
.Times(1);
|
|
EXPECT_CALL(encoder_,
|
|
SendKeyFrame(ElementsAre(VideoFrameType::kVideoFrameDelta,
|
|
VideoFrameType::kVideoFrameKey)))
|
|
.Times(1);
|
|
encoder_rtcp_feedback_.OnReceivedIntraFrameRequest(kSsrc);
|
|
encoder_rtcp_feedback_.OnReceivedIntraFrameRequest(kSsrc);
|
|
encoder_rtcp_feedback_.OnReceivedIntraFrameRequest(kOtherSsrc);
|
|
simulated_clock_.AdvanceTimeMilliseconds(10);
|
|
encoder_rtcp_feedback_.OnReceivedIntraFrameRequest(kSsrc);
|
|
encoder_rtcp_feedback_.OnReceivedIntraFrameRequest(kOtherSsrc);
|
|
|
|
EXPECT_CALL(encoder_,
|
|
SendKeyFrame(ElementsAre(VideoFrameType::kVideoFrameKey,
|
|
VideoFrameType::kVideoFrameDelta)))
|
|
.Times(1);
|
|
EXPECT_CALL(encoder_,
|
|
SendKeyFrame(ElementsAre(VideoFrameType::kVideoFrameDelta,
|
|
VideoFrameType::kVideoFrameKey)))
|
|
.Times(1);
|
|
simulated_clock_.AdvanceTimeMilliseconds(300);
|
|
encoder_rtcp_feedback_.OnReceivedIntraFrameRequest(kSsrc);
|
|
encoder_rtcp_feedback_.OnReceivedIntraFrameRequest(kSsrc);
|
|
encoder_rtcp_feedback_.OnReceivedIntraFrameRequest(kSsrc);
|
|
encoder_rtcp_feedback_.OnReceivedIntraFrameRequest(kOtherSsrc);
|
|
encoder_rtcp_feedback_.OnReceivedIntraFrameRequest(kOtherSsrc);
|
|
encoder_rtcp_feedback_.OnReceivedIntraFrameRequest(kOtherSsrc);
|
|
}
|
|
|
|
} // namespace webrtc
|