mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 13:50:40 +01:00

Bug: webrtc:344347965 Change-Id: Iee5ae13487f57f2b0c98dd6fb6a14286ff317fbb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358100 Reviewed-by: Tony Herre <herre@google.com> Commit-Queue: Lionel Koenig <lionelk@webrtc.org> Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42717}
269 lines
11 KiB
C++
269 lines
11 KiB
C++
/*
|
|
* Copyright (c) 2020 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "audio/channel_receive_frame_transformer_delegate.h"
|
|
|
|
#include <cstdint>
|
|
#include <memory>
|
|
#include <utility>
|
|
|
|
#include "api/array_view.h"
|
|
#include "api/frame_transformer_factory.h"
|
|
#include "api/frame_transformer_interface.h"
|
|
#include "api/make_ref_counted.h"
|
|
#include "api/rtp_headers.h"
|
|
#include "api/scoped_refptr.h"
|
|
#include "api/test/mock_frame_transformer.h"
|
|
#include "api/test/mock_transformable_audio_frame.h"
|
|
#include "api/units/timestamp.h"
|
|
#include "rtc_base/thread.h"
|
|
#include "test/gmock.h"
|
|
#include "test/gtest.h"
|
|
|
|
namespace webrtc {
|
|
namespace {
|
|
|
|
using ::testing::_;
|
|
using ::testing::ElementsAre;
|
|
using ::testing::NiceMock;
|
|
using ::testing::SaveArg;
|
|
|
|
constexpr Timestamp kFakeReceiveTimestamp = Timestamp::Millis(1234567);
|
|
|
|
class MockChannelReceive {
|
|
public:
|
|
MOCK_METHOD(void,
|
|
ReceiveFrame,
|
|
(rtc::ArrayView<const uint8_t> packet,
|
|
const RTPHeader& header,
|
|
Timestamp receive_time));
|
|
|
|
ChannelReceiveFrameTransformerDelegate::ReceiveFrameCallback callback() {
|
|
return [this](rtc::ArrayView<const uint8_t> packet, const RTPHeader& header,
|
|
Timestamp receive_time) {
|
|
ReceiveFrame(packet, header, receive_time);
|
|
};
|
|
}
|
|
};
|
|
|
|
// Test that the delegate registers itself with the frame transformer on Init().
|
|
TEST(ChannelReceiveFrameTransformerDelegateTest,
|
|
RegisterTransformedFrameCallbackOnInit) {
|
|
rtc::scoped_refptr<MockFrameTransformer> mock_frame_transformer =
|
|
rtc::make_ref_counted<MockFrameTransformer>();
|
|
rtc::scoped_refptr<ChannelReceiveFrameTransformerDelegate> delegate =
|
|
rtc::make_ref_counted<ChannelReceiveFrameTransformerDelegate>(
|
|
ChannelReceiveFrameTransformerDelegate::ReceiveFrameCallback(),
|
|
mock_frame_transformer, nullptr);
|
|
EXPECT_CALL(*mock_frame_transformer, RegisterTransformedFrameCallback);
|
|
delegate->Init();
|
|
}
|
|
|
|
// Test that the delegate unregisters itself from the frame transformer on
|
|
// Reset().
|
|
TEST(ChannelReceiveFrameTransformerDelegateTest,
|
|
UnregisterTransformedFrameCallbackOnReset) {
|
|
rtc::scoped_refptr<MockFrameTransformer> mock_frame_transformer =
|
|
rtc::make_ref_counted<MockFrameTransformer>();
|
|
rtc::scoped_refptr<ChannelReceiveFrameTransformerDelegate> delegate =
|
|
rtc::make_ref_counted<ChannelReceiveFrameTransformerDelegate>(
|
|
ChannelReceiveFrameTransformerDelegate::ReceiveFrameCallback(),
|
|
mock_frame_transformer, nullptr);
|
|
EXPECT_CALL(*mock_frame_transformer, UnregisterTransformedFrameCallback);
|
|
delegate->Reset();
|
|
}
|
|
|
|
// Test that when the delegate receives a transformed frame from the frame
|
|
// transformer, it passes it to the channel using the ReceiveFrameCallback.
|
|
TEST(ChannelReceiveFrameTransformerDelegateTest,
|
|
TransformRunsChannelReceiveCallback) {
|
|
rtc::AutoThread main_thread;
|
|
rtc::scoped_refptr<MockFrameTransformer> mock_frame_transformer =
|
|
rtc::make_ref_counted<NiceMock<MockFrameTransformer>>();
|
|
MockChannelReceive mock_channel;
|
|
rtc::scoped_refptr<ChannelReceiveFrameTransformerDelegate> delegate =
|
|
rtc::make_ref_counted<ChannelReceiveFrameTransformerDelegate>(
|
|
mock_channel.callback(), mock_frame_transformer,
|
|
rtc::Thread::Current());
|
|
rtc::scoped_refptr<TransformedFrameCallback> callback;
|
|
EXPECT_CALL(*mock_frame_transformer, RegisterTransformedFrameCallback)
|
|
.WillOnce(SaveArg<0>(&callback));
|
|
delegate->Init();
|
|
ASSERT_TRUE(callback);
|
|
|
|
const uint8_t data[] = {1, 2, 3, 4};
|
|
rtc::ArrayView<const uint8_t> packet(data, sizeof(data));
|
|
RTPHeader header;
|
|
EXPECT_CALL(mock_channel, ReceiveFrame);
|
|
ON_CALL(*mock_frame_transformer, Transform)
|
|
.WillByDefault(
|
|
[&callback](std::unique_ptr<TransformableFrameInterface> frame) {
|
|
callback->OnTransformedFrame(std::move(frame));
|
|
});
|
|
delegate->Transform(packet, header, /*ssrc=*/1111, /*mimeType=*/"audio/opus",
|
|
kFakeReceiveTimestamp);
|
|
rtc::ThreadManager::ProcessAllMessageQueuesForTesting();
|
|
}
|
|
|
|
// Test that when the delegate receives a Outgoing frame from the frame
|
|
// transformer, it passes it to the channel using the ReceiveFrameCallback.
|
|
TEST(ChannelReceiveFrameTransformerDelegateTest,
|
|
TransformRunsChannelReceiveCallbackForSenderFrame) {
|
|
rtc::AutoThread main_thread;
|
|
rtc::scoped_refptr<MockFrameTransformer> mock_frame_transformer =
|
|
rtc::make_ref_counted<NiceMock<MockFrameTransformer>>();
|
|
MockChannelReceive mock_channel;
|
|
rtc::scoped_refptr<ChannelReceiveFrameTransformerDelegate> delegate =
|
|
rtc::make_ref_counted<ChannelReceiveFrameTransformerDelegate>(
|
|
mock_channel.callback(), mock_frame_transformer,
|
|
rtc::Thread::Current());
|
|
rtc::scoped_refptr<TransformedFrameCallback> callback;
|
|
EXPECT_CALL(*mock_frame_transformer, RegisterTransformedFrameCallback)
|
|
.WillOnce(SaveArg<0>(&callback));
|
|
delegate->Init();
|
|
ASSERT_TRUE(callback);
|
|
|
|
const uint8_t data[] = {1, 2, 3, 4};
|
|
rtc::ArrayView<const uint8_t> packet(data, sizeof(data));
|
|
RTPHeader header;
|
|
EXPECT_CALL(mock_channel,
|
|
ReceiveFrame(ElementsAre(1, 2, 3, 4), _, kFakeReceiveTimestamp));
|
|
ON_CALL(*mock_frame_transformer, Transform)
|
|
.WillByDefault(
|
|
[&callback](std::unique_ptr<TransformableFrameInterface> frame) {
|
|
auto* transformed_frame =
|
|
static_cast<TransformableAudioFrameInterface*>(frame.get());
|
|
callback->OnTransformedFrame(CloneAudioFrame(transformed_frame));
|
|
});
|
|
delegate->Transform(packet, header, /*ssrc=*/1111, /*mimeType=*/"audio/opus",
|
|
kFakeReceiveTimestamp);
|
|
rtc::ThreadManager::ProcessAllMessageQueuesForTesting();
|
|
}
|
|
|
|
// Test that if the delegate receives a transformed frame after it has been
|
|
// reset, it does not run the ReceiveFrameCallback, as the channel is destroyed
|
|
// after resetting the delegate.
|
|
TEST(ChannelReceiveFrameTransformerDelegateTest,
|
|
OnTransformedDoesNotRunChannelReceiveCallbackAfterReset) {
|
|
rtc::AutoThread main_thread;
|
|
rtc::scoped_refptr<MockFrameTransformer> mock_frame_transformer =
|
|
rtc::make_ref_counted<testing::NiceMock<MockFrameTransformer>>();
|
|
MockChannelReceive mock_channel;
|
|
rtc::scoped_refptr<ChannelReceiveFrameTransformerDelegate> delegate =
|
|
rtc::make_ref_counted<ChannelReceiveFrameTransformerDelegate>(
|
|
mock_channel.callback(), mock_frame_transformer,
|
|
rtc::Thread::Current());
|
|
|
|
delegate->Reset();
|
|
EXPECT_CALL(mock_channel, ReceiveFrame).Times(0);
|
|
delegate->OnTransformedFrame(std::make_unique<MockTransformableAudioFrame>());
|
|
rtc::ThreadManager::ProcessAllMessageQueuesForTesting();
|
|
}
|
|
|
|
TEST(ChannelReceiveFrameTransformerDelegateTest,
|
|
ShortCircuitingSkipsTransform) {
|
|
rtc::AutoThread main_thread;
|
|
rtc::scoped_refptr<MockFrameTransformer> mock_frame_transformer =
|
|
rtc::make_ref_counted<testing::NiceMock<MockFrameTransformer>>();
|
|
MockChannelReceive mock_channel;
|
|
rtc::scoped_refptr<ChannelReceiveFrameTransformerDelegate> delegate =
|
|
rtc::make_ref_counted<ChannelReceiveFrameTransformerDelegate>(
|
|
mock_channel.callback(), mock_frame_transformer,
|
|
rtc::Thread::Current());
|
|
const uint8_t data[] = {1, 2, 3, 4};
|
|
rtc::ArrayView<const uint8_t> packet(data, sizeof(data));
|
|
RTPHeader header;
|
|
|
|
delegate->StartShortCircuiting();
|
|
rtc::ThreadManager::ProcessAllMessageQueuesForTesting();
|
|
|
|
// Will not call the actual transformer.
|
|
EXPECT_CALL(*mock_frame_transformer, Transform).Times(0);
|
|
// Will pass the frame straight to the channel.
|
|
EXPECT_CALL(mock_channel, ReceiveFrame);
|
|
delegate->Transform(packet, header, /*ssrc=*/1111, /*mimeType=*/"audio/opus",
|
|
kFakeReceiveTimestamp);
|
|
}
|
|
|
|
TEST(ChannelReceiveFrameTransformerDelegateTest,
|
|
AudioLevelAbsentWithoutExtension) {
|
|
rtc::AutoThread main_thread;
|
|
rtc::scoped_refptr<MockFrameTransformer> mock_frame_transformer =
|
|
rtc::make_ref_counted<NiceMock<MockFrameTransformer>>();
|
|
rtc::scoped_refptr<ChannelReceiveFrameTransformerDelegate> delegate =
|
|
rtc::make_ref_counted<ChannelReceiveFrameTransformerDelegate>(
|
|
/*receive_frame_callback=*/nullptr, mock_frame_transformer,
|
|
rtc::Thread::Current());
|
|
rtc::scoped_refptr<TransformedFrameCallback> callback;
|
|
EXPECT_CALL(*mock_frame_transformer, RegisterTransformedFrameCallback)
|
|
.WillOnce(SaveArg<0>(&callback));
|
|
delegate->Init();
|
|
ASSERT_TRUE(callback);
|
|
|
|
const uint8_t data[] = {1, 2, 3, 4};
|
|
rtc::ArrayView<const uint8_t> packet(data, sizeof(data));
|
|
RTPHeader header;
|
|
std::unique_ptr<TransformableFrameInterface> frame;
|
|
ON_CALL(*mock_frame_transformer, Transform)
|
|
.WillByDefault(
|
|
[&](std::unique_ptr<TransformableFrameInterface> transform_frame) {
|
|
frame = std::move(transform_frame);
|
|
});
|
|
delegate->Transform(packet, header, /*ssrc=*/1111, /*mimeType=*/"audio/opus",
|
|
kFakeReceiveTimestamp);
|
|
|
|
EXPECT_TRUE(frame);
|
|
auto* audio_frame =
|
|
static_cast<TransformableAudioFrameInterface*>(frame.get());
|
|
EXPECT_FALSE(audio_frame->AudioLevel());
|
|
EXPECT_EQ(audio_frame->Type(),
|
|
TransformableAudioFrameInterface::FrameType::kAudioFrameCN);
|
|
}
|
|
|
|
TEST(ChannelReceiveFrameTransformerDelegateTest,
|
|
AudioLevelPresentWithExtension) {
|
|
rtc::AutoThread main_thread;
|
|
rtc::scoped_refptr<MockFrameTransformer> mock_frame_transformer =
|
|
rtc::make_ref_counted<NiceMock<MockFrameTransformer>>();
|
|
rtc::scoped_refptr<ChannelReceiveFrameTransformerDelegate> delegate =
|
|
rtc::make_ref_counted<ChannelReceiveFrameTransformerDelegate>(
|
|
/*receive_frame_callback=*/nullptr, mock_frame_transformer,
|
|
rtc::Thread::Current());
|
|
rtc::scoped_refptr<TransformedFrameCallback> callback;
|
|
EXPECT_CALL(*mock_frame_transformer, RegisterTransformedFrameCallback)
|
|
.WillOnce(SaveArg<0>(&callback));
|
|
delegate->Init();
|
|
ASSERT_TRUE(callback);
|
|
|
|
const uint8_t data[] = {1, 2, 3, 4};
|
|
rtc::ArrayView<const uint8_t> packet(data, sizeof(data));
|
|
RTPHeader header;
|
|
uint8_t audio_level_dbov = 67;
|
|
AudioLevel audio_level(/*voice_activity=*/true, audio_level_dbov);
|
|
header.extension.set_audio_level(audio_level);
|
|
std::unique_ptr<TransformableFrameInterface> frame;
|
|
ON_CALL(*mock_frame_transformer, Transform)
|
|
.WillByDefault(
|
|
[&](std::unique_ptr<TransformableFrameInterface> transform_frame) {
|
|
frame = std::move(transform_frame);
|
|
});
|
|
delegate->Transform(packet, header, /*ssrc=*/1111, /*mimeType=*/"audio/opus",
|
|
kFakeReceiveTimestamp);
|
|
|
|
EXPECT_TRUE(frame);
|
|
auto* audio_frame =
|
|
static_cast<TransformableAudioFrameInterface*>(frame.get());
|
|
EXPECT_EQ(*audio_frame->AudioLevel(), audio_level_dbov);
|
|
EXPECT_EQ(audio_frame->Type(),
|
|
TransformableAudioFrameInterface::FrameType::kAudioFrameSpeech);
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace webrtc
|