mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-17 23:57:59 +01:00

Reasons: - the code is no longer used in Chrome - it is conceptually weird for WebRTC to have JSON parsing in its API - there are concerns around the reliability of the underlying JSON library Additionally, this CL removes the rtc_json "poisonous" attribute: the scheme is incompatible and redundant with testonly. Bug: webrtc:1493351 Change-Id: I0b621b0e3f183df7315919d9c89242fbe387928f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/325062 Reviewed-by: Per Åhgren <peah@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Sam Zackrisson <saza@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41014}
46 lines
1.7 KiB
C++
46 lines
1.7 KiB
C++
/*
|
|
* Copyright 2018 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "api/audio/echo_canceller3_config.h"
|
|
|
|
#include "modules/audio_processing/test/echo_canceller3_config_json.h"
|
|
#include "test/gtest.h"
|
|
|
|
namespace webrtc {
|
|
|
|
TEST(EchoCanceller3Config, ValidConfigIsNotModified) {
|
|
EchoCanceller3Config config;
|
|
EXPECT_TRUE(EchoCanceller3Config::Validate(&config));
|
|
EchoCanceller3Config default_config;
|
|
EXPECT_EQ(Aec3ConfigToJsonString(config),
|
|
Aec3ConfigToJsonString(default_config));
|
|
}
|
|
|
|
TEST(EchoCanceller3Config, InvalidConfigIsCorrected) {
|
|
// Change a parameter and validate.
|
|
EchoCanceller3Config config;
|
|
config.echo_model.min_noise_floor_power = -1600000.f;
|
|
EXPECT_FALSE(EchoCanceller3Config::Validate(&config));
|
|
EXPECT_GE(config.echo_model.min_noise_floor_power, 0.f);
|
|
// Verify remaining parameters are unchanged.
|
|
EchoCanceller3Config default_config;
|
|
config.echo_model.min_noise_floor_power =
|
|
default_config.echo_model.min_noise_floor_power;
|
|
EXPECT_EQ(Aec3ConfigToJsonString(config),
|
|
Aec3ConfigToJsonString(default_config));
|
|
}
|
|
|
|
TEST(EchoCanceller3Config, ValidatedConfigsAreValid) {
|
|
EchoCanceller3Config config;
|
|
config.delay.down_sampling_factor = 983;
|
|
EXPECT_FALSE(EchoCanceller3Config::Validate(&config));
|
|
EXPECT_TRUE(EchoCanceller3Config::Validate(&config));
|
|
}
|
|
} // namespace webrtc
|