mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-17 15:47:53 +01:00
301e546a68
As pointed out in issue webrtc:15146 this Mac/iOS specific variable, makes the SequenceChecker behave incorrectly on those platforms. The variable was introduced in a CL that merged the previous checker classes, ThreadChecker and SequencedTaskChecker, but curiously neither one of them had such a variable. So I'm not exactly sure what problem was being solved. Hence I'm wondering if we actually need it. Reference: https://webrtc-review.googlesource.com/c/src/+/129721 Bug: webrtc:15146 Change-Id: Ia7a9eb17b993c4f8a1e8204c658bf0b3dbdaa1e0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/304401 Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> Cr-Commit-Position: refs/heads/main@{#40019}
81 lines
2.8 KiB
C++
81 lines
2.8 KiB
C++
/*
|
|
* Copyright 2019 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
#include "rtc_base/synchronization/sequence_checker_internal.h"
|
|
|
|
#include <string>
|
|
|
|
#include "rtc_base/checks.h"
|
|
#include "rtc_base/strings/string_builder.h"
|
|
|
|
namespace webrtc {
|
|
namespace webrtc_sequence_checker_internal {
|
|
|
|
SequenceCheckerImpl::SequenceCheckerImpl(bool attach_to_current_thread)
|
|
: attached_(attach_to_current_thread),
|
|
valid_thread_(rtc::CurrentThreadRef()),
|
|
valid_queue_(TaskQueueBase::Current()) {}
|
|
|
|
bool SequenceCheckerImpl::IsCurrent() const {
|
|
const TaskQueueBase* const current_queue = TaskQueueBase::Current();
|
|
const rtc::PlatformThreadRef current_thread = rtc::CurrentThreadRef();
|
|
MutexLock scoped_lock(&lock_);
|
|
if (!attached_) { // Previously detached.
|
|
attached_ = true;
|
|
valid_thread_ = current_thread;
|
|
valid_queue_ = current_queue;
|
|
return true;
|
|
}
|
|
if (valid_queue_) {
|
|
return valid_queue_ == current_queue;
|
|
}
|
|
return rtc::IsThreadRefEqual(valid_thread_, current_thread);
|
|
}
|
|
|
|
void SequenceCheckerImpl::Detach() {
|
|
MutexLock scoped_lock(&lock_);
|
|
attached_ = false;
|
|
// We don't need to touch the other members here, they will be
|
|
// reset on the next call to IsCurrent().
|
|
}
|
|
|
|
#if RTC_DCHECK_IS_ON
|
|
std::string SequenceCheckerImpl::ExpectationToString() const {
|
|
const TaskQueueBase* const current_queue = TaskQueueBase::Current();
|
|
const rtc::PlatformThreadRef current_thread = rtc::CurrentThreadRef();
|
|
MutexLock scoped_lock(&lock_);
|
|
if (!attached_)
|
|
return "Checker currently not attached.";
|
|
|
|
// The format of the string is meant to compliment the one we have inside of
|
|
// FatalLog() (checks.cc). Example:
|
|
//
|
|
// # Expected: TQ: 0x0 SysQ: 0x7fff69541330 Thread: 0x11dcf6dc0
|
|
// # Actual: TQ: 0x7fa8f0604190 SysQ: 0x7fa8f0604a30 Thread: 0x700006f1a000
|
|
// TaskQueue doesn't match
|
|
|
|
rtc::StringBuilder message;
|
|
message.AppendFormat(
|
|
"# Expected: TQ: %p Thread: %p\n"
|
|
"# Actual: TQ: %p Thread: %p\n",
|
|
valid_queue_, reinterpret_cast<const void*>(valid_thread_), current_queue,
|
|
reinterpret_cast<const void*>(current_thread));
|
|
|
|
if ((valid_queue_ || current_queue) && valid_queue_ != current_queue) {
|
|
message << "TaskQueue doesn't match\n";
|
|
} else if (!rtc::IsThreadRefEqual(valid_thread_, current_thread)) {
|
|
message << "Threads don't match\n";
|
|
}
|
|
|
|
return message.Release();
|
|
}
|
|
#endif // RTC_DCHECK_IS_ON
|
|
|
|
} // namespace webrtc_sequence_checker_internal
|
|
} // namespace webrtc
|