webrtc/p2p
Per K b60f0ffbce Dont signal ReadyToSend in RtpTransport::SendPacket
Before this cl, ReadyToSend signaled false if sending a packet failed and transport->GetError() returns ECONN.
ECONN may be reported by the TCP connection (TcpConnection) if the remote closed the connection. TcpConnection will attempt to reconnect and should change the writable state if it fail.
Changing the state in the context of sending packets may cause recursive
calls and seems to cause problems with incorrect states.
It is simpler if RtpTransport::SendPacket ignore these failures and
upper layers treat these lost packets similar to if the packets had been
lost via UDP.
For safety, this change can be reverted by field trial WebRTC-SetReadyToSendFalseIfSendFail/Enabled/.

Bug: webrtc:361124449 b/359989715
Change-Id: I8e7016dfb4301862286215c4512aa8ac03a16685
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/360120
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Jonas Oreland <jonaso@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42868}
2024-08-27 14:16:53 +00:00
..
base Dont signal ReadyToSend in RtpTransport::SendPacket 2024-08-27 14:16:53 +00:00
client Remove <ostream> dependencies 2024-07-03 12:27:55 +00:00
g3doc Reland "Migrate WebRTC documentation to new renderer" 2023-01-31 09:30:04 +00:00
stunprober Convert ByteBufferWriter to be type uint8_t 2023-12-15 12:27:50 +00:00
BUILD.gn Add new constructor for TestUDPPort 2024-07-02 13:20:51 +00:00
DEPS Bind the structured ICE logging with P2PTransportChannel. 2018-02-03 07:06:49 +00:00
OWNERS Remove inactive owners. 2021-08-31 14:27:49 +00:00