mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-13 13:50:40 +01:00
05cf6be726
This CL is a manual spin-off of [1], which tried to apply clang-tidy's performance-move-const-arg [1] to the WebRTC codebase. Since there are some wrong fixes to correct, this CL collects all the fixes that could be landed as is. [1] - https://webrtc-review.googlesource.com/c/src/+/120350 [2] - https://clang.llvm.org/extra/clang-tidy/checks/performance-move-const-arg.html Bug: webrtc:10252 Change-Id: Ic4882213556344e65c66e27415e91ff6f89134d7 Reviewed-on: https://webrtc-review.googlesource.com/c/120814 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26515}
63 lines
2 KiB
C++
63 lines
2 KiB
C++
/*
|
|
* Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "api/audio_codecs/opus/audio_decoder_opus.h"
|
|
|
|
#include <memory>
|
|
#include <utility>
|
|
#include <vector>
|
|
|
|
#include "absl/memory/memory.h"
|
|
#include "absl/strings/match.h"
|
|
#include "modules/audio_coding/codecs/opus/audio_decoder_opus.h"
|
|
|
|
namespace webrtc {
|
|
|
|
absl::optional<AudioDecoderOpus::Config> AudioDecoderOpus::SdpToConfig(
|
|
const SdpAudioFormat& format) {
|
|
const auto num_channels = [&]() -> absl::optional<int> {
|
|
auto stereo = format.parameters.find("stereo");
|
|
if (stereo != format.parameters.end()) {
|
|
if (stereo->second == "0") {
|
|
return 1;
|
|
} else if (stereo->second == "1") {
|
|
return 2;
|
|
} else {
|
|
return absl::nullopt; // Bad stereo parameter.
|
|
}
|
|
}
|
|
return 1; // Default to mono.
|
|
}();
|
|
if (absl::EqualsIgnoreCase(format.name, "opus") &&
|
|
format.clockrate_hz == 48000 && format.num_channels == 2 &&
|
|
num_channels) {
|
|
return Config{*num_channels};
|
|
} else {
|
|
return absl::nullopt;
|
|
}
|
|
}
|
|
|
|
void AudioDecoderOpus::AppendSupportedDecoders(
|
|
std::vector<AudioCodecSpec>* specs) {
|
|
AudioCodecInfo opus_info{48000, 1, 64000, 6000, 510000};
|
|
opus_info.allow_comfort_noise = false;
|
|
opus_info.supports_network_adaption = true;
|
|
SdpAudioFormat opus_format(
|
|
{"opus", 48000, 2, {{"minptime", "10"}, {"useinbandfec", "1"}}});
|
|
specs->push_back({std::move(opus_format), opus_info});
|
|
}
|
|
|
|
std::unique_ptr<AudioDecoder> AudioDecoderOpus::MakeAudioDecoder(
|
|
Config config,
|
|
absl::optional<AudioCodecPairId> /*codec_pair_id*/) {
|
|
return absl::make_unique<AudioDecoderOpusImpl>(config.num_channels);
|
|
}
|
|
|
|
} // namespace webrtc
|