mirror of
https://github.com/mollyim/webrtc.git
synced 2025-05-19 08:37:54 +01:00
ccbc216ac5
This rounding triggers a dcheck that crashes debug builds. Furtunately, in release mode this does not matter as the resulting value is anyway capped to 0. Unfortunately, it is almost impossible to write a test for this even with simulated time as the conditions needed to trigger this condition includes thread scheduling being slightly off in such a way that an unscheduled process call preempts a scheduled one at a time when sending a sufficiently large padding packet becomes possible - and right after starting a new probe cluster. We should consider updating this class to make unit testing easier. Bug: webrtc:10809 Change-Id: I533e6e716bddc106d11e82a9e3edb4e0035fd21c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/192786 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32589} |
||
|---|---|---|
| .. | ||
| bitrate_prober.cc | ||
| bitrate_prober.h | ||
| bitrate_prober_unittest.cc | ||
| BUILD.gn | ||
| DEPS | ||
| interval_budget.cc | ||
| interval_budget.h | ||
| interval_budget_unittest.cc | ||
| OWNERS | ||
| paced_sender.cc | ||
| paced_sender.h | ||
| paced_sender_unittest.cc | ||
| pacing_controller.cc | ||
| pacing_controller.h | ||
| pacing_controller_unittest.cc | ||
| packet_router.cc | ||
| packet_router.h | ||
| packet_router_unittest.cc | ||
| round_robin_packet_queue.cc | ||
| round_robin_packet_queue.h | ||
| rtp_packet_pacer.h | ||
| task_queue_paced_sender.cc | ||
| task_queue_paced_sender.h | ||
| task_queue_paced_sender_unittest.cc | ||